chef-attribute-validator 0.3.0 → 0.3.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NDNkM2Y5MDMwZTEwNmYwN2Q0ZmQ3NzkzYzQyN2NlNjE2ODYwNTc1Mg==
+    ZDdiM2M5N2FjMTI2MjY4NWI0ZDViYzU5ZTAzZDAzNDBmZjgwMjkwNg==
   data.tar.gz: !binary |-
-    ZjNiMGQwNDZkM2Y0MmI2OGFjZWM3MTM0MjI2ZDA2OGRhNTFkZWZjNg==
+    NjM3MmUzZDExMWJkMmNkNTYwMWFhNWMzNDA0ZDY1NDhmY2M0NzhiYg==
 SHA512:
   metadata.gz: !binary |-
-    NWY1MTBhNTk3MTU2MTQ4NWFkZDk5MjY5NTdlZTY2ODI1YTQ4ZDcwYzU5MGQx
-    NGFlMmE1OTZhZjdiZWIwZDNiZGY1YzI0YWY3MjAzYTlhYTI0YjliNmM0NzA3
-    NzUwNzczMjI1OWVjNzFkNjdiNDYyYzE4NDAxZWUyYWYxNGZkNDA=
+    YjQwNjUzNTM5NjQ1NzBkZDZlYzEzMmQzOThjZmFmYzU5NTlhZGQ2MjMwYWMz
+    ZmFlOGZlNzVjYWIwNGRmODM4MmMzMDc5YjE5ODgyOWYzZmJjYTNmNGEyODJi
+    YTc5ZjRiMmU4YzE0YmY4YjBhMjdhOGU2NDYxNTI4NGE2MDJmOGI=
   data.tar.gz: !binary |-
-    ZWM3YzFjMjRhZTY2MjYzNjI3YzhhZmU4ZGY4ZDNhMGExYmY5YzMzZDljYmQw
-    NWQzNThjN2UwOWI3YjkyNTQ1YTJhOWRhZjFjZTIxZGJiYjJjNjBkMWYzZjdl
-    ZTliYWRhOGQ5ZDk2ZjExYjZkM2Q0ZTdiMjljMTVhZjJjOTViOTQ=
+    NTg2YjY1ZWJiYzZlNjllNGVhNWYxYTlkYzc5NGViYjA1ZDFkYTE4MmRkMDk3
+    NjA4Yjc1YjVkZjA2NTk2MTJjYmM1OWFkYjIxOGY5MDcyOTk1NmUyZjFmMGRj
+    ODg5ZTVhZjEzMDFjMWNiNGRlYzU4MmI2ZmMzNzZjZTc3ZjRjNWU=

data/CHANGES

@@ -1,3 +1,6 @@
+2013-11-15 Clinton Wolfe 0.3.1
+   regex check should violate, but not throw exception, when given a non-string
+
 2013-11-12 Clinton Wolfe 0.3.0 
    Support for enum check 
    Support for proc check
@@ -10,3 +13,4 @@
    Initial release
      Type, Regex, Min/Max Children, Required, and LooksLike checks
      No wildcards in paths yet, planned for 0.2.0
+ 

data/lib/chef-attribute-validator/checks/regex.rb

@@ -16,8 +16,12 @@ class Chef
             violations = []
             attrset.each do |path, value|
               if val_scalar?(value)
-                unless check_arg.match(value)
-                  violations.push Chef::Attribute::Validator::Violation.new(rule_name, path, "Attribute's value is '#{value}', which does not match regex '#{check_arg}'")
+                if value.respond_to?(:match)
+                  unless check_arg.match(value)
+                    violations.push Chef::Attribute::Validator::Violation.new(rule_name, path, "Attribute's value is '#{value}', which does not match regex '#{check_arg}'")
+                  end
+                else
+                  violations.push Chef::Attribute::Validator::Violation.new(rule_name, path, "Attribute's value is '#{value}' (class #{value.class.name}), which is cannot be regexed")
                 end
               end
             end

data/lib/chef-attribute-validator/version.rb

@@ -1,7 +1,7 @@
 class Chef
   class Attribute
     class Validator
-      VERSION = "0.3.0"
+      VERSION = "0.3.1"
     end
   end
 end

data/test/fixtures/check_regex_assorted.rb

@@ -5,7 +5,9 @@ default['foo'] = 'foo'
 default['bar'] = 'bar'
 default['chow'] = 'food'
 default['vittles'] = 'victuals'
-
+default['nil'] = nil
+default['false'] = false
+default['one'] = 1
 
 rules = default['attribute-validator']['rules']
 
@@ -40,3 +42,17 @@ rules['not-foo-foo'] = {
 }
 
 
+rules['foo-nil'] = {
+  'path' =>  '/nil',
+  'regex' => /foo/,
+}
+
+rules['foo-false'] = {
+  'path' =>  '/false',
+  'regex' => /foo/,
+}
+
+rules['foo-one'] = {
+  'path' =>  '/one',
+  'regex' => /foo/,
+}

data/test/unit/check_regex_spec.rb

@@ -57,6 +57,17 @@ describe "'regex' check" do
     it "/^(?!foo)/ should violate on foo" do
       expect(av.validate_rule('not-foo-foo')).not_to be_empty
     end      
+
+    it "/foo/ should violate on false" do
+      expect { av.validate_rule('foo-false') }.not_to raise_error
+      expect(av.validate_rule('foo-false')).not_to be_empty
+    end      
+
+    it "/foo/ should violate on 1" do
+      expect { av.validate_rule('foo-one') }.not_to raise_error
+      expect(av.validate_rule('foo-one')).not_to be_empty
+    end      
+
   end
 
 end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: chef-attribute-validator
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: !binary |-
+    MC4zLjE=
 platform: ruby
 authors:
 - Clinton Wolfe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-13 00:00:00.000000000 Z
+date: 2013-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler