chef-ab 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3aebb2e9a4778eb4ffc77c8620d385b360378621
-  data.tar.gz: 0b7ff68f22a22eefc7408b8b143186133c75f72d
+  metadata.gz: f941833b7b4fe75090a0c98ef524d49bccf72588
+  data.tar.gz: 17240bd5f539b85ec8f17f28db9b650e3fdec454
 SHA512:
-  metadata.gz: abc1624e92a5ec34f8c139ee48b03fa598fd0cece96f2a5e3beaae60db2acbe54853f24c0dd249ab851a90844dad42c891df6694053109f78a383b8314363bb8
-  data.tar.gz: 956354c9bf5954621022a34f3861afc291fd76618199de5aab4b0a09aac1f52b3e6ba6e34282e88a26d505f7a37b3b99b268930053bc058e5309dbf7b6045cd3
+  metadata.gz: c1f49e9230833de64e993c2ad78b892219aa959d89dd4fceaa34dd8dd940e8280c0ecc94e28ccc3a18d4cbe6919fcfa0286357db41f201dba0a329d717b65a49
+  data.tar.gz: 0c2a99eb2fd61742c0d5b272fee54b4e93808f739d7dd179ba5ee90d7ef6b3395fafbe9b03c4d2d590780763d6e61f76682cc3af1861ecae8bbd4c74e99086cf

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    chef-ab (0.1.1)
+    chef-ab (0.2.0)
       backports
       ipaddress
 

data/README.md

@@ -15,19 +15,13 @@ Very simple example in attribute file of :
 # value before upgrade
 default[:a_cookbook][:activate_experimental_feature] = false
 
-# plumbing
-one_week_in_secs = 7 * 86400
-start_time = Time.new(2014, 02, 11, 8, 30, 00, "+01:00")
-end_time = start_time + one_week_in_secs
-
 upgrade = ChefAB::TimeLinearUpgrader.new(
-  node['fqdn'], # we use fqdn as id for the migration
-  start_time,
-  end_time
+  node_id: node['fqdn'], # we use fqdn as id for the migration
+  start_time: Time.new(2014, 02, 11, 8, 30, 00, "+01:00"),
+  end_time:   Time.new(2014, 02, 18, 8, 30, 00, "+01:00")
 )
 
 upgrade.execute do
-  # value after upgrade
   default[:a_cookbook][:activate_experimental_feature] = true
 end
 
@@ -42,18 +36,14 @@ Another example, upgrading nodes exponentially depending on distance to a given
 # value before upgrade
 default[:a_cookbook][:activate_experimental_feature] = false
 
-# plumbing
-start_time = Time.new(2014, 02, 11, 8, 30, 00, "+01:00")
-period = 3600 # going larger every hour
-first_node = "10.11.12.13"
-
-upgrade = ChefAB::TimeIPBasedUpgrader.new node['ipaddress'],
-  start_time,
-  period,
-  first_node
+upgrade = ChefAB::TimeIPBasedUpgrader.new(
+  node_id: node['ipaddress'],
+  start_time: Time.new(2014, 02, 11, 8, 30, 00, "+01:00"),
+  period: 3600, #going larger every hour
+  first_node: "10.11.12.13"
+)
 
 upgrade.execute do
-  # value after upgrade
   default[:a_cookbook][:activate_experimental_feature] = true
 end
 ```

data/chef_ab.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "chef-ab"
-  s.version     = '0.1.1'
+  s.version     = '0.2.0'
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Grégoire Seux"]
   s.license     = "Apache License v2"

data/lib/chef-ab/base_upgrader.rb

@@ -4,12 +4,13 @@ module ChefAB
   class BaseUpgrader
     attr_accessor :node_id, :hash
 
-    def initialize(node_id)
-      @node_id = node_id
-      if node_id.is_a? Integer
+    def initialize(options)
+      @node_id = options[:node_id]
+      raise "node_id is a mandatory options" unless @node_id
+      if @node_id.is_a? Integer
         @hash = node_id
       else
-        @hash = Zlib.crc32 (node_id.to_s)
+        @hash = Zlib.crc32 (@node_id.to_s)
       end
     end
 

data/lib/chef-ab/time_ipbased_upgrader.rb

@@ -8,11 +8,12 @@ module ChefAB
     attr_accessor :start_time, :period
     attr_accessor :initial_ip
 
-    def initialize(node_ip, start_time, period, initial_ip)
-      super(ip_metric(initial_ip, node_ip))
-      @start_time = start_time.to_i
-      @period = period
-      @end_time = 31 * period + @start_time
+    def initialize(options)
+      options[:node_id] = ip_metric(options[:initial_ip], options[:node_id])
+      super(options)
+      @start_time = options[:start_time].to_i
+      @period = options[:period]
+      @end_time = 31 * @period + @start_time
     end
 
     def should_execute?(time = nil)

data/lib/chef-ab/time_linear_upgrader.rb

@@ -5,11 +5,11 @@ module ChefAB
 
     attr_accessor :start_time, :end_time
 
-    def initialize(node_id, start_time, end_time)
-      super(node_id)
-      @start_time = start_time.to_i
-      @end_time = end_time.to_i
-      upgrade_span = end_time - start_time
+    def initialize(options)
+      super(options)
+      @start_time = options[:start_time].to_i
+      @end_time = options[:end_time].to_i
+      upgrade_span = @end_time - @start_time
       @hash = @hash % upgrade_span
     end
 

data/spec/base_upgrader_spec.rb

@@ -3,11 +3,11 @@ require_relative '../lib/chef-ab.rb'
 
 describe ChefAB::BaseUpgrader do
   it 'should have an integer hash' do
-    up = ChefAB::BaseUpgrader.new 5
+    up = ChefAB::BaseUpgrader.new(node_id: 5)
     expect(up.hash).to be_a_kind_of(Integer)
   end
   it 'should have an integer hash in any case' do
-    up = ChefAB::BaseUpgrader.new "testing node"
+    up = ChefAB::BaseUpgrader.new(node_id: "testing node")
     expect(up.hash).to be_a_kind_of(Integer)
   end
 end

data/spec/time_ipbased_spec.rb

@@ -14,16 +14,20 @@ end
 describe ChefAB::TimeIPBasedUpgrader do
 
   def future_upgrade
-    ChefAB::TimeIPBasedUpgrader.new "192.168.17.1",
-      (Time.now + 10),
-      3600,
-      "192.168.17.1"
+    ChefAB::TimeIPBasedUpgrader.new(
+      node_id: "192.168.17.1",
+      start_time: Time.now + 10,
+      period: 3600,
+      initial_ip: "192.168.17.1"
+    )
   end
   def past_upgrade
-    ChefAB::TimeIPBasedUpgrader.new "192.168.17.1",
-      (Time.now - 10),
-      3600,
-      "192.168.17.1"
+    ChefAB::TimeIPBasedUpgrader.new(
+      node_id: "192.168.17.1",
+      start_time: Time.now - 10,
+      period: 3600,
+      initial_ip: "192.168.17.1"
+    )
   end
 
   it 'should not execute before start of upgrade' do
@@ -45,10 +49,12 @@ describe ChefAB::TimeIPBasedUpgrader do
   it 'should not call block before expected_activation and should always do after' do
     start_time = 42 #any timestamp
     period = 10
-    up = ChefAB::TimeIPBasedUpgrader.new "192.168.18.23",
-      start_time,
-      period,
-      "192.168.17.1"
+    up = ChefAB::TimeIPBasedUpgrader.new(
+      node_id: "192.168.18.23",
+      start_time: start_time,
+      period: period,
+      initial_ip: "192.168.17.1"
+    )
 
     end_time = 42 + 32 * period
 

data/spec/time_linear_spec.rb

@@ -14,10 +14,18 @@ end
 describe ChefAB::TimeLinearUpgrader do
 
   def future_upgrade
-    ChefAB::TimeLinearUpgrader.new "testing node", (Time.now + 10), (Time.now + 3600)
+    ChefAB::TimeLinearUpgrader.new(
+      node_id: "testing node",
+      start_time: Time.now + 10,
+      end_time: Time.now + 3600
+    )
   end
   def past_upgrade
-    ChefAB::TimeLinearUpgrader.new "testing node", (Time.now - 10), (Time.now - 5)
+    ChefAB::TimeLinearUpgrader.new(
+      node_id: "testing node",
+      start_time: Time.now - 10,
+      end_time: Time.now - 5
+    )
   end
 
   it 'should not execute before start of upgrade' do
@@ -39,7 +47,11 @@ describe ChefAB::TimeLinearUpgrader do
   it 'should not call block before expected_activation and should always do after' do
     start_time = 42 #any timestamp
     end_time = 60
-    up = ChefAB::TimeLinearUpgrader.new "testing node", start_time, end_time
+    up = ChefAB::TimeLinearUpgrader.new(
+      node_id: "testing node",
+      start_time: start_time,
+      end_time: end_time
+    )
 
     first_execute_time = up.expected_activation
 
@@ -56,7 +68,11 @@ describe ChefAB::TimeLinearUpgrader do
   it 'should return correct expected_activation' do
     start_time = 42 #any timestamp
     end_time = 50
-    up = ChefAB::TimeLinearUpgrader.new 5, start_time, end_time
+    up = ChefAB::TimeLinearUpgrader.new(
+      node_id: 5,
+      start_time: start_time,
+      end_time: end_time
+    )
     expect(up.expected_activation).to eq(42 + 5 +1)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chef-ab
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Grégoire Seux