checkoff 0.38.0 → 0.39.0

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: fb28394467995eb9df10b9fa896614dca20ef97b0759c2945bb3baaf98ba0d56
4
- data.tar.gz: 3b565699736d8956d83a94e8c93d910ecfac4f7f65280e27303d0da8dd3fd6ff
3
+ metadata.gz: d4aa495392c511216d69ccb2d8ba6fa8efa6fb6a2466fad23dca9f8ee89ff9fa
4
+ data.tar.gz: 0a48cd6720b49c8b7988ad8469f5b6ca3b89a5a2abeff47855386560a495c007
5
5
  SHA512:
6
- metadata.gz: 3cfeaa16ebe32cda3959dfce64b72382e743d5dcf40a2d1771c2b2d725594f8d505f094139163bca7e6059908b02d5811260c75b7670126a1bcdf22fb306c9f6
7
- data.tar.gz: 9066df52dadb002a5b8bd34a7a1fc852d1e45b4543202e21995dee9e491703357ba305b612c5772d5c9c0153e5c7245c9304988e0f5751b608bfbe03e420d214
6
+ metadata.gz: 7c9535b045a9a35fd7a5df91d01f843d001c1f51761a638d50474c6437aa75781871d9afecb85664eb90a35e06a9b5be4511f8a943ca9928ab042c30fc7881e1
7
+ data.tar.gz: 03ced5118890e61a65defd98e65cc3cde499861959da931287e6430cb3dc024215157584d45307269dd2fd0428f39bff54958d503520c7b5f823ad2de25c5d38
@@ -49,7 +49,7 @@ module Overcommit
49
49
  message = error.sub("#{file_path}:#{lineno} - ",
50
50
  "#{file_path}:#{lineno}: ")
51
51
  # Emit the errors in the specified format
52
- Overcommit::Hook::Message.new(:error, file, lineno, message)
52
+ Overcommit::Hook::Message.new(:error, file, lineno.to_i, message)
53
53
  end
54
54
  end
55
55
  end
data/.overcommit.yml CHANGED
@@ -25,7 +25,6 @@ PreCommit:
25
25
  quiet: true
26
26
  RuboCop:
27
27
  enabled: true
28
- on_warn: fail # Treat all warnings as failures
29
28
  command: ['bundle', 'exec', 'rubocop']
30
29
  include:
31
30
  - '**/*.gemspec'
@@ -36,6 +35,7 @@ PreCommit:
36
35
  - '**/Rakefile'
37
36
  - 'bin/*'
38
37
  - 'exe/*'
38
+ problem_on_unmodified_line: warn
39
39
  exclude:
40
40
  - db/migrate/*.rb
41
41
  - db/schema.rb
@@ -60,7 +60,7 @@ PreCommit:
60
60
  enabled: true
61
61
  SolargraphTypecheck:
62
62
  enabled: true
63
- on_warn: fail
63
+ problem_on_unmodified_line: warn
64
64
  include:
65
65
  - '**/*.rb'
66
66
  Punchlist:
data/.rubocop.yml CHANGED
@@ -5,6 +5,10 @@ Layout/LineLength:
5
5
  Layout/MultilineMethodCallIndentation:
6
6
  EnforcedStyle: indented
7
7
 
8
+ Lint/EmptyClass:
9
+ # some workarounds for circular dependencies require empty classes
10
+ AllowComments: true
11
+
8
12
  Lint/UnusedMethodArgument:
9
13
  AllowUnusedKeywordArguments: true
10
14
 
@@ -79,6 +83,11 @@ Style/StringLiterals:
79
83
  - double_quotes
80
84
  ConsistentQuotesInMultiline: true
81
85
 
86
+ # Solargraph needs to see a class inherited from Struct to recognize
87
+ # what's going on
88
+ Style/StructInheritance:
89
+ Enabled: false
90
+
82
91
  # I like trailing commas in arrays and hashes. They let me insert new
83
92
  # elements and see them as one line in a diff, not two.
84
93
  Style/TrailingCommaInArrayLiteral:
data/Gemfile.lock CHANGED
@@ -12,7 +12,7 @@ GIT
12
12
  PATH
13
13
  remote: .
14
14
  specs:
15
- checkoff (0.38.0)
15
+ checkoff (0.39.0)
16
16
  activesupport
17
17
  asana (> 0.10.0)
18
18
  cache_method
@@ -99,9 +99,14 @@ module Checkoff
99
99
  # handle 'subtask' search url param
100
100
  class Subtask < SimpleParam
101
101
  def convert
102
- return ['is_subtask', false] if single_value == 'is_not_subtask'
103
-
104
- raise "Teach me how to handle #{key} = #{values}"
102
+ case single_value
103
+ when 'is_not_subtask'
104
+ ['is_subtask', false]
105
+ when 'is_subtask'
106
+ ['is_subtask', true]
107
+ else
108
+ raise "Teach me how to handle #{key} = #{values}"
109
+ end
105
110
  end
106
111
  end
107
112
 
@@ -3,5 +3,5 @@
3
3
  # Command-line and gem client for Asana (unofficial)
4
4
  module Checkoff
5
5
  # Version of library
6
- VERSION = '0.38.0'
6
+ VERSION = '0.39.0'
7
7
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: checkoff
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.38.0
4
+ version: 0.39.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Vince Broz