checkoff 0.258.0 → 0.260.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cacf5e2fbe9fab040accd8cd51804fcf3f07cf0e6f050c93ecbe2da2c930bdc5
-  data.tar.gz: ebfe6f20e1be062a918afac5a4703df7a0d5205c69cb8d0479d5f6427c467767
+  metadata.gz: e08117848a46a27ffee42a7936ada4febefdda2c2d9a44ae0160dcdfa89989b8
+  data.tar.gz: a8573c8961ab241c73425008c5c9a44f03c6038a4a3ad791b3154b505cd4ee22
 SHA512:
-  metadata.gz: cddee9806d41d98908eca0331b3b52ee84b45968e419aad7b8817003389418f65e9536b02c2db20b2368796b447046b7093819b094ba01dcd7c59875eb404562
-  data.tar.gz: 82b6db32f7d6ad50d287da1fba1a537468f94aa283d60358fcf4a03953df86c41dc00da2dd514cfdbd838bd5ce2209f11e97966f00814e27fe1640cf8ad41cb3
+  metadata.gz: 43b8c4f4ff4d1fcd48a98d0fe2b7fdc6332ab29e83b81f2dad3a9a9ec3628f3c106c4ea518ae81b0e9edc882bf9618396b547c099e6dc1fb22f76d5c91ed6cd5
+  data.tar.gz: 2da763b8482d3e7a6f7e8fe8b912ef2c8175d6843da3019fc10a7aae9ea94d3978a9ed789763f5fee8d7755200f80bd04268b332ab74b2865fd6303823c99e34

data/lib/checkoff/attachments.rb

@@ -85,9 +85,10 @@ module Checkoff
     # @return [Object]
     def download_uri(uri, verify_mode: OpenSSL::SSL::VERIFY_PEER, &block)
       out = nil
-      Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https', verify_mode:) do |http|
-        # @sg-ignore Unresolved constant Net::HTTP::Get / Unresolved call to request —
-        #   stdlib RBS gap on Net::HTTP block param types
+      host = uri.host || raise("URI has no host: #{uri}")
+      Net::HTTP.start(host, uri.port, use_ssl: uri.scheme == 'https', verify_mode:) do |http|
+        # @sg-ignore tool-limitation:pr-1290-follow-up
+        #   https://github.com/castwide/solargraph/pull/1290#issuecomment-5272957964
         http.request(Net::HTTP::Get.new(uri)) do |response|
           raise("Unexpected response code: #{response.code}") unless response.code == '200'
 
@@ -108,7 +109,6 @@ module Checkoff
     def write_tempfile_from_response(response)
       Tempfile.create('checkoff') do |tempfile|
         tempfile.binmode
-        # @sg-ignore Unresolved call to read_body on #read_body
         response.read_body do |chunk|
           tempfile.write(chunk)
         end
@@ -128,16 +128,15 @@ module Checkoff
     def create_attachment_from_downloaded_url!(url, resource, attachment_name:,
                                                verify_mode: OpenSSL::SSL::VERIFY_PEER)
       uri = URI(url)
-      attachment_name ||= File.basename(uri.path)
+      # @type [String]
+      resolved_attachment_name = attachment_name || File.basename(uri.path || '')
       download_uri(uri, verify_mode:) do |tempfile|
-        # @sg-ignore attachment_name reassignment above isn't narrowed from the declared
-        #   [String, nil] param type — needs a fresh typed local, deferred to a follow-up code PR
-        content_type ||= content_type_from_filename(attachment_name)
-        # @sg-ignore URI::Generic#path can be nil
-        content_type ||= content_type_from_filename(uri.path)
-
-        # @sg-ignore same attachment_name/content_type narrowing gap as above
-        resource.attach(filename: attachment_name, mime: content_type,
+        content_type = content_type_from_filename(resolved_attachment_name)
+        content_type ||= content_type_from_filename(uri.path || '')
+        # neither the attachment name nor the URL's path has a MIME-recognizable extension
+        content_type ||= 'application/octet-stream'
+
+        resource.attach(filename: resolved_attachment_name, mime: content_type,
                         io: tempfile)
       end
     end
@@ -196,8 +195,8 @@ module Checkoff
         tasks = Checkoff::Tasks.new
         attachments = Checkoff::Attachments.new
         task = tasks.task_by_gid(gid)
-        # @sg-ignore task_by_gid can return nil; needs a raise-if-nil guard, deferred to a
-        #   follow-up code PR
+        raise "Could not find task #{gid}" if task.nil?
+
         attachment = attachments.create_attachment_from_url!(url, task)
         puts "Results: #{attachment.inspect}"
       end

data/lib/checkoff/cli.rb

@@ -161,7 +161,7 @@ module Checkoff
     # @param workspace_name [String]
     # @param project_name [String, Symbol]
     # @param section_name [String, Symbol, nil]
-    # @param task_name [String, Symbol, nil]
+    # @param task_name [String, nil]
     # @param config [Checkoff::Internal::EnvFallbackConfigLoader, Hash]
     # @param projects [Checkoff::Projects]
     # @param sections [Checkoff::Sections]
@@ -192,7 +192,6 @@ module Checkoff
       elsif task_name.nil?
         run_on_section(workspace_name, project_name, section_name)
       else
-        # @sg-ignore task_name.nil? above isn't inferred as narrowing the task_name accessor's return
         run_on_task(workspace_name, project_name, section_name, task_name)
       end
     end
@@ -243,7 +242,6 @@ module Checkoff
       task = tasks.task(workspace.to_s, project, task_name, section_name: section)
       raise "Task not found: #{task_name}" if task.nil?
 
-      # @sg-ignore nil check above is not flow-sensitive
       task_to_hash(task).to_json
     end
 
@@ -311,8 +309,9 @@ module Checkoff
     desc 'Add a short task to Asana'
     arg 'workspace'
     arg 'task_name'
+    # @param c [GLI::Command]
     command :quickadd do |c|
-      # @sg-ignore GLI's DSL block methods (c.flag/c.action) aren't resolved
+      # @param args [Array<String>]
       c.action do |_global_options, _options, args|
         workspace_name = args.fetch(0)
         task_name = args.fetch(1)
@@ -326,8 +325,9 @@ module Checkoff
     arg 'project'
     arg 'section', :optional
     arg 'task_name', :optional
+    # @param c [GLI::Command]
     command :view do |c|
-      # @sg-ignore GLI's DSL block methods (c.flag/c.action) aren't resolved
+      # @param args [Array<String>]
       c.action do |_global_options, _options, args|
         workspace_name = args.fetch(0)
         project_name = args.fetch(1)
@@ -341,38 +341,33 @@ module Checkoff
     desc 'Move tasks from one section to another within a project'
 
     # rubocop:disable Metrics/BlockLength
+    # @param c [GLI::Command]
     command :mv do |c|
-      # @sg-ignore GLI's DSL block methods (c.flag/c.action) aren't resolved
       c.flag :from_workspace,
              type: String,
              default_value: :default_workspace,
              desc: 'Workspace to move tasks from'
-      # @sg-ignore GLI's DSL block methods (c.flag/c.action) aren't resolved
       c.flag :from_project,
              type: String,
              required: true,
              desc: 'Project to move tasks from'
-      # @sg-ignore GLI's DSL block methods (c.flag/c.action) aren't resolved
       c.flag :from_section,
              type: String,
              default_value: :all_sections,
              desc: 'Section to move tasks from'
-      # @sg-ignore GLI's DSL block methods (c.flag/c.action) aren't resolved
       c.flag :to_workspace,
              type: String,
              default_value: :source_workspace,
              desc: 'Workspace to move tasks to'
-      # @sg-ignore GLI's DSL block methods (c.flag/c.action) aren't resolved
       c.flag :to_project,
              type: String,
              default_value: :source_project,
              desc: 'Section to move tasks to'
-      # @sg-ignore GLI's DSL block methods (c.flag/c.action) aren't resolved
       c.flag :to_section,
              type: String,
              default_value: :source_section,
              desc: 'Section to move tasks to'
-      # @sg-ignore GLI's DSL block methods (c.flag/c.action) aren't resolved
+      # @param options [Hash]
       c.action do |_global_options, options, _args|
         from_workspace = options.fetch('from_workspace')
         from_project = options.fetch('from_project')

data/lib/checkoff/clients.rb

@@ -30,9 +30,7 @@ module Checkoff
     # @return [Asana::Client]
     def client
       @client ||= @asana_client_class.new do |c|
-        # @sg-ignore Unresolved call to authentication — gem config DSL block, not covered by annotations
         c.authentication :access_token, @config.fetch(:personal_access_token)
-        # @sg-ignore Unresolved call to default_headers — gem config DSL block, not covered by annotations
         c.default_headers 'asana-enable' =>
                           'new_project_templates,new_user_task_lists,new_memberships,new_goal_memberships'
       end

data/lib/checkoff/custom_fields.rb

@@ -41,7 +41,6 @@ module Checkoff
     # @param custom_field_name [String]
     #
     # @return [Asana::Resources::CustomField]
-    # @sg-ignore nil check above is not flow-sensitive
     def custom_field_or_raise(workspace_name, custom_field_name)
       cf = custom_field(workspace_name, custom_field_name)
       raise "Could not find custom_field #{custom_field_name} under workspace #{workspace_name}." if cf.nil?
@@ -79,40 +78,32 @@ module Checkoff
     # @param resource [Asana::Resources::Project,Asana::Resources::Task]
     # @param custom_field_name [String]
     # @return [Array<String>]
-    # @sg-ignore Declared return type Array<String> does not match inferred type Array,Array<Array> —
-    #   fixing cleanly needs binding enum_value.fetch('name') to a typed local; leaving for a
-    #   follow-up code PR to keep this one annotation-only.
     def resource_custom_field_values_names_by_name(resource, custom_field_name)
       custom_field = resource_custom_field_by_name(resource, custom_field_name)
       return [] if custom_field.nil?
 
       resource_custom_field_enum_values(custom_field).flat_map do |enum_value|
-        if enum_value.nil?
-          []
-        else
-          [enum_value.fetch('name')]
-        end
+        [enum_value.fetch('name')]
       end
     end
 
     # @param resource [Asana::Resources::Task,Asana::Resources::Project]
     # @param custom_field_name [String]
-    # @return [Hash, nil]
+    # @return [Hash{String => Object}, nil]
     def resource_custom_field_by_name(resource, custom_field_name)
-      # @type [Array<Hash>]
+      # @type [Array<Hash{String => Object}>]
       custom_fields = resource.custom_fields
       if custom_fields.nil?
         raise "custom fields not found on resource - did you add 'custom_fields' in your extra_fields argument?"
       end
 
-      # @type [Hash, nil]
+      # @type [Hash{String => Object}, nil]
       custom_fields.find { |field| field.fetch('name') == custom_field_name }
     end
 
     # @param resource [Asana::Resources::Task,Asana::Resources::Project]
     # @param custom_field_name [String]
-    # @return [Hash]
-    # @sg-ignore nil check above is not flow-sensitive
+    # @return [Hash{String => Object}]
     def resource_custom_field_by_name_or_raise(resource, custom_field_name)
       custom_field = resource_custom_field_by_name(resource, custom_field_name)
       if custom_field.nil?
@@ -124,16 +115,15 @@ module Checkoff
 
     # @param resource [Asana::Resources::Project,Asana::Resources::Task]
     # @param custom_field_gid [String]
-    # @return [Hash]
-    # @sg-ignore nil check above is not flow-sensitive
+    # @return [Hash{String => Object}]
     def resource_custom_field_by_gid_or_raise(resource, custom_field_gid)
-      # @type [Array<Hash>]
+      # @type [Array<Hash{String => Object}>]
       custom_fields = resource.custom_fields
       if custom_fields.nil?
         raise "Could not find custom_fields under project (was 'custom_fields' included in 'extra_fields'?)"
       end
 
-      # @type [Hash, nil]
+      # @type [Hash{String => Object}, nil]
       matched_custom_field = custom_fields.find { |data| data.fetch('gid') == custom_field_gid }
       if matched_custom_field.nil?
         raise "Could not find custom field with gid #{custom_field_gid} " \
@@ -145,12 +135,11 @@ module Checkoff
 
     private
 
-    # @param custom_field [Hash{String => Hash,Array<Hash>}]
+    # rubocop:disable Layout/LineLength, YARD/TagTypeSyntax
+    # @param custom_field [Hash{"resource_subtype" => String} & Hash{"enum_value" => Hash} & Hash{"multi_enum_values" => Array<Hash>}]
     #
-    # @return [Array<Hash>]
-    # @sg-ignore Declared return type Array<Hash> does not match inferred type Array,Hash,Array<Hash> —
-    #   fixing cleanly needs restructuring the case/when to bind each branch to a typed local; leaving
-    #   for a follow-up code PR to keep this one annotation-only.
+    # @return [Array<Hash{"gid" => String} & Hash{"name" => String}>]
+    # rubocop:enable Layout/LineLength, YARD/TagTypeSyntax
     def resource_custom_field_enum_values(custom_field)
       resource_subtype = custom_field.fetch('resource_subtype')
       case resource_subtype
@@ -163,7 +152,7 @@ module Checkoff
       end
     end
 
-    # @param custom_field [Hash]
+    # @param custom_field [Hash{String => Object}]
     # @param enum_value [Hash{String => String}, nil]
     # @return [Array<String>]
     def find_gids(custom_field, enum_value)

data/lib/checkoff/internal/asana_event_enrichment.rb

@@ -69,16 +69,14 @@ module Checkoff
       #
       # @return [void]
       def enrich_webhook_subscription!(webhook_subscription)
-        webhook_subscription&.fetch('filters', nil)&.map! do |filter|
+        return if webhook_subscription.nil?
+
+        webhook_subscription.fetch('filters', nil)&.map! do |filter|
           enrich_filter(filter)
         end
-        resource = webhook_subscription&.fetch('resource', nil)
+        resource = webhook_subscription.fetch('resource', nil)
         name, resource_type = enrich_gid(resource) if resource
-        # @sg-ignore webhook_subscription is declared [Hash, nil] but this line assumes non-nil
-        #   without the &. used elsewhere in this method — looks like a real nil-safety gap, not
-        #   just a typing gap; flagging for the follow-up code PR rather than silently widening
         webhook_subscription['checkoff:enriched:name'] = name if name
-        # @sg-ignore same nil-safety gap as above
         webhook_subscription['checkoff:enriched:resource_type'] = resource_type if resource_type
       end
 
@@ -100,8 +98,8 @@ module Checkoff
       #
       # @return [void]
       def enrich_filter_parent_gid!(filter)
-        parent_gid = T.cast(filter['checkoff:parent.gid'], T.nilable(String))
-        return unless parent_gid
+        parent_gid = filter['checkoff:parent.gid']
+        return unless parent_gid.is_a?(String)
 
         name, resource_type = enrich_gid(parent_gid)
         filter['checkoff:enriched:parent.name'] = name if name
@@ -112,9 +110,9 @@ module Checkoff
       #
       # @return [void]
       def enrich_filter_resource!(filter)
-        resource_gid = T.cast(filter['checkoff:resource.gid'], T.nilable(String))
+        resource_gid = filter['checkoff:resource.gid']
 
-        return unless resource_gid
+        return unless resource_gid.is_a?(String)
 
         task = tasks.task_by_gid(resource_gid)
         task_name = task&.name
@@ -125,8 +123,8 @@ module Checkoff
       #
       # @return [void]
       def enrich_filter_section!(filter)
-        section_gid = T.cast(filter['checkoff:fetched.section.gid'], T.nilable(String))
-        return unless section_gid
+        section_gid = filter['checkoff:fetched.section.gid']
+        return unless section_gid.is_a?(String)
 
         section = sections.section_by_gid(section_gid)
         name = section&.name
@@ -143,12 +141,8 @@ module Checkoff
         return unless parent
 
         # @type [String]
-        # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-        # https://github.com/castwide/solargraph/pull/1228
         resource_type = parent.fetch('resource_type')
         # @type [String]
-        # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-        # https://github.com/castwide/solargraph/pull/1228
         gid = parent.fetch('gid')
         name, _resource_type = enrich_gid(gid, resource_type:)
         parent['checkoff:enriched:name'] = name if name
@@ -161,15 +155,11 @@ module Checkoff
       # @return [void]
       def enrich_event_resource!(asana_event)
         # @type [Hash{String => String}]
-        resource = T.cast(asana_event['resource'], T::Hash[String, String])
+        resource = asana_event['resource']
         # @type [String]
-        # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-        # https://github.com/castwide/solargraph/pull/1228
         resource_type = resource.fetch('resource_type')
 
         # @type [String]
-        # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-        # https://github.com/castwide/solargraph/pull/1228
         gid = resource.fetch('gid')
 
         name, _resource_type = enrich_gid(gid, resource_type:)

data/lib/checkoff/internal/asana_event_filter.rb

@@ -52,7 +52,7 @@ module Checkoff
 
       private
 
-      # @param filter [Hash]
+      # @param filter [Hash{String => String, Array<String>}]
       # @param asana_event [Hash]
       # @param failures [Array<String>]
       #
@@ -122,8 +122,6 @@ module Checkoff
         # @type [Hash{String => String}]
         resource = asana_event.fetch('resource')
         # @type [String]
-        # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-        # https://github.com/castwide/solargraph/pull/1228
         resource_type = resource.fetch('resource_type')
         unless resource_type == 'task'
           raise "Teach me how to check #{key.inspect} on resource type #{resource_type.inspect}"
@@ -133,8 +131,6 @@ module Checkoff
         options = {
           fields:,
         }
-        # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-        # https://github.com/castwide/solargraph/pull/1228
         @client.tasks.find_by_id(task_gid, options:)
       rescue Asana::Errors::NotFound
         nil

data/lib/checkoff/internal/config_loader.rb

@@ -20,12 +20,10 @@ module Checkoff
 
       # @param key [Symbol]
       # @return [Object]
-      # @sg-ignore return type could not be inferred — cascades from the ENV.fetch RBS gap below
       def [](key)
         config_value = @config[key]
         return config_value unless config_value.nil?
 
-        # @sg-ignore Unresolved call to fetch on RBS::Unnamed::ENVClass, Class<ENV>
         ENV.fetch(envvar_name(key), nil)
       end
 

data/lib/checkoff/internal/logging.rb

@@ -57,10 +57,8 @@ module Logging
   private
 
   # @return [Symbol]
-  # @sg-ignore return type could not be inferred — cascades from the ENV.fetch RBS gap below
   def log_level
     # rubocop:disable Style/RedundantFetchBlock
-    # @sg-ignore Unresolved call to fetch on RBS::Unnamed::ENVClass, Class<ENV>
     ENV.fetch('LOG_LEVEL') { 'INFO' }.downcase.to_sym
     # rubocop:enable Style/RedundantFetchBlock
   end

data/lib/checkoff/internal/project_hashes.rb

@@ -10,9 +10,10 @@ module Checkoff
       def initialize(_deps = {}); end
 
       # @param project_obj [Asana::Resources::Project]
-      # @param project [String, Symbol] - :not_specified, :my_tasks
+      # @param project [String, :not_specified, :my_tasks, nil] - a String is a
+      #   project name
       #
-      # @return [Hash]
+      # @return [Hash{String => Object}]
       def project_to_h(project_obj, project: :not_specified)
         project = project_obj.name if project == :not_specified
         project_hash = { **project_obj.to_h, 'project' => project }
@@ -26,8 +27,8 @@ module Checkoff
       # @param project_hash [Hash]
       # @return [void]
       def unwrap_custom_fields(project_hash)
-        # @type [Array<Hash>,nil]
-        custom_fields = project_hash.fetch('custom_fields', nil)
+        # @type [Array<Hash{String => Object}>,nil]
+        custom_fields = project_hash['custom_fields']
 
         return if custom_fields.nil?
 

data/lib/checkoff/internal/search_url/custom_field_param_converter.rb

@@ -41,7 +41,7 @@ module Checkoff
           end.transform_values(&:to_h)
         end
 
-        # @type [Hash{String => Class<CustomFieldVariant>}]
+        # @type [Hash{String => Class<CustomFieldVariant::CustomFieldVariant>}]
         VARIANTS = {
           'is' => CustomFieldVariant::Is,
           'no_value' => CustomFieldVariant::NoValue,
@@ -59,20 +59,15 @@ module Checkoff
         # @param gid [String]
         # @param single_custom_field_params [Hash{String => Array<String>}]
         # @return [Array(Hash{String => String}, Array<Symbol, Array>)]
-        # @sg-ignore `unless variant_class.nil?` return value isn't inferred as the declared tuple type
         def convert_single_custom_field_params(gid, single_custom_field_params)
           variant_key = "custom_field_#{gid}.variant"
           variant = single_custom_field_params.fetch(variant_key)
           remaining_params = single_custom_field_params.reject { |k, _v| k == variant_key }
-          # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-          # https://github.com/castwide/solargraph/pull/1228
           raise "Teach me how to handle #{variant_key} = #{variant}" unless variant.length == 1
 
-          # @type [Class<CustomFieldVariant>, nil]
-          # @sg-ignore variant.length == 1 guard above isn't inferred as narrowing variant[0] to non-nil
+          # @type [Class<CustomFieldVariant::CustomFieldVariant>, nil]
           variant_class = VARIANTS[variant[0]]
           # @type [Array(Hash{String => String}, Array<Symbol, Array>)]
-          # @sg-ignore `unless variant_class.nil?` isn't inferred as narrowing the receiver in the same statement
           return variant_class.new(gid, remaining_params).convert unless variant_class.nil?
 
           raise "Teach me how to handle #{variant_key} = #{variant}"
@@ -80,10 +75,14 @@ module Checkoff
 
         # @param key [String]
         # @return [String]
-        # @sg-ignore split(...)[n]'s nilable Array indexing isn't inferred as the declared String return
         def gid_from_custom_field_key(key)
-          # @sg-ignore split(...)[n] is nilable Array indexing; key's shape guarantees enough parts here
-          key.split('_')[2].split('.')[0]
+          gid_and_suffix = key.split('_')[2]
+          raise "Unexpected custom field param key: #{key}" if gid_and_suffix.nil?
+
+          gid = gid_and_suffix.split('.')[0]
+          raise "Unexpected custom field param key: #{key}" if gid.nil?
+
+          gid
         end
 
         # @return [Hash{String => Array<String>}]

data/lib/checkoff/internal/search_url/custom_field_variant.rb

@@ -15,6 +15,13 @@ module Checkoff
             @remaining_params = T.let(remaining_params, T::Hash[String, T::Array[String]])
           end
 
+          # Implemented by every subclass.
+          #
+          # @return [Array(Hash{String => String}, Array<Symbol, Array>)]
+          def convert
+            raise NotImplementedError
+          end
+
           private
 
           # @return [String]
@@ -37,8 +44,6 @@ module Checkoff
             case remaining_params.keys
             when [param_name]
               # @type param_values [Array<String>]
-              # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-              # https://github.com/castwide/solargraph/pull/1228
               param_values = remaining_params.fetch(param_name)
               unless param_values.length == 1
                 raise "Teach me how to handle these remaining keys for #{param_name}: #{remaining_params}"

data/lib/checkoff/internal/search_url/date_param_converter.rb

@@ -15,7 +15,6 @@ module Checkoff
         end
 
         # @return [Array(Hash{String => String}, Array<Symbol, Array>)]
-        # @sg-ignore out can genuinely be nil if none of the 3 known prefixes matched; relies on the raise above it
         def convert
           return [{}, []] if date_url_params.empty?
 
@@ -30,11 +29,19 @@ module Checkoff
 
           raise "Teach me to handle these parameters: #{date_url_params.inspect}" unless date_url_params.empty?
 
-          out
+          ensure_matched!(out)
         end
 
         private
 
+        # @param out [Array(Hash{String => String}, Array<Symbol, Array>), nil]
+        # @return [Array(Hash{String => String}, Array<Symbol, Array>)]
+        def ensure_matched!(out)
+          return out if out
+
+          raise "no date param matched a known prefix: #{date_url_params.inspect}"
+        end
+
         # @param prefix [String]
         # @return [Array(Hash{String => String}, Array<Symbol, Array>)]
         def convert_for_prefix(prefix)
@@ -130,19 +137,17 @@ module Checkoff
 
         # @param param_key [String]
         # @return [String]
-        # @sg-ignore value.length == 1 guard above isn't inferred as narrowing value[0] to non-nil
         def get_single_param(param_key)
           raise "Expected #{param_key} to have at least one value" unless date_url_params.key? param_key
 
           value = date_url_params.fetch(param_key)
 
-          # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-          # https://github.com/castwide/solargraph/pull/1228
           raise "Expected #{param_key} to have one value" if value.length != 1
 
-          # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-          # https://github.com/castwide/solargraph/pull/1228
-          value[0]
+          single_value = value[0]
+          raise "Expected #{param_key} to have a non-nil value" if single_value.nil?
+
+          single_value
         end
 
         # @param prefix [String]
@@ -158,8 +163,6 @@ module Checkoff
         def validate_unit_is_day!(prefix)
           unit = date_url_params.fetch("#{prefix}.unit").fetch(0)
 
-          # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-          # https://github.com/castwide/solargraph/pull/1228
           raise "Teach me how to handle other time units: #{unit}" unless unit == 'day'
         end
 

data/lib/checkoff/internal/search_url/parser.rb

@@ -24,10 +24,8 @@ module Checkoff
         # @param url [String]
         # @return [Array(Hash{String => String}, Array)]
         def convert_params(url)
-          # @sg-ignore URI#query can be nil for a URL with no query string; CGI.parse expects
-          #   String — looks like a real gap (unhandled no-query-string case), not just a typing
-          #   gap, flagging for the follow-up code PR rather than silently asserting non-nil
-          url_params = CGI.parse(URI.parse(url).query)
+          # URI#query is nil for a URL with no query string; CGI.parse('') correctly yields {}
+          url_params = CGI.parse(URI.parse(url).query || '')
           custom_field_params, date_url_params, simple_url_params = partition_url_params(url_params)
           custom_field_args, custom_field_task_selector = convert_custom_field_params(custom_field_params)
           date_url_args, date_task_selector = convert_date_params(date_url_params)
@@ -61,11 +59,8 @@ module Checkoff
         # @return [Array(Hash{String => Array<String>}, Hash{String => Array<String>}, Hash{String => Array<String>})]
         def partition_url_params(url_params)
           groups = T.let(url_params.to_a.group_by do |key, _values|
-                           # @sg-ignore Unresolved call to start_with? — T.let wrapping this
-                           #   chained group_by block seems to block block-param inference
                            if key.start_with? 'custom_field_'
                              :custom_field
-                           # @sg-ignore Unresolved call to include? — same T.let/block-param gap
                            elsif key.include? '_date'
                              :date
                            else

data/lib/checkoff/internal/search_url/simple_param_converter.rb

@@ -34,7 +34,6 @@ module Checkoff
           public
 
           # @return [Array<String>]
-          # @sg-ignore abstract method always raises; declared type documents the override contract, not this body
           def convert
             raise 'Implement me!'
           end
@@ -242,7 +241,7 @@ module Checkoff
             entry
           end
           # @type [Hash{String => String}]
-          out = T.cast(arr_of_tuples.to_h, T::Hash[String, String])
+          out = arr_of_tuples.to_h
           unless out.include? 'sort_by'
             # keep results consistent between calls; API using default
             # sort_by does not seem to be.
@@ -277,8 +276,6 @@ module Checkoff
         # @return [Array<String>] the converted params, as an alternating key/value flat array
         def convert_arg(key, values)
           # @type [Class<SimpleParam::SimpleParam>]
-          # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-          # https://github.com/castwide/solargraph/pull/1228
           clazz = ARGS.fetch(key)
           # @type [SimpleParam::SimpleParam]
           obj = clazz.new(key:, values:)

data/lib/checkoff/internal/section_selector_evaluator.rb

@@ -53,7 +53,7 @@ module Checkoff
       { sections:, projects:, client:, custom_fields: }
     end
 
-    # @return [Asana::Resources::Project]
+    # @return [Asana::Resources::Section]
     attr_reader :item
     # @return [Checkoff::Sections]
     attr_reader :sections

data/lib/checkoff/internal/selector_classes/common/function_evaluator.rb

@@ -8,7 +8,7 @@ module Checkoff
     module Common
       # Base class to evaluate a project selector function given fully evaluated arguments
       class FunctionEvaluator < ::Checkoff::SelectorClasses::FunctionEvaluator
-        # @param selector [Array(Symbol, Array), String]
+        # @param selector [Array<Symbol, Array>, Symbol]
         # @param custom_fields [Checkoff::CustomFields]
         # @param _kwargs [Hash]
         def initialize(selector:, custom_fields:, **_kwargs)
@@ -22,7 +22,7 @@ module Checkoff
 
         private
 
-        # @return [Array(Symbol, Array), String]
+        # @return [Array<Symbol, Array>, Symbol]
         attr_reader :selector
       end
     end