checkoff 0.148.0 → 0.149.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 59a19680baee0ffb1a81101fe640019611e61fcb2f19928a7438a720bc2cc577
-  data.tar.gz: 8cdc27dce1e2e1d171ef3d8bb1b61f4978f8dddf53fbf477c31881eed36e81c8
+  metadata.gz: d22e09a2b3d0e47fa0eebca1c5484aa916327cf014caa2f5a5491c66791aa607
+  data.tar.gz: aa50373ee49bf7c70f0930fbd8480670bb395ebf760e27309c3dbcfd692ff22d
 SHA512:
-  metadata.gz: 298bf510b836223c6bb61424011c019cc54ab600c08baba89db73b5166b3ffabb74e1f0cbdf4faccc31cf70439411987445763b62c7422d3d46afc97508d506d
-  data.tar.gz: fcd68e91155a1058af51f3d75e32064d0afc9f45be9277d3cf3a4bf53e8df966acfadbb6f440330899e879dcc2e85348eced0e29fbe4cf7819a55214b980be7d
+  metadata.gz: f855008ebd7d20737f7d4e8771796f67c6c86ab0fb991e83469caca6de5bb3fac634c97edbd0b6728ae4c9191c979a75d91722f6729b74eb1318bb4ed293eabb
+  data.tar.gz: 2bcdb1624b4bf845a61b6ac920277cccd13960212c5ce956fb02d304a9ef5a85110e9bf0f5ffb9d7bd1cdc0630b8caa7275a2ec28b95e858deab5c724514fdac

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.148.0)
+    checkoff (0.149.0)
       activesupport
       asana (> 0.10.0)
       cache_method

data/lib/checkoff/tasks.rb

@@ -8,6 +8,7 @@ require_relative 'workspaces'
 require_relative 'internal/config_loader'
 require_relative 'internal/task_timing'
 require_relative 'internal/task_hashes'
+require_relative 'internal/logging'
 require 'asana'
 
 module Checkoff
@@ -16,6 +17,8 @@ module Checkoff
     # @!parse
     #   extend CacheMethod::ClassMethods
 
+    include Logging
+
     MINUTE = 60
     HOUR = MINUTE * 60
     DAY = 24 * HOUR
@@ -167,6 +170,8 @@ module Checkoff
 
     # True if any of the task's dependencies are marked incomplete
     #
+    # Include 'dependencies.gid' in extra_fields of task passed in.
+    #
     # @param task [Asana::Resources::Task]
     def incomplete_dependencies?(task)
       # Avoid a redundant fetch.  Unfortunately, Ruby SDK allows
@@ -179,8 +184,7 @@ module Checkoff
 
       # @sg-ignore
       # @type [Enumerable<Asana::Resources::Task>, nil]
-      dependencies = task.instance_variable_get(:@dependencies)
-      dependencies = task.dependencies.map { |dependency| { 'gid' => dependency.gid } } if dependencies.nil?
+      dependencies = task.instance_variable_get(:@dependencies) || []
 
       dependencies.any? do |parent_task_info|
         # the real bummer though is that asana doesn't let you fetch
@@ -188,20 +192,36 @@ module Checkoff
         # regardless:
         parent_task_gid = parent_task_info.fetch('gid')
 
-        parent_task = task_by_gid(parent_task_gid,
-                                  only_uncompleted: false)
+        parent_task = task_by_gid(parent_task_gid, only_uncompleted: false)
         parent_task.completed_at.nil?
       end
     end
 
     # @param task [Asana::Resources::Task]
     #
-    # @return [Array<Asana::Resources::Task>]
+    # @return [Array<Hash>]
     def all_dependent_tasks(task)
       dependent_tasks = []
-      task.dependents.each do |dependent_task|
-        dependent_tasks << dependent_task
-        dependent_tasks += all_dependent_tasks(dependent_task)
+      # See note above - same applies as does in @dependencies
+      #
+      # @type [Array<Hash>]
+      dependents = task.instance_variable_get(:@dependents) || []
+      dependents.each do |dependent_task_hash_or_obj|
+        # seems like if we ever .inspect the task, it stashes the task
+        # object instead of the hash.  Try to avoid this - but maybe we
+        # need to convert if it does happen.
+        raise 'Found dependent task object!' if dependent_task_hash_or_obj.is_a?(Asana::Resources::Task)
+
+        dependent_task_hash = dependent_task_hash_or_obj
+
+        dependent_task = task_by_gid(dependent_task_hash.fetch('gid'),
+                                     only_uncompleted: true,
+                                     extra_fields: ['dependents'])
+        debug { "#{task.name} has dependent task #{dependent_task.name}" }
+        unless dependent_task.nil?
+          dependent_tasks << dependent_task
+          dependent_tasks += all_dependent_tasks(dependent_task)
+        end
       end
       dependent_tasks
     end
@@ -248,6 +268,11 @@ module Checkoff
       end
     end
 
+    # @return [Hash]
+    def as_cache_key
+      {}
+    end
+
     private
 
     # @return [Checkoff::Internal::TaskTiming]

data/lib/checkoff/timelines.rb

@@ -69,7 +69,7 @@ module Checkoff
                                                               limit_to_portfolio_name)
       end
 
-      all_dependent_task_gids = @tasks.all_dependent_tasks(task).map(&:gid)
+      all_dependent_task_gids = nil
       task.memberships.all? do |membership_data|
         unless limit_to_portfolio_name.nil?
           project_gid = membership_data.fetch('project').fetch('gid')
@@ -86,6 +86,8 @@ module Checkoff
 
         next true if last_milestone.gid == task.gid
 
+        all_dependent_task_gids ||= @tasks.all_dependent_tasks(task).map(&:gid)
+
         all_dependent_task_gids.include? last_milestone.gid
       end
     end

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.148.0'
+  VERSION = '0.149.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.148.0
+  version: 0.149.0
 platform: ruby
 authors:
 - Vince Broz