checkoff 0.103.0 → 0.104.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 18ab918128cd0d805829245306102209f7715f9dfa580a8861b4e97be7aa3b31
-  data.tar.gz: 0c40f9f30d1a0441de43140dcd442d783c7b6ae5e584e9b0ed23e13acbe5e35e
+  metadata.gz: b6d308b4ca05ee88bf3b380772496d9c621cc7b9f521b4cf19eb1351395ed2b2
+  data.tar.gz: eb14bb0c6f4dabd72e083ce67a5c3c821be931ac268f3202445714da9ae713aa
 SHA512:
-  metadata.gz: 4b0ce332d7ee01af5680511dd1c7da6b7654f94b153b3240d344c64663ebc71ceaff79bc4ae2fb01846430904e167a36b81d55ac581f992524eef3dae50c6783
-  data.tar.gz: 738deef8848a424fe874711c874f83b70b14320b9df49a85da6b187da8e817887a3d3de9b63cc65411cf866e5813eb759d5c051eaf9b3c1d50726a98fa3dde33
+  metadata.gz: 28983082df6a4c00e31fb3f458a6bafc0241920d4f1b5657e6ce3613d86127b0df6561defde8669a9ead845e2ef7d77c10ec1d45603c55d17fe735c5d3d5e716
+  data.tar.gz: dc877bc157ed76157327c2e094ff69ff4074275eaa9df93ec9d3fdf8bc67969c4402503ee9435bcf1305f489f0d7ab22f0b43129e69b0abe9e06064b4683f8e7

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.103.0)
+    checkoff (0.104.0)
       activesupport
       asana (> 0.10.0)
       cache_method

data/lib/checkoff/internal/selector_classes/common/function_evaluator.rb

@@ -15,54 +15,6 @@ module Checkoff
 
         private
 
-        # @param project [Asana::Resources::Project]
-        # @param field_name [Symbol]
-        #
-        # @sg-ignore
-        # @return [Date, nil]
-        def pull_date_field_by_name(project, field_name)
-          if field_name == :modified
-            return Time.parse(project.modified_at).to_date unless project.modified_at.nil?
-
-            return nil
-          end
-
-          if field_name == :due
-            return Time.parse(project.due_at).to_date unless project.due_at.nil?
-
-            return Date.parse(project.due_on) unless project.due_on.nil?
-
-            return nil
-          end
-
-          raise "Teach me how to handle field #{field_name}"
-        end
-
-        # @param project [Asana::Resources::Project]
-        # @param field_name [Symbol]
-        #
-        # @sg-ignore
-        # @return [Date, Time, nil]
-        def pull_date_or_time_field_by_name(project, field_name)
-          if field_name == :due
-            return Time.parse(project.due_at) unless project.due_at.nil?
-
-            return Date.parse(project.due_on) unless project.due_on.nil?
-
-            return nil
-          end
-
-          if field_name == :start
-            return Time.parse(project.start_at) unless project.start_at.nil?
-
-            return Date.parse(project.start_on) unless project.start_on.nil?
-
-            return nil
-          end
-
-          raise "Teach me how to handle field #{field_name}"
-        end
-
         # @sg-ignore
         # @param project [Asana::Resources::Project]
         # @param custom_field_gid [String]

data/lib/checkoff/internal/selector_classes/project/function_evaluator.rb

@@ -18,54 +18,6 @@ module Checkoff
 
         private
 
-        # @param project [Asana::Resources::Project]
-        # @param field_name [Symbol]
-        #
-        # @sg-ignore
-        # @return [Date, nil]
-        def pull_date_field_by_name(project, field_name)
-          if field_name == :modified
-            return Time.parse(project.modified_at).to_date unless project.modified_at.nil?
-
-            return nil
-          end
-
-          if field_name == :due
-            return Time.parse(project.due_at).to_date unless project.due_at.nil?
-
-            return Date.parse(project.due_on) unless project.due_on.nil?
-
-            return nil
-          end
-
-          raise "Teach me how to handle field #{field_name}"
-        end
-
-        # @param project [Asana::Resources::Project]
-        # @param field_name [Symbol]
-        #
-        # @sg-ignore
-        # @return [Date, Time, nil]
-        def pull_date_or_time_field_by_name(project, field_name)
-          if field_name == :due
-            return Time.parse(project.due_at) unless project.due_at.nil?
-
-            return Date.parse(project.due_on) unless project.due_on.nil?
-
-            return nil
-          end
-
-          if field_name == :start
-            return Time.parse(project.start_at) unless project.start_at.nil?
-
-            return Date.parse(project.start_on) unless project.start_on.nil?
-
-            return nil
-          end
-
-          raise "Teach me how to handle field #{field_name}"
-        end
-
         # @sg-ignore
         # @param project [Asana::Resources::Project]
         # @param custom_field_gid [String]

data/lib/checkoff/internal/selector_classes/task/function_evaluator.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require_relative '../function_evaluator'
-require 'checkoff/internal/task_timing'
 
 module Checkoff
   module SelectorClasses
@@ -22,29 +21,6 @@ module Checkoff
 
         private
 
-        # @param task [Asana::Resources::Task]
-        # @param field_name [Symbol]
-        #
-        # @sg-ignore
-        # @return [Date, nil]
-        def pull_date_field_by_name(task, field_name)
-          if field_name == :modified
-            return Time.parse(task.modified_at).to_date unless task.modified_at.nil?
-
-            return nil
-          end
-
-          if field_name == :due
-            return Time.parse(task.due_at).to_date unless task.due_at.nil?
-
-            return Date.parse(task.due_on) unless task.due_on.nil?
-
-            return nil
-          end
-
-          raise "Teach me how to handle field #{field_name}"
-        end
-
         # @sg-ignore
         # @param task [Asana::Resources::Task]
         # @param custom_field_gid [String]

data/lib/checkoff/internal/selector_classes/task.rb

@@ -2,6 +2,7 @@
 
 require_relative 'task/function_evaluator'
 require 'checkoff/internal/ready_between_relative'
+require 'checkoff/internal/task_timing'
 
 module Checkoff
   module SelectorClasses
@@ -160,7 +161,9 @@ module Checkoff
         #
         # @return [Boolean]
         def evaluate(task, field_name, num_days)
-          date = pull_date_field_by_name(task, field_name)
+          task_timing = Checkoff::Internal::TaskTiming.new
+
+          date = task_timing.date_or_time_field_by_name(task, field_name)&.to_date
 
           return false if date.nil?
 
@@ -189,7 +192,8 @@ module Checkoff
         #
         # @return [Boolean]
         def evaluate(task, field_name, num_days)
-          date = pull_date_field_by_name(task, field_name)
+          task_timing = Checkoff::Internal::TaskTiming.new
+          date = task_timing.date_or_time_field_by_name(task, field_name)&.to_date
 
           return false if date.nil?
 

data/lib/checkoff/internal/task_timing.rb

@@ -49,6 +49,13 @@ module Checkoff
         nil
       end
 
+      # @param task [Asana::Resources::Task]
+      #
+      # @return [Time, nil]
+      def modified_time(task)
+        return @time_class.parse(task.modified_at) unless task.modified_at.nil?
+      end
+
       # @param task [Asana::Resources::Task]
       # @param field_name [Symbol]
       #
@@ -59,6 +66,8 @@ module Checkoff
 
         return start_date_or_time(task) if field_name == :start
 
+        return modified_time(task) if field_name == :modified
+
         return start_date_or_time(task) || due_date_or_time(task) if field_name == :ready
 
         raise "Teach me how to handle field #{field_name}"

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.103.0'
+  VERSION = '0.104.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.103.0
+  version: 0.104.0
 platform: ruby
 authors:
 - Vince Broz