checker 0.6.4 → 0.6.5.rc1

data/.travis.yml

@@ -3,6 +3,7 @@ rvm:
   - 1.8.7
   - 1.9.2
   - 1.9.3
+  - 2.0.0
   - ree
 notifications:
   email:

data/CHANGELOG

@@ -1,3 +1,19 @@
+=== version 0.6.5.rc1 (released 2013-02-21)
+
+* release candidate version because of quite much changes
+
+KNOWN ISSUES
+* might not work with rbenv
+
+CHANGES
+* new state: warning. it is using by couple of checks (console.log, javascript)
+* added two more options: commit-on-warning and rails-for-sass (see readme for docs)
+* added check for console.log existance - returns warning if found
+* added reinstall script for git hook 
+* updated sass check to use rails runner if project is using asset-pipeline
+* fixed bug when checker was running from system ruby version from git hook, not current rvm one
+  (checker reinstall required)
+
 === version 0.6.4 (released 2012-09-24)
 
 * fix a prepare-commit-msg hook so it won't destroy line endings in the commit message
@@ -66,4 +82,4 @@
 === version 0.0.1 (released 2012-04-03)
 
 * initial version
-* haml checker
+* haml checker

data/README.md

@@ -25,15 +25,18 @@ All you need to do is type in `checker install` and it will automatically instal
 to your current git project. It will look like this:
 
 ```
-#!/bin/bash
+#!/bin/bash 
+ 
+#### Begin of checker script
 checker
 
-if [ $? == 1 ]; then
+if [ $? = 1 ]; then
   exit 1
 fi
 
 text=`echo -n ':checkered_flag: '; cat $1`
-echo $text > $1
+echo "$text" > $1
+#### End of checker script
 ```
 
 If you don't want your commits be prepended by checkered flag you can remove two last lines from the prepare-commit-msg hook.
@@ -66,13 +69,31 @@ Syntax error: Invalid CSS after "qwe:": expected pseudoclass or pseudoelement, w
 
 ### Advanced usage
 
-To check only specific filetypes on commit, use `git config` :
+You can specify checker behaviour for your project by changing the git config for checker.
+Available options are:
+
+* check
+
+  List of modules, seperated by comma, which checker will use. Defaults to all modules.
+  Example: `git config checker.check 'ruby, haml, coffeescript'`
+
+* commit-on-warning
+
+  Boolean value. If given false, checker will not commit when any module returns warning.
+  Defaults to true.
+  Example: `git config checker.commit-on-warning 'false'`
+
+* rails-for-sass
+
+  Boolean value. Will use rails runner to check for sass syntax using sprockets.
+  Works work rails >= 3.1. Defaults to true.
+  Example: `git config checker.rails-for-sass 'true'`
+
+
+As for 17.02.2013, `commit-on-warnings` and `rails-for-sass` are not yet working
 
-``` bash
-git config checker.check 'ruby, haml, coffeescript'
-```
 
-### Available options
+### Available modules
 
 #### ruby
 Checks for correct syntax in ruby (.rb) files

data/checker.gemspec

@@ -4,7 +4,7 @@ require File.expand_path('../lib/checker/version', __FILE__)
 Gem::Specification.new do |s|
   s.name        = 'checker'
   s.version     = Checker::VERSION
-  s.date        = '2012-09-24'
+  s.date        = '2013-02-21'
   s.summary     = "Syntax checker for various files"
   s.description = "A collection of modules which every is designed to check syntax for specific files."
   s.authors     = ["Jacek Jakubik", "Tomasz Pewiński"]

data/lib/checker.rb

@@ -2,18 +2,30 @@ require 'colorize'
 require 'digest/md5'
 
 require 'checker/core_ext'
+require 'checker/rvm'
 require 'checker/version'
 require 'checker/installator'
 require 'checker/helper'
+require 'checker/options'
+require 'checker/result'
 
-%w[base ruby haml slim pry coffeescript javascript sass yaml conflict].each do |mod|
+%w[base ruby haml slim pry coffeescript javascript sass yaml conflict console_log].each do |mod|
   require "checker/modules/#{mod}"
 end
 
+%w[default console_log javascript].each do |res|
+  require "checker/results/#{res}"
+end
+
 def debug_mode?
   ENV['CHECKER_DEBUG'].to_s == "1"
 end
 
 if debug_mode?
   puts "Running checker with debug mode!".colorize(:yellow)
-end
+end
+
+def debug(msg)
+  puts "[DEBUG] - #{msg}".colorize(:yellow) if debug_mode?
+end
+

data/lib/checker/cli.rb

@@ -9,6 +9,8 @@ module Checker
         else
           if ARGV[0] == "install"
             Checker::Installator.install!
+          elsif ARGV[0] == "reinstall"
+            Checker::Installator.reinstall!
           elsif ARGV[0] == "help"
             Checker::Helper.show_help!
           elsif ARGV[0] == "modules"
@@ -32,7 +34,7 @@ module Checker
         module_instances = []
         files = modified_files
         modules.each do |mod|
-          klass = "Checker::Modules::#{mod.downcase.capitalize}".constantize
+          klass = "Checker::Modules::#{mod.classify}".constantize
           module_instances << klass.new(files.dup)
         end
 
@@ -45,7 +47,7 @@ module Checker
 
       protected
       def available_modules
-        Checker::Modules.constants.map(&:to_s).map(&:downcase) - ['base']
+        Checker::Modules.constants.map(&:to_s).map(&:underscore) - ['base']
       end
 
       def check_module_availability(modules)
@@ -58,7 +60,7 @@ module Checker
       end
 
       def get_modules_to_check
-        `git config checker.check`.chomp.split(",").map(&:strip)
+        Checker::Options.modules_to_check
       end
 
       def modified_files

data/lib/checker/core_ext.rb

@@ -9,6 +9,23 @@ class CoreExt
     end
     constant
   end
+
+  def self.classify(underscored_word)
+    words = underscored_word.split("_")
+    words.each do |word|
+      word.capitalize!
+    end.join("")
+  end
+
+  def self.underscore(camel_cased_word)
+    word = camel_cased_word.to_s.dup
+    word.gsub!(/::/, '/')
+    word.gsub!(/([A-Z]+)([A-Z][a-z])/,'\1_\2')
+    word.gsub!(/([a-z\d])([A-Z])/,'\1_\2')
+    word.tr!("-", "_")
+    word.downcase!
+    word
+  end
 end
 
 class String
@@ -16,6 +33,14 @@ class String
     CoreExt.constantize(self)
   end
 
+  def classify
+    CoreExt.classify(self)
+  end
+
+  def underscore
+    CoreExt.underscore(self)
+  end
+
   def ends_with?(patt)
     patt = Regexp.new(Regexp.escape(patt) + "$")
     self.match patt

data/lib/checker/helper.rb

@@ -3,6 +3,7 @@ module Checker
     def self.show_help!
       puts "Checker version #{Checker::VERSION}"
       puts "* install - type 'checker install' to install git pre-commit-hook"
+      puts "* reinstall - type 'checker reinstall' to purge current hook git pre-commit-hook and install new one"
       puts "* modules - type 'checker modules' to see available modules"
       puts "* checks  - type 'checker [module name]' to check your current git stage"
       puts "* help    - type 'checker help' to see this message :)"
@@ -14,4 +15,4 @@ module Checker
       exit 0
     end
   end
-end
+end

data/lib/checker/installator.rb

@@ -2,16 +2,35 @@ module Checker
   class Installator
     def self.template
       dir = File.dirname(__FILE__) + "/../.."
-      open(dir + "/templates/checker-prepare-commit-msg").read
+      temp = open(dir + "/templates/checker-prepare-commit-msg").read
+      temp.gsub(/CHECKER_COMMAND/, Checker::RVM.rvm_command("checker"))
     end
 
-    def self.install!
-      hooks_dir = "#{Dir.pwd}/.git/hooks"
+    def self.hooks_dir
+      "#{Dir.pwd}/.git/hooks"
+    end
 
+    def self.check_hook!
       unless Dir.exist?(hooks_dir)
         puts "Git Hooks dir not found. Are you sure you are inside project with git?"
         exit 1
       end
+    end
+
+    def self.reinstall!
+      check_hook!
+
+      pre_commit = "#{hooks_dir}/prepare-commit-msg"
+      if File.exists?(pre_commit)
+        puts "Removing current git precommit hook..."
+        File.delete(pre_commit)
+      end
+
+      install!
+    end
+
+    def self.install!
+      check_hook!
 
       pre_commit = "#{hooks_dir}/prepare-commit-msg"
       if File.exist?(pre_commit)
@@ -43,4 +62,4 @@ module Checker
       end
     end
   end
-end
+end

data/lib/checker/modules/base.rb

@@ -25,6 +25,10 @@ module Checker
         end
       end
 
+      def classname
+        self.class.to_s.split('::').last
+      end
+
       private
 
       def print_module_header
@@ -57,9 +61,9 @@ module Checker
           @results = files_to_check.map do |file_name|
             color "  Checking #{file_name}...", :yellow
             result = check_one_file(file_name)
-            show_status(result)
-            flush_and_forget_output(result)
-            result
+            show_status result.status
+            flush_and_forget_output result.status
+            result.success?
           end
         end
       end
@@ -71,7 +75,7 @@ module Checker
 
       def check_one_file file_name
         checksum = ::Digest::MD5.hexdigest(file_name)
-        puts file_name if debug_mode?
+        debug(file_name)
         checkout_file(file_name, checksum)
         check_one(checkout_file_name(checksum), :extension => File.extname(file_name))
       end
@@ -87,7 +91,7 @@ module Checker
 
       def plain_command(cmd, options = {})
         cmd = parse_command(cmd, options)
-        execute(cmd)
+        execute(cmd, options)
       end
 
       def silent_command(cmd, options = {})
@@ -96,26 +100,44 @@ module Checker
         execute(cmd)
       end
 
-      def flush_and_forget_output(success)
-        print @buffer.to_s unless success
+      def flush_and_forget_output(status)
+        print @buffer.to_s if (status == :warning or status == :fail)
         @buffer = ""
       end
 
-      def show_status(success)
-        if success
-          puts " [OK]".green
+      def print_success_message
+        puts " [OK]".green
+      end
+
+      def print_warning_message
+        puts " [WARNING]".magenta
+      end
+
+      def print_fail_message
+        puts " [FAIL]".red
+      end
+
+      def show_status(status)
+        if status == :ok
+          print_success_message
+        elsif status == :warning
+          print_warning_message
         else
-          puts " [FAIL]".red
+          print_fail_message
         end
       end
 
-      def execute(cmd)
-        puts cmd if debug_mode?
+      def execute(cmd, options = {})
+        debug("executing: #{cmd}")
         io = IO.popen(cmd)
         Process.wait(io.pid)
         @buffer ||= ""
         @buffer << io.read
-        success?
+        options[:return_boolean] ? success? : exitstatus
+      end
+
+      def exitstatus
+        $? && $?.exitstatus
       end
 
       def success?
@@ -135,7 +157,7 @@ module Checker
       end
 
       def name
-        self.class.to_s.split('::').last.upcase
+        classname.underscore.upcase
       end
 
       def use_bundler?
@@ -150,15 +172,20 @@ module Checker
         File.exists?(rvm_shell)
       end
 
-      def rvm_command(command)
-        rvm_gem  = ENV['GEM_HOME'].to_s
-        rvm_version = rvm_gem.gsub(/.+rvm\/gems\//, "")
+      def rails_project?
+        use_bundler? && File.read("Gemfile.lock").match(/ rails /)
+      end
+
+      def rails_with_ap?
+        rails_project? && File.exists?("app/assets")
+      end
 
-        "#{rvm_shell} '#{rvm_version}' -c '#{command}'"
+      def rvm_command(command)
+        Checker::RVM.rvm_command(command)
       end
 
       def rvm_shell
-        File.join(ENV['rvm_path'].to_s, 'bin/rvm-shell')
+        Checker::RVM.rvm_shell
       end
 
       def with_checker_cache
@@ -167,6 +194,8 @@ module Checker
           yield if block_given?
         ensure
           `rm -rf .checker-cache > /dev/null 2>&1`
+          ## for sass check
+          `rm -rf app/assets/stylesheets/checker-cache*` if rails_with_ap?
         end
       end
 

data/lib/checker/modules/coffeescript.rb

@@ -4,7 +4,7 @@ module Checker
       extensions 'coffee'
       private
       def check_one(file, opts = {})
-        plain_command("cat #{file} | egrep -v '^//=' | coffee -sc > /dev/null")
+        Checker::Result.result(self, plain_command("cat #{file} | egrep -v '^//=' | coffee -sc > /dev/null"))
       end
 
       def check_for_executable

data/lib/checker/modules/conflict.rb

@@ -4,15 +4,16 @@ module Checker
 
       private
       def check_one(file, opts = {})
-        [check_for_conflict_start(file), check_for_conflict_end(file)].all_true?
+        status = [check_for_conflict_start(file), check_for_conflict_end(file)].all_true?
+        Checker::Result.result(self, status ? 0 : 1)
       end
 
       def check_for_conflict_start(file)
-        !plain_command("grep -n \"<<<<<<< \" #{file}", :bundler => false)
+        !plain_command("grep -n \"<<<<<<< \" #{file}", :bundler => false, :return_boolean => true)
       end
 
       def check_for_conflict_end(file)
-        !plain_command("grep -n \">>>>>>> \" #{file}", :bundler => false)
+        !plain_command("grep -n \">>>>>>> \" #{file}", :bundler => false, :return_boolean => true)
       end
     end
   end

data/lib/checker/modules/console_log.rb

@@ -0,0 +1,20 @@
+module Checker
+  module Modules
+    class ConsoleLog < Base
+      extensions 'coffee', 'js'
+
+      private
+      def check_one(file, opts = {})
+        Checker::Result.result(self, plain_command("grep -n \"console\\.log\" #{file}", :bundler => false))
+      end
+
+      def show_status(status)
+        if status == :ok
+          print_success_message
+        else
+          print_warning_message
+        end
+      end
+    end
+  end
+end

data/lib/checker/modules/haml.rb

@@ -4,7 +4,7 @@ module Checker
       extensions 'haml'
       private
       def check_one(file, opts = {})
-        plain_command("haml --check #{file} >> /dev/null")
+        Checker::Result.result(self, plain_command("haml --check #{file} >> /dev/null"))
       end
 
       def check_for_executable

data/lib/checker/modules/javascript.rb

@@ -4,7 +4,7 @@ module Checker
       extensions 'js'
       private
       def check_one(file, opts = {})
-        plain_command("jsl -process #{file}")
+        Checker::Result.result(self, plain_command("jsl -process #{file}"))
       end
 
       def check_for_executable
@@ -18,9 +18,14 @@ module Checker
         str
       end
 
-      # ignore exit status 1 - warnings
-      def success?
-        $? && ($?.exitstatus == 0 || $?.exitstatus == 1)
+      def show_status(status)
+        if status == :ok
+          print_success_message
+        elsif status == :warning
+          print_warning_message
+        else
+          print_fail_message
+        end
       end
     end
   end

data/lib/checker/modules/pry.rb

@@ -4,15 +4,16 @@ module Checker
 
       private
       def check_one(file, opts = {})
-        [check_for_binding_pry(file), check_for_binding_remote_pry(file)].all_true?
+        status = [check_for_binding_pry(file), check_for_binding_remote_pry(file)].all_true?
+        Checker::Result.result(self, status ? 0 : 1)
       end
 
       def check_for_binding_pry(file)
-        !plain_command("grep -n \"binding\\.pry\" #{file}", :bundler => false)
+        !plain_command("grep -n \"binding\\.pry\" #{file}", :bundler => false, :return_boolean => true)
       end
 
       def check_for_binding_remote_pry(file)
-        !plain_command("grep -n \"binding\\.remote_pry\" #{file}", :bundler => false)
+        !plain_command("grep -n \"binding\\.remote_pry\" #{file}", :bundler => false, :return_boolean => true)
       end
     end
   end

data/lib/checker/modules/ruby.rb

@@ -4,7 +4,7 @@ module Checker
       extensions 'rb'
       private
       def check_one(file, opts = {})
-        plain_command("ruby -c #{file}", :bundler => false)
+        Checker::Result.result(self, plain_command("ruby -c #{file}", :bundler => false))
       end
     end
   end

data/lib/checker/modules/sass.rb

@@ -4,7 +4,20 @@ module Checker
       extensions 'scss', 'sass'
       private
       def check_one(file, opts = {})
-        plain_command("sass #{"--scss" if opts[:extension] == ".scss"} -c #{file}")
+        if Checker::Options.use_rails_for_sass
+          rails_check(file, opts)
+        else
+          normal_check(file, opts)
+        end
+      end
+
+      def rails_check(file, opts)
+        debug("Rails project detected") if rails_project?
+        Checker::Result.result(self, plain_command(%(rails runner "Rails.application.assets.find_asset(\\"#{Dir.pwd}/#{file}\\").to_s")))
+      end
+
+      def normal_check(file, opts)
+        Checker::Result.result(self, plain_command("sass #{"--scss" if opts[:extension] == ".scss"} -c #{file}"))
       end
 
       def check_for_executable
@@ -17,6 +30,47 @@ module Checker
         str << "Sass requires haml to work properly: 'gem install haml'\n"
         str
       end
+
+      ## for rails project
+      def checkout_file file_name, target
+        debug("git show :0:#{file_name} > #{checkout_file_name(target)} 2>/dev/null")
+        mkdir_if_necessary(checkout_file_name(target))
+        `git show :0:#{file_name} > #{checkout_file_name(target)} 2>/dev/null`
+      end
+
+      def mkdir_if_necessary(target)
+        dir = target.gsub(File.basename(target), '')
+        create_dir(dir)
+      end
+
+      def create_dir(dir)
+        debug("Creating dir #{dir}")
+        Dir.mkdir(dir) unless File.exists?(dir)
+      end
+
+      def stylesheets_dir
+        "app/assets/stylesheets/"
+      end
+
+      def checkout_file_name target
+        (Checker::Options.use_rails_for_sass && rails_with_ap?) ? "#{stylesheets_dir}checker-cache#{target}" : super
+      end
+
+      def proper_path file_name
+        file_name.gsub(/app\/assets\/stylesheets\//, '')
+      end
+
+      def check_one_file file_name
+        if (Checker::Options.use_rails_for_sass && rails_with_ap?)
+          color " (using rails runner)... ", :blue
+          debug(file_name)
+          debug(proper_path(file_name))
+          checkout_file(file_name, proper_path(file_name))
+          check_one(checkout_file_name(proper_path(file_name)), :extension => File.extname(file_name))
+        else
+          super
+        end
+      end
     end
   end
 end

data/lib/checker/modules/slim.rb

@@ -4,7 +4,7 @@ module Checker
       extensions 'slim'
       private
       def check_one(file, opts = {})
-        plain_command("slimrb --compile #{file} >> /dev/null")
+        Checker::Result.result(self, plain_command("slimrb --compile #{file} >> /dev/null"))
       end
 
       def check_for_executable

data/lib/checker/modules/yaml.rb

@@ -8,12 +8,11 @@ module Checker
       def check_one(file, opts = {})
         ret = begin
           YAML.load_file(file)
-          true
+          Checker::Result.result(self, 0)
         rescue Exception => e
           puts e
-          false
+          Checker::Result.result(self, 1)
         end
-        ret
       end
     end
   end

data/lib/checker/options.rb

@@ -0,0 +1,22 @@
+module Checker
+  class Options
+    class << self
+      def get_config(conf, default = nil)
+        config = `git config checker.#{conf}`.chomp
+        (config.empty? && !default.nil?) ? default : config
+      end
+
+      def modules_to_check
+        get_config("check", "all").split(",").map(&:strip)
+      end
+
+      def prevent_commit_on_warning
+        get_config("commit-on-warning", "true") == "false"
+      end
+
+      def use_rails_for_sass
+        get_config("rails-for-sass", "true") == "true"
+      end
+    end
+  end
+end

data/lib/checker/result.rb

@@ -0,0 +1,21 @@
+module Checker
+  class Result
+    class << self
+      def result(klass, exitstatus)
+        debug klass
+        debug exitstatus
+        result_class(klass.classname).new(exitstatus)
+      end
+
+      def result_class(klass)
+        "Checker::Results::#{klass}".constantize
+      rescue NameError => e
+        default_result_class
+      end
+
+      def default_result_class
+        Checker::Results::Default
+      end
+    end
+  end
+end

data/lib/checker/results/console_log.rb

@@ -0,0 +1,13 @@
+module Checker
+  module Results
+    class ConsoleLog < Default
+      def success?
+        (Checker::Options.prevent_commit_on_warning && exitstatus == 0) ? false : true
+      end
+
+      def status
+        exitstatus == 1 ? :ok : :warning
+      end
+    end
+  end
+end

data/lib/checker/results/default.rb

@@ -0,0 +1,13 @@
+module Checker
+  module Results
+    class Default < Struct.new(:exitstatus)
+      def success?
+        exitstatus == 0
+      end
+
+      def status
+        exitstatus == 0 ? :ok : :fail
+      end
+    end
+  end
+end

data/lib/checker/results/javascript.rb

@@ -0,0 +1,24 @@
+module Checker
+  module Results
+    class Javascript < Default
+      def success?
+        case exitstatus
+        when 0 then true
+        when 1 then
+          Checker::Options.prevent_commit_on_warning ? false : true
+        else
+          false
+        end
+      end
+
+      def status
+        case exitstatus
+        when 0 then :ok
+        when 1 then :warning
+        else
+          :fail
+        end
+      end
+    end
+  end
+end

data/lib/checker/rvm.rb

@@ -0,0 +1,16 @@
+module Checker
+  class RVM
+    class << self
+      def rvm_command(command)
+        rvm_gem  = ENV['GEM_HOME'].to_s
+        rvm_version = rvm_gem.gsub(/.+rvm\/gems\//, "")
+
+        "#{rvm_shell} '#{rvm_version}' -c '#{command}'"
+      end
+
+      def rvm_shell
+        File.join(ENV['rvm_path'].to_s, 'bin/rvm-shell')
+      end
+    end
+  end
+end

data/lib/checker/version.rb

@@ -1,3 +1,3 @@
 module Checker
-  VERSION = '0.6.4'
+  VERSION = '0.6.5.rc1'
 end

data/spec/checker/fixtures/console_log/with_console_log.js

@@ -0,0 +1,3 @@
+(function() {
+  console.log("test");
+});

data/spec/checker/fixtures/console_log/without_console_log.js

@@ -0,0 +1,2 @@
+(function() {
+});

data/spec/checker/modules/coffeescript_spec.rb

@@ -5,7 +5,7 @@ describe Checker::Modules::Coffeescript do
     files = ['a.rb', 'b.js.erb', 'c.r', 'd.yml', 'e.yaml', 'f.coffee']
     mod = Checker::Modules::Coffeescript.new(files)
     mod.stub(:check_for_executable).and_return(true)
-    mod.should_receive(:check_one_file).with('f.coffee')
+    mod.should_receive(:check_one_file).with('f.coffee').and_return(stub(:success? => true, :status => :ok))
     mod.should_not_receive(:check_one_file).with('e.yaml')
     mod.should_not_receive(:check_one_file).with('d.yml')
     mod.should_not_receive(:check_one_file).with('a.rb')

data/spec/checker/modules/conflict_spec.rb

@@ -4,7 +4,7 @@ describe Checker::Modules::Conflict do
   it 'checks all files' do
     files = ['a.rb', 'b.js.erb', 'c.r', 'd.yaml', 'e.yml', 'f.coffee']
     mod = Checker::Modules::Conflict.new(files)
-    mod.stub(:check_one).and_return(true)
+    mod.stub(:check_one).and_return(stub(:success? => true, :status => :ok))
     mod.should_receive(:check_one).exactly(6).times
     mod.check 
   end

data/spec/checker/modules/console_log_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe Checker::Modules::ConsoleLog do
+  it 'checks coffee and js files' do
+    files = ['a.rb', 'b.js.erb', 'c.r', 'd.yaml', 'e.yml', 'f.coffee', 'g.js']
+    mod = Checker::Modules::ConsoleLog.new(files)
+    mod.stub(:check_one).and_return(stub(:success? => true, :status => :ok))
+    mod.should_receive(:check_one).exactly(2).times
+    mod.check 
+  end
+
+  describe "does find console.log" do
+    before do
+      files = [fixture("console_log", "with_console_log.js")]
+      @mod = Checker::Modules::ConsoleLog.new(files)
+    end
+
+    it "results to be true if prevent_commit_on_warning is set to false" do
+      Checker::Options.stub(:prevent_commit_on_warning).and_return(false)
+      @mod.check.should be_true
+    end
+
+    it "results to be false if prevent_commit_on_warning is set to true" do
+      Checker::Options.stub(:prevent_commit_on_warning).and_return(true)
+      @mod.check.should be_false
+    end
+
+    it "prints proper message" do
+      @mod.should_receive(:print_warning_message)
+      @mod.check
+    end
+  end
+
+  describe "does not find console.log" do
+    before do
+      files = [fixture("console_log", "without_console_log.js")]
+      @mod = Checker::Modules::ConsoleLog.new(files)
+    end
+
+    it "results to be true" do
+      @mod.check.should be_true
+    end
+
+    it "prints proper message" do
+      @mod.should_receive(:print_success_message)
+      @mod.check
+    end
+  end
+end

data/spec/checker/modules/haml_spec.rb

@@ -5,7 +5,7 @@ describe Checker::Modules::Haml do
     files = ['a.rb', 'b.js.erb', 'c.r', 'd.yml', 'e.yaml', 'f.coffee', 'g.haml']
     mod = Checker::Modules::Haml.new(files)
     mod.stub(:check_for_executable).and_return(true)
-    mod.stub(:check_one_file).and_return(true)
+    mod.stub(:check_one_file).and_return(stub(:success? => true, :status => :ok))
     mod.should_receive(:check_one_file).with('g.haml')
     mod.should_not_receive(:check_one_file).with('f.coffee')
     mod.should_not_receive(:check_one_file).with('e.yaml')

data/spec/checker/modules/javascript_spec.rb

@@ -5,7 +5,7 @@ describe Checker::Modules::Javascript do
     files = ['a.rb', 'b.js.erb', 'c.r', 'd.yml', 'e.yaml', 'f.coffee', 'g.haml', 'h.js']
     mod = Checker::Modules::Javascript.new(files)
     mod.stub(:check_for_executable).and_return(true)
-    mod.should_receive(:check_one_file).with('h.js').and_return(true)
+    mod.should_receive(:check_one_file).with('h.js').and_return(stub(:success? => true, :status => :ok))
     mod.should_not_receive(:check_one_file).with('g.haml')
     mod.should_not_receive(:check_one_file).with('f.coffee')
     mod.should_not_receive(:check_one_file).with('e.yaml')
@@ -15,4 +15,55 @@ describe Checker::Modules::Javascript do
     mod.should_not_receive(:check_one_file).with('c.r')
     mod.check 
   end
+
+  describe "good js file" do
+    before do
+      files = ['good.js']
+      @mod = Checker::Modules::Javascript.new(files)
+      @mod.should_receive(:check_one_file).with('good.js').and_return(stub(:success? => true, :status => :ok))
+    end
+
+    it "results to be true" do
+      @mod.check.should be_true
+    end
+
+    it "prints proper message" do
+      @mod.should_receive(:print_success_message)
+      @mod.check
+    end
+  end
+
+  describe "js with warnings" do
+    before do
+      files = ['warning.js']
+      @mod = Checker::Modules::Javascript.new(files)
+      @mod.should_receive(:check_one_file).with('warning.js').and_return(stub(:success? => true, :status => :warning))
+    end
+
+    it "results to be true" do
+      @mod.check.should be_true
+    end
+
+    it "prints proper message" do
+      @mod.should_receive(:print_warning_message)
+      @mod.check
+    end
+  end
+
+  describe "bad js with errors" do
+    before do
+      files = ['bad.js']
+      @mod = Checker::Modules::Javascript.new(files)
+      @mod.should_receive(:check_one_file).with('bad.js').and_return(stub(:success? => false, :status => :fail))
+    end
+
+    it "results to be true" do
+      @mod.check.should be_false
+    end
+
+    it "prints proper message" do
+      @mod.should_receive(:print_fail_message)
+      @mod.check
+    end
+  end
 end

data/spec/checker/modules/pry_spec.rb

@@ -4,7 +4,7 @@ describe Checker::Modules::Pry do
   it 'should check all files' do
     files = ['a.rb', 'b.js.erb', 'c.r', 'd.yaml', 'e.yml', 'f.coffee']
     mod = Checker::Modules::Pry.new(files)
-    mod.stub(:check_one).and_return(true)
+    mod.stub(:check_one).and_return(stub(:success? => true, :status => :ok))
     mod.should_receive(:check_one).exactly(6).times
     mod.check 
   end

data/spec/checker/modules/ruby_spec.rb

@@ -4,7 +4,7 @@ describe Checker::Modules::Ruby do
   it 'should only check .rb files' do
     files = ['a.rb', 'b.js.erb', 'c.r']
     mod = Checker::Modules::Ruby.new(files)
-    mod.stub(:check_one_file).and_return(true)
+    mod.stub(:check_one_file).and_return(stub(:success? => true, :status => :ok))
     mod.should_receive(:check_one_file).with('a.rb')
     mod.should_not_receive(:check_one_file).with('b.js.erb')
     mod.should_not_receive(:check_one_file).with('c.r')

data/spec/checker/modules/sass_spec.rb

@@ -5,7 +5,7 @@ describe Checker::Modules::Sass do
     files = ['a.rb', 'b.js.erb', 'c.r', 'd.yml', 'e.yaml', 'f.coffee', 'g.haml', 'h.js', 'i.scss', 'j.sass']
     mod = Checker::Modules::Sass.new(files)
     mod.stub(:check_for_executable).and_return(true)
-    mod.stub(:check_one_file).and_return(true)
+    mod.stub(:check_one_file).and_return(stub(:success? => true, :status => :ok))
     mod.should_receive(:check_one_file).with('j.sass')
     mod.should_receive(:check_one_file).with('i.scss')
     mod.should_not_receive(:check_one_file).with('h.js')
@@ -19,20 +19,56 @@ describe Checker::Modules::Sass do
     mod.check 
   end
 
-  context "different extensions" do
+  context "normal check" do
+    before do
+      Checker::Options.stub(:use_rails_for_sass).and_return(false)
+    end
+
+    it "gives proper command to sass module while checking .sass files" do
+      files = ["a.sass"]
+      mod = Checker::Modules::Sass.new(files)
+      mod.stub(:check_for_executable).and_return(true)
+      mod.should_receive(:plain_command).with("sass  -c .checker-cache/69cb154f5eeff19216d2879872ba6569").and_return(0)
+      mod.check
+    end
+
+    it "gives proper command to sass module while checking .scss files" do
+      files = ["a.scss"]
+      mod = Checker::Modules::Sass.new(files)
+      mod.stub(:check_for_executable).and_return(true)
+      mod.should_receive(:plain_command).with("sass --scss -c .checker-cache/13dbadc466ed1f9bdfbb2b545e45d012").and_return(0)
+      mod.check
+    end
+  end
+
+  context "rails check" do
+    before do
+      Checker::Options.stub(:use_rails_for_sass).and_return(true)
+    end
+
+    after do
+      `rm -rf spec/assets/stylesheets/checker-cache*`
+    end
+
     it "gives proper command to sass module while checking .sass files" do
       files = ["a.sass"]
       mod = Checker::Modules::Sass.new(files)
+      mod.stub(:rails_project?).and_return(true)
+      mod.stub(:rails_with_ap?).and_return(true)
       mod.stub(:check_for_executable).and_return(true)
-      mod.should_receive(:plain_command).with("sass  -c .checker-cache/69cb154f5eeff19216d2879872ba6569")
+      mod.stub(:stylesheets_dir).and_return("spec/assets/stylesheets/")
+      mod.should_receive(:plain_command).with("rails runner \"Rails.application.assets.find_asset(\\\"#{Dir.pwd}/spec/assets/stylesheets/checker-cachea.sass\\\").to_s\"").and_return(0)
       mod.check
     end
 
     it "gives proper command to sass module while checking .scss files" do
       files = ["a.scss"]
       mod = Checker::Modules::Sass.new(files)
+      mod.stub(:rails_project?).and_return(true)
+      mod.stub(:rails_with_ap?).and_return(true)
       mod.stub(:check_for_executable).and_return(true)
-      mod.should_receive(:plain_command).with("sass --scss -c .checker-cache/13dbadc466ed1f9bdfbb2b545e45d012")
+      mod.stub(:stylesheets_dir).and_return("spec/assets/stylesheets/")
+      mod.should_receive(:plain_command).with("rails runner \"Rails.application.assets.find_asset(\\\"#{Dir.pwd}/spec/assets/stylesheets/checker-cachea.scss\\\").to_s\"").and_return(0)
       mod.check
     end
   end

data/spec/checker/modules/slim_spec.rb

@@ -5,7 +5,7 @@ describe Checker::Modules::Slim do
     files = ['a.rb', 'b.js.erb', 'c.r', 'd.yml', 'e.yaml', 'f.coffee', 'g.slim']
     mod = Checker::Modules::Slim.new(files)
     mod.stub(:check_for_executable).and_return(true)
-    mod.stub(:check_one_file).and_return(true)
+    mod.stub(:check_one_file).and_return(stub(:success? => true, :status => :ok))
     mod.should_receive(:check_one_file).with('g.slim')
     mod.should_not_receive(:check_one_file).with('f.coffee')
     mod.should_not_receive(:check_one_file).with('e.yaml')

data/spec/checker/modules/yaml_spec.rb

@@ -4,7 +4,7 @@ describe Checker::Modules::Yaml do
   it 'should only check .yaml and .yml files' do
     files = ['a.rb', 'b.js.erb', 'c.r', 'd.yml', 'e.yaml']
     mod = Checker::Modules::Yaml.new(files)
-    mod.stub(:check_one_file).and_return(true)
+    mod.stub(:check_one_file).and_return(stub(:success? => true, :status => :ok))
     mod.should_receive(:check_one_file).with('d.yml')
     mod.should_receive(:check_one_file).with('e.yaml')
     mod.should_not_receive(:check_one_file).with('a.rb')

data/templates/checker-prepare-commit-msg

@@ -1,8 +1,8 @@
 
 #### Begin of checker script
-checker
+CHECKER_COMMAND
 
-if [ $? == 1 ]; then
+if [ $? = 1 ]; then
   exit 1
 fi
 

metadata

@@ -1,8 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: checker
 version: !ruby/object:Gem::Version
-  version: 0.6.4
-  prerelease: 
+  version: 0.6.5.rc1
+  prerelease: 6
 platform: ruby
 authors:
 - Jacek Jakubik
@@ -10,24 +10,19 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-24 00:00:00.000000000 Z
+date: 2013-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &70220750990620 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - '='
+    - - =
       - !ruby/object:Gem::Version
         version: 0.5.8
   type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.5.8
+  version_requirements: *70220750990620
 description: A collection of modules which every is designed to check syntax for specific
   files.
 email:
@@ -56,6 +51,7 @@ files:
 - lib/checker/modules/base.rb
 - lib/checker/modules/coffeescript.rb
 - lib/checker/modules/conflict.rb
+- lib/checker/modules/console_log.rb
 - lib/checker/modules/haml.rb
 - lib/checker/modules/javascript.rb
 - lib/checker/modules/pry.rb
@@ -63,10 +59,19 @@ files:
 - lib/checker/modules/sass.rb
 - lib/checker/modules/slim.rb
 - lib/checker/modules/yaml.rb
+- lib/checker/options.rb
+- lib/checker/result.rb
+- lib/checker/results/console_log.rb
+- lib/checker/results/default.rb
+- lib/checker/results/javascript.rb
+- lib/checker/rvm.rb
 - lib/checker/version.rb
+- spec/assets/stylesheets/empty
 - spec/checker/cli_spec.rb
 - spec/checker/fixtures/conflict/with_conflict.rb
 - spec/checker/fixtures/conflict/without_conflict.rb
+- spec/checker/fixtures/console_log/with_console_log.js
+- spec/checker/fixtures/console_log/without_console_log.js
 - spec/checker/fixtures/pry/with_both.rb
 - spec/checker/fixtures/pry/with_pry.rb
 - spec/checker/fixtures/pry/with_pry_remote.rb
@@ -81,6 +86,7 @@ files:
 - spec/checker/modules/base_spec.rb
 - spec/checker/modules/coffeescript_spec.rb
 - spec/checker/modules/conflict_spec.rb
+- spec/checker/modules/console_log_spec.rb
 - spec/checker/modules/haml_spec.rb
 - spec/checker/modules/javascript_spec.rb
 - spec/checker/modules/pry_spec.rb
@@ -105,12 +111,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
-  - - ! '>='
+  - - ! '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: Syntax checker for various files