checkcheckit 0.1.1 → 0.1.2

data/README.md

@@ -8,11 +8,6 @@ use checklists, like a boss
 
 ## TODO
 
-- interactive run
-  - socket.io between page and cmd line
-- save a run
-  - to file
-  - to service
 - resume a run
   - locally
 

data/lib/checkcheckit/console.rb

@@ -44,14 +44,19 @@ class CheckCheckIt::Console
       list = List.new(list_name)
       if (emails = @options['email']) || @options['live']
         @list_id = list_id = notify_server_of_start(emails, list)
-        puts "Live at URL: #{URI.join(web_service_url, list_id)}"
+        url = URI.join(web_service_url, list_id)
+        puts "Live at URL: #{url}"
+
+        if @options['open'] || @options['O']
+          Process.detach fork{ exec("open #{url}") }
+        end
 
         begin
           @client = web_socket.connect(web_service_url, sync: true) do
             after_start { emit('register', {list_id: list_id}) }
           end
         rescue Errno::ECONNREFUSED, WebSocket::Error, RuntimeError => e
-          STDERR.puts "Websocket refused connection - using POST"
+          $stderr.puts "Websocket refused connection - using POST"
           @use_post = true
         end
       end
@@ -103,15 +108,8 @@ class CheckCheckIt::Console
         return
       end
 
-      if @client
-        @client.emit 'check', {
-          list_id: @list_id,
-          step_id: i
-        }
-      end
-
-      if @use_post
-        post_check(@list_id, i)
+      if check
+        update_server_with_step(i)
       end
 
       results[i] = {
@@ -164,7 +162,6 @@ class CheckCheckIt::Console
   def post_check(list_id, step_id)
     begin
       url = URI.join(web_service_url, "/#{list_id}/check/#{step_id}").to_s
-      STDERR.puts url
       Excon.post(url)
     rescue Excon::Errors::SocketError, ArgumentError => e
       puts "Error POSTing to #{url}"
@@ -181,10 +178,18 @@ class CheckCheckIt::Console
       :headers => {
         'Content-Type' => 'application/json'
       })
-      STDERR.puts response if @options['d'] || @options['debug']
+      $stderr.puts response if @options['d'] || @options['debug']
       return response.body.gsub('"','')
     rescue Excon::Errors::SocketError => e
       puts "Error connecting to #{web_service_url}"
     end
   end
+
+  def update_server_with_step(i)
+    if @client
+      @client.emit 'check', {list_id: @list_id, step_id: i}
+    elsif @use_post
+      post_check(@list_id, i)
+    end
+  end
 end

data/lib/checkcheckit/version.rb

@@ -1,3 +1,3 @@
 module CheckCheckIt
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/test/start_test.rb

@@ -9,6 +9,12 @@ class StartTest < CheckCheckIt::TestCase
     console.web_socket = MiniTest::Mock.new
   end
 
+  def mock_web_socket
+    client = MiniTest::Mock.new
+    console.web_socket.expect :connect, client, [String, {sync: true}]
+    client
+  end
+
   def test_list_parses_steps
     3.times { console.in_stream.expect :gets, "y" }
     result = check "start groceries"
@@ -23,15 +29,28 @@ class StartTest < CheckCheckIt::TestCase
 
   # When you do
   #
-  # check start deploy --email csquared@heroku.com
+  # check start deploy --live
+  #
+  # we setup the POST with the list data
+  def test_live_flag_triggers_live_mode
+    client = mock_web_socket
+    3.times { client.expect :emit, true, ['check', Hash] }
+    Excon.stub({:method => :post, :body => {
+      emails: nil,
+      list:   List.new(home + '/personal/groceries').to_h
+    }.to_json}, {:status => 200})
+    3.times { console.in_stream.expect :gets, "y" }
+    check "start groceries --live"
+  end
+
+  # When you do
   #
-  # It PUT/POSTS? to the checkcheckit webservice
+  # check start deploy --email csquared@heroku.com
   #
   # The webservice sends you an email with a link to the list so
   # you can run it on the web.
   def test_email_flag_triggers_live_mode
-    client = MiniTest::Mock.new
-    console.web_socket.expect :connect, client, [String, {sync: true}]
+    client = mock_web_socket
     3.times { client.expect :emit, true, ['check', Hash] }
     Excon.stub({:method => :post, :body => {
       emails: "csquared@heroku.com,thea.lamkin@gmail.com",
@@ -44,8 +63,7 @@ class StartTest < CheckCheckIt::TestCase
   # Same as above but with env set
   def test_reads_email_from_env
     set_env 'CHECKCHECKIT_EMAIL', "csquared@heroku.com,thea.lamkin@gmail.com"
-    client = MiniTest::Mock.new
-    console.web_socket.expect :connect, client, [String, {sync: true}]
+    client = mock_web_socket
     3.times { client.expect :emit, true, ['check', Hash] }
     Excon.stub({:method => :post, :body => {
       emails: "csquared@heroku.com,thea.lamkin@gmail.com",
@@ -55,7 +73,28 @@ class StartTest < CheckCheckIt::TestCase
     check "start groceries"
   end
 
+  def test_live_only_sends_on_success
+    client = mock_web_socket
+    1.times { client.expect :emit, true, ['check', Hash] }
+    Excon.stub({:method => :post}, {:status => 200})
+    2.times { console.in_stream.expect :gets, "n" }
+    1.times { console.in_stream.expect :gets, "y" }
+    check "start groceries --live"
+  end
+
+  def test_live_falls_back_to_post
+    # stub it the old way
+    ws = console.web_socket
+    def ws.connect(*args); raise WebSocket::Error; end
+    4.times { Excon.stub({:method => :post}, {:status => 200}) }
+    3.times { console.in_stream.expect :gets, "y" }
+    assert_output(//,/POST/) do
+      check "start groceries --live"
+    end
+  end
+
   def test_reads_url_from_env
+    #skip "too lazy to implement"
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: checkcheckit
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -114,7 +114,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 362655053570657751
+      hash: -2207512465125543391
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -123,7 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 362655053570657751
+      hash: -2207512465125543391
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23