chatwork 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 59e4ff9379d4a6103a888096f95051bde6b365ad9e7a165f379563f95a14042d
-  data.tar.gz: 90709b0cd1ea756266fb6072cd656455bc929ed34870dcf3d889781cb29f740a
+  metadata.gz: 52031d9d56999ff66bad2a4617fb83027540f1f32dd17a5bfa9d6920a94aaf9e
+  data.tar.gz: 90555909fa6e8990000d9c4eef8fd94e599a01b0a647a20ca09135b0bb65d435
 SHA512:
-  metadata.gz: ee3317f8e4afbf7d4c8a6384562202e8d8ce68226e7ccab6e6fc806446b0548df0a1192b5b712ed879a16de4d7bc2aca5dda15f87a596f4f479c62655787a945
-  data.tar.gz: 438dc9cec86531f6be5abb10f824d3a91c9bb0a22078027fb999e2ad19745fe6f67e4b039d14fa43680f4aa39ada8f9aacc71ebb701b980713fe9da51f3a066d
+  metadata.gz: 4bfdc23a78474cd708e33b97d906ed6ada4aefa15d1028e85826a501efbe02aa5e5567fd69d8fd25faf1ee4a28661a994a13474a50e51d007eee1ab8c2b7ba0c
+  data.tar.gz: 5eb280a4f59d87e467f33510f0d6ee799eed7d1e10e49b72c3dd5d7e48eb7748578e605510fc390143409cb50aee8970ccf8108f67c48dfabb1bb38cf810258d

data/CHANGELOG.md

@@ -1,6 +1,14 @@
 # Change Log
 ## Unreleased
-[Full Changelog](https://github.com/asonas/chatwork-ruby/compare/v0.6.1...master)
+[Full Changelog](https://github.com/asonas/chatwork-ruby/compare/v0.6.2...master)
+
+## v0.6.2
+[Full Changelog](https://github.com/asonas/chatwork-ruby/compare/v0.6.1...v0.6.2)
+
+* Fixed. `NoMethodError` when error response is empty
+  * https://github.com/asonas/chatwork-ruby/pull/43
+* Fixed. uninitialized constant `ChatWork::AuthenticateError` when other error class has not been called at all
+  * https://github.com/asonas/chatwork-ruby/pull/45
 
 ## v0.6.1
 [Full Changelog](https://github.com/asonas/chatwork-ruby/compare/v0.6.0...v0.6.1)

data/lib/chatwork.rb

@@ -5,6 +5,7 @@ module ChatWork
   autoload :BaseClient,         "chatwork/base_client"
   autoload :APIConnectionError, "chatwork/chatwork_error"
   autoload :APIError,           "chatwork/chatwork_error"
+  autoload :AuthenticateError,  "chatwork/chatwork_error"
   autoload :ChatWorkError,      "chatwork/chatwork_error"
   autoload :Client,             "chatwork/client"
   autoload :Contacts,           "chatwork/contacts"

data/lib/chatwork/chatwork_error.rb

@@ -1,6 +1,8 @@
 module ChatWork
   class ChatWorkError < StandardError
     def self.from_response(status, body, headers)
+      body ||= {}
+
       if headers.has_key?("WWW-Authenticate")
         return AuthenticateError.from_www_authenticate(
           www_authenticate: headers["WWW-Authenticate"],

data/lib/chatwork/member.rb

@@ -42,11 +42,11 @@ module ChatWork
     # @return [Hashie::Mash]
     #
     # @example response format
-    # {
-    #   "admin": [123, 542, 1001],
-    #   "member": [10, 103],
-    #   "readonly": [6, 11]
-    # }
+    #   {
+    #     "admin": [123, 542, 1001],
+    #     "member": [10, 103],
+    #     "readonly": [6, 11]
+    #   }
     def self.update_all(room_id:, members_admin_ids:, members_member_ids: nil, members_readonly_ids: nil)
       params = {
         members_admin_ids: Array(members_admin_ids).join(","),

data/lib/chatwork/version.rb

@@ -1,3 +1,3 @@
 module ChatWork
-  VERSION = "0.6.1".freeze
+  VERSION = "0.6.2".freeze
 end

data/spec/lib/chatwork/chatwork_error_spec.rb

@@ -1,6 +1,8 @@
 describe ChatWork::ChatWorkError do
   describe ".from_response" do
-    subject { ChatWork::ChatWorkError.from_response(status, Hashie::Mash.new(body), headers) }
+    subject { ChatWork::ChatWorkError.from_response(status, body_mash, headers) }
+
+    let(:body_mash) { Hashie::Mash.new(body) }
 
     context "with WWW-Authenticate header" do
       let(:status) { 401 }
@@ -42,6 +44,14 @@ describe ChatWork::ChatWorkError do
       its(:error_description) { should eq "The client ID `client_id` is unknown." }
       its(:error_response)    { should eq body }
     end
+
+    context "when body is nil" do
+      let(:status)    { 401 }
+      let(:body_mash) { nil }
+      let(:headers)   { {} }
+
+      it { should be_an_instance_of ChatWork::APIConnectionError }
+    end
   end
 
   describe ChatWork::AuthenticateError do

data/spec/lib/support/utils/raml_parser_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe RamlParser do
     let(:verb)   { :get }
     let(:path)   { "/rooms/{room_id}/members" }
 
-    its(["description"]) { should eq "チャットのメンバー一覧を取得\n" }
+    its(["description"]) { should eq "チャットのメンバー一覧を取得" }
     its(["is"])          { should eq ["room_member_list_response", "unauthorized_response"] }
   end
 

data/spec/spec_helper.rb

@@ -1,6 +1,13 @@
 if ENV["CI"]
+  require "simplecov"
   require "coveralls"
-  Coveralls.wear!
+
+  SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+  SimpleCov.start do
+    %w[spec].each do |ignore_path|
+      add_filter(ignore_path)
+    end
+  end
 end
 
 $LOAD_PATH << File.expand_path(File.join("..", "..", "lib"), __FILE__)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chatwork
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - asonas
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-12 00:00:00.000000000 Z
+date: 2018-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -331,7 +331,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: Ruby bindings of ChatWork API