chatterbox 0.8.4 → 0.8.5

data/CHANGELOG.markdown

@@ -1,5 +1,9 @@
 # Changelog
 
+### 0.8.5
+  - Allow setting the ignore list off for exceptions on a per
+    exception level.
+    
 ### 0.8.4
   - Log ignored exceptions
 

data/chatterbox.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{chatterbox}
-  s.version = "0.8.4"
+  s.version = "0.8.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Rob Sanheim"]
-  s.date = %q{2009-12-17}
+  s.date = %q{2010-01-04}
   s.description = %q{Send notifications and messages.  However you want.}
   s.email = %q{rsanheim@gmail.com}
   s.extra_rdoc_files = [

data/examples/lib/chatterbox/exception_notification_example.rb

@@ -17,6 +17,12 @@ describe Chatterbox::ExceptionNotification do
         Chatterbox::ExceptionNotification.configure { |c| c.ignore = Chatterbox::ExceptionNotification.default_ignored_exceptions }
       end
       
+      it "does not notify" do
+        Chatterbox::ExceptionNotification.configure { |c| c.ignore << RuntimeError }
+        Chatterbox.expects(:notify).never
+        Chatterbox::ExceptionNotification.handle(:exception => RuntimeError.new)
+      end
+      
       it "returns nil for explicit exception" do
         Chatterbox::ExceptionNotification.configure { |c| c.ignore << RuntimeError }
         Chatterbox::ExceptionNotification.handle(RuntimeError.new).should be_nil
@@ -32,9 +38,22 @@ describe Chatterbox::ExceptionNotification do
         Chatterbox.logger.expects(:debug).once
         Chatterbox::ExceptionNotification.handle(RuntimeError.new)
       end
+      
+      describe "with the ignore list manually turned off" do
+        it "notifies" do
+          Chatterbox::ExceptionNotification.configure { |c| c.ignore << RuntimeError }
+          Chatterbox.expects(:notify)
+          Chatterbox::ExceptionNotification.handle(:exception => RuntimeError.new, :use_ignore_list => false)
+        end
+      end
     end
     
     describe "when not on ignore list" do
+      it "notifies" do
+        Chatterbox.expects(:notify)
+        Chatterbox::ExceptionNotification.handle(:exception => Exception.new)
+      end
+      
       it "logs nothing" do
         Chatterbox.logger.expects(:debug).never
         Chatterbox::ExceptionNotification.handle(:exception => Exception.new)

data/lib/chatterbox/exception_notification.rb

@@ -11,7 +11,7 @@ module Chatterbox
     # * Objects are simply treated as a 'summary' message were an exception may not be necessary
     def handle(args)
       hsh = normalize_to_hash(args)
-      return if on_ignore_list?(hsh[:exception])
+      return if use_ignore_list?(hsh) && on_ignore_list?(hsh[:exception])
       hsh = Extracter.wrap(hsh)
       hsh = RailsExtracter.wrap(hsh)
       hsh = Presenter.render(hsh)
@@ -26,6 +26,14 @@ module Chatterbox
       end
     end
     
+    # Check to see if we should use ignore list for this exception - 
+    # first use the value from the passed in options, otherwise
+    # use the configuration value (which defaults to true)
+    def use_ignore_list?(hsh)
+      return hsh[:use_ignore_list] if hsh.key?(:use_ignore_list)
+      configuration.use_ignore_list
+    end
+    
     def on_ignore_list?(exception)
       ignored = configuration.ignore.include?(exception.class) || 
                 configuration.ignore.include?(exception.class.to_s)
@@ -37,8 +45,14 @@ module Chatterbox
       Chatterbox.logger.debug { %[Chatterbox::ExceptionNotification ignoring exception: "#{exception}" as its on the ignore list] }
     end
 
+    # Default configuration for ExceptionNotification
+    #   :ignore => array of exceptions to ignore by default
+    #   :use_ignore_list => whether to use the ignore list - 
+    #     defaults to true, and can be overidden on per exception level
     def configuration
-      @configuration ||= OpenStruct.new(:ignore => default_ignored_exceptions)
+      @configuration ||= OpenStruct.new(
+        :ignore => default_ignored_exceptions,
+        :use_ignore_list => true)
     end
     
     # Configure ExceptionNotification

data/lib/chatterbox/version.rb

@@ -3,7 +3,7 @@ module Chatterbox # :nodoc:
     unless defined?(MAJOR)
       MAJOR  = 0
       MINOR  = 8
-      TINY   = 4
+      TINY   = 5
 
       STRING = [MAJOR, MINOR, TINY].compact.join('.')
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: chatterbox
 version: !ruby/object:Gem::Version 
-  version: 0.8.4
+  version: 0.8.5
 platform: ruby
 authors: 
 - Rob Sanheim
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-12-17 00:00:00 -05:00
+date: 2010-01-04 00:00:00 -06:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency