charyf 0.2.9 → 0.2.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7c18514711153530b6ec38086d043116a9fe43f4
-  data.tar.gz: bd3695d976533447bf9a1c822ccc9289c4ba4f07
+  metadata.gz: 9b99229b9888f43029d9e51373d9df530df31265
+  data.tar.gz: 5abf44d14306c35517f165fa367e07205f6d1366
 SHA512:
-  metadata.gz: 1e0e95b6362d59a34a67bf2eef0ed2d4de4de2042892ff6b7e9a8d599a42ba123028f7b1b4cd10b20b2e9fac19308530122e24060c01e1b2690bc050d1efd37c
-  data.tar.gz: 6704b0af876f06ba75609ef1e6c477f3377d47435f002769e0bb30cf6618c50c747299cfd814d5344333c204c4c7fe11030e379b7b891a17f0ff7ef1652876ab
+  metadata.gz: 11388a95f19750048153a6e31804ad7fcf3603ff6c3fb58d1ca4817acfbb88b97b376661ee17980e7282b355ba8740ffdc81447fcbcf10f822d2baeb1cd79baf
+  data.tar.gz: 4752b08207fee648489bb475da0786956e4ee3e337b05ad9b1a178ee875b612cc80aa4ef5ace4c72ccfa697939781eb317d6cb4de6aa6d00ab73f6b57eec8337

data/Gemfile.lock

@@ -1,8 +1,7 @@
 PATH
   remote: .
   specs:
-    charyf (0.2.9)
-      charyf_sig (~> 1.1.2)
+    charyf (0.2.10)
       colorize (~> 0.8)
       i18n (~> 0.9)
       thor (>= 0.18.1, < 2.0)
@@ -10,7 +9,6 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    charyf_sig (1.1.2)
     coderay (1.1.2)
     colorize (0.8.1)
     concurrent-ruby (1.0.5)

data/charyf.gemspec

@@ -33,7 +33,6 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
 
   # Internal dependencies
-  spec.add_runtime_dependency 'charyf_sig', '~> 1.1.2'
 
   # External dependencies
   spec.add_runtime_dependency 'i18n', '~> 0.9'

data/lib/charyf/deps.rb

@@ -1,9 +1,2 @@
-# Signature checking
-if %w(development test).include?((ENV['CHARYF_ENV'] || 'development').downcase) || ENV['ENABLE_SIG']
-  require 'charyf_sig'
-  else
-  require 'charyf_sig/none'
-end
-
 # I18n
 require 'i18n'

data/lib/charyf/engine/controller/controller.rb

@@ -28,7 +28,6 @@ module Charyf
 
       protected
 
-      sig [{text: ['String','NilClass'], render: ['Symbol', 'String', 'NilClass']}], nil,
       def reply(
           text: nil,
           html: nil,

data/lib/charyf/engine/controller/renderers.rb

@@ -30,7 +30,6 @@ module Charyf
 
       end # End of ClassMethods
 
-      # TODO sig
       def response_folder
         return nil if skill.nil?
 
@@ -48,12 +47,10 @@ module Charyf
         end
       end
 
-      # TODO sig
       def responses_for(action)
         Dir[response_folder.join("#{action}**")]
       end
 
-      # TODO sig
       def render_text_response(action)
         file_path = response_folder.join("#{action}.txt.erb")
 
@@ -62,7 +59,6 @@ module Charyf
         _render_sample_response file_path
       end
 
-      # TODO sig
       def render_html_response(action)
         file_path = response_folder.join("#{action}.html.erb")
 
@@ -84,12 +80,10 @@ module Charyf
       end
 
 
-      # TODO sig
       def controller_path
         controller_name.underscore
       end
 
-      # TODO sig
       def exists?(path)
         File.exists?(path)
       end

data/lib/charyf/engine/dispatcher/base.rb

@@ -63,7 +63,6 @@ module Charyf
           self.class.routes
         end
 
-        sig ['Charyf::Engine::Context'], nil,
         def spawn_controller(context)
 
           Charyf.logger.flow_request("[FLOW] Dispatching request [#{context.request.inspect}]" +

data/lib/charyf/engine/interface/program.rb

@@ -25,7 +25,6 @@ module Charyf
         # NOP
       end
 
-      sig_self ['String', 'Charyf::Engine::Response'], nil,
       def self.reply(conversation_id, message_id, response)
         interface = _interfaces[conversation_id]
         raise InvalidConversationError.new("No program interface found for conversation #{conversation_id}") unless interface
@@ -33,7 +32,6 @@ module Charyf
         interface.reply(response)
       end
 
-      sig_self ['String', 'Proc'], 'Charyf::Interface::Program',
       def self.create(conversation_id, handler)
         interface = self.new(conversation_id, handler)
 
@@ -46,24 +44,20 @@ module Charyf
         @_interfaces ||= Hash.new
       end
 
-      sig [nil, 'Proc'],
       def initialize(conversation_id, handler)
 
         @handler = handler
         @conversation_id = conversation_id.to_s
       end
 
-      sig ['Charyf::Engine::Request'],
       def process(request)
         self.class.dispatcher.dispatch(request)
       end
 
-      sig ['Charyf::Engine::Response'],
       def reply(response)
         handler.call(response)
       end
 
-      sig [], 'Charyf::Engine::Request',
       def request
         Charyf::Engine::Request.new(self.class, conversation_id, SecureRandom.hex)
       end

data/lib/charyf/engine/request.rb

@@ -8,7 +8,6 @@ module Charyf
 
 
       # Module -> anything of type Charyf::Interface::Base
-      # sig ['Module', 'String'], nil,
       def initialize(referer, conversation_id, message_id)
         @referer = referer
         @conversation_id = conversation_id

data/lib/charyf/engine/session/processors/processor.rb

@@ -11,12 +11,10 @@ module Charyf
 
           include Charyf::Strategy::BaseClass
 
-          sig ['Charyf::Engine::Request'], ['Charyf::Engine::Session', 'NilClass'],
           def process(request)
             raise Charyf::Utils::NotImplemented.new
           end
 
-          sig_self [], ['Charyf::Engine::Session::Processor::Base'],
           def self.get
             raise Charyf::Utils::NotImplemented.new
           end

data/lib/charyf/engine/session/session.rb

@@ -7,7 +7,6 @@ module Charyf
       attr_reader :uuid, :skill, :controller, :action, :timestamp
 
       # TODO - mention it could return nil
-      # TODO sig
       def self.get(uuid)
         yaml = _storage.get(uuid)
         yaml ? YAML.load(yaml) : nil
@@ -45,7 +44,6 @@ module Charyf
         self.class._storage.store(@uuid, YAML.dump(self))
       end
 
-      sig [], ['Symbol', 'String', 'NilClass'],
       def full_controller_name
         @controller.blank? ? nil : @skill.camelize + '::' + @controller.camelize
       end

data/lib/charyf/engine/skill/info.rb

@@ -8,7 +8,6 @@ module Charyf
 
       module ClassMethods
 
-        sig ['String', 'Symbol', 'NilClass'], ['Symbol'],
         def skill_name(name = nil)
           if name
             @_name = name.to_sym

data/lib/charyf/utils/application.rb

@@ -64,7 +64,6 @@ module Charyf
       instance_eval(&block)
     end
 
-    # TODO sig, nullable
     def session_processor
       # TODO resolve dependency on engine - maybe move the base classes to utils?
       klass = Charyf::Engine::Session::Processor.list[config.session_processor]
@@ -105,7 +104,6 @@ module Charyf
       klass
     end
 
-    # TODO sig, nullable
     def storage_provider
       klass = Charyf::Utils::StorageProvider.list[config.storage_provider]
       raise Charyf::Utils::InvalidConfiguration.new("No storage provider with name '#{config.storage_provider}' found") unless klass

data/lib/charyf/utils/machine.rb

@@ -9,7 +9,6 @@ module Charyf
 
       class << self
 
-        # Sig does not handle blocks
         def state(name, default: false, final: false, action: nil, &block)
           if default
             raise DefaultExists.new if @_default_state

data/lib/charyf/utils/storage/provider.rb

@@ -11,22 +11,18 @@ module Charyf
 
         include Charyf::Strategy::BaseClass
 
-        sig_self [['Module', 'String']], ['Charyf::Utils::StorageProvider::Base'],
         def self.get_for(klass)
           raise Charyf::Utils::NotImplemented.new
         end
 
-        sig [nil], [nil],
         def get(key)
           raise Charyf::Utils::NotImplemented.new
         end
 
-        sig [nil, nil], [nil],
         def store(key, value)
           raise Charyf::Utils::NotImplemented.new
         end
 
-        sig [nil], [nil],
         def remove(key)
           raise Charyf::Utils::NotImplemented.new
         end

data/lib/charyf/utils/utils.rb

@@ -54,7 +54,6 @@ module Charyf
       }
     end
 
-    sig_self ['Symbol', 'Hash'], ['TrueClass', 'FalseClass'],
     def self.match_action_filters?(name, filters = {only: [], except: []} )
       (filters[:only] == :all && !filters[:except].include?(name)) ||
           ((filters[:only] != :all) && (filters[:only] || []).include?(name))

data/lib/charyf/version.rb

@@ -11,7 +11,7 @@ module Charyf
   module VERSION
     MAJOR = 0
     MINOR = 2
-    TINY  = 9
+    TINY  = 10
     PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")

data/todo.md

@@ -1,5 +1,4 @@
 * remove all imports, everything should import what is needed
-* remove sig -> too many problems
 * dispatcher - sync vs async
 * only one reply, however allow sends to the same interface
   * this should add a message id to request

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: charyf
 version: !ruby/object:Gem::Version
-  version: 0.2.9
+  version: 0.2.10
 platform: ruby
 authors:
 - Richard Ludvigh
@@ -10,20 +10,6 @@ bindir: exe
 cert_chain: []
 date: 2018-05-09 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: charyf_sig
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.1.2
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.1.2
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement