chargify_api_ares 1.4.14 → 1.4.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 208e13dde40fe8a97354321a8496e87956ec6095
-  data.tar.gz: 1733723435ca4476e94959ecdb1845efe42caa0b
+SHA256:
+  metadata.gz: 9df580c55a36eb2d98f33aef4030cddca3758e96e8a08fce6922c4a8a9ab4bf9
+  data.tar.gz: 2b97d5712cd2b0b1a9e9c9776bc930dbd5f1f5523d90cfcb4f842dbc530d5981
 SHA512:
-  metadata.gz: 8d78f8e973cf406911ffde3a5814f795eecc8a8596eab6040281f01db14c0e8bb6bf0d514c61bbed215e2f57ab662d7ae2dd3745765f0c7ef6cabff3b3ddca26
-  data.tar.gz: d15450a708efba0c3a4b729633250117849b19c1a62787d49dd403a0a5285e2733850a89ecc3977922ab8d993dc8ccbfce7dffbf8cec64ae52061c909038789a
+  metadata.gz: ab6fb12e2711d83bc41a301ffeeb58f6e6c041f12659fd5ce4758442b8708dfe5e7d6a7586ec4dea6be4e7fd17f760aa83c03677e0a66c2fec6d2aaeb77d2919
+  data.tar.gz: 7e6f9bfc00e560a5330975be5d7959e4f503fe7c9787a3e2969f4edb8a44c4650cba46016834fff7d9e3b173819860a711026f51e0e4d759e12f51a891a2c9d1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    chargify_api_ares (1.4.14)
+    chargify_api_ares (1.4.15)
       activeresource (>= 3.2.16)
 
 GEM
@@ -67,4 +67,4 @@ DEPENDENCIES
   vcr
 
 BUNDLED WITH
-   1.16.0
+   1.16.1

data/HISTORY.md

@@ -1,3 +1,8 @@
+## 1.4.15 / June 20, 2018
+
+* Changes Subscription#remove_coupon to use coupon_code instead of code [PR 165](https://github.com/chargify/chargify_api_ares/pull/165).  
+  With this change, the currently applied coupon code must be passed for removal to occur.
+
 ## 1.4.14 / December 7, 2017
 
 * Allows canceling a subscription with all supported attributes [PR 161](https://github.com/chargify/chargify_api_ares/pull/161)

data/README.md

@@ -2,12 +2,16 @@ Chargify API wrapper for Ruby (using ActiveResource)
 ====================================================
 [![build status](https://secure.travis-ci.org/chargify/chargify_api_ares.png)](http://travis-ci.org/chargify/chargify_api_ares) [![Code Climate](https://codeclimate.com/github/chargify/chargify_api_ares/badges/gpa.svg)](https://codeclimate.com/github/chargify/chargify_api_ares)
 
+This is a community-maintained Ruby wrapper for the [Chargify](https://www.chargify.com) API that leverages ActiveResource.
+
+Though we do not proactively maintain it, Chargify is happy to review pull requests and manage the release process for the gem. We encourage community contributions to make the wrapper even more comprehensive and powerful.
+
+If you notice an endpoint or method that is missing, please feel free to add it by submitting a pull request. We appreciate your support!
+
 **Note:** we have bumped to v1.0.0 to indicate a backwards incompatible change to the responses from `Chargify::Subscription.charge` and `Chargify::Subscription.migrate`.  Please see the HISTORY.md for more information.
 
 **Please see important compatibility information at the bottom of this file.**
 
-This is a Ruby wrapper for the [Chargify](http://chargify.com) API that leverages ActiveResource.
-
 ### Installation
 
 This library can be installed as a gem. It is hosted on [Rubygems](http://rubygems.org).

data/chargify_api_ares.gemspec

@@ -4,8 +4,8 @@ Gem::Specification.new do |s|
   s.rubygems_version          = '1.3.7'
 
   s.name        = 'chargify_api_ares'
-  s.version     = '1.4.14'
-  s.date        = '2017-12-07'
+  s.version     = '1.4.15'
+  s.date        = '2018-06-20'
   s.summary     = 'A Chargify API wrapper for Ruby using ActiveResource'
   s.description = ''
   s.authors     = ["Chargify Development Team"]

data/lib/chargify_api_ares/resources/subscription.rb

@@ -170,7 +170,7 @@ module Chargify
         if code.nil?
           delete :remove_coupon
         else
-          delete :remove_coupon, :code => code
+          delete :remove_coupon, :coupon_code => code
         end
       end
     end

data/spec/remote/remote_spec.rb

@@ -645,6 +645,88 @@ describe "Remote" do
     end
   end
 
+  describe "removing a coupon" do
+    let(:coupon1) do
+      Chargify::Coupon.create(
+        product_family_id: acme_projects.id,
+        name: 'CODE 1',
+        code: 'CODE1',
+        description: 'a coupon',
+        percentage: 10,
+        stackable: true
+      )
+    end
+
+    context 'when a subscription has a single coupon' do
+
+      let(:subscription) do
+        Chargify::Subscription.create(
+          :product_handle => pro_plan.handle,
+          :customer_reference => johnadoe.reference,
+          :payment_profile_attributes => good_payment_profile_attributes,
+          :coupon_codes => coupon1.code
+        )
+      end
+
+      it 'removes the coupon when a code is provided' do
+        subscription.remove_coupon('CODE1')
+        subscription.reload
+
+        expect(subscription.coupon_code).to be_nil
+      end
+
+      it 'removes the coupon without a code' do
+        subscription.remove_coupon
+        subscription.reload
+
+        expect(subscription.coupon_code).to be_nil
+      end
+
+      it 'does not remove the coupon given a mismatched code' do
+        subscription.remove_coupon('NOT_A_CODE')
+        subscription.reload
+
+        expect(subscription.coupon_code).to eq 'CODE1'
+      end
+    end
+
+    context 'when a subscription has multiple coupons' do
+      let(:coupon2) do
+        Chargify::Coupon.create(
+          product_family_id: acme_projects.id,
+          name: 'CODE 2',
+          code: 'CODE2',
+          description: 'another coupon',
+          percentage: 10,
+          stackable: true
+        )
+      end
+
+      let(:subscription) do
+        Chargify::Subscription.create(
+          :product_handle => pro_plan.handle,
+          :customer_reference => johnadoe.reference,
+          :payment_profile_attributes => good_payment_profile_attributes,
+          :coupon_codes => [coupon1.code, coupon2.code]
+        )
+      end
+
+      it 'does not remove any coupons without a code' do
+        subscription.remove_coupon
+        subscription.reload
+
+        expect(subscription.coupon_codes).to eq ['CODE1', 'CODE2']
+      end
+
+      it 'removes the specified coupon when a code is given' do
+        subscription.remove_coupon('CODE1')
+        subscription.reload
+
+        expect(subscription.coupon_codes).to eq ['CODE2']
+      end
+    end
+  end
+
   describe "adding a refund" do
     before(:all) do
       @subscription = Chargify::Subscription.create(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chargify_api_ares
 version: !ruby/object:Gem::Version
-  version: 1.4.14
+  version: 1.4.15
 platform: ruby
 authors:
 - Chargify Development Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-07 00:00:00.000000000 Z
+date: 2018-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource
@@ -270,7 +270,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 3
 summary: A Chargify API wrapper for Ruby using ActiveResource