chargify_api_ares 1.4.13 → 1.4.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d402f3d0f5291f1c0e72180aee716fb1555ce8cd
-  data.tar.gz: 670c20c39aea7bcff92391cbafff2b11be7df30b
+  metadata.gz: 208e13dde40fe8a97354321a8496e87956ec6095
+  data.tar.gz: 1733723435ca4476e94959ecdb1845efe42caa0b
 SHA512:
-  metadata.gz: 54edbc80a59b7767d31d79a12442f719ddf34a5b8c5082b06da622eb5693ec7cfcccfcee1dabc23f66d25c2466c7a09baf3b5e58028ebeabd880af43b167f173
-  data.tar.gz: 5edbb32b7ba8b80e052f5bbd8ead0a66bd5274102b33ef9fa4b23262cfd2253cc6bdf0285d635d8eaae297120df3bef6835713fd7307e77284d39f7c918d2b20
+  metadata.gz: 8d78f8e973cf406911ffde3a5814f795eecc8a8596eab6040281f01db14c0e8bb6bf0d514c61bbed215e2f57ab662d7ae2dd3745765f0c7ef6cabff3b3ddca26
+  data.tar.gz: d15450a708efba0c3a4b729633250117849b19c1a62787d49dd403a0a5285e2733850a89ecc3977922ab8d993dc8ccbfce7dffbf8cec64ae52061c909038789a

data/.travis.yml

@@ -2,6 +2,7 @@ language: ruby
 before_install:
   - gem update --system
   - gem update bundler
+  - bundle install --no-deployment
 rvm:
   - 2.1.3
   - 2.0.0

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    chargify_api_ares (1.4.13)
+    chargify_api_ares (1.4.14)
       activeresource (>= 3.2.16)
 
 GEM
@@ -67,4 +67,4 @@ DEPENDENCIES
   vcr
 
 BUNDLED WITH
-   1.14.6
+   1.16.0

data/HISTORY.md

@@ -1,3 +1,7 @@
+## 1.4.14 / December 7, 2017
+
+* Allows canceling a subscription with all supported attributes [PR 161](https://github.com/chargify/chargify_api_ares/pull/161)
+
 ## 1.4.13 / July 21, 2017
 
 * Note: No changes from 1.4.12, previous release was not officially published

data/chargify_api_ares.gemspec

@@ -4,8 +4,8 @@ Gem::Specification.new do |s|
   s.rubygems_version          = '1.3.7'
 
   s.name        = 'chargify_api_ares'
-  s.version     = '1.4.13'
-  s.date        = '2017-07-21'
+  s.version     = '1.4.14'
+  s.date        = '2017-12-07'
   s.summary     = 'A Chargify API wrapper for Ruby using ActiveResource'
   s.description = ''
   s.authors     = ["Chargify Development Team"]

data/examples/subscriptions.rb

@@ -53,6 +53,12 @@ subscription.cancel
 subscription.reload
 # => #<Chargify::Subscription:0x1020ed4b0 @prefix_options={}, @attributes={"cancellation_message"=>nil, "activated_at"=>Tue Nov 17 16:00:17 UTC 2009, "expires_at"=>nil, "updated_at"=>Tue Nov 17 16:00:17 UTC 2009, "credit_card"=>#<Chargify::Subscription::CreditCard:0x10234f168 @prefix_options={}, @attributes={"card_type"=>"bogus", "expiration_year"=>2015, "masked_card_number"=>"XXXX-XXXX-XXXX-2", "first_name"=>"Michael", "expiration_month"=>1, "last_name"=>"Klett"}>, "product"=>#<Chargify::Product:0x10234f370 @prefix_options={}, @attributes={"price_in_cents"=>0, "name"=>"Chargify API Ares Test", "handle"=>"chargify-api-ares-test", "product_family"=>#<Chargify::Product::ProductFamily:0x102354708 @prefix_options={}, @attributes={"name"=>"Chargify API ARes Test", "handle"=>"chargify-api-ares-test", "id"=>79, "accounting_code"=>nil}>, "id"=>153, "accounting_code"=>nil, "interval_unit"=>"month", "interval"=>1}>, "credit_card_attributes"=>{:full_number=>"2", :expiration_year=>"2015"}, "trial_ended_at"=>nil, "id"=>331, "current_period_ends_at"=>Thu Dec 17 16:00:17 UTC 2009, "product_handle"=>"chargify-api-ares-test", "customer"=>#<Chargify::Customer:0x10234f730 @prefix_options={}, @attributes={"reference"=>"moklett", "updated_at"=>Tue Nov 17 15:51:02 UTC 2009, "id"=>331, "first_name"=>"Michael", "organization"=>"Chargify", "last_name"=>"Klett", "email"=>"moklett@example.com", "created_at"=>Tue Nov 17 15:51:02 UTC 2009}>, "trial_started_at"=>nil, "balance_in_cents"=>0, "current_period_started_at"=>Tue Nov 17 16:00:17 UTC 2009, "state"=>"canceled", "created_at"=>Tue Nov 17 16:00:17 UTC 2009, "customer_reference"=>"moklett"}>
 
+# Cancel a subscription with key/value options (Omitted options remain nil)
+subscription.cancel(
+  :cancellation_message => "Some cancellation message",
+  :reason_code => "Some reason code"
+)
+
 # Schedule a delayed cancellation
 subscription.delayed_cancel
 subscription.delayed_cancel(true)

data/lib/chargify_api_ares/resources/subscription.rb

@@ -21,12 +21,19 @@ module Chargify
       super
     end
 
-    def cancel(cancellation_message = nil)
-      if cancellation_message.nil?
+    def cancel(params = {})
+      if params.blank?
         destroy
       else
         #Destroy does not support body, must work around it to send verb DELETE
-        self.connection.post(element_path, {:cancellation_message => cancellation_message}.to_xml(:root => :subscription), self.class.headers.merge({'X-Http-Method-Override' => 'DELETE'}))
+        self.connection.post(
+          element_path,
+          {
+            cancellation_message: params[:cancellation_message] || nil,
+            reason_code: params[:reason_code] || nil
+          }.to_xml(:root => :subscription),
+          self.class.headers.merge({'X-Http-Method-Override' => 'DELETE'})
+        )
       end
     end
 

data/spec/remote/remote_spec.rb

@@ -330,6 +330,30 @@ describe "Remote" do
       @subscription.cancel
       Chargify::Subscription.find(@subscription.id).state.should == 'canceled'
     end
+
+    it "does not set optional attributes" do
+      @subscription.cancel
+      @subscription.reload.cancellation_message.should be_nil
+      @subscription.reload.reason_code.should be_nil
+    end
+
+    it "only sets optional cancellation_message attribute" do
+      @subscription.cancel(cancellation_message: "This is a cancellation message.")
+      @subscription.reload.cancellation_message.should == "This is a cancellation message."
+      @subscription.reload.reason_code.should be_nil
+    end
+
+    it "only sets optional reason_code attribute" do
+      @subscription.cancel(reason_code: "This is a reason code.")
+      @subscription.reload.cancellation_message.should be_nil
+      @subscription.reload.reason_code.should == "This is a reason code."
+    end
+
+    it "sets multiple optional attributes" do
+      @subscription.cancel(cancellation_message: "This is a cancellation message.", reason_code: "This is a reason code.")
+      @subscription.reload.cancellation_message.should == "This is a cancellation message."
+      @subscription.reload.reason_code.should == "This is a reason code."
+    end
   end
 
   describe "scheduling a subscription cancellation" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chargify_api_ares
 version: !ruby/object:Gem::Version
-  version: 1.4.13
+  version: 1.4.14
 platform: ruby
 authors:
 - Chargify Development Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-21 00:00:00.000000000 Z
+date: 2017-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource
@@ -270,7 +270,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.5.2.1
 signing_key: 
 specification_version: 3
 summary: A Chargify API wrapper for Ruby using ActiveResource