changes_are_logged 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d90d72f1008b87901b0fba752fada04b4aeedb3
-  data.tar.gz: 75b748b04d97a23f087d561b2906f547f7e56104
+  metadata.gz: ce6f89495c02282666101bb8a64a7a9e1da9c6a3
+  data.tar.gz: 8233bfd6e2fc6efe463341fb2a0531dc2a0e50ca
 SHA512:
-  metadata.gz: 7ce9d121191517b0175fd3622c8abda82dd6e135778a9f59c091f932ffc750e29ac10892cd49af456beb8a69f5f4e609e72481c4c9681ead8ea61a7efec8d191
-  data.tar.gz: cebba36a943ec5ba20c5c2584fe9743c798ea654f14a5aa4c9ec9196cc29ddbe058b0551988c40d3910407c1ebb9ea291af67f7506faaef8c0e7c2dd79d7648d
+  metadata.gz: ac02e46ccbb4ebe6608b7a156cdd4e5890faf9903dbdc2fac82ede1b6bc23a5bd6a20c5d632600c68c59119164ca61e0b60e17bae69205b0577081df9b58c715
+  data.tar.gz: 62dc644409c8078f9d8948dd89425b15f3b9c709bea0e3afd59bd0fc114756ab97fbbfe4891d1ce40534fb329c3796fa248e2c2af6994ef7bc562cda65deae8b

data/.travis.yml

@@ -1,6 +1,6 @@
 language: ruby
 rvm:
-  - 2.3.3
+  - 2.5.3
 sudo: false
 cache:
   - bundler
@@ -8,7 +8,7 @@ notifications:
   email: false
 script: bundle exec rspec
 env:
-  - RAILS_VERSION='~> 4.0.0'
-  - RAILS_VERSION='~> 4.1.0'
   - RAILS_VERSION='~> 4.2.0'
-  - RAILS_VERSION='~> 5.0.0'
+  - RAILS_VERSION='~> 5.0.7'
+  - RAILS_VERSION='~> 5.1.7'
+  - RAILS_VERSION='~> 5.2.3

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 1.2.0
+* Add Rails 5 compatibility
+
 # 1.1.0
 * Don't monkey patch 'attribute_change' method from ActiveModel::Dirty
 

data/changes_are_logged.gemspec

@@ -15,9 +15,9 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  s.add_dependency 'activerecord', ENV.fetch('RAILS_VERSION', '>= 4.0')
+  s.add_dependency 'activerecord', ENV.fetch('RAILS_VERSION', '>= 4.0'), '< 6'
 
   # specify any dependencies here instead of Gemfile:
   s.add_development_dependency 'rspec-rails', '~> 3.0'
-  s.add_development_dependency 'sqlite3', '~> 1.3'
+  s.add_development_dependency 'sqlite3', '~> 1.3.6'
 end

data/lib/changes_are_logged.rb

@@ -21,17 +21,18 @@ module ChangesAreLogged
         @change_comments = "new record" if @change_comments.blank?
         @changes_logged = {}
         save_change_log
-      elsif changed? || !@change_comments.blank?
+      elsif (ActiveRecord::VERSION::STRING >= '5.1' ? saved_changes? : changed?) || !@change_comments.blank?
         @changes_logged = HashWithIndifferentAccess.new
 
+        ar_version_changes = ActiveRecord::VERSION::STRING >= '5.1' ? saved_changes : changes
         if log_changes_callback
-          changes.each do |attribute, (old_value, new_value)|
+          ar_version_changes.each do |attribute, (old_value, new_value)|
             @changes_logged[attribute] = log_changes_callback.call(
               attribute, old_value, new_value
             )
           end
         else
-          @changes_logged.merge!(changes)
+          @changes_logged.merge!(ar_version_changes)
         end
 
         @changes_logged.delete("updated_at")

data/lib/changes_are_logged/version.rb

@@ -1,3 +1,3 @@
 module ChangesAreLogged
-  VERSION = '1.1.0'
+  VERSION = '1.2.0'
 end

data/spec/change_log_spec.rb

@@ -9,7 +9,7 @@ describe 'ChangeLog' do
     end
 
     it 'should add an entry to the change_logs' do
-      @game.reload.change_logs.size.should == @original_change_logs_size + 1
+      expect(@game.reload.change_logs.size).to eq(@original_change_logs_size + 1)
     end
   end
 
@@ -75,7 +75,7 @@ describe 'ChangeLog' do
     end
 
     it 'should not log anything' do
-      @game.reload.change_logs.size.should == @original_change_logs_size
+      expect(@game.reload.change_logs.size).to eq(@original_change_logs_size)
     end
   end
 
@@ -88,9 +88,9 @@ describe 'ChangeLog' do
     end
 
     it 'should log the comment and indicate no changes' do
-      @game.reload.change_logs.size.should == @original_change_logs_size + 1
-      @game.change_logs.last.changes_logged.should == {}
-      @game.change_logs.last.comments.should == "commenting on a non-change"
+      expect(@game.reload.change_logs.size).to eq(@original_change_logs_size + 1)
+      expect(@game.change_logs.last.changes_logged).to eq({})
+      expect(@game.change_logs.last.comments).to eq("commenting on a non-change")
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: changes_are_logged
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Lawrence Wang
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-27 00:00:00.000000000 Z
+date: 2019-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -18,6 +18,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -25,6 +28,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
@@ -45,14 +51,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 1.3.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 1.3.6
 description: Tracks changes to your activerecord models
 email: 
 executables: []