change_manager 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eaef00e1eb69b31268ab24e359ea02a343db52c6
-  data.tar.gz: 66624dafb2f25dd2f1000dee0db38302ba065b16
+  metadata.gz: ea1e4209fecbde33ceccb43f2b03c220b87f6b4a
+  data.tar.gz: a1832f3f3e1dbabc4764ee1899c418265476359d
 SHA512:
-  metadata.gz: 4c6e6dc30d5565d0a67b89ea76a31746f169700b7e7a1156526eb60c523e7d3e0c2eeced999e19f5a539ab60868bb93a4a141c381fdd342cd5f9d160cfeb67f4
-  data.tar.gz: cc12a9ede04b38dedd74d274d3f83b7baad529e5c03703342496483cf2ec8a426e4603d9c9725c242f1f119a23bea8a852b82b4bf73789961dcf143651d30880
+  metadata.gz: bc8139bb9f8ba564a4f6f066844b66230d62f81d2e30777201dd78b8491752ecec77b3d86a3ef9b578c6eea40b237a6c3c557d2d495d1314322d7ae18da83b21
+  data.tar.gz: 7e09f3c776bd61c8437acb7b9da1173b6484055092d2920557f5d291c36fa85f23ae2f3e6a1f13dde1706a59f7b6b9d491d5e0bbeca3600ad7768042286e82b6

data/app/jobs/change_manager/begin_change.rb

@@ -7,7 +7,7 @@ module ChangeManager
 
 		def self.perform(change_id)
 			puts 'job started'
-			config ||= YAML.load_file(File.join(Curate::Engine.root, 'config/change_manager_config.yml'))
+			config ||= YAML.load_file(File.join(Rails.root, 'config/change_manager_config.yml'))
 			config['manager_class'].constantize.process_change(change_id)
 		end
 	end

data/app/mailers/change_manager/notification_mailer.rb

@@ -1,12 +1,14 @@
+require 'yaml'
+
 module ChangeManager
 	class NotificationMailer < ActionMailer::Base
-		
+		CONFIG ||= YAML.load_file(File.join(Rails.root, 'config/change_manager_config.yml'))
 		def construct_email(changes)
 			@body = prepare_body(changes)
 			mail(
 				to: changes.first.target,
 				from: changes.first.owner,
-				subject: 'Updates from Scholar@UC',
+				subject: 'Recent Updates from ' + CONFIG['site_name'],
 				)
 		end
 

data/app/models/change_manager/change.rb

@@ -2,6 +2,7 @@ require 'yaml'
 
 module ChangeManager
   class Change < ActiveRecord::Base
+    include ComparisonConcern
   	validates :change_type, :owner, :target, presence: true
 
   	def self.new_change(owner, change_type, context, target, cancelled = false)
@@ -37,20 +38,8 @@ module ChangeManager
       self.notified
     end
 
-    def is_group_change?
-      self.change_type == 'added_to_group' || self.change_type == 'removed_from_group'
-    end
-
-    def is_delegate_change?
-      self.change_type == 'added_as_delegate' || self.change_type == 'removed_as_delegate'
-    end
-
-    def is_editor_change?
-      self.change_type == 'added_as_editor' || self.change_type == 'removed_as_editor'
-    end
-
     def inverse_of?(possible_inverse_change)
-      @change_types ||= YAML.load_file(File.join(ChangeManager::Engine.root, 'config/change_types.yaml'))
+      @change_types ||= YAML.load_file(File.join(ChangeManager::Engine.root, 'config/change_types.yml'))
       if self.context == possible_inverse_change.context
         self.change_type == @change_types[possible_inverse_change.change_type]['inverse']
       else 

data/lib/change_manager/version.rb

@@ -1,3 +1,3 @@
 module ChangeManager
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/spec/testapp/app/models/concerns/change_manager/comparison_concern.rb

@@ -0,0 +1,5 @@
+module ChangeManager
+	module ComparisonConcern
+		extend ActiveSupport::Concern
+	end
+end

data/spec/testapp/config/change_manager_config.yml

@@ -0,0 +1,2 @@
+manager_class: LocalManager
+site_name: Test App

data/spec/testapp/config/change_types.yml

@@ -0,0 +1,24 @@
+added_as_delegate:
+ print: added_as_delegate
+ inverse: removed_as_delegate
+ human_readable: Added as a delegate
+removed_as_delegate:
+ print: removed_as_delegate
+ inverse: added_as_delegate
+ human_readable: Removed as a delegate
+added_as_editor:
+ print: added_as_editor
+ inverse: removed_as_editor
+ human_readable: Added as an editor
+removed_as_editor:
+ print: removed_as_editor
+ inverse: added_as_editor
+ human_readable: Removed as an editor
+added_to_group:
+ print: added_to_group
+ inverse: removed_from_group
+ human_readable: Added to a group
+removed_from_group:
+ print: removed_from_group
+ inverse: added_to_group
+ human_readable: Removed from a group

data/spec/testapp/log/development.log

@@ -7,3 +7,80 @@ Migrating to CreateChangeManagerChanges (20160420192850)
    (1.5ms)  CREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")
    (0.1ms)  SELECT version FROM "schema_migrations"
    (1.7ms)  INSERT INTO "schema_migrations" (version) VALUES ('20160420192850')
+   (1.5ms)  CREATE TABLE "change_manager_changes" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "change_type" varchar(255), "cancelled" boolean, "notified" datetime, "owner" varchar(255), "target" varchar(255), "context" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (1.4ms)  CREATE TABLE "schema_migrations" ("version" varchar(255) NOT NULL) 
+   (1.2ms)  CREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")
+   (0.1ms)  SELECT version FROM "schema_migrations"
+   (1.3ms)  INSERT INTO "schema_migrations" (version) VALUES ('20160420192850')
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (1.6ms)  CREATE TABLE "change_manager_changes" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "change_type" varchar(255), "cancelled" boolean, "notified" datetime, "owner" varchar(255), "target" varchar(255), "context" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (1.3ms)  CREATE TABLE "schema_migrations" ("version" varchar(255) NOT NULL) 
+   (1.2ms)  CREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")
+   (0.1ms)  SELECT version FROM "schema_migrations"
+   (1.2ms)  INSERT INTO "schema_migrations" (version) VALUES ('20160420192850')
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (1.9ms)  DROP TABLE "change_manager_changes"
+   (1.0ms)  CREATE TABLE "change_manager_changes" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "change_type" varchar(255), "cancelled" boolean, "notified" datetime, "owner" varchar(255), "target" varchar(255), "context" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.1ms)  SELECT version FROM "schema_migrations"
+   (1.9ms)  DROP TABLE "change_manager_changes"
+   (1.0ms)  CREATE TABLE "change_manager_changes" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "change_type" varchar(255), "cancelled" boolean, "notified" datetime, "owner" varchar(255), "target" varchar(255), "context" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.1ms)  SELECT version FROM "schema_migrations"
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (1.8ms)  DROP TABLE "change_manager_changes"
+   (1.1ms)  CREATE TABLE "change_manager_changes" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "type" varchar(255), "change_type" varchar(255), "cancelled" boolean, "notified" datetime, "owner" varchar(255), "target" varchar(255), "context" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.1ms)  SELECT version FROM "schema_migrations"
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (2.0ms)  CREATE TABLE "change_manager_changes" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "type" varchar(255), "change_type" varchar(255), "cancelled" boolean, "notified" datetime, "owner" varchar(255), "target" varchar(255), "context" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (1.0ms)  CREATE TABLE "schema_migrations" ("version" varchar(255) NOT NULL) 
+   (0.8ms)  CREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")
+   (0.1ms)  SELECT version FROM "schema_migrations"
+   (1.1ms)  INSERT INTO "schema_migrations" (version) VALUES ('20160420192850')
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (2.0ms)  DROP TABLE "change_manager_changes"
+   (1.0ms)  CREATE TABLE "change_manager_changes" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "type" varchar(255), "change_type" varchar(255), "cancelled" boolean, "notified" datetime, "owner" varchar(255), "target" varchar(255), "context" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.1ms)  SELECT version FROM "schema_migrations"
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (44.3ms)  CREATE TABLE "change_manager_changes" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "type" varchar(255), "change_type" varchar(255), "cancelled" boolean, "notified" datetime, "owner" varchar(255), "target" varchar(255), "context" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (1.3ms)  CREATE TABLE "schema_migrations" ("version" varchar(255) NOT NULL) 
+   (1.4ms)  CREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")
+   (0.1ms)  SELECT version FROM "schema_migrations"
+   (1.3ms)  INSERT INTO "schema_migrations" (version) VALUES ('20160420192850')
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (2.0ms)  CREATE TABLE "schema_migrations" ("version" varchar(255) NOT NULL) 
+   (1.1ms)  CREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+Migrating to CreateChangeManagerChanges (20160420192850)
+   (0.1ms)  begin transaction
+   (0.4ms)  CREATE TABLE "change_manager_changes" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "change_type" varchar(255), "cancelled" boolean, "notified" datetime, "owner" varchar(255), "target" varchar(255), "context" varchar(255), "created_at" datetime, "updated_at" datetime) 
+  SQL (0.2ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20160420192850"]]
+   (1.3ms)  commit transaction
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (1.2ms)  CREATE TABLE "schema_migrations" ("version" varchar(255) NOT NULL) 
+   (0.9ms)  CREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+Migrating to CreateChangeManagerChanges (20160420192850)
+   (0.0ms)  begin transaction
+   (0.3ms)  CREATE TABLE "change_manager_changes" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "change_type" varchar(255), "cancelled" boolean, "notified" datetime, "owner" varchar(255), "target" varchar(255), "context" varchar(255), "created_at" datetime, "updated_at" datetime) 
+  SQL (0.1ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20160420192850"]]
+   (2.4ms)  commit transaction
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (2.2ms)  CREATE TABLE "schema_migrations" ("version" varchar(255) NOT NULL) 
+   (1.1ms)  CREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+Migrating to CreateChangeManagerChanges (20160420192850)
+   (0.1ms)  begin transaction
+   (0.4ms)  CREATE TABLE "change_manager_changes" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "change_type" varchar(255), "cancelled" boolean, "notified" datetime, "owner" varchar(255), "target" varchar(255), "context" varchar(255), "created_at" datetime, "updated_at" datetime) 
+  SQL (0.1ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20160420192850"]]
+   (1.2ms)  commit transaction
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (2.4ms)  CREATE TABLE "change_manager_changes" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "change_type" varchar(255), "cancelled" boolean, "notified" datetime, "owner" varchar(255), "target" varchar(255), "context" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (1.1ms)  CREATE TABLE "schema_migrations" ("version" varchar(255) NOT NULL) 
+   (1.0ms)  CREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")
+   (0.1ms)  SELECT version FROM "schema_migrations"
+   (1.2ms)  INSERT INTO "schema_migrations" (version) VALUES ('20160420192850')