chamber 2.3.1 → 2.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d48bb3c07ffa698d1e92373894be7bffdf42d77e
-  data.tar.gz: 4863eae0eb8ba8eb13a6b392b808ca00de03ad41
+  metadata.gz: f0a6b77f9bb4f79a5aa98dd6986a1bf9c55a4745
+  data.tar.gz: 65fd0c813eff8f0771d33dffb354c9defcd06c5d
 SHA512:
-  metadata.gz: 895a2c62003b2731c9b66cd166787069f4d125f35eb3cb2ea7f61f712de23b7ea45be4bfe2ea3485f74c18010217d5c618d539d0651ad49402ae7742fd44cf84
-  data.tar.gz: 1da38db267b770168a30117f7b94c3d84fd13b2d3da2eefc7846de50e0337f889e55fdb4f21fbcf8d947c7a3b387db3e850447a6d04837a5ce0fc4b4c14f708d
+  metadata.gz: c75a2ac2c75c2d3f342b2926d4784a536fd11119aef5e5142950b0ce676fa60b6b1ea8fc4a003d8f1c0fed6f1f23f8d6ea1680070d27ce526375267177c0cc0a
+  data.tar.gz: 074b2e34a9c5de417cb3d26f087e1ae17eac011a1b2bfd0088988832fd8c92c978f70323fa3a2afe92bef59f75da986017d863d6e6edcd8aa47bb4057a64a4c8

data/README.md

@@ -16,9 +16,9 @@ we (and assumed others) needed.
 
 1. Thou shalt be configurable, but use conventions so that configuration isn't
    necessary
-1. Thou shalt seemlessly work with Heroku or other deployment platforms, where custom
+1. Thou shalt seamlessly work with Heroku or other deployment platforms, where custom
    settings must be stored in environment variables
-1. Thou shalt seemlessly work with Travis CI and other cloud CI platforms
+1. Thou shalt seamlessly work with Travis CI and other cloud CI platforms
 1. Thou shalt not force users to use arcane
    long_variable_names_just_to_keep_their_settings_organized
 1. Thou shalt not require users keep a separate repo or cloud share sync just to
@@ -131,7 +131,7 @@ Either you have to use a separate private repo, or you have to use something
 like a Dropbox share.  In either case, you'd then symlink the files from their
 locations into your application.  What. A. Pain.
 
-Chamber uses public/private encryption keys to seemlessly store any of your
+Chamber uses public/private encryption keys to seamlessly store any of your
 configuration values as encrypted text.  The only file that needs to be synced
 *once* between developers is the private key.  And even that file would only be
 needed by the users deploying the application.  If you're deploying via CI,
@@ -143,7 +143,8 @@ After running `chamber init` as described above, the hard work is done.  From
 here on out, Chamber makes working with secure settings almost an afterthought.
 
 When you create your configuration YAML file (or add a new setting to an
-existing one), you can format your secure keys like so:
+existing one), you can add a secure key by prefixing the key name with
+`_secure_`, like so:
 
 ```yaml
 # settings.yml
@@ -151,9 +152,14 @@ existing one), you can format your secure keys like so:
 _secure_my_secure_key_name: 'my secure value'
 ```
 
-When Chamber sees this convention (`_secure_` followed by the key name), it will
-automatically look to either encrypt or decrypt the value using the
-public/private keys you generated above into something like:
+To encrypt the secret with your key pair, use the `chamber secure` command:
+
+```sh
+$ chamber secure
+```
+
+This will replace the plaintext secret with an encrypted version, looking
+something like this:
 
 ```yaml
 # settings.yml
@@ -161,8 +167,9 @@ public/private keys you generated above into something like:
 _secure_my_secure_key_name: 8239f293r9283r9823r92hf9823hf9uehfksdhviwuehf923uhrehf9238
 ```
 
-However you would still be able to access the value like so (assuming you had
-the private key in the application's root):
+Now, only users with the private key file can access the secret value. Once
+the private key is in your application's root directory, you can access the
+secret by name:
 
 ```ruby
 Chamber.env.my_secure_key_name
@@ -211,7 +218,7 @@ information on Heroku.
 
 To solve this problem, Heroku allows you to set environment variables in your
 application.  Unfortunately this has the nasty side effect of being a pain to
-deal with.  For one, you have to deal with environment variables with unweildy
+deal with.  For one, you have to deal with environment variables with unwieldy
 names (eg `MY_THIRD_PARTY_SERVICE_DEV_API_KEY`).  For another, it makes the
 organization of those variables difficult.
 
@@ -822,7 +829,7 @@ if Chamber.env.my_feature.enabled == 'true'
 end
 ```
 
-but that looks awful and isn't very idomatic.
+but that looks awful and isn't very idiomatic.
 
 To solve this problem, Chamber reviews all of your settings values and, if they
 are any of the following exact strings (case insensitive):

data/bin/chamber

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 
+require 'chamber'
 require 'chamber/binary/runner'
 
 Chamber::Binary::Runner.start

data/lib/chamber/commands/base.rb

@@ -1,3 +1,4 @@
+require 'pathname'
 require 'chamber/instance'
 
 module  Chamber

data/lib/chamber/commands/initialize.rb

@@ -1,4 +1,6 @@
+require 'pathname'
 require 'openssl'
+require 'chamber/configuration'
 require 'chamber/commands/base'
 
 module  Chamber

data/lib/chamber/context_resolver.rb

@@ -1,3 +1,4 @@
+require 'pathname'
 require 'hashie/mash'
 
 module  Chamber

data/lib/chamber/file.rb

@@ -76,11 +76,14 @@ class   File < Pathname
     file_contents     = self.read
 
     insecure_settings.each_pair do |name_pieces, value|
-      secure_value = secure_settings[name_pieces]
+      secure_value  = secure_settings[name_pieces]
+
+      escaped_name  = Regexp.escape(name_pieces.last)
+      escaped_value = Regexp.escape(value)
 
       file_contents.
         sub!(
-          /^(\s*)_secure_#{name_pieces.last}(\s*):(\s*)['"]?#{value}['"]?$/,
+          /^(\s*)_secure_#{escaped_name}(\s*):(\s*)['"]?#{escaped_value}['"]?$/,
           "\\1_secure_#{name_pieces.last}\\2:\\3#{secure_value}")
     end
 

data/lib/chamber/file_set.rb

@@ -1,3 +1,4 @@
+require 'pathname'
 require 'chamber/namespace_set'
 require 'chamber/file'
 require 'chamber/settings'

data/lib/chamber/rubinius_fix.rb

@@ -1,4 +1,6 @@
-unless Pathname.new('foo').respond_to? :write
+require 'pathname'
+
+unless Pathname.instance_methods.include?(:write)
   class Pathname
     def write(*args)
       IO.write @path, *args

data/lib/chamber/version.rb

@@ -1,3 +1,3 @@
 module Chamber
-  VERSION = '2.3.1'
+  VERSION = '2.3.2'
 end

data/spec/lib/chamber/file_spec.rb

@@ -167,6 +167,26 @@ other:
     <<: *default
     _secure_another_setting: #{secure_another_setting_encoded}
     regular_setting:         <%= 1 + 1 %>
+HEREDOC
+  end
+
+  it 'when rewriting the file, can handle names and values with regex special characters' do
+    tempfile      = create_tempfile_with_content <<-HEREDOC
+stuff:
+  _secure_another+_setting: "Thanks for +all the fish"
+HEREDOC
+
+    settings_file = File.new  path:           tempfile.path,
+                              encryption_key: './spec/spec_key.pub'
+
+    settings_file.secure
+
+    file_contents                  = ::File.read(tempfile.path)
+    secure_another_setting_encoded = file_contents[/  _secure_another\+_setting: ([A-Za-z0-9\+\/]{342}==)$/, 1]
+
+    expect(::File.read(tempfile.path)).to eql <<-HEREDOC
+stuff:
+  _secure_another+_setting: #{secure_another_setting_encoded}
 HEREDOC
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chamber
 version: !ruby/object:Gem::Version
-  version: 2.3.1
+  version: 2.3.2
 platform: ruby
 authors:
 - stevenhallen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-10 00:00:00.000000000 Z
+date: 2014-08-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -193,7 +193,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: chamber
-rubygems_version: 2.3.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A surprisingly configurable convention-based approach to managing your application's