chain 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 78f46a473a0b2ca4c82513bb2d4e492cb6e85c46
-  data.tar.gz: ef312f8a83617ba52da44b9f304298c68306932a
+  metadata.gz: d41aefd46847e3024559446254ca04cff1145beb
+  data.tar.gz: ad97bde45dc46839e592b45c3244b2eae472c2a1
 SHA512:
-  metadata.gz: 36763e8dc1cdf79e8fec74b121b0344412bd9465cc5941264f35888d82b7883421550676e8cc2ee23eb38814c90badaaa4fda4245e318306c2e2ef334dbe6b8f
-  data.tar.gz: 9d04368dacab30f6ca15eaa377599fa6e158e41a724facda1adaf356ba3dbf9fe5f560b8624729a4550e95a48eccdf9fa0bdd61b1359589bed1ddc41ebd2e127
+  metadata.gz: 0f7475d798767b183a715e9952f486818d27fbf4887900e7551c06d062fdf9776b53ce7661668d7b6982a082a34c043ec2bf06a842b6a69a550c731a89cb1e95
+  data.tar.gz: 652d27ed64b97d9d0d056f6d0891511d32a44b972a13572d0bcbdd71b54801666d29c2558090604aa8280758a14ab31c1f137a0c79e0459b945b85ef18d2cd28

data/README.md

@@ -32,7 +32,7 @@ items = site.items!
 items.data.each do |item|
 
    # ...iterate through and print out the `name` attribute for http://www.site.com/items/#
-   puts items[item.id]!.name
+   puts items[item.id]._fetch.name
 end
 ```
 

data/lib/chain.rb

@@ -7,3 +7,5 @@ require "hashie"
 require "chain/url"
 require "chain/version"
 require "chain/middleware/hashie_mash_response"
+require "chain/middleware/parse_error"
+require "chain/middleware/request_error"

data/lib/chain/middleware/hashie_mash_response.rb

@@ -2,12 +2,28 @@ module Chain
   module Middleware
     class HashieMashResponse < Faraday::Response::Middleware
       def on_complete(env)
-        body = JSON.parse(env[:body].to_s.encode('UTF-8', {:invalid => :replace, :undef => :replace, :replace => '?'}))
-        headers = env[:response_headers]
-        env[:body] = Hashie::Mash.new(body).tap do |item|
-          item._headers = Hashie::Mash.new(headers)
-          item._status  = env[:status]
+        case env[:status]
+        when 200
+          body    = env[:body].to_s.encode('UTF-8', {invalid: :replace, undef: :replace, replace: '?'})
+
+          json    = JSON.parse(body)
+          headers = env[:response_headers]
+
+          env[:body] = Hashie::Mash.new(json).tap do |item|
+            item._headers = Hashie::Mash.new(headers)
+            item._status  = env[:status]
+          end
+        else
+          raise Chain::Middleware::RequestError, env[:status]
         end
+
+      rescue JSON::ParserError => ex
+        raise Chain::Middleware::ParseError, "Unable to parse JSON response: #{ex.message}"
+
+      rescue NoMethodError => ex
+        # This captures parsing errors from Hashie::Mash. Unfortunately, HM does not raise
+        # their own errors.
+        raise Chain::Middleware::ParseError, "Unable to parse JSON as object: #{ex.message}"
       end
     end
   end

data/lib/chain/middleware/parse_error.rb

@@ -0,0 +1,9 @@
+module Chain
+  module Middleware
+    class ParseError < StandardError
+      def initialize(message)
+        super(message)
+      end
+    end
+  end
+end

data/lib/chain/middleware/request_error.rb

@@ -0,0 +1,12 @@
+module Chain
+  module Middleware
+    class RequestError < StandardError
+      attr_reader :error_code
+
+      def initialize(error_code)
+        @error_code = error_code
+        super("HTTP Response Code: #{error_code}")
+      end
+    end
+  end
+end

data/lib/chain/version.rb

@@ -1,3 +1,3 @@
 module Chain
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/middleware/hasie_mash_response_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe Chain::Middleware::HashieMashResponse do
+
+  subject do
+    described_class.new
+  end
+
+  describe '#on_complete' do
+
+    context 'a valid response response with a 200 status' do
+      let(:env){{body: {success: true}.to_json, status: 200}}
+
+      it 'should yield a Hashie::Mash object from the request' do
+        subject.on_complete(env)
+        expect(env[:body].success).to be true
+      end
+    end
+
+    context 'a response with invalid json' do
+      let(:env){{body: "[1,2,3]", status: 200}}
+
+      it 'should raise a ParseError instance' do
+        expect { subject.on_complete(env) }.to raise_error(Chain::Middleware::ParseError)
+      end
+    end
+
+    context 'a response with a 404 status' do
+      let(:env){{body: nil, status: 404}}
+
+      it 'should raise an instance of RequestError with a 404 status code' do
+        expect { subject.on_complete(env) }.to raise_error do |exception|
+          expect(exception.status_code).to eq(404) 
+        end
+      end
+    end
+  end
+end

data/spec/url_spec.rb

@@ -88,6 +88,14 @@ describe Chain::Url do
           should have_been_made
       end
 
+      it 'should generate a request if a hash is passed into a method' do
+        subject.item(foo: 'bar')
+
+        a_request(:get, 'http://test.com/item').
+          with(query: hash_including({'foo' => 'bar'})).
+          should have_been_made
+      end
+
       it 'should parse the _method parameter as the HTTP request type' do
         subject.item[_method: :post]._fetch
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chain
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Stefan Novak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-18 00:00:00.000000000 Z
+date: 2013-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -109,8 +109,11 @@ files:
 - chain.gemspec
 - lib/chain.rb
 - lib/chain/middleware/hashie_mash_response.rb
+- lib/chain/middleware/parse_error.rb
+- lib/chain/middleware/request_error.rb
 - lib/chain/url.rb
 - lib/chain/version.rb
+- spec/middleware/hasie_mash_response_spec.rb
 - spec/spec_helper.rb
 - spec/url_spec.rb
 homepage: https://github.com/slnovak/chain
@@ -138,5 +141,6 @@ signing_key:
 specification_version: 4
 summary: Access API endpoints via method chaining in Ruby.
 test_files:
+- spec/middleware/hasie_mash_response_spec.rb
 - spec/spec_helper.rb
 - spec/url_spec.rb