cfn-nag 0.4.71 → 0.4.72

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8aac032953583895153e90c0c12415050b835ff4d220df996979b4ec8d769a82
-  data.tar.gz: 6ebf25a6c6a86e76e11081c7016bbad1148a5af529cc85db608d84b9bbcf7836
+  metadata.gz: 2070e9e1e8036793323aa8e4660a547f62be5f007500d2c779aaa58da83940e1
+  data.tar.gz: 204d19593a97fc5af6fef830b314f3310c45f7240da90f8142a032c038fb84d5
 SHA512:
-  metadata.gz: 90b0d3a36532be603b08bbf78c8c5f28df13bf3164cd5cf0c9ed06ff56093445dc42a27540b0e09a2c8f1606d1e5b28bfdec4cb8d4a742c09e972bdcab34cf29
-  data.tar.gz: f798dd0079bb6448ee8bd130d13f053e9c2c282a7c2b7e06976850962ecb166437ccb158634cb8859c23b496a33c17ce9199aa9a309dd1b521c8abf48814c4f3
+  metadata.gz: 3ce1b777c7d6b62d3ea8dc221e8c2cbc6bf60a891b3120dd6245f1f7768b7a5e38aee421cc32cad3003d08877b78ce549055e4f7d938b671b066428faf5191c8
+  data.tar.gz: 31027d63b7eacf0133ddd1e8738670be3d6c1e2d5ab4f3509823071e2201a78fd56209c7af75d8f9be6a599aaa6ac91899d85ca0fc9cff84f5919698b21b2976

data/lib/cfn-nag/custom_rules/CodePipelineWebhookAuthenticationConfigurationSecretTokenRule.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'cfn-nag/violation'
+require_relative 'password_base_rule'
+
+class CodePipelineWebhookAuthenticationConfigurationSecretTokenRule < PasswordBaseRule
+  def rule_text
+    'CodePipeline Webhook AuthenticationConfiguration SecretToken must not be ' \
+    'a plaintext string or a Ref to a NoEcho Parameter with a Default value.'
+  end
+
+  def rule_type
+    Violation::FAILING_VIOLATION
+  end
+
+  def rule_id
+    'F69'
+  end
+
+  def resource_type
+    'AWS::CodePipeline::Webhook'
+  end
+
+  def password_property
+    :authenticationConfiguration
+  end
+
+  def sub_property_name
+    'SecretToken'
+  end
+end

data/lib/cfn-nag/custom_rules/DocDBDBClusterMasterUserPasswordRule.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'cfn-nag/violation'
+require_relative 'password_base_rule'
+
+class DocDBDBClusterMasterUserPasswordRule < PasswordBaseRule
+  def rule_text
+    'DocDB DB Cluster master user password must not be a plaintext string ' \
+    'or a Ref to a NoEcho Parameter with a Default value.'
+  end
+
+  def rule_type
+    Violation::FAILING_VIOLATION
+  end
+
+  def rule_id
+    'F70'
+  end
+
+  def resource_type
+    'AWS::DocDB::DBCluster'
+  end
+
+  def password_property
+    :masterUserPassword
+  end
+end

data/lib/cfn-nag/custom_rules/ElastiCacheReplicationGroupAuthTokenRule.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'cfn-nag/violation'
+require_relative 'password_base_rule'
+
+class ElastiCacheReplicationGroupAuthTokenRule < PasswordBaseRule
+  def rule_text
+    'ElastiCache ReplicationGroup AuthToken must not be a plaintext string ' \
+    'or a Ref to a NoEcho Parameter with a Default value.'
+  end
+
+  def rule_type
+    Violation::FAILING_VIOLATION
+  end
+
+  def rule_id
+    'F44'
+  end
+
+  def resource_type
+    'AWS::ElastiCache::ReplicationGroup'
+  end
+
+  def password_property
+    :authToken
+  end
+end

data/lib/cfn-nag/custom_rules/LambdaPermissionEventSourceTokenRule.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'cfn-nag/violation'
+require_relative 'password_base_rule'
+
+class LambdaPermissionEventSourceTokenRule < PasswordBaseRule
+  def rule_text
+    'Lambda Permission EventSourceToken must not be a plaintext string ' \
+    'or a Ref to a NoEcho Parameter with a Default value.'
+  end
+
+  def rule_type
+    Violation::FAILING_VIOLATION
+  end
+
+  def rule_id
+    'F45'
+  end
+
+  def resource_type
+    'AWS::Lambda::Permission'
+  end
+
+  def password_property
+    :eventSourceToken
+  end
+end

data/lib/cfn-nag/custom_rules/ManagedBlockchainMemberMemberFabricConfigurationAdminPasswordRule.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+require 'cfn-nag/violation'
+require 'cfn-nag/util/enforce_reference_parameter'
+require 'cfn-nag/util/enforce_string_or_dynamic_reference'
+require_relative 'base'
+
+class ManagedBlockchainMemberMemberFabricConfigurationAdminPasswordRule < BaseRule
+  def rule_text
+    'ManagedBlockchain Member MemberFabricConfiguration AdminPasswordRule must ' \
+    'not be a plaintext string or a Ref to a NoEcho Parameter with a Default value.'
+  end
+
+  def rule_type
+    Violation::FAILING_VIOLATION
+  end
+
+  def rule_id
+    'F71'
+  end
+
+  def audit_impl(cfn_model)
+    managed_blockchain_members = cfn_model.resources_by_type('AWS::ManagedBlockchain::Member')
+    violating_managed_blockchains = managed_blockchain_members.select do |member|
+      if password_property_does_not_exist(member)
+        false
+      else
+        pw = member.memberConfiguration['MemberFrameworkConfiguration']['MemberFabricConfiguration']['AdminPassword']
+        insecure_parameter?(cfn_model, pw) ||
+          insecure_string_or_dynamic_reference?(cfn_model, pw)
+      end
+    end
+
+    violating_managed_blockchains.map(&:logical_resource_id)
+  end
+
+  private
+
+  # Checks to see if these properties are present as they are optional
+  # properties for the 'AWS::ManagedBlockchain::Member' resource:
+  #   'MemberFrameworkConfiguration'
+  #   'MemberFabricConfiguration'
+  #   'AdminPassword'
+  def password_property_does_not_exist(member)
+    if member.memberConfiguration['MemberFrameworkConfiguration'].nil?
+      true
+    elsif member.memberConfiguration['MemberFrameworkConfiguration']['MemberFabricConfiguration'].nil?
+      true
+    elsif member.memberConfiguration['MemberFrameworkConfiguration']['MemberFabricConfiguration']['AdminPassword'].nil?
+      true
+    else
+      false
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cfn-nag
 version: !ruby/object:Gem::Version
-  version: 0.4.71
+  version: 0.4.72
 platform: ruby
 authors:
 - Eric Kascic
@@ -171,10 +171,12 @@ files:
 - lib/cfn-nag/custom_rules/CloudFormationAuthenticationRule.rb
 - lib/cfn-nag/custom_rules/CloudFrontDistributionAccessLoggingRule.rb
 - lib/cfn-nag/custom_rules/CodeBuildEncryptionKeyRule.rb
+- lib/cfn-nag/custom_rules/CodePipelineWebhookAuthenticationConfigurationSecretTokenRule.rb
 - lib/cfn-nag/custom_rules/DMSEndpointMongoDbSettingsPasswordRule.rb
 - lib/cfn-nag/custom_rules/DMSEndpointPasswordRule.rb
 - lib/cfn-nag/custom_rules/DirectoryServiceMicrosoftADPasswordRule.rb
 - lib/cfn-nag/custom_rules/DirectoryServiceSimpleADPasswordRule.rb
+- lib/cfn-nag/custom_rules/DocDBDBClusterMasterUserPasswordRule.rb
 - lib/cfn-nag/custom_rules/EC2SubnetMapPublicIpOnLaunchRule.rb
 - lib/cfn-nag/custom_rules/EFSFileSystemEncryptedRule.rb
 - lib/cfn-nag/custom_rules/EMRClusterKerberosAttributesADDomainJoinPasswordRule.rb
@@ -183,6 +185,7 @@ files:
 - lib/cfn-nag/custom_rules/EbsVolumeEncryptionKeyRule.rb
 - lib/cfn-nag/custom_rules/EbsVolumeHasSseRule.rb
 - lib/cfn-nag/custom_rules/ElastiCacheReplicationGroupAtRestEncryptionRule.rb
+- lib/cfn-nag/custom_rules/ElastiCacheReplicationGroupAuthTokenRule.rb
 - lib/cfn-nag/custom_rules/ElastiCacheReplicationGroupTransitEncryptionRule.rb
 - lib/cfn-nag/custom_rules/ElasticLoadBalancerAccessLoggingRule.rb
 - lib/cfn-nag/custom_rules/ElasticLoadBalancerV2AccessLoggingRule.rb
@@ -216,8 +219,10 @@ files:
 - lib/cfn-nag/custom_rules/KinesisFirehoseDeliveryStreamRedshiftDestinationConfigurationPasswordRule.rb
 - lib/cfn-nag/custom_rules/KinesisFirehoseDeliveryStreamSplunkDestinationConfigurationHECTokenRule.rb
 - lib/cfn-nag/custom_rules/KinesisStreamStreamEncryptionRule.rb
+- lib/cfn-nag/custom_rules/LambdaPermissionEventSourceTokenRule.rb
 - lib/cfn-nag/custom_rules/LambdaPermissionInvokeFunctionActionRule.rb
 - lib/cfn-nag/custom_rules/LambdaPermissionWildcardPrincipalRule.rb
+- lib/cfn-nag/custom_rules/ManagedBlockchainMemberMemberFabricConfigurationAdminPasswordRule.rb
 - lib/cfn-nag/custom_rules/ManagedPolicyOnUserRule.rb
 - lib/cfn-nag/custom_rules/MissingBucketPolicyRule.rb
 - lib/cfn-nag/custom_rules/NeptuneDBClusterStorageEncryptedRule.rb