cfn-nag 0.4.39 → 0.4.40

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 58da9ee2e7018ed739b1e7786b819a1d940f4ce8dab01722ff99984588f83904
-  data.tar.gz: 30fa31d07e15643fdc3d9947805e5be5762bb633768d62b56fcb818fe14efcf1
+  metadata.gz: 84fab67d616f1d8e20a7bed01e110d16ee2a7e3be28659566975b43d1fa62f49
+  data.tar.gz: 6005bc66745ff5b054b8d621aab4117ece00d3e326602dd887b454299fd6bd6a
 SHA512:
-  metadata.gz: bf75696d2aee6fa79fc0d405c5925273096d2dd6795a2158b1ca1eb6ac1aa8c8bc52e842c3b0180b67c4cddb38e511eb845e89fccd30e18cd214c0eb6de9965b
-  data.tar.gz: cf7e9a622fcca686d12e4ff19f6c359075de7ffcdcc1e45ebd6b40185cd247ede61156c7db836afdc59f504d1ffd2dd547061429c53a59ed97af2dd7fe4e1f22
+  metadata.gz: c4399c6417ace2f9a9949dd1dcec508abdbc3d0f36e8124f9579edf648a34ce71f34ab0c6db9b5329fc01b9f8888dc1c5f59591a6f02e418e0a6bb9a2894e539
+  data.tar.gz: 74d61738a619b4ddf160bb29b5004478b2b2609595720a79d86fe89e79d79578655553263b7588f0d56e2c5a2c18b6c1e3ad55191168b0537fc558ce78052ce4

data/lib/cfn-nag/custom_rules/IamRoleAdministratorAccessPolicyRule.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+require 'cfn-nag/violation'
+require_relative 'base'
+
+class IamRoleAdministratorAccessPolicyRule < BaseRule
+  def rule_text
+    'IAM role should not have AdministratorAccess policy'
+  end
+
+  def rule_type
+    Violation::WARNING
+  end
+
+  def rule_id
+    'W43'
+  end
+
+  def audit_impl(cfn_model)
+    violating_roles = cfn_model.resources_by_type('AWS::IAM::Role').select do |role|
+      role.managedPolicyArns.find { |policy| policy.include? 'arn:aws:iam::aws:policy/AdministratorAccess' }
+    end
+
+    violating_roles.map(&:logical_resource_id)
+  end
+end

data/lib/cfn-nag/ip_addr.rb

@@ -15,8 +15,7 @@ module IpAddr
 
     # only care about literals.  if a Hash/Ref not going to chase it down
     # given likely a Parameter with external val
-    (NetAddr::CIDRv6.create(normalized_cidr_ip6) ==
-     NetAddr::CIDRv6.create('::/0'))
+    NetAddr::IPv6Net.parse(normalized_cidr_ip6).cmp(NetAddr::IPv6Net.parse('::/0')).zero?
   end
 
   def ip4_cidr_range?(ingress)
@@ -29,7 +28,7 @@ module IpAddr
 
     # only care about literals.  if a Hash/Ref not going to chase it down
     # given likely a Parameter with external val
-    !NetAddr::CIDRv6.create(normalized_cidr_ip6).to_s.end_with?('/128')
+    !NetAddr::IPv6Net.parse(normalized_cidr_ip6).to_s.end_with?('/128')
   end
 
   ##

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cfn-nag
 version: !ruby/object:Gem::Version
-  version: 0.4.39
+  version: 0.4.40
 platform: ruby
 authors:
 - Eric Kascic
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-13 00:00:00.000000000 Z
+date: 2019-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -128,14 +128,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 2.0.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 2.0.4
 - !ruby/object:Gem::Dependency
   name: trollop
   requirement: !ruby/object:Gem::Requirement
@@ -195,6 +195,7 @@ files:
 - lib/cfn-nag/custom_rules/IamPolicyPassRoleWildcardResourceRule.rb
 - lib/cfn-nag/custom_rules/IamPolicyWildcardActionRule.rb
 - lib/cfn-nag/custom_rules/IamPolicyWildcardResourceRule.rb
+- lib/cfn-nag/custom_rules/IamRoleAdministratorAccessPolicyRule.rb
 - lib/cfn-nag/custom_rules/IamRoleNotActionOnPermissionsPolicyRule.rb
 - lib/cfn-nag/custom_rules/IamRoleNotActionOnTrustPolicyRule.rb
 - lib/cfn-nag/custom_rules/IamRoleNotPrincipalOnTrustPolicyRule.rb