cfn-nag 0.4.10 → 0.4.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7c5be6d25789f38b37bbde75e1b732dbec718ef49f0121efbd61f4032cd1f37
-  data.tar.gz: 48f3345f39d00e23b7448b5316dc5e77993afd087974c237fb7e655c2a7cb73c
+  metadata.gz: c35d32f533c4b6fcf0b1efc441e31907685d27e65a9dd3fc99c9ef2eb9744ed6
+  data.tar.gz: 00b28123f542e1ba4d2e5739d86115b0817606da368a17558c99b75523468fa8
 SHA512:
-  metadata.gz: 84f04c28790ed9efc963455ca677acb1886f3b4af262efb0ac32e078d367393c7f6eca51bf59ac49ee97f0bb68133af4d2adde192535656483ec64c149cda9e8
-  data.tar.gz: bfa559caa6910cf0e1f49d03499b3254c13857c6ae677f61697a932c41a629be88e8803caddfd775bc88773664cea092f4c2c8ae7d709b55bd5973f3263372c9
+  metadata.gz: 87fddfa8917f0b3060a54b6447ea5106c894a4337f2217850a461607b84afcf07083a4a8f3d2d0cfb9322fa589c6632e0d8698e2ed766b8fe90f242b3768e8bf
+  data.tar.gz: 710aadc37b551e762e36eb165d45b3d56a05d3e0ed1910e3ffd249b7af7d71f8c4ae4d69855e9fccff3acbf63baafcbd6eebe0ca540894c35800c4bdcbd8a82e

data/lib/cfn-nag/custom_rules/ElastiCacheReplicationGroupTransitEncryptionRule.rb

@@ -13,7 +13,7 @@ class ElastiCacheReplicationGroupTransitEncryptionRule < BooleanBaseRule
   end
 
   def rule_id
-    'F24'
+    'F33'
   end
 
   def resource_type

data/lib/cfn-nag/result_view/rules_view.rb

@@ -8,10 +8,24 @@ class RulesView
     puts
     puts 'FAILING VIOLATIONS:'
     emit_failings rule_registry.failings, profile
+
+    if rule_registry.duplicate_ids?
+      emit_duplicates(rule_registry.duplicate_ids)
+      exit 1
+    end
   end
 
   private
 
+  def emit_duplicates(duplicates)
+    duplicates.each do |info|
+      puts '------------------'.red
+      puts "Rule ID conflict detected for #{info[:id]}.".red
+      puts "New rule: #{info[:new_message]}".red
+      puts "Registered rule: #{info[:registered_message]}".red
+    end
+  end
+
   def emit_warnings(warnings, profile)
     warnings.sort { |left, right| sort_id(left, right) }.each do |warning|
       if profile.nil?

data/lib/cfn-nag/rule_registry.rb

@@ -3,10 +3,15 @@
 require_relative 'rule_definition'
 
 class RuleRegistry
-  attr_reader :rules
+  attr_reader :rules, :duplicate_ids
 
   def initialize
     @rules = []
+    @duplicate_ids = []
+  end
+
+  def duplicate_ids?
+    @duplicate_ids.count.positive?
   end
 
   def definition(id:,
@@ -20,7 +25,11 @@ class RuleRegistry
     if existing_def.nil?
       add_rule rule_definition
     else
-      existing_def
+      @duplicate_ids << {
+        id: id,
+        new_message: message,
+        registered_message: existing_def.message
+      }
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cfn-nag
 version: !ruby/object:Gem::Version
-  version: 0.4.10
+  version: 0.4.11
 platform: ruby
 authors:
 - Eric Kascic