cfn-nag 0.0.11 → 0.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1d2eb6f776c60b81f34b4a83def409388e57166b
-  data.tar.gz: f17a7d7cf729d905c3e7e5cb9059b41e21504f3c
+  metadata.gz: 292f48533183f6f2b074d57757ec5771db23a597
+  data.tar.gz: c253df7e9188ef34a47f832b2b055eaf41649e55
 SHA512:
-  metadata.gz: 9282462416eb211dda553aef5fea816a41ffc91a3a65847fa9062a77c0c791c3765f8b4c143328522895bc616f2a3f218e9ff46492f3ad9342b1fdf23787450a
-  data.tar.gz: 5f0cab6ea6bd403bc30fdaa742d1f4f699ab9bd24fffae2e3fba45c62c880f7a8b95fcf1ce308ef082783147b320cc17f6eb013c23ac8ca1caae1472e1e305c4
+  metadata.gz: 840362bbf552584f4f080a572e15d73bdfb4013008c6eb5ae56008f96c78a28db6d30790e56a7484bbcd4d2e5c015594aa03d8f53ad77a39e0bdee9f53ca1203
+  data.tar.gz: a661ea828ffcb4ead2f2827d0b9c56cac24b08f0c025ef753a5b245f98e84a9ccdf62972b0b51b2b44fd84ce9307b16ddbffd6f0cb4c801877be1b0342b5b655

data/lib/cfn_nag.rb

@@ -11,19 +11,29 @@ class CfnNag
   def audit(input_json_path:,
             output_format:'txt')
 
+    aggregate_results = audit_results input_json_path: input_json_path,
+                                      output_format: output_format
+
+    aggregate_results.inject(0) { |total_failure_count, results| total_failure_count + results[:file_results][:failure_count] }
+  end
+
+  def audit_results(input_json_path:,
+                    output_format:'txt')
+
     templates = discover_templates(input_json_path)
 
     aggregate_results = []
     templates.each do |template|
       aggregate_results << {
-        filename: template,
-        file_results: audit_file(input_json_path: template)
+          filename: template,
+          file_results: audit_file(input_json_path: template)
       }
     end
 
-    results_renderer(output_format).new.render(aggregate_results)
+    render_results(aggregate_results: aggregate_results,
+                   output_format: output_format)
 
-    aggregate_results.inject(0) { |total_failure_count, results| total_failure_count + results[:file_results][:failure_count] }
+    aggregate_results
   end
 
   def self.configure_logging(opts)
@@ -39,6 +49,10 @@ class CfnNag
 
   private
 
+  def render_results(aggregate_results:,output_format:)
+    results_renderer(output_format).new.render(aggregate_results)
+  end
+
   def audit_file(input_json_path:)
     @stop_processing = false
     @violations = []

data/lib/json_rules/loadbalancer_rules.rb

@@ -0,0 +1,7 @@
+warning jq: '[.Resources|with_entries(.value.LogicalResourceId = .key)[] | select(.Type == "AWS::ElasticLoadBalancing::LoadBalancer")|'\
+              'select(.Properties.AccessLoggingPolicy == null)]|map(.LogicalResourceId) ',
+        message: 'Elastic Load Balancer should have access logging configured'
+
+warning jq: '[.Resources|with_entries(.value.LogicalResourceId = .key)[] | select(.Type == "AWS::ElasticLoadBalancing::LoadBalancer")|'\
+              'select(.Properties.AccessLoggingPolicy?.Enabled == false)]|map(.LogicalResourceId) ',
+        message: 'Elastic Load Balancer should have access logging enabled'

data/lib/violation.rb

@@ -30,4 +30,8 @@ class Violation
       violating_code: @violating_code
     }
   end
+
+  def ==(other_violation)
+    other_violation.class == self.class && other_violation.to_h == to_h
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cfn-nag
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - someguy
@@ -55,6 +55,7 @@ files:
 - lib/json_rules/ebs_rules.rb
 - lib/json_rules/iam_policy_rules.rb
 - lib/json_rules/iam_user_rules.rb
+- lib/json_rules/loadbalancer_rules.rb
 - lib/json_rules/port_rules.rb
 - lib/model/cfn_model.rb
 - lib/model/iam_user_parser.rb