cfita 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 424b84e97b24a15273e3ef1cfc4cf7af8d333342acde10d656375f9e97eec6f9
-  data.tar.gz: 401e7387c2e19cafea5ef406f33ed30ab4dac68147fcaa6162038f93cca82703
+  metadata.gz: b0510a1eea1c9a417a70c0d5fbb91a275495569963e745dea6d369df11f91e32
+  data.tar.gz: a0d7f593151788aab9617dbc9922778d214b29e73784734a76874925188ce937
 SHA512:
-  metadata.gz: 293c36acf2d95209ca2e6602b9052087b20f4a45a073c541e0a6042d113475ce7b988e3961fb2d73a46d5d7bc468f06307df54ed000ed2db275acae59c87ff2d
-  data.tar.gz: 5962972ecfbffdea99f53423c480b3ff962e205b15a90d4d47cf9c73c79af2b4ceb103ef108dd13f151be6b61f8827ea7c1ac59e199e06202af8315a701744a7
+  metadata.gz: 69ef59d65dbc4403b74a74da2d848682277855d862e30056201bc24f1c0f4c49ccba60f2396ce30cdaa4396201c04930a3ef4cd165e38cc08844b6509c948cc8
+  data.tar.gz: fe5325bdf5a020c0da7d0f1832261da154ec8a48e926c33b97ae261a03e28c448eed62a07069c3b17d413324c3f4d83bdfa631475aee1e05786992748b406d36

data/.gitignore

@@ -1,2 +1,3 @@
 *.gem
-test/cfs.txt
+test/cfs.txt
+Gemfile.lock

data/CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## v0.4.0 - 2022-12-10
+
+### Fix
+
+- return nil from cf_sex, cf_birth_places and cf_birth_date when fiscal code is invalid
+
 ## v0.3.1 - 2022-12-10
 
 ### Added

data/lib/cfita/codice_fiscale.rb

@@ -46,12 +46,14 @@ module Cfita
     def cf_sex
       return @cf_sex if @cf_sex
       case @fiscal_code[9]
+      when nil
       when /[0-3LMNP]/
         @cf_sex = 'M'
       when /[4-7QRST]/
         @cf_sex = 'F'
       else
         @errors << 'Cifra decina giorno di nascita errata'
+        nil
       end
     end
 
@@ -63,10 +65,12 @@ module Cfita
 
     def cf_birth_date
       return @cf_birth_date if @cf_birth_date
+
       yy = cifre(6..7)
       day = cifre(9..10)
+      return unless yy && day
       @errors << 'Cifra decina giorno di nascita errata' if day && day > 71
- 
+
       month = MESI.index(@fiscal_code[8])
       @errors << 'Mese errato' unless month
       return unless yy && month && day
@@ -76,17 +80,15 @@ module Cfita
 
     private
 
-    def codice_catastale 
+    def codice_catastale
       return @codice_catastale if @codice_catastale
-      letter = @fiscal_code[11]
-      numbers =
-        @fiscal_code[12..14]
-        .split(//)
-        .map do |c|
-          i = OMOCODICI.index(c)
-          i ? i.to_s : c
-        end
-        .join
+      return unless letter = @fiscal_code[11]
+      return unless numbers = @fiscal_code[12..14]
+
+      numbers = numbers.chars.map do |c|
+        i = OMOCODICI.index(c)
+        i ? i.to_s : c
+      end.join
       letter + numbers
     end
 
@@ -194,6 +196,8 @@ module Cfita
       result = 0
       range.each do |position|
         char = @fiscal_code[position]
+        return nil unless char
+
         value = CIFRE.index(char)
         @errors << "Carattere '#{char}' errato in posizione #{position}" unless value
         return nil unless value

data/lib/cfita.rb

@@ -4,5 +4,5 @@
 module Cfita
   require 'cfita/codice_fiscale'
 
-  VERSION='0.3.1'
+  VERSION='0.4.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cfita
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Stefano Savanelli