cetus 0.1.29 → 0.1.32

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a6bfd0c8210eacca8888f7c6f22e5682feff8c82f3a90d799849d8bb153fd5e9
-  data.tar.gz: 3ebbdd0708cd4cc6f75a3a77a2161f443a68d703f2c769ca870ffd37242f839e
+  metadata.gz: 97704d648638971cc77d3f7f9b22e631893f7f176013da0acd95babf9dd69db1
+  data.tar.gz: fc1759b09b662da0f31a93593d1b9eee8859503e122a84927873830bec342603
 SHA512:
-  metadata.gz: f0425f755732c290eaf51aa0903a6785fef35f54d72b83f2fd281280e5c00064706cad9dd2d598419a1495d9625792a0b3e15dcb7e0edb1fc8c5f07d177fcc2a
-  data.tar.gz: 5d9c5f24e835a522adccfc91156469ff148b66013c49ac1c83fc5d41fd00da212500eb2786765593a0585baf4210c9a75f614914b34e1d2faa9ffca5ac7f2613
+  metadata.gz: d9975620b45a6b2a426af50e3c6d6afe48738d69a04d090aaf71090c8e647f1fe15fd17e3780eecd3dd7b4f749904432397f71aaaf66c140d67b2035432c75a6
+  data.tar.gz: af1b12d3aa62b1f8e5a828d62bbedee51b222c71b6aab9840f44799322499c838a2ff168ca3f14ba5e09255a49246d6daebc0eba1234fe0562e74c0f7e5629cf

data/.gitignore

@@ -16,3 +16,19 @@ tmp
 .yardoc
 _yardoc
 doc/
+Gemfile.lock
+README.NOW
+a test directory/
+archived.txt
+bug
+column.rb
+gemenv.txt
+index.html
+log.txt
+oldlib/
+tada.txt
+todo
+todo.notes
+fix.txt
+deadlink
+livelink

data/README.md

@@ -6,6 +6,8 @@ lightning-fast file navigator
 Tested with ruby 2.5
 
 Latest changes:
+2019-03-26 - Reading up 'LS_COLORS' and coloring filenames. v0.1.30
+2019-03-24 - Major refactoring and cleanup. v 0.1.29
 2019-03-04 - q is quit key, not Q
            - show directories first, then files.
            - trying not to pollute main screen/terminal with listings (i.e. use alt screen)

data/bin/cetus

@@ -6,10 +6,12 @@
 #       Author: rkumar http://github.com/rkumar/cetus/
 #         Date: 2013-02-17 - 17:48
 #      License: GPL
-#  Last update: 2019-03-24 11:58
+#  Last update: 2019-04-06 10:15
 # --------------------------------------------------------------------------- #
 #  cetus.rb  Copyright (C) 2012-2019 rahul kumar
 # == CHANGELOG
+# 2019-03-24 - adding colors per line, but columnate will have to change
+#  since size calc will include color codes. Same for truncate
 # 2019-02-20 - added smcup and rmcup so alt-screen is used. works a bit
 # 2019-03-04 - change clear to go to 0,0 and clear down to reduce pollution
 # 2019-03-04 - changed quit to q (earlier Q)
@@ -17,7 +19,6 @@
 # 2019-03-10 - changing selected_files to have fullpath
 # 2019-03-22 - refactoring the code, esp run()
 #  == TODO
-#  FIXME how to check that redraw not called twice depending on where
 #  a method is called from. a menu or direct from key. e.g help
 #  To dirs add GEMHOME RUBYLIB PYTHONILB or PYTHONPATH,
 #  Make rubygem aware : gemspec or Gemfile the expand lib and bin
@@ -29,21 +30,25 @@ require 'io/wait'
 require 'shellwords'
 # https://docs.ruby-lang.org/en/2.6.0/FileUtils.html
 require 'fileutils'
+require 'logger'
+# @log = Logger.new(File.expand_path '~/tmp/log.txt')
+@log = Logger.new('log.txt')
 
 ## INSTALLATION
 # copy into PATH
 # alias c=~/bin/cetus.rb
 # c
 
-VERSION = '0.1.29.0'.freeze
-CONFIG_FILE = '~/.config/cetus/conf.yml'.freeze
+VERSION = '0.1.32.0'.freeze
+CONFIG_PATH = ENV['XDG_CONFIG_HOME'] || File.join(ENV['HOME'], '.config')
+CONFIG_FILE = "#{CONFIG_PATH}/cetus/conf.yml".freeze
 
-$bindings = {}
+# $bindings = {}
 $bindings = {
   '`' => 'main_menu',
   '=' => 'toggle_menu',
-  'M-y' => 'selection_menu',
-  'M-s' => 'sort_menu',
+  'M-s' => 'selection_menu',
+  'M-o' => 'sort_menu',
   'ENTER' => 'select_current',
   'C-p' => 'page_current',
   'C-e' => 'edit_current',
@@ -51,7 +56,7 @@ $bindings = {
   'C-s' => 'toggle_select',
   'C-r' => 'reduce',
   'C-g' => 'debug_vars',
-  '@' => 'selection_mode_toggle',
+  '@' => 'toggle_selection_mode',
   'M-a' => 'select_all',
   'M-A' => 'unselect_all',
   '!' => 'execute',
@@ -193,7 +198,9 @@ def setup_terminal
   # '\e[2J':     Clear the screen.
   # '\e[1;Nr':   Limit scrolling to scrolling area.
   #              Also sets cursor to (0,0).
-  printf("\e[?1049h\e[?7l\e[?25l\e[2J\e[1;%sr", $glines)
+  # printf("\e[?1049h\e[?7l\e[?25l\e[2J\e[1;%sr", $glines)
+  # 2019-03-29 - XXX temporarily not hiding cursor to see if we can place it.
+  printf("\e[?1049h\e[?7l\e[?25h\e[2J\e[1;%sr", $glines)
   # earlier glines was grows
 
   # Hide echoing of user input
@@ -202,15 +209,20 @@ end
 
 # wrap readline so C-c can be ignored, but blank is taken as default
 def readline prompt='>'
+  last_line
+  # do we need to clear till end of line, see enter_regex commented
   # unhide cursor
   print "\e[?25h"
+  system 'stty echo'
   begin
     target = Readline.readline(prompt, true)
   rescue Interrupt
     return nil
   ensure
     # hide cursor
-    print "\e[?25l"
+    # NO LONGER HIDING cursor 2019-03-29 -
+    # print "\e[?25l"
+    system 'stty -echo'
   end
   target.chomp
 end
@@ -261,7 +273,10 @@ def get_char
   # end
   return c.chr if c
 ensure
-  system('stty -raw echo 2>/dev/null') # turn raw input on
+  # system('stty -raw echo 2>/dev/null') # turn raw input on
+  # 2019-03-29 - echo was causing printing of arrow key code on screen
+  # if moving fast
+  system('stty -raw 2>/dev/null') # turn raw input on
 end
 
 ## GLOBALS
@@ -292,6 +307,8 @@ $pager_command = {
   unknown: 'open'
 }
 $dir_position = {}
+$movement = $old_cursor = nil  # cursor movement has happened only, don't repaint
+$selection_mode = 1 # single select
 
 ## ----------------- CONSTANTS ----------------- ##
 GMARK = '*'.freeze
@@ -306,11 +323,43 @@ ON_RED = "\e[41m".freeze
 GREEN      = "\e[32m".freeze
 YELLOW     = "\e[33m".freeze
 BLUE       = "\e[1;34m".freeze
+MAGENTA    = "\e[35m".freeze
+CYAN       = "\e[36m".freeze
 
 ON_BLUE    = "\e[44m".freeze
 REVERSE    = "\e[7m".freeze
 UNDERLINE    = "\e[4m".freeze
-CURSOR_COLOR = ON_BLUE
+CURSOR_COLOR = REVERSE
+
+# NOTE: that osx uses LSCOLORS which only has colors for filetypes not
+#  extensions and patterns which LS_COLORS has.
+# LS_COLORS contains 2 character filetype colors. ex executable mi broken link
+#   extension based colros starting with '*.'
+#   file pattern starting with '*' and a character that is not .
+#   File.ftype(path) returns
+#   file, directory di, characterSpecial cd, blockSpecial bd, fifo pi, link ln, socket so, or unknown
+
+# This hash contains color codes for extensions. It is updated from
+# LS_COLORS.
+$ls_color = {
+  '.rb' => RED,
+  '.tgz' => MAGENTA,
+  '.zip' => MAGENTA,
+  '.torrent' => GREEN,
+  '.srt' => GREEN,
+  '.sh' => CYAN
+}
+# This hash contains colors for file patterns, updated from LS_COLORS
+$ls_pattern = {}
+# This hash contains colors for file types, updated from LS_COLORS
+# Default values in absence of LS_COLORS
+$ls_ftype = {
+  'directory' =>  BLUE,
+  'link'      =>  "\e[01;36m",
+  'mi'        =>  "\e[01;31;7m",
+  'or'        =>  "\e[40;31;01m",
+  'ex'        =>  "\e[01;32m"
+}
 ## --------------------------------------------- ##
 
 $patt = nil
@@ -322,7 +371,8 @@ $visited_files = []
 $visited_dirs = []
 ## dirs where some work has been done, for saving and restoring
 $used_dirs = []
-$default_sort_order = 'om'
+# zsh o = order m = modified time
+$default_sort_order = 'Om'
 $sorto = $default_sort_order
 $viewctr = 0
 $history = []
@@ -337,16 +387,85 @@ $status_color = 4 # status line, can be 2 3 4 5 6
 # ------------------- read_directory ------------------ #
 def read_directory
   rescan_required false
-  # $files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}M)'`.split("\n")
+
+  # http://zsh.sourceforge.net/Doc/Release/Shell-Builtin-Commands.html
+  # zsh print -rl
+  # -l Print the arguments separated by newlines instead of spaces.
+  # -r Ignore the escape conventions of echo.
+  # zshglob M = MARK_DIRS
+
   $filterstr ||= 'M'
-  $files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}#{$filterstr})'`.split("\n")
+  # $files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}#{$filterstr})'`.split("\n")
+  $files = list_files
   $files = sort_file_list $files
+  return unless $enhanced_mode
+
   enhance_file_list
-  ## added by RK 2014-03-31 - 00:29 since too many duplicates
-  $files = $files.uniq if $enhanced_mode
+  $files = $files.uniq
+end
+
+# return a list of directory contents sorted as per sort order
+# NOTE: FNM_CASEFOLD does not work with Dir.glob
+def list_files dir='*', sorto=$sorto, hidden=$hidden, filter=$filterstr
+
+  dir += '/*' if File.directory?(dir)
+  dir = dir.gsub('//', '/')
+
+  # decide sort method based on second character
+  # first char is o or O (reverse)
+  # second char is macLn etc (as in zsh glob)
+  so = sorto ? sorto[1] : nil
+  func = case so
+         when 'm'
+           :mtime
+         when 'a'
+           :atime
+         when 'c'
+           :ctime
+         when 'L'
+           :size
+         when 'n'
+           :path
+         end
+
+  # sort by time and then reverse so latest first.
+  sorted_files = if hidden == 'D'
+                   Dir.glob(dir, File::FNM_DOTMATCH)
+                 else
+                   Dir.glob(dir)
+                 end
+
+  # WARN: crashes on a dead link since no mtime
+  # HACK: use first files return value for bad link
+  if func
+    sorted_files = sorted_files.sort_by do |f|
+      if File.exist? f
+        File.send(func, f)
+      else
+        sys_stat(f, func)
+      end
+    end
+  end
+
+  sorted_files.sort! { |w1, w2| w1.casecmp(w2) } if func == :path && $ignorecase
+
+  # zsh gives mtime sort with latest first, ruby gives latest last
+  sorted_files.reverse! if sorto[0] == 'O'
+
+  # add slash to directories
+  sorted_files = add_slash sorted_files
+  return sorted_files
 end
 # ------------- end of read_directory --------------------------------#
 
+# this is just a tempo method to deal with dead links.
+# I should be doing a system stat and parsing that
+def sys_stat file, func
+  return unless File.symlink? file
+
+  return File.lstat(file).send(func)
+end
+
 # ------------------- create_viewport ------------------ #
 def create_viewport
   $view = if $patt
@@ -382,21 +501,27 @@ def print_title
   $title ||= Dir.pwd.sub(ENV['HOME'], '~')
   fin = $sta + $viewport.size
   fl = $view.size
-  t = "#{$title}  #{$sta + 1} to #{fin} of #{fl}  #{$sorto} F:#{$filterstr}"
+  if fl.zero?
+    t = "#{$title}  No files."
+  else
+    t = "#{$title}  #{$sta + 1} to #{fin} of #{fl}  #{$sorto} F:#{$filterstr}"
+  end
 
   # don't exceed columns while printing
   t = t[t.size - $gcols..-1] if t.size >= $gcols
 
   print "#{BOLD}#{t}#{CLEAR}\n"
+  print "EMPTY" if fl.zero?
 end
 # ------------- end of print_title --------------------------------#
 
-# TODO clean this up and simplify it
+# TODO: clean this up and simplify it
+# NOTE: earlier this was called on every key (up-arow down arrow, now only
+# called when page changes, so we only put directory name)
 def status_line
     # prompt
     v_mm = $mode ? "[#{$mode}] " : ''
     cf = current_file
-    $message = "No file highlighted (#{cf})" if cf and !$highlighted_a_column
     $message = ' | No matches. Press ESCAPE' if $patt && !cf
 
     clear_status_line
@@ -404,23 +529,22 @@ def status_line
     # Print the filename at the right side of the status_line
     # sometimes due to search, there is no file
     if cf
-      # cfl = cf.size
-      # print right aligned TODO REFACTOR THIS
-      # padding = @debug_flag ? 15 : 3
-      # system "tput cup #{$glines} #{$gcols - cfl - padding}"
-      # print "#{REVERSE}#{cf}#{CLEAR}"
       if @debug_flag
-        print_on_right "#{$sta},#{$cursor},#{$stact},#{$viewport.size},#{$grows} | #{cf}"
+        # XXX this will not work on file basis FIXME
+        print_debug_info cf
       else
-        print_on_right "#{cf}"
+        print_on_right "#{Dir.pwd}"
       end
     end
-    # print "\r#{v_mm}#{$patt} #{GREEN}#{$message}#{CLEAR} >"
     # move to beginning of line, reset text mode after printing
     print "\r#{v_mm}#{$patt}#{$message}\e[m"
 
 end
 
+def print_debug_info cf=current_file()
+  print_on_right "= #{$sta},#{$cursor},#{$stact},#{$viewport.size},#{$grows} | #{cf}"
+end
+
 # should we do a read of the dir
 def rescan?
   $rescan_required
@@ -449,16 +573,73 @@ def draw_directory
   print_title
 
   # add hint and format the line
-  buff = _format $viewport
+  buff = format_array $viewport
 
-  # break into as many columns as required
+  # break viewport into as many columns as required
   # This is where directories get their blue color
   buff = columnate buff, $grows
 
+  # starts printing array on line 3
   buff.each { |line| print line, "\n" }
   print
 
   status_line
+
+  # place cursor correctly, we will use this to highlight current row
+end
+
+# place cursor correctly, we will use this to highlight current row
+# XXX i am not sure how to highlight the bg without rewriting the text.
+# I can get the filename but it has been truncated.
+# I can get the earlier filename but the color has to be determined again.
+# FIXME flinks after paging
+# FIXME color of original hint lost
+def place_cursor
+  # clear_cursor
+  # hint = get_shortcut($cursor)
+  c = $cursor - $sta
+  if c < $grows
+    # system "tput cup #{c + 2} 0"
+    # print "\e[#{c + 3};0H"
+    tput_cup c, 0
+    # print "#{CURSOR_COLOR}#{hint} >#{CLEAR}"
+    return
+  end
+  wid = get_width $viewport.size, $grows
+  rows = c % $grows
+  cols = (c / $grows) * wid
+  # system "tput cup #{rows + 2} #{cols}"
+  # print "\e[#{rows + 3};#{cols + 1}H"
+  tput_cup rows, cols
+  # print "#{CURSOR_COLOR}#{hint} >#{CLEAR}"
+end
+
+# clear the earlier position when we move.
+# Currently not using until I can implement chgat here.
+def clear_cursor
+  return unless $old_cursor
+
+  hint = get_shortcut($old_cursor)
+  if $old_cursor < $grows
+    # FIXME: faster way of getting here ? see fff
+    # system "tput cup #{$old_cursor + 2} 0"
+    tput_cup $old_cursor, 0
+    # print "#{CURSOR_COLOR}#{hint} >#{CLEAR}"
+    print "#{hint}  "
+    return
+  end
+  wid = get_width $viewport.size, $grows
+  rows = $old_cursor % $grows
+  cols = ($old_cursor / $grows) * wid
+  # system "tput cup #{rows + 2} #{cols}"
+  tput_cup rows, cols
+  # print "#{CURSOR_COLOR}#{hint} >#{CLEAR}"
+  print "#{hint}  "
+end
+
+def tput_cup row, col
+  # we add 3: 2 is for the help and directory line. 1 is since tput is 1 based
+  print "\e[#{row + 3};#{col + 1}H"
 end
 
 def redraw_required(flag=true) $redraw_required = flag; end
@@ -490,12 +671,10 @@ def resolve_binding key
     args = x
     send(binding, *args) if binding
   else
-    perror "No binding for #{key}"
+    # perror "No binding for #{key}"
   end
 end
 
-
-
 ## write current dir to a file so we can ccd to it when exiting
 def write_curdir
   f = File.expand_path('~/.fff_d')
@@ -529,79 +708,43 @@ end
 ##
 #
 # print in columns
-# ary - array of data
-# sz  - lines in one column
+# ary - array of data (viewport, not view)
+# siz  - how many lines should there be in one column
 #
-def columnate(ary, sz)
+def columnate ary, siz
   buff = []
   return buff if ary.nil? || ary.empty?
 
-  # 2019-03-19 - just to make sure highlighted column is visible
-  $highlighted_a_column = false
-
   # determine width based on number of files to show
   # if less than sz then 1 col and full width
   #
-  wid = 30
-  ars = ary.size
-  ars = [$pagesize, ary.size].min
-  d = 0
-  if ars <= sz
-    wid = $gcols - d
-  else
-    tmp = (ars * 1.000 / sz).ceil
-    wid = $gcols / tmp - d
-  end
-  # elsif ars < sz * 2
-  # wid = $gcols/2 - d
-  # elsif ars < sz * 3
-  # wid = $gcols/3 - d
-  # else
-  # wid = $gcols/$gviscols - d
-  # end
+  wid = get_width ary.size, siz
 
   # ix refers to the index in the complete file list, wherease we only show 60 at a time
   ix = 0
   loop do
     ## ctr refers to the index in the column
+    #  siz is how many items in one column
     ctr = 0
-    while ctr < sz
+    while ctr < siz
 
       f = ary[ix]
       # f is not just filename but marker and hint
-      # Check last char to see if directory
-      linecolor = nil
-      linecolor = BLUE if f[-1] == '/'
 
       # check to see if we need to truncate
-      # TODO 2019-03-18 - truncate from middle of string.
-      fsz = f.size
-      if fsz > wid
-        fromstart = wid - 8
-        # f = f[0, wid - 2] + '$ '
-        # 2019-03-18 - trying to truncate from center
-        f = f[0, fromstart] + '$' + f[-6..-1] + ' '
-        ## we do the coloring after trunc so ANSI escpe seq does not get get
-        if ix + $sta == $cursor
-          f = "#{CURSOR_COLOR}#{f}#{CLEAR}"
-          $highlighted_a_column = true
-        elsif linecolor
-          f = "#{linecolor}#{f}#{CLEAR}"
-        end
+      # 2019-03-18 - truncate from middle of string.
+      # 2019-03-24 - truncate and size to take care of color codes
+      # fsz = f.size
+      unformatted_len, _ = filename_len(f)
+      if unformatted_len > wid
+        # take the excess out from the center on both sides
+        f = truncate_formatted_filename(f, unformatted_len, wid)
+
 
       else
 
-        ## we do the coloring before padding so the entire line does not get
-        # padded, only file name
-        # f = "#{CURSOR_COLOR}#{f}#{CLEAR}" if ix + $sta == $cursor
-        if ix + $sta == $cursor
-          f = "#{CURSOR_COLOR}#{f}#{CLEAR}"
-          $highlighted_a_column = true
-        else
-          f = "#{linecolor}#{f}#{CLEAR}"  if linecolor
-        end
         # f = f.ljust(wid)
-        f << ' ' * (wid - fsz)
+        f << ' ' * (wid - unformatted_len)
 
       end
 
@@ -621,15 +764,43 @@ def columnate(ary, sz)
   buff
 end
 
+# shorten the filename to wid
+# unformatted_len is the length without ANSI formatting
+def truncate_formatted_filename f, unformatted_len, wid
+  excess = unformatted_len - wid
+  center = unformatted_len / 2
+  excess_half = excess / 2
+  point = center + excess_half
+  point1 = point - excess
+  # the space comes after the ANSI formatting
+  f = f[0..(point1 - 1)] + '$' + f[point + 2 .. -1] + ' '
+  f
+end
+
+def get_width arysz, siz
+  ars = [$pagesize, arysz].min
+  d = 0
+  return $gcols - d if ars <= siz
+
+  tmp = (ars * 1.000 / siz).ceil
+  wid = $gcols / tmp - d
+  wid
+end
+
+# calculate length of filename without ANSI color codes
+def filename_len name
+  l = name.length
+  return l if name[0] != "\e"
+
+  # we have an escape code at the start of the name (and end, too)
+  index = name.index('m')
+  eindex = name.rindex("\e")
+  reall = eindex - index - 1
+  return reall, l
+end
+
 ## formats the data with number, mark and details
-# 2019-03-09 - at some time this got renamed to `format` which is a kernel
-#  method and this overshadowed that method.
-#  NOTE: this does not do any coloring since the codes may get chopped by
-#   columnate method
-#   TODO 2019-03-23 - 23:30 we can do coloring here. columnate must check for color
-#   code at start of line, and check size accordingly. If it needs to truncate, then
-#   first take off the ANSI codes, truncate and put back.
-def _format(ary)
+def format_array(ary)
   # buff = Array.new
   buff = Array.new(ary.size)
   return buff if ary.nil? || ary.empty?
@@ -648,37 +819,45 @@ def _format(ary)
     mark = SPACE
     mark = '+' if visited? f
     cur = SPACE
-    cur = CURMARK if ix + $sta == $cursor
+    # cur = CURMARK if ix + $sta == $cursor # 2019-03-29 - removed reduced calls
     # NOTE seems like f and ary[ix] are the same
     mark = GMARK if selected?(ary[ix])
 
+    # take care of shortcuts in visited files and dirs
+    fullname = f[0] == '~' ? File.expand_path(f) : f
+    color = color_for fullname
+
     if $long_listing
       begin
         if File.exist? f
           stat = File.stat(f)
         else
-          # remove last character and get stat
-          last = f[-1]
-          stat = File.stat(f.chop) if last == ' ' || last == '@' || last == '*'
+          # dead link
+          if File.symlink?(f)
+            stat = File.lstat(f)
+          else
+            # remove last character and get stat
+            last = f[-1]
+            stat = File.stat(f.chop) if last == ' ' || last == '@' || last == '*'
+          end
         end
         # this is for saved directories etc which are shortened
         stat ||= File.stat(File.expand_path(f))
         f = format('%10s  %s  %s', readable_file_size(stat.size, 1),
                    date_format(stat.mtime), f)
       rescue StandardError => e
+        @log.warn "WARN::#{e}: FILE:: #{f}"
         f = format('%10s  %s  %s', '?', '??????????', f)
       end
     end
 
-    s = "#{ind}#{mark}#{cur}#{f}"
+    # 2019-03-31 - replace unprintable chars with ?
+    f = f.gsub(/[^[:print:]]/, '?')
 
-    # NOTE: I cannot color the current line since _format does the chopping
-    # so not only does the next lines alignment get skewed,
-    # but also if the line is truncated
-    # then the color overflows.
-    # if ix + $sta == $cursor
-    # s = "#{RED}#{s}#{CLEAR}"
-    # end
+    s = "#{ind}#{mark}#{cur}#{f}"
+    if color
+      s = "#{color}#{s}#{CLEAR}"
+    end
 
     buff[ctr] = s
 
@@ -688,6 +867,104 @@ def _format(ary)
   buff
 end
 
+# determine color for a filename based on extension, then pattern, then filetype
+def color_for fname
+  extension = File.extname(fname)
+  color = $ls_color[extension]
+  return color if color
+
+  # check file against patterns
+  if File.file?(fname)
+    $ls_pattern.each_pair do |k, v|
+      # if fname.match?(/k/)
+      if fname =~ /#{k}/
+        # @log.debug "#{fname} matched #{k}. color is #{v[1..-2]}"
+        return v
+      # else
+        # @log.debug "#{fname} di not match #{k}. color is #{v[1..-2]}"
+      end
+    end
+  end
+
+  # check filetypes
+  if File.exist? fname
+    # @log.debug "Filetype:#{File.ftype(fname)}"
+
+    return $ls_ftype[File.ftype(fname)] if $ls_ftype.key? File.ftype(fname)
+    return $ls_ftype['ex'] if File.executable?(fname)
+  else
+    # orphan file, but fff uses mi
+    return $ls_ftype['mi'] if File.symlink?(fname)
+
+    @log.warn "FILE WRONG: #{fname}"
+    return $ls_ftype['or']
+  end
+
+  nil
+end
+
+def parse_ls_colors
+
+  colorvar = ENV['LS_COLORS']
+  if colorvar.nil?
+    $ls_colors_found = nil
+    return
+  end
+  $ls_colors_found = true
+  ls = colorvar.split(':')
+  ls.each do |e|
+    patt, colr = e.split '='
+    colr = "\e[" + colr + 'm'
+    if e.start_with? '*.'
+      # extension, avoid '*' and use the rest as key
+      $ls_color[patt[1..-1]] = colr
+      # @log.debug "COLOR: Writing extension (#{patt})."
+    elsif e[0] == '*'
+      # file pattern, this would be a glob pattern not regex
+      # only for files not directories
+      patt = patt.gsub('.', '\.')
+      patt = patt.sub('+', '\\\+') # if i put a plus it does not go at all
+      patt = patt.gsub('-', '\-')
+      patt = patt.gsub('?', '.')
+      patt = patt.gsub('*', '.*')
+      patt = "^#{patt}" if patt[0] != '.'
+      patt = "#{patt}$" if patt[-1] != '*'
+      $ls_pattern[patt] = colr
+      # @log.debug "COLOR: Writing file (#{patt})."
+    elsif patt.length == 2
+      # file type, needs to be mapped to what ruby will return
+      # file, directory di, characterSpecial cd, blockSpecial bd, fifo pi, link ln, socket so, or unknown
+      # di = directory
+      # fi = file
+      # ln = symbolic link
+      # pi = fifo file
+      # so = socket file
+      # bd = block (buffered) special file
+      # cd = character (unbuffered) special file
+      # or = symbolic link pointing to a non-existent file (orphan)
+      # mi = non-existent file pointed to by a symbolic link (visible when you type ls -l)
+      # ex = file which is executable (ie. has 'x' set in permissions).
+      case patt
+      when 'di'
+        $ls_ftype['directory'] = colr
+      when 'cd'
+        $ls_ftype['characterSpecial'] = colr
+      when 'bd'
+        $ls_ftype['blockSpecial'] = colr
+      when 'pi'
+        $ls_ftype['fifo'] = colr
+      when 'ln'
+        $ls_ftype['link'] = colr
+      when 'so'
+        $ls_ftype['socket'] = colr
+      else
+        $ls_ftype[patt] = colr
+      end
+      # @log.debug "COLOR: ftype #{patt}"
+    end
+  end
+end
+
 ## select file based on key pressed
 def select_hint view, key
   # a to y is direct
@@ -711,14 +988,14 @@ def select_hint view, key
 end
 
 ## toggle selection state of file
-def toggle_select(f=current_file)
-  # dir = Dir.pwd
-  # file = File.join(dir, f)
+def toggle_select f=current_file
   if selected? f
     remove_from_selection f
   else
+    $selected_files.clear if $selection_mode == 1
     add_to_selection f
   end
+  message "#{$selected_files.count} files selected.   "
   # XXX is it possible to just redraw this line
   redraw_required
 end
@@ -734,13 +1011,12 @@ def open_file(f)
     last = f[-1]
     f = f.chop if last == ' ' || last == '@' || last == '*'
   end
-  nextpos = nil
 
   # could be a bookmark with position attached to it
-  f, nextpos = f.split(':') if f.index(':')
+  f, _nextpos = f.split(':') if f.index(':')
   if File.directory? f
     save_dir_pos
-    change_dir f, nextpos
+    change_dir f #, nextpos
   elsif File.readable? f
     # TODO: looks complex pls simplify !! XXX
     $default_command ||= '$PAGER'
@@ -842,9 +1118,7 @@ def run_command(f)
 end
 
 ## cd to a dir.
-# Also, position cursor on child directory that we changed from if second param
-# is true.
-def change_dir f, position_cursor=false
+def change_dir f
   unless File.directory? f
     perror "#{f} is not a directory, or does not exist."
     return
@@ -852,8 +1126,7 @@ def change_dir f, position_cursor=false
 
   # before leaving a dir we save it in the list, as well as the cursor
   # position, so we can restore that position when we return
-  dir_from = Dir.pwd
-  $visited_dirs.insert(0, dir_from)
+  $visited_dirs.insert(0, Dir.pwd)
   save_dir_pos
 
   f = File.expand_path(f)
@@ -861,14 +1134,6 @@ def change_dir f, position_cursor=false
   read_directory
   post_cd
 
-  # position the cursor on the previous directory
-  # This happens when we go to parent directory
-  if position_cursor
-    # get the position of the previous directory
-    pos = index_of(File.basename(dir_from) + '/')
-    $cursor = pos if pos
-  end
-
   redraw_required
 end
 
@@ -903,10 +1168,11 @@ def refresh
 end
 
 # put directories first, then files
-def sort_file_list(_files)
-  _dirs = $files.select { |f| File.directory?(f) }
-  _files = $files.select { |f| File.file?(f) }
-  _dirs + _files
+def sort_file_list files
+  dirs = files.select { |f| File.directory?(f) }
+  # earlier I had File? which removed links, esp dead ones
+  fi   = files.select { |f| !File.directory?(f) }
+  dirs + fi
 end
 
 ## unselect all files
@@ -924,10 +1190,10 @@ end
 ## accept dir to goto and change to that ( can be a file too)
 def goto_dir
   # print "\e[?25h"
-  print_last_line 'Enter path: '
+  # print_last_line 'Enter path: '
   begin
     # path = gets.chomp
-    path = readline
+    path = readline 'Enter path to go to: '
     if path.nil? || path == ''
       clear_status_line
       return
@@ -960,44 +1226,35 @@ end
 #  In selection, pressed hotkey selects a file without opening, one can keep selecting
 #  (or deselecting).
 #
-def selection_mode_toggle
+def toggle_selection_mode
   if $mode == 'SEL'
+    $selection_mode = 1
     unselect_all
     $mode = nil
+    message 'Selection mode is single.   '
   else
-    # $selection_mode = !$selection_mode
+    $selection_mode = 2
     $mode = 'SEL'
+    message 'Typing a hint selects the file. Toggling again will clear selection.  '
   end
 end
 
-## toggle command mode
-# 2019-03-15 - TODO FIXME preferable when we go into command mode
-#  run a command on current or selected files. But then is it a mode, do we remain
-#  there, or come out immediately ?
-#  2019-03-17 - have removed this altogether. not required
-def command_mode
-  if $mode == 'COM'
-    $mode = nil
-    return
-  end
-  $mode = 'COM'
-end
-
 # go to parent dir, and maintain cursor on the dir we came out of
 def goto_parent_dir
-  # 2019-03-20 - when changing to parent, we need to keep cursor on
+  # When changing to parent, we need to keep cursor on
   #  parent dir, not first
-  # curr = File.basename(Dir.pwd)
+  curr = File.basename(Dir.pwd)
+
+  return if curr == '/'
+
+  change_dir '..'
 
-  change_dir '..', true
+  return if curr == Dir.pwd
 
-  # TODO 2019-03-24 - we can revert to old thing and remove second arg from cd
-  # FIXME 2019-03-23 - too late to change the cursor here since change_dir
-  #  now does a redraw !!! XXX
   # get index of child dir in this dir, and set cursor to it.
-  # index = $files.index(curr + '/')
-  # pause "WARNING: Could not find #{curr} in this directory." unless index
-  # $cursor = index if index
+  index = $files.index(curr + '/')
+  pause "WARNING: Could not find #{curr} in this directory." unless index
+  $cursor = index if index
 end
 
 def goto_home_dir
@@ -1022,6 +1279,7 @@ end
 # If lower case character given, then go to first file starting with char.
 def goto_bookmark(key = nil)
   unless key
+    last_line
     print 'Enter bookmark char: '
     key = get_char
   end
@@ -1036,7 +1294,7 @@ def goto_bookmark(key = nil)
         nextpos = d[ix + 1..-1]
         d = d[0, ix]
       end
-      change_dir d, nextpos
+      change_dir d #, nextpos
     else
       perror "#{key} not a bookmark"
     end
@@ -1050,7 +1308,7 @@ end
 def enter_regex
   # print 'Enter (regex) pattern: '
   # move to beginning of line, and clear till EOL
-  print "\r\e[K"
+  # print "\r\e[K"
   $patt = readline '/'
 end
 
@@ -1059,23 +1317,16 @@ def next_page
   $sta += $pagesize
   $cursor += $pagesize
   $sta = $cursor if $sta > $cursor
-  # FIXME this is sometimes correct, but in short  cases, cursor no longer refers
-  #  to a file. also after cycling, it no longer has a file.
-  #  FIXME: 2019-03-20 - if cursor is panned to 3rd column and then we page,
-  #   then after a while no hints show up since stact is high.
   $stact = 0
+  $old_cursor = nil
   redraw_required
-  # next just does not work on the last page when it should
-  #  perhaps viewport has not yet been adjusted, that's why
-  # $stact = 0 if $stact >= $viewport.size
-  # setting to zero is not the best solution since hints are reset but this is better
-  #  than trying to maintain the same stact since the columns reduce in the end.
-  #  I tried checking that stact < viewport.size but nothing happened
 end
 
 def prev_page
   $sta -= $pagesize
   $cursor -= $pagesize
+  $old_cursor = nil
+  # FIXME: check cursor sanity and if not changed then no redraw
   redraw_required
 end
 
@@ -1130,9 +1381,8 @@ def page_with_tempfile
 end
 
 def debug_vars
-  @debug_flag = true
   page_with_tempfile do |file|
-    file.puts 'DEBUG VARIABLES ARE:'
+    file.puts "DEBUG VARIABLES for #{current_file}:"
     file.puts
     file.puts "sta    #{$sta}"
     file.puts "cursor #{$cursor}"
@@ -1142,6 +1392,10 @@ def debug_vars
     file.puts "view.size      #{$view.size}"
     file.puts "grows          #{$grows}"
     file.puts "file   #{current_file}"
+    file.puts
+    file.puts `file "#{current_file}"`
+    file.puts
+    file.puts %x[stat   "#{current_file}"]
   end
   redraw_required
 end
@@ -1156,7 +1410,7 @@ def view_bookmarks
   goto_bookmark(key) if key =~ /^[0-9A-Z]$/
 end
 
-# MENU MAIN -- keep consistent with zfm
+# MENU MAIN
 def main_menu
   h = {
     :a => :ag,
@@ -1171,11 +1425,11 @@ def main_menu
     '2' => :select_from_used_dirs,
     :t => :dirtree,
     '4' => :tree,
-    :s => :sort_menu,
+    :o => :sort_menu,
     :F => :filter_menu,
     :c => :command_menu,
     :b => :bookmark_menu,
-    :y => :selection_menu,
+    :s => :selection_menu,
     :B => :bindkey_ext_command,
     :M => :create_a_dir,
     '%' => :create_a_file,
@@ -1190,7 +1444,7 @@ def selection_menu
     :a => :select_all,
     :u => :unselect_all,
     :s => :toggle_select,
-    '@' => 'selection_mode_toggle',
+    '@' => 'toggle_selection_mode',
     'x' => 'visual_mode_toggle',
     :v => :view_selected_files
   }
@@ -1210,6 +1464,7 @@ end
 def menu title, h
   return unless h
 
+  last_line # 2019-03-30 - required since cursor is not longer at bottom
   pbold title.to_s
   # h.each_pair { |k, v| puts " #{k}: #{v}" }
   # 2019-03-09 - trying out using `column` to print in cols
@@ -1231,15 +1486,25 @@ def menu title, h
 end
 
 def toggle_menu
-  h = { :h => :toggle_hidden, :c => :toggle_case, :l => :toggle_long_list, '1' => :toggle_columns,
-        :p => :toggle_pager_mode, :e => :toggle_enhanced_list }
+  h = { :h => :toggle_hidden,
+        :c => :toggle_case,
+        :l => :toggle_long_list,
+        '1' => :toggle_columns,
+        :p => :toggle_pager_mode,
+        :d => :toggle_debug_flag,
+        :m => :toggle_selection_mode,
+        :e => :toggle_enhanced_list }
+
   _, menu_text = menu 'Toggle Menu', h
   return unless menu_text
 
   case menu_text
   when :toggle_hidden
+    # NOTE: now that I am shifting queries to ruby not sure this will continue
+    # FNM_DOTMATCH
+    #  working everywhere
+    # zsh D - dot files should show
     $hidden = $hidden ? nil : 'D'
-    # pause "Show hidden files is now #{!$hidden.nil?}. Press a key."
     message "Show hidden is now #{!$hidden.nil?}"
     rescan_required
   when :toggle_case
@@ -1249,8 +1514,6 @@ def toggle_menu
     message "Ignore Case is now #{$ignorecase}"
     rescan_required
   when :toggle_columns
-    # FIXME: 2019-03-20 - if 3 then 1
-    # adjust stact and sta, if moving from panned position
     if $gviscols == 1
       $gviscols = 3
     else
@@ -1287,27 +1550,34 @@ def toggle_menu
       $pagesize = $pagesize == x ? $grows : x
     end
     if $stact > 0
-      # FIXME what if we had paged down as well and sta was > 0
       $sta = $stact
       $stact = 0 # in case user was panned 2019-03-20 -
     end
     message "Long listing is #{$long_listing}, vis cols is #{$gviscols}"
     rescan_required
+  when :toggle_debug_flag
+    @debug_flag = !@debug_flag
+    message "Debug flag is #{@debug_flag}"
   end
 end
 
 def sort_menu
+  # zsh o = order, O = reverse order
+  # ruby mtime/atime/ctime come reversed so we have to change o to O
   lo = nil
   h = { m: :modified, a: :accessed, M: :oldest,
-        l: :largest, s: :smallest, n: :name, r: :rev_name, d: :dirs, c: :clear }
+        l: :largest, s: :smallest, n: :name, r: :rev_name, d: :dirs, c: :inode,
+        z: :clear }
   _, menu_text = menu 'Sort Menu', h
   case menu_text
   when :modified
-    lo = 'om'
+    lo = 'Om'
   when :accessed
-    lo = 'oa'
+    lo = 'Oa'
+  when :inode
+    lo = 'Oc'
   when :oldest
-    lo = 'Om'
+    lo = 'om'
   when :largest
     lo = 'OL'
   when :smallest
@@ -1325,9 +1595,6 @@ def sort_menu
   $sorto = lo
   message "Sorted on #{menu_text}"
   rescan_required
-  # $files = `zsh -c 'print -rl -- *(#{lo}#{$hidden}M)'`.split("\n") if lo
-  # $title = nil
-  # $files =$(eval "print -rl -- ${pattern}(${MFM_LISTORDER}$filterstr)")
 end
 
 # thse need to be placed in correct position, some do nothing
@@ -1359,11 +1626,12 @@ def command_menu
   when :locate
     locate
   when :today
-    # FIXME use filterstring
+    # zshglob: M = MARK_DIRS with slash
+    # zshglob: 'm0' 'm' = modified time, '0' = 0 days ago
     $files = `zsh -c 'print -rl -- *(#{$hidden}Mm0)'`.split("\n")
     $title = "Today's files"
   when :default_command
-    puts " THis no longer works"
+    puts ' This no longer works'
     puts 'Selecting a file usually invokes $EDITOR'
     puts 'What command do you want to use repeatedly on selected files: '
     $default_command = gets.chomp
@@ -1408,18 +1676,22 @@ def filter_menu
   case menu_text
   when :dirs
     $filterstr = '/M'
+    # zsh /M MARK_DIRS appends trailing '/' to directories
     files = `zsh -c 'print -rl -- *(#{$sorto}/M)'`.split("\n")
     $title = 'Filter: directories only'
   when :files
     $filterstr = '.'
+    # zsh '.' for files, '/' for dirs
     files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}.)'`.split("\n")
     $title = 'Filter: files only'
   when :emptydirs
     $filterstr = '/D^F'
+    # zsh F = full dirs, ^F empty dirs
     files = `zsh -c 'print -rl -- *(#{$sorto}/D^F)'`.split("\n")
     $title = 'Filter: empty directories'
   when :emptyfiles
     $filterstr = '.L0'
+    # zsh .L size in bytes
     files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}.L0)'`.split("\n")
     $title = 'Filter: empty files'
   when :reduce_list
@@ -1427,17 +1699,20 @@ def filter_menu
   when :extension
     files = filter_for_current_extension
   end
-  if files
+  if files && files.count > 0
     $files = files
     $stact = 0
-    $message = "Filtered on #{menu_text}"
+    $message = "Filtered on #{menu_text}. Press ESC to return."
     # redraw
+  else
+    perror 'Sorry, No files. '
+    $title = nil
   end
 end
 
 def reduce pattern=nil
   unless pattern
-    print 'Enter a pattern to reduce current list: '
+    last_line 'Enter a pattern to reduce current list: '
     pattern = gets.chomp
   end
   $title = "Filter: pattern #{pattern}"
@@ -1481,9 +1756,6 @@ def pop_dir
   ## XXX make sure the dir exists, cuold have been deleted. can be an error or crash otherwise
   $visited_dirs.push d
   Dir.chdir d
-  # $filterstr ||= 'M'
-  # $files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}#{$filterstr})'`.split("\n")
-  # $files = sort_file_list $files
   post_cd
   rescan_required
 end
@@ -1493,11 +1765,10 @@ def post_cd
   $title = $patt = $message = nil
   $sta = $cursor = $stact = 0
   $visual_block_start = nil
-  $current_dir = Dir.pwd # 2019-03-10 - so i don't keep doing in functions
+  $current_dir = Dir.pwd
   screen_settings
 
   # goto last position cursor was in this dir
-  # THis only makes sense if called after read_directory but before redraw
   revert_dir_pos
 end
 
@@ -1562,9 +1833,9 @@ end
 def create_bookmark
 
   print 'Enter A to Z or 0-9 to create a bookmark: '
-  print "\e[?25h" # unhide cursor
+  # print "\e[?25h" # unhide cursor
   key = get_char
-  print "\e[?25l" # hide cursor
+  # print "\e[?25l" # hide cursor
   if key =~ /^[0-9A-Z]$/
     # $bookmarks[key] = "#{Dir.pwd}:#{$cursor}"
     $bookmarks[key] = Dir.pwd
@@ -1580,6 +1851,7 @@ end
 # Was this supposed to be augmented, or just remain limited like this
 # We should be able to do everything in the menus from here. TODO
 def subcommand
+  last_line
   print 'Enter command: q x wq p w e r h '
   begin
     command = readline
@@ -1590,6 +1862,7 @@ def subcommand
   if command == 'q'
     # FIXME: 2019-03-22 - should this not call quit_command ?
     if $modified
+      last_line
       print 'Do you want to save bookmarks? (y/n): '
       key = get_char
       if key == 'y'
@@ -1627,14 +1900,15 @@ end
 
 def quit_command
   if $modified
-    puts 'Press w to save bookmarks before quitting ' if $modified
-    print 'Press another q to quit '
+    last_line
+    puts 'Press y to save bookmarks before quitting ' if $modified
+    print 'Press n to quit without saving'
     key = get_char
   else
     $quitting = true
   end
-  $quitting = true if key == 'q'
-  $quitting = $writing = true if key == 'w'
+  $quitting = true if key == 'n'
+  $quitting = $writing = true if key == 'y'
 end
 
 def views
@@ -1651,14 +1925,32 @@ end
 
 def child_dirs
   $title = 'Directories in current directory'
-  $files = `zsh -c 'print -rl -- *(/#{$sorto}#{$hidden}M)'`.split("\n")
-  message "#{$files.size} files."
+  # M is MARK_DIRS option for putting trailing slash after dir
+  # $files = `zsh -c 'print -rl -- *(/#{$sorto}#{$hidden}M)'`.split("\n")
+  # $files = Dir.glob("*", File::FNM_DOTMATCH).select {|f| File.directory?(f)} - %w[ . ..]
+  $files = dirs
+  message "#{$files.size} directories."
   # redraw
 end
 
+def dirs dir='*'
+  files = Dir.glob(dir, File::FNM_DOTMATCH).select {|f| File.directory?(f)} - %w[ . ..]
+  files = add_slash files
+  files
+end
+
+def add_slash files
+  return files.map do |f|
+    File.directory?(f) ? f + '/' : f
+  end
+end
+
 def dirtree
-  $title = 'Child directories with depth'
-  $files = `zsh -c 'print -rl -- **/*(/#{$sorto}#{$hidden}M)'`.split("\n")
+  $title = 'Child directories recursive'
+  # zsh **/ is recursive
+  files1 = `zsh -c 'print -rl -- **/*(/#{$sorto}#{$hidden}M)'`.split("\n")
+  $files = Dir['**/']
+  @log.debug "zsh #{files1} != rb #{$files}" if files1 != $files
   message "#{$files.size} files."
   # redraw
 end
@@ -1669,7 +1961,8 @@ end
 def tree
   # Caution: use only for small projects, don't use in root.
   $title = 'Full Tree'
-  $files = `zsh -c 'print -rl -- **/*(#{$sorto}#{$hidden}M)'`.split("\n")
+  # $files = `zsh -c 'print -rl -- **/*(#{$sorto}#{$hidden}M)'`.split("\n")
+  $files = Dir['**/*']
   message "#{$files.size} files."
   # redraw
 end
@@ -1679,6 +1972,8 @@ end
 def recent_files
   # print -rl -- **/*(Dom[1,10])
   $title = 'Recent files'
+  # zsh D DOT_GLOB, show dot files
+  # zsh om order on modification time
   $files = `zsh -c 'print -rl -- **/*(Dom[1,15])'`.split("\n").reject {|f| f[0] == '.'}
   # redraw
 end
@@ -1711,6 +2006,7 @@ def perror text
 end
 
 def pause text=' Press a key.'
+  last_line
   print text
   get_char
 end
@@ -1795,10 +2091,12 @@ def ask_hint(deflt = nil)
 end
 
 ## check screen size and accordingly adjust some variables
+# NOTE: tput is ncurses dependent, so use stty
 #
 def screen_settings
-  $glines = `tput lines`.to_i
-  $gcols = `tput cols`.to_i
+  $glines, $gcols = `stty size`.split.map{|e| e.to_i}
+  # $glines = `tput lines`.to_i
+  # $gcols = `tput cols`.to_i
   $grows = $glines - 3
   # $pagesize = 60
   # $gviscols = 3
@@ -1842,7 +2140,7 @@ end
 #  from selection
 def file_actions(action = nil)
   # only add dtrx for gz
-  h = { d: :delete, m: :move, r: :rename, v: ENV['EDITOR'] || :vim,
+  h = { d: :delete, D: '/bin/rm', m: :move, r: :rename, v: ENV['EDITOR'] || :vim,
         c: :copy, C: :chdir, W: :remspace, e: :execute, s: :page_stat_for_file,
         l: :less, p: :most, f: :file, o: :open, x: :dtrx, z: :zip }
   # acttext = h[action.to_sym] || action
@@ -1892,20 +2190,22 @@ def file_actions(action = nil)
 
   when :delete
     delcommand = 'rmtrash'
-    print "#{delcommand} #{text} ?[yn?]: "
+    last_line
+    print "#{delcommand} #{text} ? [yn?]: "
     key = get_char
     view_selected_files if key == '?'
     return if key != 'y'
 
+    clear_status_line
+    print "\r deleting ..."
     system "#{delcommand} #{files}"
     refresh
 
   when :move
     # 2019-03-07 - NOTE this will only work with single file selection
-    print "move #{text} to : "
     # target = gets().chomp
     # target = Readline.readline('>', true)
-    target = readline
+    target = readline "Move #{text} to : "
     return unless target
 
     target = '.' if target == ''
@@ -1929,8 +2229,7 @@ def file_actions(action = nil)
 
   when :copy
     # Target must be directory
-    print "copy #{text} to : "
-    target = readline
+    target = readline "Copy #{text} to : "
     return unless target # C-c
 
     target = '.' if target == ''
@@ -1953,9 +2252,8 @@ def file_actions(action = nil)
     change_dir File.dirname(text)
 
   when :zip
-    print 'Archive name: '
     # target = gets().chomp
-    target = readline
+    target = readline 'Archive name: '
     return unless target
     return if target == ''
 
@@ -1973,8 +2271,7 @@ def file_actions(action = nil)
   when :rename
     # 2019-03-07 NOTE works for single file FIXME
     # 2019-03-07 - TODO for n files replace pattern with string
-    print "rename #{text} to : "
-    target = readline
+    target = readline "Rename #{text} to : "
     return if target == ''
 
     text = File.expand_path(text)
@@ -2021,13 +2318,12 @@ def file_actions(action = nil)
   else
     return unless menu_text
 
-    print "#{menu_text} #{files}"
-    pause
-    print
+    @log.debug "#{menu_text} #{files}"
+    last_line
+    pause "#{menu_text} #{files}"
     system "#{menu_text} #{files}"
     setup_terminal
     refresh
-    pause
   end
 
   # remove non-existent files from select list due to move or delete
@@ -2077,16 +2373,22 @@ def execute
 end
 
 def ag
-  print 'Enter a pattern to search (ag): '
-  pattern = readline
+  pattern = readline 'Enter a pattern to search (ag): '
   return if pattern == ''
 
-  $title = "Files found using 'ag' #{pattern}"
-  system("ag #{pattern}")
+  $title = "Files found using 'ag -t: ' #{pattern}"
+
+  ## ag options :
+  #     -t : all text files
+  #     -l : print only file names
+  #     -a : print all files, even ignored
+  system %[ag -t "#{pattern}"]
+
   pause
-  files = `ag -l #{pattern}`.split("\n")
+  files = `ag -lt "#{pattern}"`.split("\n")
   if files.empty?
-    perror 'No files found for #{pattern}.'
+    perror "No files found for #{pattern}."
+    $title = nil
     return
   end
   $files = files
@@ -2094,12 +2396,13 @@ def ag
 end
 
 def ffind
-  print 'Enter a file name pattern to find: '
-  pattern = readline
+  last_line
+  # print 'Enter a file name pattern to find: '
+  pattern = readline '! find . -iname :'
   return if pattern == ''
 
   $title = "Files found using 'find' #{pattern}"
-  files = `find . -name "#{pattern}"`.split("\n")
+  files = `find . -iname "#{pattern}"`.split("\n")
   if files.empty?
     perror 'No files found. Try adding *'
   else
@@ -2169,10 +2472,14 @@ def cursor_scroll_up
 end
 
 def cursor_dn
+  $movement = true
+  $old_cursor = $cursor
   moveto(pos + 1)
 end
 
 def cursor_up
+  $old_cursor = $cursor
+  $movement = true
   moveto(pos - 1)
 end
 
@@ -2191,6 +2498,7 @@ def moveto(position)
   # FIXME not correct, it must stop at end or correctly cycle
   # sta goes to 0 but cursor remains at 70
   # viewport.size may be wrong here, maybe should be pagesize only
+  oldsta = $sta
   if $cursor - $sta >= $pagesize
     $sta += $pagesize
   # elsif $sta - $cursor >= $viewport.size
@@ -2200,6 +2508,8 @@ def moveto(position)
     # $sta = $cursor
   end
 
+  $movement = nil if oldsta != $sta # we need to redraw
+
   star = [orig, $cursor].min
   fin = [orig, $cursor].max
   return unless $visual_mode
@@ -2215,7 +2525,7 @@ def moveto(position)
     # $selected_files.concat $view[star..fin]
     add_to_selection $view[star..fin]
   end
-ensure
+# ensure
   # redraw
 end
 
@@ -2233,7 +2543,6 @@ def visited?(file)
   return $visited_files.index file
 end
 
-# TODO: can be array
 def add_to_selection(file)
   ff = file
   case file
@@ -2247,7 +2556,6 @@ def add_to_selection(file)
   end
 end
 
-# TODO: can be array
 def remove_from_selection(file)
   ff = file
   case file
@@ -2382,10 +2690,7 @@ def create_a_file
   print
   print 'Enter file name: '
   str = readline
-  return if str == ''
-
-  # FIXME a file with space will not create single file
-  # 2019-03-10 - maybe touch a file
+  return if str.nil? || str == ''
 
   system %($EDITOR "#{str}")
   setup_terminal
@@ -2408,6 +2713,9 @@ end
 # prompt for scripts to execute, giving selected file names
 # NOTE: TODO 2019-03-21 - some scripts can output a filelist to display
 def scripts
+  write_selected_files
+  # some scripts may work with the selected_files and not want to be called
+  #  with filenames.
   title = 'Select a script'
   script_path = '~/.config/cetus/scripts'
   # TODO write selected files to a known file before calling
@@ -2429,20 +2737,22 @@ end
 
 # ------------------- view_selected_files ------------------ #
 def view_selected_files
-  require 'tempfile'
-  file = Tempfile.new('selected_files')
-  begin
-    $selected_files.each { |row| file.puts row }
-    file.flush
-    system "$PAGER #{file.path}"
-    setup_terminal
-  rescue
-    file.close
-    file.unlink
-  end
+  fname = write_selected_files
+  system "$PAGER #{fname}"
+  setup_terminal
 end
 # ------------- end of view_selected_files --------------------------------#
 
+# write selected files to a file and return path
+def write_selected_files
+  fname = File.join(File.dirname(CONFIG_FILE), 'selected_files')
+  fname = File.expand_path(fname)
+
+  File.open(fname, 'w') do |file|
+    $selected_files.each { |row| file.puts row }
+  end
+  return fname
+end
 ##
 # Editing of the User Dir List.
 # remove current entry from used dirs list, since we may not want some entries being there
@@ -2491,15 +2801,27 @@ end
 def enhance_file_list
   return unless $enhanced_mode
 
+  # zshglob: M = MARK_DIRS with slash
+  # zshglob: N = NULL_GLOB no error if no result, this is causing space to split
+  #  file sometimes for single file.
+
   # if only one entry and its a dir
   # get its children and maybe the recent mod files a few
-
+  # FIXME: simplify condition into one
   if $files.size == 1
     # its a dir, let give the next level at least
     if $files.first[-1] == '/'
       d = $files.first
-      f = `zsh -c 'print -rl -- #{d}*(omM)'`.split("\n")
+      # zshglob: 'om' = ordered on modification time
+      # f1 = `zsh -c 'print -rl -- #{d}*(omM)'`.split("\n")
+      f = get_files_by_mtime(d)
+
+      # @log.warn "f1:#{f1} != f:#{f} in #{d}" if f1 != f
+      # order returned by zsh and ruby are different since the time is the same
+
+      # TODO: use ruby this throws errors if not files
       if f && !f.empty?
+        # @log.debug "CONCAT: #{f}" if @debug_flag
         $files.concat f
         $files.concat get_important_files(d)
         return
@@ -2511,29 +2833,40 @@ def enhance_file_list
   end
   #
   # check if a ruby project dir, although it could be a backup file too,
-  # if so , expand lib and maby bin, put a couple recent files
-  #
+  # if so , expand lib and maybe bin, put a couple recent files
+  # FIXME: gemspec file will be same as current folder
   if $files.index('Gemfile') || !$files.grep(/\.gemspec/).empty?
     # usually the lib dir has only one file and one dir
     flg = false
     $files.concat get_important_files(Dir.pwd)
     if $files.index('lib/')
-      f = `zsh -c 'print -rl -- lib/*(om[1,5]M)'`.split("\n")
+      # get first five entries by modification time
+      # f1 = `zsh -c 'print -rl -- lib/*(om[1,5]MN)'`.split("\n")
+      f = get_files_by_mtime('lib')&.first(5)
+      # @log.warn "f1 #{f1} != #{f} in lib" if f1 != f
       if f && !f.empty?
         insert_into_list('lib/', f)
         flg = true
       end
+
+      # look into lib file for that project
       dd = File.basename(Dir.pwd)
       if f.index("lib/#{dd}/")
-        f = `zsh -c 'print -rl -- lib/#{dd}/*(om[1,5]M)'`.split("\n")
+        # f1 = `zsh -c 'print -rl -- lib/#{dd}/*(om[1,5]MN)'`.split("\n")
+        f = get_files_by_mtime("lib/#{dd}")&.first(5)
+        # @log.warn "2756 f1 #{f1} != #{f} in lib/#{dd}" if f1 != f
         if f && !f.empty?
           insert_into_list("lib/#{dd}/", f)
           flg = true
         end
       end
     end
+
+    # look into bin directory and get first five modified files
     if $files.index('bin/')
-      f = `zsh -c 'print -rl -- bin/*(om[1,5]M)'`.split("\n")
+      # f1 = `zsh -c 'print -rl -- bin/*(om[1,5]MN)'`.split("\n")
+      f = get_files_by_mtime("bin")&.first(5)
+      # @log.warn "2768 f1 #{f1} != #{f} in bin/" if f1 != f
       insert_into_list('bin/', f) if f && !f.empty?
       flg = true
     end
@@ -2544,20 +2877,58 @@ def enhance_file_list
   end
   return if $files.size > 15
 
-  ## first check accessed else modified will change accessed
-  moda = `zsh -c 'print -rn -- *(/oa[1]M)'`
+  # Get most recently accessed directory
+  ## NOTE: first check accessed else modified will change accessed
+  # 2019-03-28 - adding NULL_GLOB breaks file name on spaces
+  # print -n : don't add newline
+  # zzmoda = `zsh -c 'print -rn -- *(/oa[1]MN)'`
+  # zzmoda = nil if zzmoda == ''
+  moda = get_most_recently_accessed_dir
+  # @log.warn "Error 2663 #{zzmoda} != #{moda}" if zzmoda != moda
   if moda && moda != ''
-    modf = `zsh -c 'print -rn -- #{moda}*(oa[1]M)'`
+
+    # get most recently accessed file in that directory
+    # NOTE: adding NULL_GLOB splits files on spaces
+    # FIXME: this zsh one gave a dir instead of file.
+    # zzmodf = `zsh -c 'print -rl -- #{moda}*(oa[1]M)'`.chomp
+    # zzmodf = nil if zzmodf == ''
+    modf = get_most_recently_accessed_file moda
+    # @log.warn "Error 2670 (#{zzmodf}) != (#{modf}) gmra in #{moda} #{zzmodf.class}, #{modf.class} : Loc: #{Dir.pwd}" if zzmodf != modf
+
+    raise "2784: #{modf}" if modf && !File.exist?(modf)
+
     insert_into_list moda, modf if modf && modf != ''
-    modm = `zsh -c 'print -rn -- #{moda}*(om[1]M)'`
+
+    # get most recently modified file in that directory
+    # zzmodm = `zsh -c 'print -rn -- #{moda}*(om[1]M)'`.chomp
+    modm = get_most_recently_modified_file moda
+    # zzmodm = nil if zzmodm == ''
+    # @log.debug "Error 2678 (gmrmf) #{zzmodm} != #{modm} in #{moda}" if zzmodm != modm
+    raise "2792: #{modm}" if modm && !File.exist?(modm)
+
     insert_into_list moda, modm if modm && modm != '' && modm != modf
   end
-  ## get last modified dir
-  modm = `zsh -c 'print -rn -- *(/om[1]M)'`
+
+  ## get most recently modified dir
+  # zzmodm = `zsh -c 'print -rn -- *(/om[1]M)'`
+  # zzmodm = nil if zzmodm == ''
+  modm = get_most_recently_modified_dir
+  # @log.debug "Error 2686 rmd #{zzmodm} != #{modm}" if zzmodm != modm
+
   if modm != moda
-    modmf = `zsh -c 'print -rn -- #{modm}*(oa[1]M)'`
+
+    # get most recently accessed file in that directory
+    # modmf = `zsh -c 'print -rn -- #{modm}*(oa[1]M)'`
+    modmf = get_most_recently_accessed_file modm
+    raise "2806: #{modmf}" if modmf && !File.exist?(modmf)
+
     insert_into_list modm, modmf
-    modmf1 = `zsh -c 'print -rn -- #{modm}*(om[1]M)'`
+
+    # get most recently modified file in that directory
+    # modmf11 = `zsh -c 'print -rn -- #{modm}*(om[1]M)'`
+    modmf1 = get_most_recently_modified_file modm
+    raise "2812: #{modmf1}" if modmf1 && !File.exist?(modmf1)
+
     insert_into_list(modm, modmf1) if modmf1 != modmf
   else
     # if both are same then our options get reduced so we need to get something more
@@ -2567,7 +2938,7 @@ def enhance_file_list
 end
 
 # insert important files to end of $files
-def insert_into_list(_dir, file)
+def insert_into_list _dir, file
   # ix = $files.index(dir)
   # raise "something wrong can find #{dir}." unless ix
   # $files.insert ix, *file
@@ -2579,33 +2950,96 @@ end
 # 2019-03-23 - not exactly clear what is happening XXX
 # this gets a directory (containing '/' at end)
 def get_important_files dir
+
   # checks various lists like visited_files and bookmarks
   # to see if files from this dir or below are in it.
   # More to be used in a dir with few files.
   list = []
   l = dir.size + 1
+
   # 2019-03-23 - i think we are getting the basename of the file
   #  if it is present in the given directory XXX
   $visited_files.each do |e|
     list << e[l..-1] if e.index(dir) == 0
   end
+
   # bookmarks if it starts with this directory then add it
   # FIXME it puts same directory cetus into the list with full path
   # We need to remove the base until this dir. get relative part
   list1 = $bookmarks.values.select do |e|
     e.index(dir) == 0 && e != dir
   end
+
   list.concat list1
   list
 end
 
+def get_most_recently_accessed_dir dir='.'
+  gmr dir, :directory?, :atime
+end
+
+def get_most_recently_accessed_file dir='.'
+  gmr dir, :file?, :atime
+end
+
+def get_most_recently_modified_file dir='.'
+  gmr dir, :file?, :mtime
+end
+
+def get_most_recently_modified_dir dir='.'
+  file = gmr dir, :directory?, :mtime
+end
+
+# get most recent file or directory, based on atime or mtime
+# dir is name of directory in which to get files, default is '.'
+# type is :file? or :directory?
+# func can be :mtime or :atime or :ctime or :birthtime
+def gmr dir, type, func
+  file = Dir.glob(dir + '/*')
+            .select { |f| File.send(type, f) }
+            .max_by { |f| File.send(func, f) }
+  file = File.basename(file) + '/' if file && type == :directory?
+  return file.gsub('//', '/') if file
+
+  nil
+end
+
+# return a list of entries sorted by mtime.
+# A / is added after to directories
+def get_files_by_mtime dir='*'
+  gfb dir, :mtime
+end
+
+def get_files_by_atime dir='.'
+  gfb dir, :atime
+end
+
+# get files ordered by mtime or atime, returning latest first
+# dir is dir to get files in, default '.'
+# func can be :atime or :mtime or even :size or :ftype
+def gfb dir, func
+  dir += '/*' if File.directory?(dir)
+  dir = dir.gsub('//', '/')
+
+  # sort by time and then reverse so latest first.
+  sorted_files = Dir[dir].sort_by { |f| File.send(func, f) }.reverse
+
+  # add slash to directories
+  sorted_files = add_slash sorted_files
+  return sorted_files
+  # sorted_files.map do |f|
+  # File.directory?(f) ? f + '/' : f
+  # end
+end
 # set message which will be displayed in status line
 def message mess
   $message = mess
 end
 
 def last_line
-  system "tput cup #{$glines} 0"
+  # system "tput cup #{$glines} 0"
+  # print "\e[#{$glines};0H"
+  tput_cup $glines, 0
 end
 
 def clear_status_line
@@ -2615,9 +3049,11 @@ def clear_status_line
   # %*s        - set blank spaces for entire line
   print "\e[33;4%sm%*s" % [$status_color || '1', $gcols, " "]
 end
+
 def print_on_right text
   sz = text.size
-  system "tput cup #{$glines} #{$gcols - sz -1}"
+  system "tput cup #{$glines} #{$gcols - sz - 1}"
+  # tput_cup $glines, $gcols - sz - 1
   print text
 end
 
@@ -2636,8 +3072,10 @@ def run
 
   setup_terminal
   config_read
+  parse_ls_colors
 
   redraw true
+  place_cursor
 
   # do we need this, have they changed after redraw
   $patt = nil
@@ -2646,18 +3084,25 @@ def run
   # forever loop that prints dir and takes a key
   loop do
 
-    # moved the printing out of here
-    # TODO we need to call it from where required
-
     key = get_char
     resolve_key key
+    if $movement && $old_cursor
+      clear_status_line
+      print_debug_info if @debug_flag
+      # we may want to print debug info if flag is on
+      place_cursor
+      $movement = false
+      next
+    end
     redraw rescan?
+    place_cursor
 
     break if $quitting
   end
   write_curdir
   puts 'bye'
   config_write if $writing
+  @log&.close
 end
 
 run