cerealize 0.8.5 → 0.8.6

data/CHANGES

@@ -1,8 +1,12 @@
 = cerealize changes history
 
+== cerealize 0.8.6 -- 2010-09-29
+
+* Make sure attr_hash didn't get saved setting the same value.
+
 == cerealize 0.8.5 -- 2010-09-29
 
-* Fix a bug that nil can't be set in cerealized column.
+* Fixed a bug that nil can't be set in cerealized column.
   This shows the bug:
 
     apple = Apple.find(Apple.create(:data => [5]).id)

data/README

@@ -1,4 +1,4 @@
-= cerealize 0.8.3
+= cerealize 0.8.6
 by Cardinal Blue ( http://cardinalblue.com )
 
 == LINKS:

data/README.rdoc

@@ -1,4 +1,4 @@
-= cerealize 0.8.3
+= cerealize 0.8.6
 by Cardinal Blue ( http://cardinalblue.com )
 
 == LINKS:

data/cerealize.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{cerealize}
-  s.version = "0.8.5"
+  s.version = "0.8.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Cardinal Blue", "Lin Jen-Shin (aka godfat 真常)", "Jaime Cham"]

data/lib/cerealize/attr_hash.rb

@@ -13,13 +13,16 @@ module Cerealize
           end
 
           def #{attr}= value
+            self.#{property} ||= {}
+
             # this line fixes the quirks in ActiveRecord 2.3.9 at
             # activerecord-2.3.9/lib/active_record/associations/association_collection.rb:L352-L363
             # when we're using associations and STI, thanks Jaime
             # TODO: test for this?
-            #{property}_will_change! if respond_to? :#{property}_will_change!
+            #{property}_will_change! if
+              respond_to?(:#{property}_will_change!) &&
+              #{property}[:#{attr}] != value
 
-            self.#{property} ||= {}
             #{property}[:#{attr}] = value
           end
         RUBY

data/lib/cerealize/version.rb

@@ -1,4 +1,4 @@
 
 module Cerealize
-  VERSION = '0.8.5'
+  VERSION = '0.8.6'
 end

data/test/real.rb

@@ -64,4 +64,5 @@ end
 
 ActiveRecord::Base.connection.create_table :apples, :force => true do |t|
   t.text :data
+  t.timestamps :updated_at
 end

data/test/test_attr_hash.rb

@@ -25,6 +25,21 @@ class AttrHashTest < Test::Unit::TestCase
     assert_nil Apple.new.data
   end
 
+  def test_dont_save_twice
+    apple = Apple.create(:name => 'banana')
+    assert apple.updated_at
+
+    Apple.record_timestamps = false
+    apple.update_attributes(:updated_at => nil)
+    Apple.record_timestamps = true
+    apple2 = Apple.find(apple.id)
+    assert_equal nil, apple2.updated_at
+    apple2.update_attributes :name => 'banana'
+    assert_equal nil, apple2.updated_at
+    apple2.update_attributes :name => 'pineapple'
+    assert apple2.updated_at
+  end
+
   def simple_case hh, ah
     assert_equal hh[:name], ah.name
     assert_equal hh[:size], ah.size

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 8
-  - 5
-  version: 0.8.5
+  - 6
+  version: 0.8.6
 platform: ruby
 authors: 
 - Cardinal Blue