cerbero 0.0.1 → 0.0.2

data/README.md

@@ -1,6 +1,6 @@
 # Cerbero
 
-Uniqueness validation do not guarantee uniqueness. Only the database
+Uniqueness validation does not guarantee uniqueness. Only the database
 constraints do this. But there is a flaw - when database constraints
 fail, an exception is thrown, and even when we catch it, the validation
 error is not set.
@@ -36,6 +36,11 @@ and in your migration:
 add_index :users, [:email, :company_id], unique: true
 ```
 
+__Important:__ you should add both validation and db constraint. If you
+don't supply validation, you'll have `save` returning `false`, yet no
+validation errors will be displayed, which is a strange and obscure
+behavior.
+
 Then if the gem is required, it makes the stuff work so that when the
 uniqueness validtion lets you in, but the database constraint then
 fails, `save` returns `false`, then uniqueness validation is re-run and
@@ -53,6 +58,10 @@ provide some code:
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
 
+## Contributors
+
+* [Andry Conchin](https://github.com/andrykonchin)
+
 ## TODO:
 
 - Apply a cleaner pattern to test via multiple databases.

data/gemfiles/activerecord30.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/dak/projects/cerbero
   specs:
-    cerbero (0.0.1)
+    cerbero (0.0.2)
       activerecord (>= 3.0.0)
 
 GEM

data/gemfiles/activerecord31.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/dak/projects/cerbero
   specs:
-    cerbero (0.0.1)
+    cerbero (0.0.2)
       activerecord (>= 3.0.0)
 
 GEM

data/gemfiles/activerecord32.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/dak/projects/cerbero
   specs:
-    cerbero (0.0.1)
+    cerbero (0.0.2)
       activerecord (>= 3.0.0)
 
 GEM

data/lib/cerbero.rb

@@ -1,9 +1,9 @@
 require "cerbero/version"
 
 class ActiveRecord::Base
-  def save
+  def save(*args)
     super
-  rescue ActiveRecord::RecordNotUnique, ActiveRecord::StatementInvalid
+  rescue ActiveRecord::StatementInvalid
     valid?
     false
   end

data/lib/cerbero/version.rb

@@ -1,3 +1,3 @@
 module Cerbero
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/cerbero_spec.rb

@@ -18,7 +18,7 @@ describe 'cerbero' do
     user.errors[:email].should_not be_blank
   end
 
-  it 'gives validation error when database constraint throws error' do
+  it 'is not pokemon exception handling' do
     User.create! :email => 'test@mailinator.com', :company_id => 25
 
     stub_uniqueness_validation!
@@ -26,4 +26,11 @@ describe 'cerbero' do
       UserWithSaveError.create :email => 'test@mailinator.com', :company_id => 25
     }.should raise_error(RuntimeError)
   end
+
+  it 'supports saving with options' do
+    lambda {
+      user = User.new :email => 'test@mailinator.com', :company_id => 25
+      user.save(:validation => true)
+    }.should_not raise_error
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cerbero
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-10 00:00:00.000000000 Z
+date: 2012-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -135,7 +135,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2835968287369647992
+      hash: -738609250160776711
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -144,7 +144,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2835968287369647992
+      hash: -738609250160776711
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23