celsius-primo_ubpb 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4878f6998457988e3ef1735d6eab10743d9eaa5a
-  data.tar.gz: 3b8dbc8258a646e566e13078965a5e00de9740d0
+  metadata.gz: dcd45846cf55850b43a088fbb815d3e9babd197f
+  data.tar.gz: 9bf625abc36c1201b11c73cd2554f809c1b3db16
 SHA512:
-  metadata.gz: d68def5e622882c395040ed7b443c4a34c0d1b044ad2c0e424edaf9e18362ab0305b0a1e68d90b615a07a92ee857814b19015bc0efc071eef008aa1e54211a3d
-  data.tar.gz: 35f1093199e0a4e5325a4f91eb4ed62a62c13edb31e3f6e2c58edadfe23483f5b86d15ad89d27ce0aacac8f66550e3f50379ebcd7af68bb4024eb8361300622a
+  metadata.gz: e8c411a764cb2dacc24429c721ea3602aa8b462101adb44d0a596ff44b92d8add81079349e84b8916c2e3fc0a6fa53461cb0e48ce9fc7bbfcb084ee0c1b22903
+  data.tar.gz: 4b9e93dde6062973171867c5df80f21ecd2649b28af9ed57d8746c520107abc65a435e6d2254bd43385b1b267d0fcbf7b3bc7836bd68ed87baf6d6f566845d03

data/Gemfile

@@ -6,7 +6,8 @@ gemspec
 gem "codeclimate-test-reporter", group: :test, require: nil
 
 gem "pry",                "~> 0.9.12.6"
-gem "pry-nav",            "~> 0.2.3"
+gem "pry-byebug",         "<= 1.3.2"
+gem "pry-rescue",         "~> 1.4.1"
 gem "pry-stack_explorer", "~> 0.4.9.1"
 gem "pry-syntax-hacks",   "~> 0.0.6"
 

data/lib/celsius/primo_ubpb/adapter/search/search_result_transformation/make_facet_creationdate_histogram_facet.rb

@@ -4,7 +4,7 @@ class Celsius::PrimoUbpb::Adapter::Search::SearchResultTransformation::
   MakeFacetCreationdateHistogramFacet < Celsius::Transformation::Step
 
   def call
-    target["facets"]["facet_creationdate"].tap do |facet_creationdate|
+    if facet_creationdate = target["facets"]["facet_creationdate"]
       facet_creationdate["_type"] = "histogram"
       facet_creationdate["entries"] = facet_creationdate["terms"]
       facet_creationdate.delete("terms")

data/lib/celsius/primo_ubpb/version.rb

@@ -1,5 +1,5 @@
 module Celsius
   module PrimoUbpb
-    VERSION = "0.1.2"
+    VERSION = "0.1.3"
   end
 end

data/spec/assets/adapter/search/empty_search_result.yml

@@ -0,0 +1,36 @@
+---
+took: 
+hits:
+  hits: []
+  total: 0
+facets:
+  facet_tlevel:
+    _type: terms
+    terms: []
+  facet_creator:
+    _type: terms
+    terms: []
+  facet_local31:
+    _type: terms
+    terms: []
+  facet_topic:
+    _type: terms
+    terms: []
+  facet_creationdate:
+    _type: histogram
+    entries: []
+  facet_domain:
+    _type: terms
+    terms: []
+  facet_lang:
+    _type: terms
+    terms: []
+  facet_local15:
+    _type: terms
+    terms: []
+  facet_local32:
+    _type: terms
+    terms: []
+  facet_local33:
+    _type: terms
+    terms: []

data/spec/assets/adapter/search/search_request_with_empty_result.yml

@@ -0,0 +1,54 @@
+---
+facets:
+  facet_tlevel:
+    terms:
+      field: facet_tlevel
+      shard_size: 75
+  facet_creator:
+    terms:
+      field: facet_creator
+      shard_size: 75
+  facet_local31:
+    terms:
+      field: facet_local31
+      shard_size: 75
+  facet_topic:
+    terms:
+      field: facet_topic
+      shard_size: 75
+  facet_creationdate:
+    terms:
+      field: facet_creationdate
+      shard_size: 75
+  facet_domain:
+    terms:
+      field: facet_domain
+      shard_size: 75
+  facet_lang:
+    terms:
+      field: facet_lang
+      shard_size: 75
+  facet_local15:
+    terms:
+      field: facet_local15
+      shard_size: 75
+  facet_local32:
+    terms:
+      field: facet_local32
+      shard_size: 75
+  facet_local33:
+    terms:
+      field: facet_local33
+      shard_size: 75
+from: 0
+query:
+  bool:
+    must:
+    - query_string:
+        default_operator: AND
+        fields:
+        - _all
+        query: fooobasdasd
+size: 20
+sort:
+- _score

data/spec/assets/adapter/search/search_result.yml

@@ -748,6 +748,9 @@ facets:
       key: '2009'
     - count: 1
       key: '2010'
+  facet_domain:
+    _type: terms
+    terms: []
   facet_lang:
     _type: terms
     terms:

data/spec/cassettes/Celsius_PrimoUbpb_Adapter/_search/returns_a_ubpb_extended_search_result.yml

@@ -1166,4 +1166,89 @@ http_interactions:
         Michael&quot;,&quot;&#xD6;ggl, Bernd&quot;]}&lt;/lad01&gt; \n&lt;/addata&gt;\n&lt;/record&gt;&lt;/PrimoNMBib&gt;&lt;sear:LINKS&gt;&lt;sear:thumbnail/&gt;&lt;sear:linktotoc&gt;errorPage&lt;/sear:linktotoc&gt;&lt;/sear:LINKS&gt;&lt;/sear:DOC&gt;&lt;/sear:DOCSET&gt;&lt;/sear:RESULT&gt;&lt;sear:searchToken&gt;0&lt;/sear:searchToken&gt;&lt;/sear:JAGROOT&gt;&lt;/sear:SEGMENTS&gt;</searchBriefReturn></ns1:searchBriefResponse></soapenv:Body></soapenv:Envelope>"
     http_version: 
   recorded_at: Tue, 20 Jan 2015 13:42:42 GMT
+- request:
+    method: post
+    uri: http://primo.kobv.de/primo_library/libweb/webservices/services/searcher
+    body:
+      encoding: UTF-8
+      string: |
+        <?xml version="1.0" encoding="UTF-8"?>
+        <env:Envelope xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:impl="http://primo.kobv.de/PrimoWebServices/services/searcher" xmlns:env="http://schemas.xmlsoap.org/soap/envelope/" xmlns:ins0="http://xml.apache.org/xml-soap">
+          <env:Body>
+            <impl:searchBrief>
+              <searchRequestStr>
+                <![CDATA[
+        <searchRequest xmlns="http://www.exlibris.com/primo/xsd/wsRequest" xmlns:uic="http://www.exlibris.com/primo/xsd/primoview/uicomponents">
+          <PrimoSearchRequest xmlns="http://www.exlibris.com/primo/xsd/search/request">
+            <QueryTerms>
+              <BoolOpeator>AND</BoolOpeator>
+              <QueryTerm>
+                <IndexField>any</IndexField>
+                <PrecisionOperator>contains</PrecisionOperator>
+                <Value>fooobasdasd</Value>
+              </QueryTerm>
+            </QueryTerms>
+            <StartIndex>1</StartIndex>
+            <BulkSize>20</BulkSize>
+            <DidUMeanEnabled>false</DidUMeanEnabled>
+            <HighlightingEnabled>false</HighlightingEnabled>
+            <Languages>
+              <Language>ger</Language>
+              <Language>eng</Language>
+            </Languages>
+            <SortByList>
+              <SortField>relevance</SortField>
+            </SortByList>
+            <Locations>
+              <uic:Location type="local" value="scope:(PAD_ALEPH)"/>
+            </Locations>
+          </PrimoSearchRequest>
+          <onCampus>false</onCampus>
+          <institution>PAD</institution>
+        </searchRequest>
+        ]]>
+              </searchRequestStr>
+            </impl:searchBrief>
+          </env:Body>
+        </env:Envelope>
+    headers:
+      Content-Type:
+      - application/xml
+      Soapaction:
+      - searchBrief
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - Apache-Coyote/1.1
+      Set-Cookie:
+      - JSESSIONID=5CCAF81FB7AB54ADEDAB747530A2C159; Path=/primo_library/libweb/;
+        HttpOnly
+      Vary:
+      - Accept-Encoding
+      Content-Type:
+      - text/xml;charset=utf-8
+      Transfer-Encoding:
+      - chunked
+      Date:
+      - Thu, 22 Jan 2015 09:08:23 GMT
+    body:
+      encoding: UTF-8
+      string: <?xml version="1.0" encoding="UTF-8"?><soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/"
+        xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"><soapenv:Body><ns1:searchBriefResponse
+        soapenv:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/" xmlns:ns1="http://primo.kobv.de/PrimoWebServices/services/searcher"><searchBriefReturn
+        xsi:type="soapenc:string" xmlns:soapenc="http://schemas.xmlsoap.org/soap/encoding/">&lt;sear:SEGMENTS
+        xmlns:sear=&quot;http://www.exlibrisgroup.com/xsd/jaguar/search&quot;&gt;&lt;sear:JAGROOT&gt;&lt;sear:RESULT&gt;&lt;sear:QUERYTRANSFORMS/&gt;&lt;sear:FACETLIST/&gt;&lt;sear:DOCSET
+        HIT_TIME=&quot;72&quot; TOTALHITS=&quot;0&quot; FIRSTHIT=&quot;1&quot; LASTHIT=&quot;0&quot;
+        TOTAL_TIME=&quot;81&quot; IS_LOCAL=&quot;true&quot;/&gt;&lt;/sear:RESULT&gt;&lt;sear:searchToken&gt;0&lt;/sear:searchToken&gt;&lt;/sear:JAGROOT&gt;&lt;/sear:SEGMENTS&gt;</searchBriefReturn></ns1:searchBriefResponse></soapenv:Body></soapenv:Envelope>
+    http_version: 
+  recorded_at: Thu, 22 Jan 2015 09:08:21 GMT
 recorded_with: VCR 2.9.3

data/spec/celsius-primo_ubpb/adapter_spec.rb

@@ -29,11 +29,19 @@ describe Celsius::PrimoUbpb::Adapter do
   end
 
   describe "#search" do
+    asset_dir = "adapter/search"
+
     it "returns a ubpb extended search result", :vcr do
-      search_request = YAML.load(read_asset("adapter/search/search_request.yml"))
-      expected_search_result = YAML.load(read_asset("adapter/search/search_result.yml"))
-      
-      expect(adapter.search(search_request)).to eq(expected_search_result)
+      [
+        ["#{asset_dir}/search_request.yml", "#{asset_dir}/search_result.yml"],
+        ["#{asset_dir}/search_request_with_empty_result.yml", "#{asset_dir}/empty_search_result.yml"]
+      ]
+      .each do |search_request_yaml_filename, search_response_yaml_filename|
+        search_request = YAML.load(read_asset(search_request_yaml_filename))
+        expected_search_result = YAML.load(read_asset(search_response_yaml_filename))
+
+        expect(search_result = adapter.search(search_request)).to eq(expected_search_result)
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: celsius-primo_ubpb
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Michael Sievers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-21 00:00:00.000000000 Z
+date: 2015-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: celsius
@@ -163,8 +163,9 @@ files:
 - lib/celsius/primo_ubpb/locales/de.yml
 - lib/celsius/primo_ubpb/locales/en.yml
 - lib/celsius/primo_ubpb/version.rb
-- spec/assets/adapter/search/celsius_primo_search_result.yml
+- spec/assets/adapter/search/empty_search_result.yml
 - spec/assets/adapter/search/search_request.yml
+- spec/assets/adapter/search/search_request_with_empty_result.yml
 - spec/assets/adapter/search/search_result.yml
 - spec/cassettes/Celsius_PrimoUbpb_Adapter/_search/returns_a_ubpb_extended_search_result.yml
 - spec/celsius-primo_ubpb/adapter_spec.rb
@@ -195,8 +196,9 @@ signing_key:
 specification_version: 4
 summary: Ubpb specific primo celsius adapter
 test_files:
-- spec/assets/adapter/search/celsius_primo_search_result.yml
+- spec/assets/adapter/search/empty_search_result.yml
 - spec/assets/adapter/search/search_request.yml
+- spec/assets/adapter/search/search_request_with_empty_result.yml
 - spec/assets/adapter/search/search_result.yml
 - spec/cassettes/Celsius_PrimoUbpb_Adapter/_search/returns_a_ubpb_extended_search_result.yml
 - spec/celsius-primo_ubpb/adapter_spec.rb