celluloid-eventsource 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b3dbbbc109063bca1fc5bb81a4034ca39438f48f
-  data.tar.gz: ac911968885e272b5b6e1e3d669e526196a304e3
+  metadata.gz: a04973c2d3ee62344eea60784a41fbc3e386d851
+  data.tar.gz: 9ae2e87a728c6a96d18148d9a5cfbac93ea951f4
 SHA512:
-  metadata.gz: 12975ec688913ea7370198f848b910bfc2f5290c370714cf39303122c6ee1a7fbb9095a689306273be2f56098d20a05a3423531a6cc5fb02c56437de30e8b67a
-  data.tar.gz: 067be06d38ce78d5c95e8105031363cbfa206d3efec7f72aeab245de75baaaa8a6fe41b9dec915501b567af63f9d28638d58806552ee0631dedc6c0c4561c3d5
+  metadata.gz: 8ddf468f93cfb7d72cca9b59b2bfe2dd482671f73db5c8dace8bd9384f9710d6ecb3f9c568a043445816dfbcd1a0d26f6ba84156a346718a319d8202d3b79916
+  data.tar.gz: 0d2eb65594cd71fcc5529b4af985bf9d7483b9b1ed2eee62c9649f85bc9fa60e9dd0f26a925f594e0c56dc8f50f3f3fc252200703890fb4c0b97547b01ddf07b

data/.gitignore

@@ -5,6 +5,7 @@
 .yardoc
 .ruby-version
 .ruby-gemset
+examples/
 Gemfile.lock
 InstalledFiles
 _yardoc

data/README.md

@@ -51,7 +51,7 @@ es = Celluloid::EventSource.new("http://example.com/") do |conn|
   end
 
   conn.on_error do |message|
-    puts "Error message #{message}"
+    puts "Response status #{message[:status_code]}, Response body #{message[:body]}"
   end
 
   conn.on(:time) do |event|

data/lib/celluloid/eventsource/version.rb

@@ -1,5 +1,5 @@
 module Celluloid
   class EventSource
-    VERSION = "0.1.0"
+    VERSION = "0.2.0"
   end
 end

data/lib/celluloid/eventsource.rb

@@ -101,8 +101,11 @@ module Celluloid
       end
 
       if @parser.status_code != 200
+        until @socket.eof?
+          @parser << @socket.readline
+        end
         close
-        @on[:error].call("Unable to establish connection. Response status #{@parser.status_code}")
+        @on[:error].call({status_code: @parser.status_code, body: @parser.chunk})
       end
 
       handle_headers(@parser.headers)
@@ -174,7 +177,7 @@ module Celluloid
         @on[:open].call
       else
         close
-        @on[:error].call("Invalid Content-Type #{headers['Content-Type']}. Expected text/event-stream")
+        @on[:error].call({status_code: @parser.status_code, body: "Invalid Content-Type #{headers['Content-Type']}. Expected text/event-stream"})
       end
     end
 

data/spec/celluloid/eventsource/response_parser_spec.rb

@@ -9,6 +9,7 @@ Content-Type: text/html; charset=UTF-8
 Content-Length: 131
 X_CASE_HEADER: foo
 X_Mixed-Case: bar
+x-lowcase-header: hello
 eos
 }
 
@@ -56,7 +57,8 @@ eos
   it 'makes response headers canonicalized' do
     streamed(response_string) { |line| parser << line }
     expected_headers = {
-      'X-Mixed-Case' => 'bar', 'Content-Type' => 'text/html; charset=UTF-8', 'Content-Length' => "131", 'X-Case-Header' => 'foo'
+      'X-Mixed-Case' => 'bar', 'Content-Type' => 'text/html; charset=UTF-8', 'Content-Length' => "131",
+      'X-Case-Header' => 'foo', 'X-Lowcase-Header' => "hello"
     }
     expect(parser.headers).to include(expected_headers)
   end

data/spec/celluloid/eventsource_spec.rb

@@ -78,6 +78,31 @@ RSpec.describe Celluloid::EventSource do
     end
   end
 
+  it 'receives response body through error event' do
+    with_sse_server do |server|
+      expect { |error|
+        ces = Celluloid::EventSource.new("http://localhost:63310/error") do |conn|
+          conn.on_error(&error)
+        end
+
+        sleep TIMEOUT until ces.closed?
+
+      }.to yield_with_args({status_code: 400, body:"blop"})
+    end
+  end
+
+  it 'receives response without a body through error event' do
+    with_sse_server do |server|
+      expect { |error|
+        ces = Celluloid::EventSource.new("http://localhost:63310/error/no_body") do |conn|
+          conn.on_error(&error)
+        end
+
+        sleep TIMEOUT until ces.closed?
+
+      }.to yield_with_args({status_code: 400, body:""})
+    end
+  end
 
   it 'receives custom events through event handlers' do
     with_sse_server do |server|

data/spec/spec_helper.rb

@@ -87,7 +87,15 @@ class ServerSentEvents < Reel::Server::HTTP
 
   def on_connection(connection)
     connection.each_request do |request|
-      handle_request(request)
+      if request.path == '/error'
+        request.respond :bad_request, {'Content-Type' => 'application/json; charset=UTF-8'}, "blop"
+        request.close
+      elsif request.path == '/error/no_body'
+        request.respond :bad_request, {'Content-Type' => 'application/json; charset=UTF-8'}
+        request.close
+      else
+        handle_request(request)
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: celluloid-eventsource
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Leo Correa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-14 00:00:00.000000000 Z
+date: 2014-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: celluloid-io