celluloid-benchmark 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e9c3d7d1944efb1aaf1bad886c4b908e85091c60
-  data.tar.gz: e279f4774b8790d66c6acde77963cb8e7865e53b
+  metadata.gz: 87902d700dba56fd25b4d8a800780d3ad537632d
+  data.tar.gz: f15b09d76bd846a93921e349860557730284391f
 SHA512:
-  metadata.gz: 80245cd323174a52cdeb6f6cd71ade1fd02491793086b76fb0eb4608781ea5c415bf74fa8171b7ac9fcf8b0e34bbc6fc19779d0288dff493b51dac5d1c93d266
-  data.tar.gz: 35c665225dc623b5eecc11d19b7f8fecba92d3b23cb1849da98e89cfbbce884d83cf0f7e13c71affc048565a4d1ff86891c7ede5a59f5ebb980f3203b7ee1d05
+  metadata.gz: 4f3dde3a1daeb364b7c4c9e648087ef65c7a2684aa3befdbf09027abfed02d927a33f811ac7e3d8faa97de8e32f5da8cebe2459536024478895b034e6e3b2867
+  data.tar.gz: 5bbe5bb2e854a9acc7459ea6bfcfba0f35c832ffbb9c43ead4433fb27a77f93543e935000dcdf4e1e838b86c68852ab77a98713baeb5f184a67b93d9c5da57a4

data/lib/celluloid_benchmark/benchmark_run.rb

@@ -62,7 +62,10 @@ module CelluloidBenchmark
 
     def network_time
       requests = network_times.values.flatten
-      requests.reduce(:+) / requests.size
+
+      if requests.size > 0
+        requests.reduce(:+) / requests.size
+      end
     end
 
     def benchmarks

data/lib/celluloid_benchmark/data_sources.rb

@@ -15,8 +15,17 @@ module CelluloidBenchmark
     end
 
     def data_source(key)
+      raise_empty(key) if empty?(key)
       data_sources[key]
     end
+
+    def raise_empty(key)
+      raise "Empty random data for '#{key}'. Ensure target has test data and run rake app:performance:get_random_data."
+    end
+
+    def empty?(key)
+      data_sources[key].size == 0
+    end
   end
 end
 

data/lib/celluloid_benchmark/version.rb

@@ -1,3 +1,3 @@
 module CelluloidBenchmark
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/lib/celluloid_benchmark/visitor.rb

@@ -16,7 +16,7 @@ module CelluloidBenchmark
 
     def_delegators :@browser, :add_auth, :submit, :transact
 
-    attr_reader :benchmark_run
+    attr_accessor :benchmark_run
     attr_accessor :browser
     attr_accessor :current_request_label
     attr_accessor :current_request_threshold
@@ -79,36 +79,17 @@ module CelluloidBenchmark
       end
     end
 
-
-    private
-
-    def add_browser_timing_hooks
-      browser.pre_connect_hooks << proc do |agent, request|
-        self.request_start_time = Time.now
-      end
-
-      browser.post_connect_hooks << proc do |agent, uri, response, body|
-        self.request_end_time = Time.now
-      end
-    end
-
-    def server_response_time(page)
-      if page && page["x-runtime"]
-        page["x-runtime"].to_f
-      end
-    end
-
     def log_response(page)
-      if benchmark_run
-        benchmark_run.async.log(
-          page.code,
-          request_start_time,
-          request_end_time,
-          server_response_time(page),
-          current_request_label,
-          current_request_threshold
-        )
-      end
+      benchmark_run.async.log(
+        page.code,
+        request_start_time,
+        request_end_time,
+        server_response_time(page),
+        current_request_label,
+        current_request_threshold
+      )
+
+      true
     end
 
     def log_response_code_error(error)
@@ -117,9 +98,11 @@ module CelluloidBenchmark
         error.response_code,
         request_start_time,
         request_end_time,
+        server_response_time(browser.current_page),
         current_request_label,
         current_request_threshold
       )
+      true
     end
 
     def log_network_error(error)
@@ -128,9 +111,30 @@ module CelluloidBenchmark
         500,
         request_start_time,
         request_end_time,
+        server_response_time(browser.current_page),
         current_request_label,
         current_request_threshold
       )
+      true
+    end
+
+
+    private
+
+    def add_browser_timing_hooks
+      browser.pre_connect_hooks << proc do |agent, request|
+        self.request_start_time = Time.now
+      end
+
+      browser.post_connect_hooks << proc do |agent, uri, response, body|
+        self.request_end_time = Time.now
+      end
+    end
+
+    def server_response_time(page)
+      if page && page["x-runtime"]
+        page["x-runtime"].to_f
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: celluloid-benchmark
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Scott Willson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-05 00:00:00.000000000 Z
+date: 2015-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: celluloid