cellect-client 2.1.1 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 629d4f83d1f5203b9daac11d92da40ed592a0f33
-  data.tar.gz: 7225f6c225eaf55deaa1e28c2e051bc31bad222b
+  metadata.gz: 1078227bba61ad301cc8455264181baf5fd6cd87
+  data.tar.gz: 66a0abcc056d63bd77c0b0d6fd49b1e0f65c2e12
 SHA512:
-  metadata.gz: 32f22dfd59946343e81873f938c4bfad24b8f32ae55216516a8d37664755352c2b871109e980e840fa6ab6c500846a8a9d8f422b162676d52591ab6b78e9747a
-  data.tar.gz: 686c2f16afef3cd6a0f58c5fdd41436eda271e97279930a8a838ba18a58f49ad872943fdb6cceff1be7a3afa2acfb7e806c25d24b700d2a80ec83f3190fcae15
+  metadata.gz: 20f5686575a9f73df5df7d9d811eac8663b469769a0f83e5eb19bbc9895ab11ee33d7e63c5baf5869331fe4687d3987d9e8a649c326a3cd55d1865d375d4acae
+  data.tar.gz: 95431db5865b17a590f44beac3e3f8fa6c2904d3969ab0fa670a275d745008443c59ba5817302e179a48021812137e274036a3e98ddb2f48283599afcc2419b6

data/.travis.yml

@@ -13,3 +13,10 @@ rvm:
 script: bundle exec rake spec
 services:
   - redis-server
+
+addons:
+  code_climate:
+    repo_token: $CODECLIMATE_REPO_TOKEN
+
+after_success:
+  - bundle exec codeclimate-test-reporter

data/cellect.gemspec

@@ -29,7 +29,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'puma', '~> 2.8'
   spec.add_development_dependency 'pg', '~> 0.17'
   spec.add_development_dependency 'connection_pool', '~> 2.0'
-  spec.add_development_dependency 'codeclimate-test-reporter'
+  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "codeclimate-test-reporter", "~> 1.0.0"
 
   spec.add_runtime_dependency 'cellect-server', Cellect::VERSION
   spec.add_runtime_dependency 'cellect-client', Cellect::VERSION

data/lib/cellect/version.rb

@@ -1,3 +1,3 @@
 module Cellect
-  VERSION = '2.1.1'
+  VERSION = '3.0.0'
 end

data/spec/spec_helper.rb

@@ -1,5 +1,5 @@
-require 'codeclimate-test-reporter'
-CodeClimate::TestReporter.start
+require "simplecov"
+SimpleCov.start
 
 CELLECT_ROOT = File.expand_path File.join(File.dirname(__FILE__), '../')
 

data/spec/support/shared_examples_for_loader.rb

@@ -0,0 +1,42 @@
+shared_examples_for 'loader' do |name|
+  let(:fixtures) do
+    Cellect::Server
+      .adapter
+      .fixtures
+      .fetch(workflow.name, { })
+      .fetch('entries', [])
+  end
+  let(:fixture_count) { fixtures.count }
+
+  describe "#load_data" do
+    it "should use the server adapter to load data" do
+      expect(Cellect::Server.adapter)
+        .to receive(:load_data_for)
+        .with(workflow.name)
+        .and_call_original
+      loader.load_data
+    end
+
+    it "should mark the workflow as loaded" do
+      expect { loader.load_data }.to change { workflow.state }.to(:ready)
+    end
+  end
+
+  describe "#reload_data" do
+    it "should replace the existing subjects with the reloaded set" do
+      expect {
+        loader.reload_data(subjects)
+      }.to change {
+        workflow.subjects
+      }.to(subjects)
+    end
+
+    it "should mark the workflow as ready" do
+      expect {
+        loader.reload_data(subjects)
+      }.to change {
+        workflow.state
+      }.to(:ready)
+    end
+  end
+end

data/spec/support/shared_examples_for_workflow.rb

@@ -1,10 +1,4 @@
 shared_examples_for 'workflow' do |name|
-  let(:obj){ send name }
-
-  before(:each) do
-    Cellect::Server.adapter.load_workflow obj.name
-  end
-
   it 'should add singleton instances to the registry' do
     expect(obj.class[obj.name]).to be_a_kind_of Cellect::Server::Workflow
     expect(obj.class[obj.name].object_id).to eq obj.class[obj.name].object_id
@@ -14,8 +8,12 @@ shared_examples_for 'workflow' do |name|
     expect(obj.name).to be_a String
     expect(obj.users).to be_a Hash
 
-    set_klass = obj.prioritized? ? DiffSet::PrioritySet : DiffSet::RandomSet
-    expect(obj.subjects).to be_a set_klass
+    if obj.grouped?
+      expect(obj.subjects).to eq({})
+    else
+      set_klass = obj.prioritized? ? DiffSet::PrioritySet : DiffSet::RandomSet
+      expect(obj.subjects).to be_a set_klass
+    end
   end
 
   it 'should provide a user lookup' do
@@ -23,4 +21,82 @@ shared_examples_for 'workflow' do |name|
     expect(obj.user(1).object_id).to eq obj.user(1).object_id
     expect(obj.users.keys).to include 1
   end
+
+  context "with a celluloid stubbed async loader" do
+    let(:loader) do
+      if obj.grouped?
+        Cellect::Server::GroupedLoader.new(obj)
+      else
+        Cellect::Server::Loader.new(obj)
+      end
+    end
+    let(:celluloid_target) { loader.wrapped_object }
+
+    before do
+      allow(obj.wrapped_object).to receive(:data_loader).and_return(loader)
+      allow(loader).to receive(:async).and_return(loader)
+    end
+
+    describe '#load_data' do
+      it 'should request data from the loader' do
+        expect(celluloid_target).to receive(:load_data)
+        obj.load_data
+      end
+
+      it 'should not attempt to reload subjects when in ready state' do
+        obj.state = :ready
+        expect(celluloid_target).not_to receive(:load_data)
+        obj.load_data
+      end
+    end
+
+    describe '#reload_data' do
+      context "able to reload" do
+        before do
+          obj.can_reload_at = Time.now - 1
+          obj.state = :ready
+        end
+
+        it 'should request data from the loader' do
+          expect(celluloid_target)
+            .to receive(:reload_data)
+            .with(instance_of(obj.subjects.class))
+          obj.reload_data
+        end
+
+        it 'should not reload subjects when state is in any kind of loading' do
+          %i(reloading loading).each do |state|
+            obj.state = state
+            expect(celluloid_target).not_to receive(:reload_data)
+            obj.reload_data
+          end
+        end
+      end
+
+      it 'should not allow reloading until after loading' do
+        expect(celluloid_target).not_to receive(:reload_data)
+        obj.reload_data
+      end
+
+      context "after initial data load" do
+        before do
+          obj.state = :ready
+          obj.set_reload_at_time
+        end
+
+        it 'should not allow reloading after first load' do
+          expect(celluloid_target).not_to receive(:reload_data)
+          obj.reload_data
+        end
+
+        context "when reload time gaurds has past" do
+          it 'should allow reloading after timer has reset' do
+            obj.can_reload_at = Time.now - 1
+            expect(celluloid_target).to receive(:reload_data)
+            obj.reload_data
+          end
+        end
+      end
+    end
+  end
 end

data/spec/support/spec_adapter.rb

@@ -10,7 +10,12 @@ class SpecAdapter < Cellect::Server::Adapters::Default
   end
 
   def load_data_for(workflow_name)
-    fixtures.fetch(workflow_name, { }).fetch 'entries', []
+    entries = fixtures.fetch(workflow_name, { }).fetch 'entries', []
+    if block_given?
+      entries.each { |entry| yield entry }
+    else
+      entries
+    end
   end
 
   def fixtures

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cellect-client
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 3.0.0
 platform: ruby
 authors:
 - Michael Parrish
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-09 00:00:00.000000000 Z
+date: 2017-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -209,6 +209,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/cellect_helper.rb
 - spec/support/shared_api_context.rb
+- spec/support/shared_examples_for_loader.rb
 - spec/support/shared_examples_for_set.rb
 - spec/support/shared_examples_for_workflow.rb
 - spec/support/spec_adapter.rb
@@ -254,6 +255,7 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/cellect_helper.rb
 - spec/support/shared_api_context.rb
+- spec/support/shared_examples_for_loader.rb
 - spec/support/shared_examples_for_set.rb
 - spec/support/shared_examples_for_workflow.rb
 - spec/support/spec_adapter.rb