cdigits 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bb6c4b993ed0c2d9ae35c5900b85b12f663c65b0fadea88c572734e79b925351
-  data.tar.gz: ba3cceb4188ff489c3b9f7aac535a90a80eaaad47582b8e52dbfe005c244db60
+  metadata.gz: ee3bdcddd0d7d2725e9744ae11f557404e1555cbbc5487940ca45854efca3a76
+  data.tar.gz: 87ca68f822cc714e4e2f3b38ffc94c54adf073fb11146251e1e278c59b0bd9e1
 SHA512:
-  metadata.gz: 2c01c99b794d798ada867b0dd07b6dcf2f45b7477e36c61b2640e15cf6f448f1ca08aa3a0f482837899cd41a5a983cbde9342de1037962de9eb583643991c35d
-  data.tar.gz: aa6b66c35b3af0377d45cf74b99c30f40c62b5844017112de1dd576cf2cfee69539fa735719085b198023559b1107fbd655bb2870c7ee24071112f6fc3ce7cad
+  metadata.gz: 6d4fe3e3584577f942346eafcab6de214045feff760cc507cefab7eab2f39c2a2e9dc91d8ece9602d47ec6519fa143c987d07002fa7dda3b4dd0af1369c3bad4
+  data.tar.gz: 5280b3e582ae3376378b8d6888defed0ed03d2dc35354c331614425d486561c752ddce6331b757d13fdd80e7a6a844970e278a53ce9fa11f0d7623348542f730

data/.rubocop.yml

@@ -8,6 +8,10 @@
 # where the inspected file is and continue its way up to the root directory.
 #
 # See https://github.com/rubocop-hq/rubocop/blob/master/manual/configuration.md
+AllCops:
+  Exclude:
+    - 'cdigits.gemspec'
+    - 'vendor/**/*'
 Layout/LineLength:
   Max: 120
 Style/Documentation:

data/README.md

@@ -16,8 +16,8 @@ Also, you can generate code in any format using placeholder.
 example:
 
 ```rb
-Cdigits::Luhn.number 'CA##-####-####-###?' # => "CA66-6567-2324-6526"
-Cdigits::Luhn.number '2020-01##-####-###?' # => "2020-0160-1171-1643"
+Cdigits::Luhn.number 'CA##-####-####-###?' # => "CA63-6485-2316-2675"
+Cdigits::Luhn.number '2020-01##-####-###?' # => "2020-0173-1935-2569"
 ```
 
 ## Installation
@@ -43,21 +43,21 @@ Or install it yourself as:
 ```rb
 placeholder = 'CA##-####-####-###?'
 Cdigits::Luhn.number
-# => "6907562414"
+# => "1638302982"
 Cdigits::Luhn.number placeholder
-# => "CA98-4890-6337-4381"
+# => "CA16-5930-2060-1262"
 Cdigits::Luhn.hex
-# => "2c14a42508"
+# => "2b69307483"
 Cdigits::Luhn.hex placeholder
-# => "CA27-675e-7136-5fa1"
+# => "CA1e-fe6c-1c04-9a28"
 Cdigits::Luhn.alphanumeric
-# => "yrkxeh4eie"
+# => "th5h7fewjl"
 Cdigits::Luhn.alphanumeric placeholder
-# => "CA59-bdxv-wjei-gdc9"
+# => "CAwf-mfkx-ncsv-odl2"
 Cdigits::Luhn.easy
-# => "16TPF8RETL"
+# => "NWK036TN1R"
 Cdigits::Luhn.easy placeholder
-# => "CABW-LF40-G11S-TL3U"
+# => "CAPY-SHHN-U55U-9PG7"
 ```
 
 #### Special chars in placeholder

data/cdigits.gemspec

@@ -9,7 +9,12 @@ Gem::Specification.new do |spec|
   spec.email         = ['kengo@kengos.jp']
 
   spec.summary       = 'Generate code with Luhn mod N algorithm using placeholder.'
-  spec.description   = "`Cdigits::Luhn.number('CA##-####-####-###?')` #=> 'CA98-4890-6337-4381'\n`Cdigits::Luhn.easy` #=> '16TPF8RETL'"
+  spec.description   = [
+    'Generate code with Luhn mod N algorithm using placeholder.',
+    'e.g)',
+    "Cdigits::Luhn.number('CA##-####-####-###?') #=> 'CA63-6485-2316-2675'",
+    "Cdigits::Luhn.easy #=> '16TPF8RETL'"
+  ].join("\n")
   spec.homepage      = 'https://github.com/kengos/cdigits'
   spec.license       = 'MIT'
   spec.required_ruby_version = Gem::Requirement.new('>= 2.3.0')

data/lib/cdigits/luhn/random_table.rb

@@ -0,0 +1,85 @@
+# frozen_string_literal: true
+
+module Cdigits
+  module Luhn
+    class RandomTable
+      attr_accessor :previsous
+
+      def initialize(modulus:)
+        @modulus = modulus
+        @previsous = nil
+      end
+
+      # pick from number table exclude 0
+      # @return [Integer]
+      def pick_non_zero
+        pick(exclude: [0])
+      end
+
+      # pick from number table
+      # @param exclude [Array<Intger>] exclude numbers
+      # @return [Integer]
+      def pick(exclude: [])
+        table(exclude).sample
+      end
+
+      private
+
+      def numbers
+        @numbers ||= (0..max).to_a.freeze
+      end
+
+      def max
+        @modulus - 1
+      end
+
+      # @return [Array<Integer>]
+      def table(exclude)
+        exclude << next_numbers_to_avoid[@previsous]
+        table = numbers - exclude.compact
+        table.empty? ? numbers : table
+      end
+
+      def next_numbers_to_avoid
+        @next_numbers_to_avoid ||= build_next_numbers_to_avoid
+      end
+
+      def build_next_numbers_to_avoid
+        defaults = { 0 => max, max => 0 }
+        return defaults unless occure_twin_error?
+
+        defaults.merge(twin_error_values)
+      end
+
+      # @note
+      #   modulus = 10
+      #   twin | doubled value
+      #   ---- | -------------
+      #   00 | 0
+      #   11 | 3
+      #   22 | 6
+      #   33 | 9
+      #   44 | 12
+      #   55 | 6
+      #   66 | 9
+      #   77 | 12
+      #   88 | 15
+      #   99 | 18
+      # @example
+      #   # when @modulus = 10
+      #   twin_error_values # => { 2 => 2, 3 => 3, 4 => 4, 5 => 5, 6 => 6, 7 => 7 }
+      # @return [Hash]
+      def twin_error_values
+        size = (max / 3).to_i
+        start = (@modulus / 2.0).ceil - size
+        stop = start + size * 2 - 1
+        values = (start..stop).to_a
+        values.zip(values).to_h
+      end
+
+      def occure_twin_error?
+        (max % 3).zero?
+      end
+    end
+  end
+end

data/lib/cdigits/luhn/store.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'securerandom'
+require 'cdigits/luhn/random_table'
 
 module Cdigits
   module Luhn
@@ -34,19 +34,21 @@ module Cdigits
       # Append random non-zero number to digits array
       # @return [Integer] appended value
       def append_non_zero_number
-        append random_number(@modulus - 1) + 1
+        append table.pick_non_zero
       end
 
       # Append random number to digits array
       # @return [Integer] appended value
       def append_number
-        append random_number(@modulus)
+        append table.pick
       end
 
       # Append passed value to digits array
-      # @param [Integer] value
+      # @param value [Integer]
+      # @param freeze [Boolean]
       # @return [Integer] appended value
       def append(value)
+        table.previsous = value
         @digits << value
         value
       end
@@ -62,8 +64,8 @@ module Cdigits
 
       private
 
-      def random_number(num)
-        ::SecureRandom.random_number(num)
+      def table
+        @table ||= ::Cdigits::Luhn::RandomTable.new(modulus: @modulus)
       end
 
       def calculate_check_digit(value, odd)

data/lib/cdigits/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Cdigits
-  VERSION = '0.1.1'
+  VERSION = '0.2.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cdigits
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - kengos
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-01-09 00:00:00.000000000 Z
+date: 2020-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -67,8 +67,10 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description: |-
-  `Cdigits::Luhn.number('CA##-####-####-###?')` #=> 'CA98-4890-6337-4381'
-  `Cdigits::Luhn.easy` #=> '16TPF8RETL'
+  Generate code with Luhn mod N algorithm using placeholder.
+  e.g)
+  Cdigits::Luhn.number('CA##-####-####-###?') #=> 'CA63-6485-2316-2675'
+  Cdigits::Luhn.easy #=> '16TPF8RETL'
 email:
 - kengo@kengos.jp
 executables: []
@@ -90,6 +92,7 @@ files:
 - lib/cdigits.rb
 - lib/cdigits/luhn.rb
 - lib/cdigits/luhn/placeholder.rb
+- lib/cdigits/luhn/random_table.rb
 - lib/cdigits/luhn/store.rb
 - lib/cdigits/version.rb
 homepage: https://github.com/kengos/cdigits