ccy_convertor 0.0.2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6cd5bc29c2df00a8629ba57024c388232494f90c
-  data.tar.gz: a4ef3c9b93ae1f0ce86987f110f964f81a610dbd
+  metadata.gz: ea00cf636ccf956c5e6ef07a8e0187cc8417ff7e
+  data.tar.gz: acad21629105b1e49f93053f106c13a83ed79c0b
 SHA512:
-  metadata.gz: 96976f7e8d1aa9f0e9acbe5251a631a43197d11ea058d660ec252f2298767b4a1a7ce063bc6d569fbd4692e0a8677f329d36d0cbc00a87695757aa0c852ce322
-  data.tar.gz: bea4e021e2bacef892d284c63321ab6d75fdec76913bba22695e155f14e3ffbd7343069d8aa9646d7118a54d42fd7cb9bad268e4d2cb488f14f34fb363a66ad4
+  metadata.gz: d3cf80f94e9cffb418c35363c5ef7248fd2c5900e50ef42b2e6e9e3b65a3b77ad1e0a53b750f6a322b345a67847e5b361dd65ee2233309e0824cd1febcedb6ed
+  data.tar.gz: 756ee7a4664491c997a0f4f66d7d4be84824cbe454489993b8aadc68ab3092ff828d57ce23fd5bdbe9781dd3889a07801f5f6330f2c684ab9af17a3b0a51d7c9

data/README.md

@@ -57,13 +57,11 @@ You can convert money from one currency to another in following ways
 Below code will use rate provided from www.openexchangerates.org
 ```ruby
 CcyConvertor::OpenExchangeRate.convert(from_ccy: 'USD', to_ccy: 'NZD', amount: 10)
-10.usd.to_nzd(rate_provider: Ccyconvertor::OpenExchangeRate)
 ```
 
 Below code will use default rate provider. Default rate provider is configurable . Check [configuration section](#configuration)
 ```ruby
 CcyConvertor.convert(from_ccy: 'USD', to_ccy: 'NZD', amount: 10)
-10.usd.to_nzd
 ```
 You can also get all currency rate  (rate matrix) with respect to USD in single request for OpenExchangeRate and CurrencyLayer rate provider
 ```ruby
@@ -77,7 +75,7 @@ While For Ccyconvertor::CurrencyLayer we can specify the base currency
 Ccyconvertor::CurrencyLayer.rate_matrix('NZD')
 ```
  All rates returned would be with respect to NZD. If no parameter is given then base currency is USD by default
- 
+
  Note:
  You cannot provide base currency for free account at currencylayer.com. By defualt base currency will be USD. You need a paid account at currencylayer.com to supply base currency. And Ccyconvertor::YahooFinance do not support rate_matrix method
 

data/ccy_convertor.gemspec

@@ -22,5 +22,4 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
 
   spec.add_runtime_dependency "activesupport", ">= 3.0"
-  spec.add_runtime_dependency "httparty"
 end

data/lib/ccy_convertor.rb

@@ -1,13 +1,10 @@
 require 'active_support/core_ext/string/inflections'
 require 'active_support/cache.rb'
-require 'httparty'
 require 'digest/sha1'
 
 require 'ccy_convertor/version'
 require 'ccy_convertor/configuration'
 require 'ccy_convertor/constant'
-require 'ccy_convertor/extension'
-require 'ccy_convertor/money'
 require 'ccy_convertor/exception'
 require 'ccy_convertor/rate_cache'
 require 'ccy_convertor/process_and_validate_option'
@@ -19,7 +16,6 @@ require 'ccy_convertor/rate_providers/currency_layer'
 module CcyConvertor
   class << self
     def rate(options)
-      RateProvider.process_options!(options)
       RateProvider.validate_presence_of_hash_keys!(options, [:from_ccy, :to_ccy])
       rate = rate_provider(options).rate(options[:to_ccy], options[:from_ccy])
       return rate if CcyConvertor.configuration.round_up_rate.nil?

data/lib/ccy_convertor/exception.rb

@@ -6,4 +6,6 @@ module CcyConvertor
   class InvalidCurrencyCode < StandardError; end
 
   class CurrencyNotSupported < StandardError; end
-end
+
+  class ResponseInvalid < StandardError; end
+end

data/lib/ccy_convertor/process_and_validate_option.rb

@@ -1,11 +1,5 @@
 module CcyConvertor
   module ProcessAndValidateOption
-    def process_options!(options)
-      unless options[:money].nil?
-        options.merge!(from_ccy: options[:money].code, amount: options[:money].amount)
-      end
-    end
-
     def validate_options!(options)
       validate_presence_of_hash_keys!(options, [:from_ccy, :to_ccy, :amount])
       validate_amount!(options[:amount])
@@ -42,4 +36,4 @@ module CcyConvertor
       end
     end
   end
-end
+end

data/lib/ccy_convertor/rate_providers/currency_layer.rb

@@ -6,8 +6,13 @@ module CcyConvertor
       end
 
       def rate_matrix(base_ccy = nil)
-        rates = rate_matrix_response(base_ccy)['quotes']
-        rates.inject({}) { |acc, (k, v)| acc[k[3, 3]] = v; acc }
+        rate_matrix_response = rate_matrix_response(base_ccy)
+        if error = rate_matrix_response['error']
+          raise CcyConvertor::ResponseInvalid, error['info']
+        end
+        rate_matrix_response['quotes'].inject({}) do |acc, (k, v)|
+          acc[k[3, 3]] = v; acc
+        end
       end
     end
   end

data/lib/ccy_convertor/rate_providers/open_exchange_rate.rb

@@ -6,8 +6,12 @@ module CcyConvertor
       end
 
       def rate_matrix
+        rate_matrix_response = rate_matrix_response()
+        if rate_matrix_response['error']
+          raise CcyConvertor::ResponseInvalid, rate_matrix_response['description']
+        end
         rate_matrix_response['rates']
       end
     end
   end
-end
+end

data/lib/ccy_convertor/rate_providers/rate_provider.rb

@@ -1,3 +1,6 @@
+require 'net/http'
+require 'json'
+
 module CcyConvertor
   class RateProvider
     extend CcyConvertor::RateCache
@@ -26,7 +29,8 @@ module CcyConvertor
       def response_hash(request_url)
         cache_key = cache_key(request_url)
         return cache.read(cache_key) if cache.exist?(cache_key)
-        response = HTTParty.get(request_url).parsed_response
+
+        response = JSON.parse(Net::HTTP.get(URI(request_url)))
         cache.write(cache_key, response, expires_in: cache_duration)
         response
       end
@@ -47,7 +51,6 @@ module CcyConvertor
       alias :rate :rate_from_rate_matrix
 
       def convert(options)
-        process_options!(options)
         validate_options!(options)
         converted_rate = options[:amount] * rate(options[:to_ccy], options[:from_ccy])
         return converted_rate if CcyConvertor.configuration.round_up_amount.nil?
@@ -55,4 +58,4 @@ module CcyConvertor
       end
     end
   end
-end
+end

data/lib/ccy_convertor/version.rb

@@ -1,3 +1,3 @@
 module CcyConvertor
-  VERSION = '0.0.2'
+  VERSION = '1.0.0'
 end

metadata

@@ -1,71 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: ccy_convertor
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 1.0.0
 platform: ruby
 authors:
 - Rohan Pujari
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-04 00:00:00.000000000 Z
+date: 2016-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: httparty
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 description: CcyConvertor provides live currency rate for various currencies and allows
   to convert money from one currency to other. Currently it supports 3 rate provider.
   New rate provider can be easily plugged in
@@ -75,7 +61,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -85,8 +71,6 @@ files:
 - lib/ccy_convertor/configuration.rb
 - lib/ccy_convertor/constant.rb
 - lib/ccy_convertor/exception.rb
-- lib/ccy_convertor/extension.rb
-- lib/ccy_convertor/money.rb
 - lib/ccy_convertor/process_and_validate_option.rb
 - lib/ccy_convertor/rate_cache.rb
 - lib/ccy_convertor/rate_providers/currency_layer.rb
@@ -104,12 +88,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -120,4 +104,3 @@ specification_version: 4
 summary: CcyConvertor provides live currency rate for various currencies and allows
   to convert money from one currency to other
 test_files: []
-has_rdoc: 

data/lib/ccy_convertor/extension.rb

@@ -1,5 +0,0 @@
-class Numeric
-  CcyConvertor::Constant::CCY_CODE_AND_NAME.each do |code, name|
-    define_method(code.downcase) { CcyConvertor::Money.new(code, self) }
-  end
-end

data/lib/ccy_convertor/money.rb

@@ -1,21 +0,0 @@
-module CcyConvertor
-  class Money
-    attr_accessor :code, :name, :amount
-
-    def initialize(code, amount)
-      @code = code
-      @amount = amount
-    end
-
-    def name
-      CcyConvertor::Constant::CCY_CODE_AND_NAME[code]
-    end
-
-    CcyConvertor::Constant::CCY_CODE_AND_NAME.each do |code, name|
-      define_method("to_#{code.downcase}") do |options = {}|
-        options.merge!(money: self, to_ccy: code)
-        CcyConvertor.convert(options)
-      end
-    end
-  end
-end