ccb_connect_client 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3e117ad6c14f5c141c0bf6e60e2b8fd0ed7daa25
-  data.tar.gz: 733eddbfe7f51f2361ec145dbf4c3ead8123f422
+  metadata.gz: 31b10d941b84128279c3814498c820c7e326a64a
+  data.tar.gz: 29281c41a38c4c3f80250b2427f704f73b628427
 SHA512:
-  metadata.gz: 0c64881a50068ed9739feca15520deb9b4c513385c94bb2712674e2569e7beac9fa2b981018e568a26681aba7256e7992c1c0f8bffdb446882ab62dfdef676e2
-  data.tar.gz: c853bded6d4e251e0e2ee6327163c06eb8803bda21e721eed523ab7adc8f52be596fbe1affe8173c738604de3a7be2af8c90a9d01ef419969e34e13ba09cdb55
+  metadata.gz: 13fc72d0b18b2f3e127f57e22588f53d7ac4778b39ca2e819c43a1b93f4c8615d05ef44fcb92f791402fbf2675aed368859b4013446ebb27b6d3dbf599fd72c9
+  data.tar.gz: 7bfc9d379a36a6cf8f0035dd895c257bcbefff34993c9aa5b0a6421d87116910227f4339c2bd53576d92f82d5eaf23c06b14f5d3060d7f56aec89e365b0d44a5

data/lib/ccb_connect_client/service.rb

@@ -18,32 +18,33 @@ module CcbConnectClient
     class Handler
 
       def response_handler(request, response)
-
-        http_post_form CcbConnectClient.server, request.to_xml do |res|
-          doc = Document.new(res.body)
-
-          if doc.elements["TX/RETURN_CODE"].text != "000000"
-            result = BaseResponse.from_xml res.body
-            result.successful = false
-          else
-            result = response.from_xml res.body
-            result.successful = true
-          end
+        res = http_post_form CcbConnectClient.server, request.to_xml
+        doc = Document.new(res.body)
+
+        if doc.elements["TX/RETURN_CODE"].text != "000000"
+          result = BaseResponse.from_xml res.body
+          result.successful = false
+        else
+          result = response.from_xml res.body
+          result.successful = true
         end
+        result
       end
 
       private
+
       def http_post_form(url, xml)
         uri = URI.parse(url)
         req = Net::HTTP::Post.new(uri)
         req["Content-Type"] = "application/x-www-form-urlencoded"
+        # We don't accpet gzip encoding since the http.request method will raise the EOF error
         req["Accept-Encoding"] = "identity"
-        Net::HTTP.start(uri.host, uri.port, :use_ssl => uri.scheme == 'https') do |http|
+        res = Net::HTTP.start(uri.host, uri.port, :use_ssl => uri.scheme == 'https') do |http|
           req.set_form_data('requestXml' => xml)
-          res = http.request req
-          yield res
+          http.request req
         end
       end
+
     end
   end
 end

data/lib/ccb_connect_client/version.rb

@@ -1,3 +1,3 @@
 module CcbConnectClient
-  VERSION = '0.1.3'.freeze
+  VERSION = '0.1.4'.freeze
 end

data/spec/ccb_connect_client_service_spec.rb

@@ -10,9 +10,11 @@ describe CcbConnectClient::Service do
     CcbConnectClient.password = file_lines[3].gsub("\n", '').split(pattern='\'')[1]
     CcbConnectClient.language = file_lines[4].split(pattern='\'')[1]
     request = CcbConnectClient::RefundRequest.new
-    request.money = 7.01
+    request.money = 0.01
     request.order = 'L238201903071717YKIHNW'
-    CcbConnectClient::Service.refund request
+    response = CcbConnectClient::Service.refund request
+    p response
+    expect(response).to be_instance_of(CcbConnectClient::RefundResponse)
   end
 
   it 'PaymentDetailsQueryRequest should be successful' do
@@ -42,6 +44,8 @@ describe CcbConnectClient::Service do
     # request.pos_code = '20190306'
     request.status = '3'
     # request.mrch_no = '20190306'
-    CcbConnectClient::Service.payment_details_query request
+    response = CcbConnectClient::Service.payment_details_query request
+    p response
+    expect(response).to be_instance_of(CcbConnectClient::PaymentDetailsQueryResponse)
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ccb_connect_client
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - LCola