cb_nitride 0.1.14 → 0.1.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9f0e4d5a9f6a4cbbccdec3b2ebd3cc448eadf266
-  data.tar.gz: a4b0b1a3f8bb13d0f61c4055db8071e0bfffcdef
+  metadata.gz: 4ef29e6b54fa90b0aee2c7dd154f87ad6136ea6f
+  data.tar.gz: 9eb6c981703dca995c8e546ef5101d83297559e9
 SHA512:
-  metadata.gz: c82f8e8b54592fdb1db104342d683ba8d274b08b8e14e7f4d28ad55ef44b77ef688b00aab22fbbdbd5c0b84f019f58f22505dd96837b7189bb11173eaeeb3f29
-  data.tar.gz: dc7578aa27001e5b74837d3afb25f3d356ab17c9acca8f75c076740d9c919fc5583456d2aabcf1c7ac8e86b8ac5d455c731d7e729634dfc528f945a85e0b7308
+  metadata.gz: e73c79b2036496c82bd090d530265d523ff058f7845e1f2c0bafb5c47ef421569eb4ac4c7e1bf47101df9d9070fd928e4c9bb034612f29061a3bce2606da05d6
+  data.tar.gz: 5426d1eacf48a6064957371844e535ba4bcb7599af1de51eeaac38dc4df5b2f21ad810302b2762475edeb08c6c7bde3e10caa8d45b83f2465be9147382f89eb5

data/lib/cb_nitride/diamond_item.rb

@@ -1,6 +1,8 @@
 module CbNitride
   class DiamondItem
 
+    SHORT_PAREN_OF_PATTERN = /\s*[O][f][(]/
+
     attr_reader :state, :diamond_number, :stock_number, :image_url, :publisher, :creators, :description, :release_date, :price, :category_code, :errors, :raw_title, :image
 
     def initialize(options = {})
@@ -105,6 +107,10 @@ module CbNitride
       @_is_collection ||= CategorySorter::COLLECTION_CODE  == category_code
     end
 
+    def raw_title
+      @_raw_title ||= @raw_title.sub(SHORT_PAREN_OF_PATTERN, ' (Of ')
+    end
+
     def is_merch?
       @_is_merch ||= CategorySorter::MERCHANDISE_CODES.include? category_code
     end

data/lib/cb_nitride/title_formatter.rb

@@ -9,7 +9,7 @@ module CbNitride
       @raw_title = raw_title
     end
 
-    OF_PATTERN = /[(].*[Oo][fF].*\d+.*[)]/
+    LONG_PAREN_OF_PATTERN = /[(].*[Oo][fF].*\d+.*[)]/
 
     def series_title
       @_series_title ||=
@@ -28,20 +28,28 @@ module CbNitride
 
     def limited_series_max_issue
       @_limited_series_max_issue ||=
-        num = clean_title.match(OF_PATTERN).to_s.match(/\d+/).to_s.strip
-        num.empty? ? nil : num.to_i
+        if clean_title.match(LONG_PAREN_OF_PATTERN)
+          clean_long_paren_of_text
+        else
+          nil
+        end
     end
 
     def variant_description
       @_variant_description ||=
         array = clean_title.split(/#\S+/)
         return nil if array.size == 1
-        string = array.last.gsub(OF_PATTERN, '').strip
+        string = array.last.gsub(LONG_PAREN_OF_PATTERN, '').strip
         string.empty? ? nil : string
     end
 
+    def clean_long_paren_of_text
+      clean_title.match(LONG_PAREN_OF_PATTERN).to_s.match(/\d+/).to_s.strip.to_i
+    end
+
     def clean_title
-      @_clean_title ||= raw_title.gsub(/[(][C].*[)]?/, '').gsub('(MR)', '').gsub('(NET)', '').strip
+      @_clean_title ||= 
+        raw_title.gsub(/[(][C].*[)]?/, '').gsub('(MR)', '').gsub('(NET)', '').strip
     end
 
   end

data/lib/cb_nitride/version.rb

@@ -1,3 +1,3 @@
 module CbNitride
-  VERSION = "0.1.14"
+  VERSION = "0.1.15"
 end

data/test/unit/diamond_item_test.rb

@@ -37,6 +37,4 @@ class DiamondItemTest < MiniTest::Unit::TestCase
     assert_equal :merchandise, ideal_merchandise
   end
 
-  #TODO Test for Correct Creator filtering, consider moving ideal objects to module
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cb_nitride
 version: !ruby/object:Gem::Version
-  version: 0.1.14
+  version: 0.1.15
 platform: ruby
 authors:
 - Alex Jarvis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-03 00:00:00.000000000 Z
+date: 2013-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler