cats_core 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b6ff0706b8636cf94fea0714f73ed8fead005d08a2647f5365f43ac7ba6a53b6
-  data.tar.gz: ab055e9fc942f99eed1e28ab7a755e0c5f54098a854705cf46c6c9bc880d0cff
+  metadata.gz: d34a61d070d789f175697fa32b8d763c04908b7bdb031c577fa35ba7eceedc88
+  data.tar.gz: 36039d25f798567b2e9196ffb37189b99f4bfa7406c66abccb0dbc2b614dcfdc
 SHA512:
-  metadata.gz: 82950facfa04e42a6aa4e934bfe9f950c158db65dbf55e61c6aff04ad2c9041354e2560a61222817864c5cd8288649282e099f362e7014f7abf65d3ba628a441
-  data.tar.gz: 8e951eebc249a57a1868dbc9155c1818bfc791ef6a0c987aaccf203c34e2d9fab7a3598b138c70de6e6c5f910cd8d2970e838c9719198f9ccd1d6380b9989143
+  metadata.gz: 8fb02566443952aca7ec7e45c1e665206b4eb8edbc7058ef444c1c7b65e2a946b9005f8284c50fbb5a6dea820286ffbf7a52b6904c02e081512828f48dc2803b
+  data.tar.gz: 06cde81638ce5e693929122574b7dc32079370c4a481651f8b9d26159709ceb91d2b60451874cfe733807fb44fd9707705e78b1385657a90bde759f7e80a4aec

data/app/models/cats/core/commodity.rb

@@ -12,6 +12,7 @@ module Cats
       belongs_to :unit_of_measure
 
       validates :quantity, presence: true, numericality: { greater_than: 0 }
+      validates :volume_per_metric_ton, numericality: { greater_than: 0, allow_nil: true }
     end
   end
 end

data/app/models/cats/core/notification.rb

@@ -4,6 +4,10 @@ module Cats
       include Noticed::Model
 
       belongs_to :recipient, polymorphic: true
+
+      def message
+        to_notification.message
+      end
     end
   end
 end

data/app/models/cats/core/stack.rb

@@ -37,7 +37,18 @@ module Cats
       end
 
       def stacking_rules
-        rule ||= Cats::Core::StackingRule.first
+        rule = Cats::Core::StackingRule.first
+
+        # If no rule is defined, then define a default rule
+        rule ||= Cats::Core::StackingRule(
+          space_between_stack: 1,
+          distance_from_gangway: 2,
+          distance_from_ceiling: 1,
+          maximum_height: 5,
+          maximum_length: 5,
+          maximum_width: 5,
+          distance_from_wall: 1
+        )
         rule
       end
 

data/app/services/cats/core/notification_service.rb

@@ -25,16 +25,20 @@ module Cats
         NOTIFICATION_RULES
       end
 
+      def create_notifier(rule)
+        clazz = rule[:notification].constantize
+        clazz.with(**@params)
+      end
+
       def notify
-        rules = notification_rules
-        clazz = rules[@code][:notification].constantize
-        app_code = rules[@code][:application]
-        roles = rules[@code][:recipients]
+        rule = notification_rules[@code]
+        notifier = create_notifier(rule)
+        app_code = rule[:application]
+        roles = rule[:recipients]
 
-        notification = clazz.with(**@params)
         users = Cats::Core::User.joins(:application_module)
                                 .where(application_module: { prefix: app_code }).with_all_roles(*roles)
-        notification.deliver(users)
+        notifier.deliver(users)
       end
     end
   end

data/db/migrate/20210717033223_create_cats_core_commodities.rb

@@ -21,6 +21,7 @@ class CreateCatsCoreCommodities < ActiveRecord::Migration[6.1]
       t.string :description
       t.boolean :hazardous, null: false, default: false
       t.date :best_use_before
+      t.float :volume_per_metric_ton
 
       t.timestamps
     end

data/lib/cats/core/version.rb

@@ -1,5 +1,5 @@
 module Cats
   module Core
-    VERSION = '1.0.5'.freeze
+    VERSION = '1.0.6'.freeze
   end
 end

data/spec/factories/cats/core/commodities.rb

@@ -8,5 +8,6 @@ FactoryBot.define do
     quantity { 100 }
     hazardous { false }
     best_use_before { Date.today + 2.month }
+    volume_per_metric_ton { 10 }
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cats_core
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - Henock L.
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-07-29 00:00:00.000000000 Z
+date: 2021-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ancestry