cassette 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27cfa48a748bedca25340e26864baeed00a733ce246892a309891228ccdc132d
-  data.tar.gz: cff0103bee5189300805c36ff24f3d559911c82d919c4eac294101b8f78aa3e0
+  metadata.gz: 33c8ac4e79e63b44d3a2806fd7725ad5098605409abc8fe89f0c4d0dd5313eb8
+  data.tar.gz: 6165b70c92ab25a0123bbe7cd9c6d4f9e407e9c715219337bcaa57b6a3210465
 SHA512:
-  metadata.gz: 823da9e1561d8521c0aa7e17e590df027ded2eca1ea7671aff54373dbbeeb89917db759c57e5dee709c07a75ca5913cefae46e609c60b77aea23edfd9e0e6cc0
-  data.tar.gz: 07da8bc42bd54cde6cd190596fa33ef93157a4b99bdf97258a1d90c6f3f95a8d38394661e6c4b83dbfff83415a73d4154951800bba0eb4123c43446f69025f41
+  metadata.gz: efd380df4df71bea613ee498eac11874fd938773a1008ca08b7a5499b47e1ec52a9e9029a71578acd51b4e0f8894f9b8fb018fe008b0f1aedf791922ffb55e87
+  data.tar.gz: 2a57fdbb03ce6ae51b99fe9b4eab39791c94d2c2f33b62b4bd8b1edc17f92ed5a0c7c892ac28f0175f9fbcb11a2f3cd99bec212b5c672fbd4dff4bae4f37801c

data/README.md

@@ -25,10 +25,18 @@ $ bundle
 Require this library and create an intializer to set its configuration:
 
 ```ruby
-Cassette.config = config
+Cassete.config = OpenStruct.new(
+  username: 'user',
+  password: 'secret',
+  service: 'test-api.example.org',
+  base: 'https://some-cas.example.org',
+  base_authority: 'CASTEST',
+  verify_ssl: true,       # If not defined, the default value will be: false.
+  tls_version: 'TLSv1_2'  # if not defined, the default value will be: 'TLSv1'.
+)
 ```
 
-where config is an object that responds to the methods `base` for the base CAS uri, `username` and `password` if you are authenticating on other systems and `service` and `base_authority` if you are using the authentication filter to authenticate your app.
+where config is an OpenStruct that responds to the methods `base` for the base CAS uri, `username` and `password` if you are authenticating on other systems and `service` and `base_authority` if you are using the authentication filter to authenticate your app.
 
 You may also set the caching backend using the .backend= module method:
 

data/lib/cassette.rb

@@ -21,7 +21,9 @@ module Cassette
 
   attr_writer :config, :logger
 
-  DEFAULT_TIMEOUT = 10
+  DEFAULT_TIMEOUT     = 10
+  DEFAULT_TLS_VERSION = 'TLSv1'.freeze
+  DEFAULT_VERIFY_SSL  = false
 
   def logger
     @logger ||= begin
@@ -35,6 +37,12 @@ module Cassette
 
   def config
     @config if defined?(@config)
+
+    @config.tls_version = DEFAULT_TLS_VERSION if @config.tls_version.nil?
+
+    @config.verify_ssl = DEFAULT_VERIFY_SSL if @config.verify_ssl.nil?
+
+    @config
   end
 
   def cache_backend

data/lib/cassette/http/request.rb

@@ -36,7 +36,8 @@ module Cassette
       end
 
       def request
-        @request ||= Faraday.new(url: config.base, ssl: { verify: false, version: 'TLSv1' }) do |conn|
+        @request ||= Faraday.new(url: config.base, ssl:
+          { verify: config.verify_ssl, version: config.tls_version }) do |conn|
           conn.adapter Faraday.default_adapter
         end
       end

data/lib/cassette/version.rb

@@ -1,8 +1,8 @@
 module Cassette
   class Version
-    MAJOR = '1'
-    MINOR = '3'
-    PATCH = '0'
+    MAJOR = '1'.freeze
+    MINOR = '4'.freeze
+    PATCH = '0'.freeze
 
     def self.version
       [MAJOR, MINOR, PATCH].join('.')

data/spec/cassette_spec.rb

@@ -7,6 +7,78 @@ describe Cassette do
     Cassette.logger = original_logger
   end
 
+  describe '.config' do
+    it 'defines Cassette initial configuration based on a OpenStruct' do
+
+      config = OpenStruct.new(
+        YAML.load_file('spec/config.yml')
+      )
+
+      Cassette.config = config
+
+      expect(Cassette.config)
+        .to eq(config)
+    end
+
+    context 'when tls_version was not specified' do
+      it 'uses default TLS version: TLSv1' do
+        config = OpenStruct.new(
+          YAML.load_file('spec/config.yml')
+        )
+
+        # Removing tls_version field
+        config.delete_field(:tls_version)
+
+        Cassette.config = config
+
+        expect(Cassette.config.tls_version)
+          .to eq('TLSv1')
+      end
+    end
+
+    context 'when tls_version is specified' do
+      it 'uses this version' do
+        config = OpenStruct.new(
+          YAML.load_file('spec/config.yml')
+        )
+
+        Cassette.config = config
+
+        expect(Cassette.config.tls_version)
+          .to eq('TLSv1_2')
+      end
+    end
+
+    context 'when verify_ssl was not specified' do
+      it 'uses default verify_ssl value: false' do
+        config = OpenStruct.new(
+          YAML.load_file('spec/config.yml')
+        )
+
+        # Removing verify_ssl field
+        config.delete_field(:verify_ssl)
+
+        Cassette.config = config
+
+        expect(Cassette.config.verify_ssl)
+          .to be false
+      end
+    end
+
+    context 'when verify_ssl is specified' do
+      it 'uses this value' do
+        config = OpenStruct.new(
+          YAML.load_file('spec/config.yml')
+        )
+
+        Cassette.config = config
+
+        expect(Cassette.config.verify_ssl)
+          .to be true
+      end
+    end
+  end
+
   describe '.logger' do
     it 'returns a default instance' do
       expect(Cassette.logger).not_to be_nil

data/spec/config.yml

@@ -1,5 +1,7 @@
-username: "user"
-password: "secret"
-service: "test-api.example.org"
-base: "https://some-cas.example.org"
-base_authority: "CASTEST"
+username: 'user'
+password: 'secret'
+service: 'test-api.example.org'
+base: 'https://some-cas.example.org'
+base_authority: 'CASTEST'
+verify_ssl: true
+tls_version: 'TLSv1_2'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cassette
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Ricardo Hermida Ruiz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-19 00:00:00.000000000 Z
+date: 2020-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday