cassette 1.1.5 → 1.2.0.pre

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0e9da653330f2b19a49cd4710abfc4ab68f38dac
-  data.tar.gz: 97863b30cdbfdc0455b1296bd893eef92d505f9a
+  metadata.gz: 36477f617205d04852d5cbfbfecfa50c804979a4
+  data.tar.gz: 25cd9472c3cd2f16896a89330fc7512b6e693afc
 SHA512:
-  metadata.gz: e6ef4f0b1a396d3de5e01f404a156717fc0f1db0738874e1bcb5bbf74a6a67f6fd791706834730217d6c7118e13a1b63cb42b3331636d1260d386afb746d0b33
-  data.tar.gz: fc589953459901c2539d126cf09944caf2a7898b4a402ac83aa5894a428384d59103948eee935277193837a3d297c6c37da537792108bf47ba5a32fdcc8d9800
+  metadata.gz: 97cc8d0ee09138579a8aa99ab4c98938206806c06cf72c685c5cfb9de534203ee77351ab0dca094bd7517dd19a27b45fbe241c74283fa39daf75cda206aa7e84
+  data.tar.gz: 9f7afb92efbb6d7b330a108a9b2cbf1dce9f6839e9e104e91e5f1700288c95dfdab4f59555db34773a4b4d1ea958ee97ec89bb87fea71898fb56ad50a23c3739

data/lib/cassette/authentication/filter.rb

@@ -1,14 +1,12 @@
 # encoding: UTF-8
 
-require 'active_support/concern'
 require 'cassette/authentication/user'
 
 module Cassette
   class Authentication
     module Filter
-      extend ActiveSupport::Concern
-
-      included do |controller|
+      def self.included(controller)
+        controller.extend(ClassMethods)
         controller.before_action(:validate_authentication_ticket)
         controller.send(:attr_accessor, :current_user)
       end

data/lib/cassette/authentication/user.rb

@@ -2,13 +2,15 @@
 
 require 'cassette/authentication'
 require 'cassette/authentication/authorities'
-require 'delegate'
+require 'forwardable'
 
 module Cassette
   class Authentication
     class User
+      extend Forwardable
+
       attr_accessor :login, :name, :authorities, :email, :ticket, :type
-      delegate :has_role?, :has_raw_role?, to: :@authorities
+      def_delegators :@authorities, :has_role?, :has_raw_role?
 
       def initialize(attrs = {})
         config       = attrs[:config]

data/lib/cassette/authentication.rb

@@ -31,7 +31,7 @@ module Cassette
         begin
           logger.info("Validating #{ticket} on #{validate_path}")
 
-          response = http.get(validate_path, ticket: ticket, service: service).body
+          response = http.post(validate_path, ticket: ticket, service: service).body
           ticket_response = Http::TicketResponse.new(response)
 
           logger.info("Validation resut: #{response.inspect}")
@@ -54,29 +54,6 @@ module Cassette
 
     attr_accessor :cache, :logger, :http, :config
 
-    def try_content(node, *keys)
-      keys.inject(node) do |a, e|
-        a.try(:[], e)
-      end.try(:[], '__content__')
-    end
-
-    def extract_user(xml, ticket)
-      ActiveSupport::XmlMini.with_backend('LibXML') do
-        result = ActiveSupport::XmlMini.parse(xml)
-
-        login = try_content(result, 'serviceResponse', 'authenticationSuccess', 'user')
-
-        if login
-          attributes = result['serviceResponse']['authenticationSuccess']['attributes']
-          name = try_content(attributes, 'cn')
-          authorities = try_content(attributes, 'authorities')
-
-          Cassette::Authentication::User.new(login: login, name: name, authorities: authorities,
-                                             ticket: ticket, config: config)
-        end
-      end
-    end
-
     def validate_path
       "/serviceValidate"
     end

data/lib/cassette/cache/null_store.rb

@@ -0,0 +1,34 @@
+# encoding: UTF-8
+
+module Cassette
+  module Cache
+    # You cache nothing, null store
+    #
+    # This is a fallback class when Rails or ActiveSupport cache cannot
+    # be loaded
+    class NullStore
+      def clear
+      end
+
+      def read(_key, _options)
+        nil
+      end
+
+      def delete_matched(_key)
+        true
+      end
+
+      def write(_key, _value, _options)
+        true
+      end
+
+      def increment(_key)
+        0
+      end
+
+      def fetch(_key, _options, &block)
+        block.call
+      end
+    end
+  end
+end

data/lib/cassette/cache.rb

@@ -1,6 +1,10 @@
 # encoding: UTF-8
 
-require 'active_support/cache'
+begin
+  require 'active_support/cache'
+rescue LoadError
+  require 'cassette/cache/null_store'
+end
 
 module Cassette
   module Cache
@@ -8,8 +12,10 @@ module Cassette
       @backend ||= begin
         if defined?(::Rails) && ::Rails.cache
           ::Rails.cache
-        else
+        elsif defined?(::ActiveSupport::Cache::MemoryStore)
           ActiveSupport::Cache::MemoryStore.new
+        else
+          NullStore.new
         end
       end
     end

data/lib/cassette/errors.rb

@@ -1,16 +1,14 @@
 # encoding: UTF-8
 
-require 'active_support/inflector'
-
 module Cassette
   module Errors
     TYPES = {
-      401 => :authorization_required,
-      400 => :bad_request,
-      403 => :forbidden,
-      500 => :internal_server_error,
-      404 => :not_found,
-      412 => :precondition_failed
+      401 => :AuthorizationRequired,
+      400 => :BadRequest,
+      403 => :Forbidden,
+      500 => :InternalServerError,
+      404 => :NotFound,
+      412 => :PreconditionFailed
     }
 
     def self.raise_by_code(code)
@@ -19,12 +17,12 @@ module Cassette
       if name
         fail error_class(name)
       else
-        fail error_class(:internal_server_error)
+        fail error_class(:InternalServerError)
       end
     end
 
     def self.error_class(name)
-      "Cassette::Errors::#{name.to_s.camelize}".constantize
+      Cassette::Errors.const_get(name)
     end
 
     class Base < StandardError
@@ -34,7 +32,7 @@ module Cassette
     end
 
     TYPES.each do |status, name|
-      const_set(name.to_s.camelize, Class.new(Errors::Base))
+      const_set(name, Class.new(Errors::Base))
       error_class(name).const_set('CODE', status)
     end
   end

data/lib/cassette/http/request.rb

@@ -17,13 +17,6 @@ module Cassette
         end
       end
 
-      def get(path, payload, timeout = DEFAULT_TIMEOUT)
-        perform(:get, path) do |req|
-          req.params = payload
-          req.options.timeout = timeout
-        end
-      end
-
       private
 
       attr_accessor :config

data/lib/cassette/http/ticket_response.rb

@@ -1,47 +1,30 @@
+require 'rexml/document'
+require 'rexml/xpath'
+
 module Cassette
   module Http
     class TicketResponse
-      def initialize(response)
-        @content = ParsedResponse.new(response)
-      end
-
-      def login
-        fetch_val(
-          content,
-          'serviceResponse',
-          'authenticationSuccess',
-          'user',
-          '__content__'
-        )
-      end
-
-      def name
-        fetch_val(attributes, 'cn', '__content__')
-      end
-
-      def authorities
-        fetch_val(attributes, 'authorities', '__content__')
-      end
-
-      private
-
-      attr_reader :content
-
-      def fetch_val(hash, *keys)
-        keys.reduce(hash, &access_key)
-      end
-
-      def access_key
-        lambda { |hash, key| hash.try(:[], key) }
-      end
+      attr_reader :login, :name, :authorities
 
-      def attributes
-        fetch_val(
-          content,
-          'serviceResponse',
-          'authenticationSuccess',
-          'attributes'
-        )
+      def initialize(response)
+        namespaces = { "cas" => "http://www.yale.edu/tp/cas" }
+        query = "//cas:serviceResponse/cas:authenticationSuccess/cas:user"
+
+        document = REXML::Document.new(response)
+        element = REXML::XPath.first(document, query, namespaces)
+        @login = element.try(:text)
+
+        if @login
+          attributes_query =
+            "//cas:serviceResponse/cas:authenticationSuccess/cas:attributes"
+          attributes = Hash[REXML::XPath.
+            first(document, attributes_query, namespaces).
+            elements.
+            map { |e| [e.name, e.text] }]
+
+          @name = attributes['cn']
+          @authorities = attributes['authorities']
+        end
       end
     end
   end

data/lib/cassette/http.rb

@@ -1,5 +1,4 @@
 require_relative 'http/request'
-require_relative 'http/parsed_response'
 require_relative 'http/ticket_response'
 
 module Cassette

data/lib/cassette/rubycas/user_factory.rb

@@ -1,8 +1,6 @@
 module Cassette
   module Rubycas
     module UserFactory
-      extend ActiveSupport::Concern
-
       def from_session(session)
         attributes = session[:cas_extra_attributes]
         Cassette::Authentication::User.new(login: session[:cas_user],

data/lib/cassette/version.rb

@@ -1,8 +1,8 @@
 module Cassette
   class Version
     MAJOR = '1'
-    MINOR = '1'
-    PATCH = '5'
+    MINOR = '2'
+    PATCH = '0.pre'
 
     def self.version
       [MAJOR, MINOR, PATCH].join('.')

data/lib/cassette.rb

@@ -12,9 +12,11 @@ require 'cassette/authentication/cache'
 require 'cassette/authentication/filter'
 
 require 'faraday'
+require 'forwardable'
 require 'logger'
 
 module Cassette
+  extend Forwardable
   extend self
 
   attr_writer :config, :logger
@@ -35,5 +37,5 @@ module Cassette
     @config if defined?(@config)
   end
 
-  delegate :post, to: :'Http::Request'
+  def_delegators Http::Request, :post
 end

data/spec/cassette/authentication_spec.rb

@@ -45,13 +45,13 @@ describe Cassette::Authentication do
       end
 
       it 'raises a Forbidden exception on any exceptions' do
-        allow(http).to receive(:get).with(anything, anything).and_raise(Cassette::Errors::BadRequest)
+        allow(http).to receive(:post).with(anything, anything).and_raise(Cassette::Errors::BadRequest)
         expect { subject.ticket_user('ticket') }.to raise_error(Cassette::Errors::Forbidden)
       end
 
       context 'with a failed CAS response' do
         before do
-          allow(http).to receive(:get).with(anything, anything)
+          allow(http).to receive(:post).with(anything, anything)
             .and_return(OpenStruct.new(body: fixture('cas/fail.xml')))
         end
 
@@ -62,7 +62,7 @@ describe Cassette::Authentication do
 
       context 'with a successful CAS response' do
         before do
-          allow(http).to receive(:get).with(anything, anything)
+          allow(http).to receive(:post).with(anything, anything)
             .and_return(OpenStruct.new(body: fixture('cas/success.xml')))
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cassette
 version: !ruby/object:Gem::Version
-  version: 1.1.5
+  version: 1.2.0.pre
 platform: ruby
 authors:
 - Ricardo Hermida Ruiz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-20 00:00:00.000000000 Z
+date: 2017-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -24,20 +24,6 @@ dependencies:
     - - ">"
       - !ruby/object:Gem::Version
         version: '0.9'
-- !ruby/object:Gem::Dependency
-  name: libxml-ruby
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -45,7 +31,7 @@ dependencies:
     - - ">"
       - !ruby/object:Gem::Version
         version: 3.1.0
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -235,13 +221,13 @@ files:
 - lib/cassette/authentication/filter.rb
 - lib/cassette/authentication/user.rb
 - lib/cassette/cache.rb
+- lib/cassette/cache/null_store.rb
 - lib/cassette/client.rb
 - lib/cassette/client/cache.rb
 - lib/cassette/errors.rb
 - lib/cassette/errors/not_a_customer.rb
 - lib/cassette/errors/not_an_employee.rb
 - lib/cassette/http.rb
-- lib/cassette/http/parsed_response.rb
 - lib/cassette/http/request.rb
 - lib/cassette/http/ticket_response.rb
 - lib/cassette/rubycas.rb
@@ -261,7 +247,6 @@ files:
 - spec/cassette/client/cache_spec.rb
 - spec/cassette/client_spec.rb
 - spec/cassette/errors_spec.rb
-- spec/cassette/http/parsed_response_spec.rb
 - spec/cassette/http/request_spec.rb
 - spec/cassette/http/ticket_response_spec.rb
 - spec/cassette/rubycas/routing_constraint_spec.rb
@@ -286,12 +271,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Generates, validates and caches TGTs and STs
@@ -306,7 +291,6 @@ test_files:
 - spec/cassette/client/cache_spec.rb
 - spec/cassette/client_spec.rb
 - spec/cassette/errors_spec.rb
-- spec/cassette/http/parsed_response_spec.rb
 - spec/cassette/http/request_spec.rb
 - spec/cassette/http/ticket_response_spec.rb
 - spec/cassette/rubycas/routing_constraint_spec.rb

data/lib/cassette/http/parsed_response.rb

@@ -1,20 +0,0 @@
-require 'delegate'
-require 'active_support/xml_mini'
-
-module Cassette
-  module Http
-    class ParsedResponse < SimpleDelegator
-      def initialize(raw_content, parser = XMLParser)
-        super(parser.call(raw_content))
-      end
-
-      XMLParser = lambda do |raw_content|
-        ActiveSupport::XmlMini.with_backend('LibXML') do
-          ActiveSupport::XmlMini.parse(raw_content)
-        end
-      end
-
-      private_constant :XMLParser
-    end
-  end
-end

data/spec/cassette/http/parsed_response_spec.rb

@@ -1,27 +0,0 @@
-describe Cassette::Http::ParsedResponse do
-  subject(:parsed_response) { described_class.new(xml_response) }
-
-  let(:xml_response) { fixture('cas/success.xml') }
-
-  let(:hash_response) do
-    {
-      "serviceResponse" => {
-        "authenticationSuccess" => {
-          "user"=> {
-            "__content__" => "test-user"
-          },
-          "attributes" => {
-            "authorities" => {
-              "__content__" => "[CUPOM, AUDITING,]"
-            },
-            "cn" => {
-              "__content__" => "Test System"
-            }
-          }
-        }
-      }
-    }
-  end
-
-  it { is_expected.to eq(hash_response) }
-end