casino_core 1.4.1 → 1.4.2

data.tar.gz.sig

@@ -1 +1 @@
-w�h�|�Pi��vDxM�,I����E�m��*N1� ��\;_JNw��D<^6�2~;��\�-� M(~������Hx�"�p5!��*ՏD�,2�G��Aw]k��'��z�7����k�p���L	Bf����W���mW�QJ�w喞�l	�2w����?��4�9�F�b�b�R>6�����8'��+��cߖ4���{ϽU����J��fP)�y�	��f�
+��#h��X�f��]���*t�@޶�!�UL'���RE��(75�~�<���q���\>��{��eґ��kd ��_�����Wǡ��S�,oO�A�s�b�7��������[r�V��81'2�Mk��������z�k�룴Z�݉id"Ք443CU|>�9Y9c��1���@�:W��t�zA9I�9��n#2S��>t���MH�TrSR�W�}�00�/�il`�x���{9�E���8�c����2����

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    casino_core (1.4.0)
+    casino_core (1.4.2)
       activerecord (~> 3.2.9)
       addressable (~> 2.3)
       faraday (~> 0.8)

data/lib/casino_core/helper/service_tickets.rb

@@ -9,6 +9,8 @@ module CASinoCore
 
       class ServiceNotAllowedError < StandardError; end
 
+      RESERVED_CAS_PARAMETER_KEYS = ['service', 'ticket', 'gateway', 'renew']
+
       def acquire_service_ticket(ticket_granting_ticket, service, credentials_supplied = nil)
         service_url = clean_service_url(service)
         unless CASinoCore::Model::ServiceRule.allowed?(service_url)
@@ -27,7 +29,7 @@ module CASinoCore
         return dirty_service if dirty_service.blank?
         service_uri = Addressable::URI.parse dirty_service
         unless service_uri.query_values.nil?
-          service_uri.query_values = service_uri.query_values.except('service', 'ticket', 'gateway', 'renew')
+          service_uri.query_values = service_uri.query_values(Array).select { |k,v| !RESERVED_CAS_PARAMETER_KEYS.include?(k) }
         end
         if service_uri.query_values.blank?
           service_uri.query_values = nil

data/lib/casino_core/model/service_ticket.rb

@@ -25,7 +25,7 @@ class CASinoCore::Model::ServiceTicket < ActiveRecord::Base
 
   def service_with_ticket_url
     service_uri = Addressable::URI.parse(self.service)
-    service_uri.query_values = (service_uri.query_values || {}).merge(ticket: self.ticket)
+    service_uri.query_values = (service_uri.query_values(Array) || []) << ['ticket', self.ticket]
     service_uri.to_s
   end
 

data/lib/casino_core/version.rb

@@ -1,3 +1,3 @@
 module CASinoCore
-  VERSION = '1.4.1'
+  VERSION = '1.4.2'
 end

data/spec/processor/login_credential_requestor_spec.rb

@@ -99,6 +99,16 @@ describe CASinoCore::Processor::LoginCredentialRequestor do
         end
       end
 
+      context 'with a service with nested attributes' do
+        let(:service) { 'http://example.com/?a%5B%5D=test&a%5B%5D=example' }
+        let(:params) { { service: service } }
+
+        it 'does not remove the attributes' do
+          listener.should_receive(:user_logged_in).with(/\?a%5B%5D=test&a%5B%5D=example&ticket=ST\-[^&]+$/)
+          processor.process(params, cookies, user_agent)
+        end
+      end
+
       context 'without a service' do
         it 'calls the #user_logged_in method on the listener' do
           listener.should_receive(:user_logged_in).with(nil)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: casino_core
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
   prerelease: 
 platform: ruby
 authors:
@@ -36,7 +36,7 @@ cert_chain:
   b1VSdnUwRzgvWXlIVUFtSVUvV0tyanIxYmdjZjFWUnYKUjRLRDFNblVWL3Y1
   MDJwaU1sWG1qeE9XZGJLOHl2UUVIa3N1L3pqYkNqU3UrTTJrd0ZtV0dzeDVu
   eCtWZHc9PQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==
-date: 2013-03-26 00:00:00.000000000 Z
+date: 2013-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -447,15 +447,21 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -1266012444534367385
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -1266012444534367385
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: A CAS server core library.