casino_core 1.0.5 → 1.0.6

data/VERSION

@@ -1 +1 @@
-1.0.5
+1.0.6

data/casino_core.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "casino_core"
-  s.version = "1.0.5"
+  s.version = "1.0.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Nils Caspar"]
-  s.date = "2012-12-30"
+  s.date = "2012-12-31"
   s.description = "A CAS server core library."
   s.email = "ncaspar@me.com"
   s.extra_rdoc_files = [

data/lib/casino_core/processor/api/login_credential_acceptor.rb

@@ -16,8 +16,9 @@ class CASinoCore::Processor::API::LoginCredentialAcceptor < CASinoCore::Processo
   # * `#invalid_login_credentials_via_api`: No argument
   #
   # @param [Hash] login_data parameters supplied by user (username and password)
-  def process(login_data)
+  def process(login_data, user_agent = nil)
     @login_data = login_data
+    @user_agent = user_agent
 
     validate_login_data
 
@@ -39,7 +40,7 @@ class CASinoCore::Processor::API::LoginCredentialAcceptor < CASinoCore::Processo
   end
 
   def generate_ticket_granting_ticket
-    @ticket_granting_ticket = acquire_ticket_granting_ticket(@authentication_result)
+    @ticket_granting_ticket = acquire_ticket_granting_ticket(@authentication_result, @user_agent)
   end
 
   def callback_invalid_login_credentials

data/lib/casino_core/processor/api/logout.rb

@@ -2,16 +2,15 @@ require 'casino_core/processor'
 require 'casino_core/helper'
 require 'casino_core/model'
 
-# The Logout processor should be used to process API DELET requests to /cas/v1/tickets/TGT-fdsjfsdfjkalfewrihfdhfaie
+# The Logout processor should be used to process API DELETE requests to /cas/v1/tickets/<ticket_granting_ticket>
 class CASinoCore::Processor::API::Logout < CASinoCore::Processor
   include CASinoCore::Helper::TicketGrantingTickets
 
-  # This method will call `#user_logged_out_via_api`
+  # This method will call `#user_logged_out_via_api` on the listener.
   #
-  # @param [String] ticket_granting_ticket Ticket granting ticket to logout
-  def process(ticket_granting_ticket)
-
-    remove_ticket_granting_ticket(ticket_granting_ticket)
+  # @param [String] ticket_granting_ticket Ticket-granting ticket to logout
+  def process(ticket_granting_ticket, user_agent = nil)
+    remove_ticket_granting_ticket(ticket_granting_ticket, user_agent)
     callback_user_logged_out
   end
 

data/lib/casino_core/processor/api/service_ticket_provider.rb

@@ -11,15 +11,19 @@ class CASinoCore::Processor::API::ServiceTicketProvider < CASinoCore::Processor
   # Use this method to process the request.
   #
   # The method will call one of the following methods on the listener:
-  # * `#granted_service_ticket_via_api`: First and only argument is a String with the ST-id
-  # * `#invalid_ticket_granting_ticket_via_api`: No argument
-  # * `#no_service_provided_via_api`: No argument
+  # * `#granted_service_ticket_via_api`: First and only argument is a String with the service ticket.
+  #   The service ticket (and nothing else) should be displayed.
+  # * `#invalid_ticket_granting_ticket_via_api`: No argument. The application should respond with status "400 Bad Request"
+  # * `#no_service_provided_via_api`: No argument. The application should respond with status "400 Bad Request"
   #
   # @param [String] ticket_granting_ticket ticket_granting_ticket supplied by the user in the URL
-  # @param [Hash] parameters parameters supplied by user (ticket granting ticket and service url)
-  def process(ticket_granting_ticket, parameters)
+  # @param [Hash] parameters parameters supplied by user (`service` in particular)
+  # @param [String] user_agent user-agent delivered by the client
+  def process(ticket_granting_ticket, parameters = nil, user_agent = nil)
+    parameters ||= {}
     @client_ticket_granting_ticket = ticket_granting_ticket
     @service_url = parameters[:service]
+    @user_agent = user_agent
 
     fetch_valid_ticket_granting_ticket
     handle_ticket_granting_ticket
@@ -27,7 +31,7 @@ class CASinoCore::Processor::API::ServiceTicketProvider < CASinoCore::Processor
 
   private
   def fetch_valid_ticket_granting_ticket
-    @ticket_granting_ticket = find_valid_ticket_granting_ticket(@client_ticket_granting_ticket, nil)
+    @ticket_granting_ticket = find_valid_ticket_granting_ticket(@client_ticket_granting_ticket, @user_agent)
   end
 
   def handle_ticket_granting_ticket

data/spec/processor/api/login_credential_acceptor_spec.rb

@@ -4,34 +4,49 @@ describe CASinoCore::Processor::API::LoginCredentialAcceptor do
   describe '#process' do
     let(:listener) { Object.new }
     let(:processor) { described_class.new(listener) }
+    let(:user_agent) { 'ThisIsATestBrwoser 1.0' }
 
     context 'with invalid credentials' do
-      let(:login_data) { {username: 'testuser', password: 'wrong'} }
+      let(:login_data) { { username: 'testuser', password: 'wrong' } }
 
-      it 'calls the #invalid_login_credentials method on the listener' do
+      before(:each) do
+        listener.stub(:invalid_login_credentials_via_api)
+      end
+
+      it 'calls the #invalid_login_credentials_via_api method on the listener' do
         listener.should_receive(:invalid_login_credentials_via_api)
-        processor.process(login_data).should be_false
+        processor.process(login_data, user_agent).should be_false
+      end
+
+      it 'does not generate a ticket-granting ticket' do
+        expect {
+          processor.process(login_data, user_agent)
+        }.to_not change(CASinoCore::Model::TicketGrantingTicket, :count)
       end
     end
 
     context 'with valid credentials' do
-      let(:login_data) { {username: 'testuser', password: 'foobar123'} }
+      let(:login_data) { { username: 'testuser', password: 'foobar123' } }
 
       before(:each) do
-        listener.stub(:user_logged_in)
+        listener.stub(:user_logged_in_via_api)
       end
 
-      it 'calls the #user_logged_in method on the listener' do
+      it 'calls the #user_logged_in_via_api method on the listener' do
         listener.should_receive(:user_logged_in_via_api).with(/^TGC\-/)
-        processor.process(login_data)
+        processor.process(login_data, user_agent)
       end
 
       it 'generates a ticket-granting ticket' do
-        listener.should_receive(:user_logged_in_via_api).with(/^TGC\-/)
         expect {
-          processor.process(login_data)
+          processor.process(login_data, user_agent)
         }.to change(CASinoCore::Model::TicketGrantingTicket, :count).by(1)
       end
+
+      it 'sets the user-agent in the ticket-granting ticket' do
+        processor.process(login_data, user_agent)
+        CASinoCore::Model::TicketGrantingTicket.last.user_agent.should == user_agent
+      end
     end
   end
 end

data/spec/processor/api/logout_spec.rb

@@ -6,22 +6,23 @@ describe CASinoCore::Processor::API::Logout do
     let(:processor) { described_class.new(listener) }
 
     context 'with an existing ticket-granting ticket' do
-      let(:ticket_granting_ticket) { FactoryGirl.create(:ticket_granting_ticket, user_agent: nil) }
+      let(:ticket_granting_ticket) { FactoryGirl.create(:ticket_granting_ticket) }
+      let(:user_agent) { ticket_granting_ticket.user_agent }
 
       it 'deletes the ticket-granting ticket' do
         listener.should_receive(:user_logged_out_via_api)
-        processor.process(ticket_granting_ticket.ticket)
+        processor.process(ticket_granting_ticket.ticket, user_agent)
         CASinoCore::Model::TicketGrantingTicket.where(id: ticket_granting_ticket.id).first.should == nil
       end
 
       it 'calls the #user_logged_out_via_api method on the listener' do
         listener.should_receive(:user_logged_out_via_api)
-        processor.process(ticket_granting_ticket)
+        processor.process(ticket_granting_ticket, user_agent)
       end
 
     end
 
-    context 'with an invlaid ticket-granting ticket' do
+    context 'with an invalid ticket-granting ticket' do
       let(:tgt) { 'TGT-lalala' }
 
       it 'calls the #user_logged_out method on the listener' do

data/spec/processor/api/service_ticket_provider_spec.rb

@@ -17,17 +17,19 @@ describe CASinoCore::Processor::API::ServiceTicketProvider do
     end
 
     context 'with a valid ticket-granting ticket' do
-      let(:ticket_granting_ticket) { FactoryGirl.create(:ticket_granting_ticket, user_agent: nil).ticket }
+      let(:ticket_granting_ticket) { FactoryGirl.create(:ticket_granting_ticket) }
+      let(:ticket) { ticket_granting_ticket.ticket }
+      let(:user_agent) { ticket_granting_ticket.user_agent }
 
       it 'calls the #granted_service_ticket_via_api method on the listener' do
         listener.should_receive(:granted_service_ticket_via_api).with(/^ST\-/)
-        processor.process(ticket_granting_ticket, parameters)
+        processor.process(ticket, parameters, user_agent)
       end
 
       it 'generates a ticket-granting ticket' do
         listener.should_receive(:granted_service_ticket_via_api).with(/^ST\-/)
         expect {
-          processor.process(ticket_granting_ticket, parameters)
+          processor.process(ticket, parameters, user_agent)
         }.to change(CASinoCore::Model::ServiceTicket, :count).by(1)
       end
 
@@ -36,7 +38,7 @@ describe CASinoCore::Processor::API::ServiceTicketProvider do
 
         it 'calls the #no_service_provided_via_api method on the listener' do
           listener.should_receive(:no_service_provided_via_api)
-          processor.process(ticket_granting_ticket, parameters)
+          processor.process(ticket, parameters, user_agent)
         end
       end
 

metadata

@@ -2,7 +2,7 @@
 name: casino_core
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors: 
 - Nils Caspar
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-12-30 00:00:00 Z
+date: 2012-12-31 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activerecord
@@ -288,7 +288,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -2705901659147789141
+      hash: -3280265477686707578
       segments: 
       - 0
       version: "0"