casino_core 0.0.3 → 0.0.4

data/VERSION

@@ -1 +1 @@
-0.0.3
+0.0.4

data/casino_core.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "casino_core"
-  s.version = "0.0.3"
+  s.version = "0.0.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Nils Caspar"]
-  s.date = "2012-12-17"
+  s.date = "2012-12-19"
   s.description = "A CAS server core library."
   s.email = "ncaspar@me.com"
   s.extra_rdoc_files = [

data/lib/casino_core/model/ticket_granting_ticket.rb

@@ -11,4 +11,12 @@ class CASinoCore::Model::TicketGrantingTicket < ActiveRecord::Base
     user_agent = UserAgent.parse(self.user_agent)
     "#{user_agent.browser} (#{user_agent.platform})"
   end
+
+  def same_user?(other_ticket)
+    if other_ticket.nil?
+      false
+    else
+      other_ticket.username == self.username
+    end
+  end
 end

data/lib/casino_core/processor/logout.rb

@@ -3,21 +3,15 @@ require 'casino_core/helper'
 require 'casino_core/model'
 
 class CASinoCore::Processor::Logout < CASinoCore::Processor
-  include CASinoCore::Helper
+  include CASinoCore::Helper::TicketGrantingTickets
 
-  def process(params = nil, cookies = nil)
-    params = params || {}
+  def process(params = nil, cookies = nil, user_agent = nil)
+    params ||= {}
     cookies ||= {}
-    session_destroyer = CASinoCore::Processor::SessionDestroyer.new(DummyListener.new)
-    session_destroyer.process(cookies[:tgt])
-    @listener.user_logged_out(params[:url])
-  end
-
-  class DummyListener
-    def ticket_deleted(*args)
-    end
-
-    def ticket_not_found(*args)
+    ticket_granting_ticket = find_valid_ticket_granting_ticket(cookies[:tgt], user_agent)
+    unless ticket_granting_ticket.nil?
+      ticket_granting_ticket.destroy
     end
+    @listener.user_logged_out(params[:url])
   end
 end

data/lib/casino_core/processor/session_destroyer.rb

@@ -2,12 +2,23 @@ require 'casino_core/processor'
 require 'casino_core/helper'
 require 'casino_core/model'
 
+# The SessionDestroyer processor is used to destroy a ticket-granting ticket.
+#
+# This feature is not described in the CAS specification so it's completly optional
+# to implement this on the web application side. It is especially useful in
+# combination with the {CASinoCore::Processor::SessionOverview} processor.
 class CASinoCore::Processor::SessionDestroyer < CASinoCore::Processor
-  include CASinoCore::Helper
 
-  def process(tgt)
-    ticket = CASinoCore::Model::TicketGrantingTicket.where(ticket: tgt).first
-    if ticket.nil?
+  # This method will call `#ticket_not_found` or `#ticket_deleted` on the listener.
+  # @param [Hash] params parameters supplied by user (ID of ticket-granting ticket to delete should by in params[:id])
+  # @param [Hash] cookies cookies supplied by user
+  # @param [String] user_agent user-agent delivered by the client
+  def process(params = nil, cookies = nil, user_agent = nil)
+    params ||= {}
+    cookies ||= {}
+    ticket = CASinoCore::Model::TicketGrantingTicket.where(id: params[:id]).first
+    owner_ticket = CASinoCore::Model::TicketGrantingTicket.where(ticket: cookies[:tgt]).first
+    if ticket.nil? || !ticket.same_user?(owner_ticket)
       @listener.ticket_not_found
     else
       ticket.destroy

data/spec/processor/logout_spec.rb

@@ -7,6 +7,7 @@ describe CASinoCore::Processor::Logout do
     let(:cookies) { { tgt: tgt } }
     let(:url) { nil }
     let(:params) { { :url => url } unless url.nil? }
+    let(:user_agent) { 'TestBrowser 1.0' }
 
     before(:each) do
       listener.stub(:user_logged_out)
@@ -18,19 +19,19 @@ describe CASinoCore::Processor::Logout do
           ticket: 'TGC-HXdkW233TsRtiqYGq4b8U7',
           username: 'test',
           extra_attributes: nil,
-          user_agent: 'TestBrowser 1.0'
+          user_agent: user_agent
         })
       }
       let(:tgt) { ticket_granting_ticket.ticket }
 
-      it 'calls the #process method of SessionDestroyer' do
-        CASinoCore::Processor::SessionDestroyer.any_instance.should_receive(:process).with(tgt)
-        processor.process(params, cookies)
+      it 'deletes the ticket-granting ticket' do
+        processor.process(params, cookies, user_agent)
+        CASinoCore::Model::TicketGrantingTicket.where(id: ticket_granting_ticket.id).first.should == nil
       end
 
       it 'calls the #user_logged_out method on the listener' do
         listener.should_receive(:user_logged_out).with(nil)
-        processor.process(params, cookies)
+        processor.process(params, cookies, user_agent)
       end
 
       context 'with an URL' do
@@ -38,7 +39,7 @@ describe CASinoCore::Processor::Logout do
 
         it 'calls the #user_logged_out method on the listener and passes the URL' do
           listener.should_receive(:user_logged_out).with(url)
-          processor.process(params, cookies)
+          processor.process(params, cookies, user_agent)
         end
       end
     end

data/spec/processor/session_destroyer_spec.rb

@@ -5,7 +5,7 @@ describe CASinoCore::Processor::SessionDestroyer do
     let(:listener) { Object.new }
     let(:processor) { described_class.new(listener) }
     let(:user_agent) { 'TestBrowser 1.0' }
-    let(:other_ticket_granting_ticket) {
+    let(:owner_ticket_granting_ticket) {
       CASinoCore::Model::TicketGrantingTicket.create!({
         ticket: 'TGC-ocCudGzZjJtrvOXJ485mt3',
         username: 'test',
@@ -13,6 +13,7 @@ describe CASinoCore::Processor::SessionDestroyer do
         user_agent: user_agent
       })
     }
+    let(:cookies) { { tgt: owner_ticket_granting_ticket.ticket } }
 
     before(:each) do
       listener.stub(:ticket_deleted)
@@ -28,40 +29,64 @@ describe CASinoCore::Processor::SessionDestroyer do
           user_agent: user_agent
         })
       }
-      let(:tgt) { ticket_granting_ticket.ticket }
+      let(:params) { { id: ticket_granting_ticket.id } }
 
       it 'deletes only one ticket-granting ticket' do
         ticket_granting_ticket
-        other_ticket_granting_ticket
+        owner_ticket_granting_ticket
         lambda do
-          processor.process(tgt)
+          processor.process(params, cookies, user_agent)
         end.should change(CASinoCore::Model::TicketGrantingTicket, :count).by(-1)
       end
 
       it 'deletes the ticket-granting ticket' do
-        processor.process(tgt)
-        CASinoCore::Model::TicketGrantingTicket.where(ticket: tgt).length.should == 0
+        processor.process(params, cookies, user_agent)
+        CASinoCore::Model::TicketGrantingTicket.where(id: params[:id]).length.should == 0
       end
 
       it 'calls the #ticket_deleted method on the listener' do
         listener.should_receive(:ticket_deleted).with(no_args)
-        processor.process(tgt)
+        processor.process(params, cookies, user_agent)
       end
     end
 
     context 'with an invlaid ticket-granting ticket' do
-      let(:tgt) { 'TGT-lalala' }
+      let(:params) { { id: 99999 } }
+      it 'does not delete a ticket-granting ticket' do
+        owner_ticket_granting_ticket
+        lambda do
+          processor.process(params, cookies, user_agent)
+        end.should change(CASinoCore::Model::TicketGrantingTicket, :count).by(0)
+      end
+
+      it 'calls the #ticket_not_found method on the listener' do
+        listener.should_receive(:ticket_not_found).with(no_args)
+        processor.process(params, cookies, user_agent)
+      end
+    end
+
+    context 'when trying to delete ticket-granting ticket of another user' do
+      let(:ticket_granting_ticket) {
+        CASinoCore::Model::TicketGrantingTicket.create!({
+          ticket: 'TGC-HXdkW233TsRtiqYGq4b8U7',
+          username: 'this_is_another_user',
+          extra_attributes: nil,
+          user_agent: user_agent
+        })
+      }
+      let(:params) { { id: ticket_granting_ticket.id } }
 
       it 'does not delete a ticket-granting ticket' do
-        other_ticket_granting_ticket
+        owner_ticket_granting_ticket
+        ticket_granting_ticket
         lambda do
-          processor.process(tgt)
+          processor.process(params, cookies, user_agent)
         end.should change(CASinoCore::Model::TicketGrantingTicket, :count).by(0)
       end
 
       it 'calls the #ticket_not_found method on the listener' do
         listener.should_receive(:ticket_not_found).with(no_args)
-        processor.process(tgt)
+        processor.process(params, cookies, user_agent)
       end
     end
   end

metadata

@@ -2,7 +2,7 @@
 name: casino_core
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors: 
 - Nils Caspar
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-12-17 00:00:00 Z
+date: 2012-12-19 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activerecord
@@ -219,7 +219,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 4231038589682610511
+      hash: 3879793628887711018
       segments: 
       - 0
       version: "0"