casino-ldap_authenticator 2.0.1 → 2.0.2

data/lib/casino/ldap_authenticator.rb

@@ -42,7 +42,7 @@ class CASino::LDAPAuthenticator
       @ldap.auth(@options[:admin_user], @options[:admin_password])
     end
     @user_plain = @ldap.bind_as(:base => @options[:base], :size => 1, :password => @password, :filter => user_filter)
-    if @user_plain != false
+    if @user_plain
       include_attributes = @options[:extra_attributes].values + [username_attribute]
       @user_plain = @ldap.search(:base => @options[:base], :filter => user_filter, :attributes => include_attributes)
       if @user_plain.is_a?(Array)

data/lib/casino/ldap_authenticator/version.rb

@@ -1,5 +1,5 @@
 module CASino
   class LDAPAuthenticator
-    VERSION = '2.0.1'
+    VERSION = '2.0.2'
   end
 end

data/spec/casino/ldap_authenticator_spec.rb

@@ -43,9 +43,26 @@ describe CASino::LDAPAuthenticator do
       subject.validate(username, password)
     end
 
-    it 'calls the #search method on the LDAP connection' do
-      connection.should_receive(:search).with(:base => options[:base], :filter => user_filter, :attributes => extra_attributes + [options[:username_attribute]])
-      subject.validate(username, password)
+    context 'when validation succeeds' do
+      before(:each) do
+        connection.stub(:bind_as).and_return(Net::LDAP::Entry.new)
+      end
+
+      it 'calls the #search method on the LDAP connection' do
+        connection.should_receive(:search).with(:base => options[:base], :filter => user_filter, :attributes => extra_attributes + [options[:username_attribute]])
+        subject.validate(username, password)
+      end
+    end
+
+    context 'when validation fails' do
+      before(:each) do
+        connection.stub(:bind_as).and_return(false)
+      end
+
+      it 'does not call the #search method on the LDAP connection' do
+        connection.should_not_receive(:search)
+        subject.validate(username, password)
+      end
     end
 
     context 'when validation succeeds for user with missing data' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: casino-ldap_authenticator
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-14 00:00:00.000000000 Z
+date: 2015-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake