cartman 2.1.0 → 2.1.1

data/lib/cartman/cart.rb

@@ -29,11 +29,11 @@ module Cartman
     end
 
     def items(type=nil)
-      items = ItemCollection.new(line_item_ids.collect{ |item_id| get_item(item_id)})
       if type
-        return items.select{ |item| item.type == type }
+        items = line_item_ids.collect{ |item_id| get_item(item_id)}.select{ |item| item.type == type }
+        return ItemCollection.new(items)
       else
-        return items
+        return ItemCollection.new(line_item_ids.collect{ |item_id| get_item(item_id)})
       end
     end
 

data/lib/cartman/version.rb

@@ -1,3 +1,3 @@
 module Cartman
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/spec/item_collection_spec.rb

@@ -2,8 +2,7 @@ require 'spec_helper'
 
 describe Cartman do
   describe Cartman::ItemCollection do
-    before(:all) do
-    end
+    let(:cart) { Cartman::Cart.new(1) }
 
     before(:each) do
       Cartman.config.redis.flushdb
@@ -11,14 +10,21 @@ describe Cartman do
       Bottle = double
       Bottle.stub(:find).and_return(bottle)
     end
-    
+
     describe "#each_with_object" do
       let(:bottle) { double("Bottle") }
+
       it "should be magical" do
-        cart = Cartman::Cart.new(1)
-        cart.add_item(id: 17, type: "Bottle", name: "Bordeux", unit_cost: 92.12, cost: 184.24, quantity: 2) 
+        cart.add_item(id: 17, type: "Bottle", name: "Bordeux", unit_cost: 92.12, cost: 184.24, quantity: 2)
         expect { |b| cart.items.each_with_object(&b)}.to yield_successive_args([cart.items.first, bottle])
       end
+
+      it "should work with items('Type')" do
+        cart.add_item(id: 17, type: "Bottle", name: "Bordeux", unit_cost: 92.12, cost: 184.24, quantity: 2)
+        cart.add_item(id: 27, type: "UserGiftCard", unit_cost: 25, quantity: 1)
+        expect { |b| cart.items("Bottle").each_with_object(&b)}.to_not raise_error(ArgumentError)
+      end
+
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cartman
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
   prerelease: 
 platform: ruby
 authors: