carrierwave_reupload_fix 0.1.0 → 0.2.0

data/CHANGELOG.md

@@ -0,0 +1,8 @@
+# Version 0.2.0
+
+Fix bug in update action - in version 0.1.0 it always returned true
+
+# Version 0.1.0
+
+First release
+

data/lib/carrierwave_reupload_fix/version.rb

@@ -1,3 +1,3 @@
 module CarrierwaveReuploadFix
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/lib/carrierwave_reupload_fix.rb

@@ -41,8 +41,12 @@ module CarrierwaveReuploadFix
     alias :original_update :update
 
     def update(attributes)
-      original_update(attributes)
-      ReuploadFixer.new(self, VersionsRecreator.new, ExtensionsAssigner.new).fix
+      if original_update(attributes)
+        ReuploadFixer.new(self, VersionsRecreator.new, ExtensionsAssigner.new).fix
+        true
+      else
+        false
+      end
     end
   end
 end

data/spec/carrierwave_reupload_fix_spec.rb

@@ -56,17 +56,43 @@ describe CarrierwaveReuploadFix do
     expect(DummyMainModel.new).to respond_to :update
   end
 
-  it "calls fixer on update" do
-    model_instance = DummyMainModel.new
-    fixer = double(:fixer)
-    recreator = double(:recreator)
-    assigner = double(:assigner)
-    CarrierwaveReuploadFix::VersionsRecreator.stub(:new) { recreator }
-    CarrierwaveReuploadFix::ExtensionsAssigner.stub(:new) { assigner }
-    CarrierwaveReuploadFix::ReuploadFixer.should_receive(:new).with(model_instance,
-        recreator, assigner) { fixer }
-    fixer.should_receive(:fix)
-    model_instance.update({})
+  context "#update" do
+
+    it "calls fixer on update if update returns true and the entire" do
+      model_instance = DummyMainModel.new
+      model_instance.stub(:original_update) { true }
+      fixer = double(:fixer)
+      recreator = double(:recreator)
+      assigner = double(:assigner)
+      CarrierwaveReuploadFix::VersionsRecreator.stub(:new) { recreator }
+      CarrierwaveReuploadFix::ExtensionsAssigner.stub(:new) { assigner }
+      CarrierwaveReuploadFix::ReuploadFixer.should_receive(:new).with(model_instance,
+          recreator, assigner) { fixer }
+      fixer.should_receive(:fix)
+      model_instance.update({})
+    end
+
+    it "returns true if original_update returns true" do
+      model_instance = DummyMainModel.new
+      model_instance.stub(:original_update) { true }
+      CarrierwaveReuploadFix::VersionsRecreator.stub(:new)
+      CarrierwaveReuploadFix::ExtensionsAssigner.stub(:new)
+      CarrierwaveReuploadFix::ReuploadFixer.stub_chain(:new, :fix)
+      expect(model_instance.update({})).to be true
+    end
+
+    it "does not call fixer if original_update returns false" do
+      model_instance = DummyMainModel.new
+      model_instance.stub(:original_update) { false }
+      CarrierwaveReuploadFix::ReuploadFixer.should_not_receive(:new)
+      model_instance.update({})
+    end
+
+    it "returns false if original_update returns false" do
+      model_instance = DummyMainModel.new
+      model_instance.stub(:original_update) { false }
+      expect(model_instance.update({})).to be false
+    end
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: carrierwave_reupload_fix
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-09 00:00:00.000000000 Z
+date: 2013-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -100,6 +100,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md