carrierwave_reupload_fix 0.0.1

data/.gitignore

@@ -0,0 +1,17 @@
+*.gem
+*.rbc
+.bundle
+.config
+.yardoc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp

data/Gemfile

@@ -0,0 +1,4 @@
+source 'https://rubygems.org'
+
+# Specify your gem's dependencies in carrierwave_reupload_fix.gemspec
+gemspec

data/LICENSE.txt

@@ -0,0 +1,22 @@
+Copyright (c) 2013 Azdaroth
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -0,0 +1,130 @@
+# CarrierwaveReuploadFix
+
+Extension for fixing processing images with carrierwave on reupload when file extension changes.
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+    gem 'carrierwave_reupload_fix'
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install carrierwave_reupload_fix
+
+## Usage
+
+Consider a Carrierwave uploader below:
+
+```ruby
+class SomeUploader < CarrierWave::Uploader::Base
+
+  # some code
+
+  def filename
+    "original.#{model.logo.file.extension}" if original_filename
+  end
+
+  version :thumb do
+    # some processing
+    process :convert => 'png'
+    def full_filename(for_file)
+      "thumb.png"
+    end
+  end
+
+end
+```
+
+When you upload an image for the first time, e.g. img.jpg, the original file is saved as original.jpg and thumb.png is created, when reuploading file with the same extension, everything works as expected, the uploaded file is again stored as original.jpg and a thumb is created. But if a file with diffrent extension is reuploaded, thumb version is not being processed. This gem solves this problem by overriding original ActiveRecord::Persistence#update method when CarrierwaveReuploadFix module is included to a model. It requires string database column, which stores the extension of the file, so that it knows, when to call #recreate_versions!, e.g. when you have :image column, the :image_extension column is also required. 
+
+To fix images on reupload, add this in your model:
+
+```ruby
+fix_on_reupload :image_column, :another_image_column
+```
+
+It works also with nested attributes, just add symbols with associations e.g.:
+    
+```ruby
+nested_fix_on_reupload :photos, :profile
+```
+
+And restart your application.
+
+Example:
+
+
+```ruby
+class DummyModel < ActiveRecord::Base
+
+  include CarrierwaveReuploadFix
+
+  has_many :associated_records
+  has_one :profile
+
+  accepts_nested_attributes_for :associated_records
+  accepts_nested_attributes_for :profile
+
+  mount_uploader :logo, LogoUploader
+  mount_uploader :image, ImageUploader
+
+  # add logo_extension and image_extension columns
+
+  fix_on_reupload :logo, :image
+  nested_fix_on_reupload :associated_records, :profile
+
+end
+
+class AssociatedRecord < ActiveRecord::Base
+
+  include CarrierwaveReuploadFix
+
+  belongs_to :dummy_model
+
+  # add photo_extension column
+
+  mount_uploader :photo, PhotoUploader
+  fix_on_reupload :photo
+
+end
+
+class Profile < ActiveRecord::Base
+
+  include CarrierwaveReuploadFix
+
+  belongs_to :dummy_model
+
+  # add img_extension column
+
+  mount_uploader :img, ImgUploader
+  fix_on_reupload :img
+
+end
+```
+
+Use ActiveRecord::Persistence#update method:
+
+```ruby
+DummyModel.find(id).update(some_attributes) 
+```
+
+Restart your application and enjoy.
+
+Works with Rails 4. If you are using Rails 3, you should alias update_attributes to update:
+
+```ruby
+alias :update :update_attributes
+```
+
+## Contributing
+
+1. Fork it
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Commit your changes (`git commit -am 'Add some feature'`)
+4. Push to the branch (`git push origin my-new-feature`)
+5. Create new Pull Request

data/Rakefile

@@ -0,0 +1,12 @@
+require "bundler/gem_tasks"
+require 'rake'
+require 'rspec/core/rake_task'
+
+Bundler::GemHelper.install_tasks
+
+desc "Run tests"
+RSpec::Core::RakeTask.new(:spec) do |t|
+  t.rspec_opts = %w[--color]
+end
+
+task :default => [:spec]

data/carrierwave_reupload_fix.gemspec

@@ -0,0 +1,28 @@
+# coding: utf-8
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'carrierwave_reupload_fix/version'
+
+Gem::Specification.new do |spec|
+  spec.name          = "carrierwave_reupload_fix"
+  spec.version       = CarrierwaveReuploadFix::VERSION
+  spec.authors       = ["Azdaroth"]
+  spec.email         = ["azdaroth@gmail.com"]
+  spec.description   = %q{Extension for fixing processing images with carrierwave on reupload
+                          when file extension changes}
+  spec.summary       = %q{Extension for fixing processing images with carrierwave}
+  spec.homepage      = "https://github.com/Azdaroth/carrierwave_reupload_fix"
+  spec.license       = "MIT"
+
+  spec.files         = `git ls-files`.split($/)
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.require_paths = ["lib"]
+
+  spec.add_development_dependency "bundler", "~> 1.3"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec"
+  spec.add_dependency "carrierwave"
+  spec.add_dependency("rails", [">= 3.0"])
+
+end

data/lib/carrierwave_reupload_fix.rb

@@ -0,0 +1,48 @@
+require "carrierwave_reupload_fix/version"
+require "carrierwave_reupload_fix/reupload_fixer"
+require "carrierwave_reupload_fix/versions_recreator"
+require "carrierwave_reupload_fix/extensions_assigner"
+require 'active_support/concern'
+require 'active_support/core_ext/object'
+
+module CarrierwaveReuploadFix
+  extend ActiveSupport::Concern
+
+  included do
+
+    def self.carrierwave_fields_marked_for_fix_on_reupload
+      @carrierwave_fields_marked_for_fix_on_reupload ||= []
+    end
+
+    def self.associations_marked_for_fix_in_nested_attributes
+      @associations_marked_for_fix_in_nested_attributes ||= []
+    end
+
+    def self.fix_on_reupload(*marked_fields)  
+      fields = carrierwave_fields_marked_for_fix_on_reupload
+      marked_fields.each { |field| fields << field }
+      @carrierwave_fields_marked_for_fix_on_reupload = fields
+    end
+
+    def self.nested_fix_on_reupload(*associations)
+      assocs = associations_marked_for_fix_in_nested_attributes
+      associations.each { |assoc| assocs << assoc }
+      @associations_marked_for_fix_in_nested_attributes = assocs
+    end
+
+    def carrierwave_fields_marked_for_fix_on_reupload
+      self.class.carrierwave_fields_marked_for_fix_on_reupload
+    end
+
+    def associations_marked_for_fix_in_nested_attributes
+      self.class.associations_marked_for_fix_in_nested_attributes
+    end
+
+    alias :original_update :update
+
+    def update(attributes)
+      original_update(attributes)
+      ReuploadFixer.new(self, VersionsRecreator.new, ExtensionsAssigner.new).fix
+    end
+  end
+end

data/lib/carrierwave_reupload_fix/extensions_assigner.rb

@@ -0,0 +1,10 @@
+module CarrierwaveReuploadFix
+  class ExtensionsAssigner
+    
+    def assign(model_instance, field, extension)
+      model_instance.send("#{field}_extension=", extension)
+      model_instance.save
+    end
+
+  end
+end

data/lib/carrierwave_reupload_fix/reupload_fixer.rb

@@ -0,0 +1,55 @@
+module CarrierwaveReuploadFix
+  class ReuploadFixer
+    
+    attr_reader :model_instance, :versions_recreator, :extension_assigner
+    def initialize(model_instance, versions_recreator, extension_assigner)
+      @model_instance = model_instance
+      @versions_recreator = versions_recreator
+      @extension_assigner = extension_assigner
+    end
+
+    def fix
+      fix_carrierwave_processing(model_instance)
+      handle_associations
+    end
+
+    def handle_associations
+      model_instance.associations_marked_for_fix_in_nested_attributes.each do |assoc|
+        Array(model_instance.send(assoc)).each do |record|
+          fix_carrierwave_processing(record) if record.carrierwave_fields_marked_for_fix_on_reupload.present?
+        end
+      end
+    end
+
+    def fix_carrierwave_processing(obj)
+      fix_carrierwave(obj)
+      assign_extensions(obj)
+    end
+
+    private
+
+      def fix_carrierwave(obj)
+        obj.carrierwave_fields_marked_for_fix_on_reupload.each do |field|
+          versions_recreator.recreate!(obj, field) if extension_changed?(obj, field)
+        end
+      end
+
+      def assign_extensions(obj)
+        obj.carrierwave_fields_marked_for_fix_on_reupload.each do |field|
+          current_extension = get_current_extension(obj, field)
+          extension_assigner.assign(obj, field, current_extension) unless current_extension.nil?
+        end
+      end
+
+      def extension_changed?(obj, field)
+        previous_extension = obj.send("#{field}_extension".to_sym)
+        current_extension = get_current_extension(obj, field)
+        current_extension.present? and current_extension != previous_extension
+      end
+
+      def get_current_extension(obj, field)
+        obj.send(field).to_s.split('.').last
+      end
+
+  end
+end

data/lib/carrierwave_reupload_fix/version.rb

@@ -0,0 +1,3 @@
+module CarrierwaveReuploadFix
+  VERSION = "0.0.1"
+end

data/lib/carrierwave_reupload_fix/versions_recreator.rb

@@ -0,0 +1,9 @@
+module CarrierwaveReuploadFix
+  class VersionsRecreator
+   
+    def recreate!(model_instance, field)
+      model_instance.send(field).recreate_versions!
+    end
+
+  end
+end

data/spec/carrierwave_reupload_fix/extenions_assigner_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe CarrierwaveReuploadFix::ExtensionsAssigner do 
+
+  it "assigns extenions and saves record" do
+    obj = double(:obj)
+    assigner = CarrierwaveReuploadFix::ExtensionsAssigner.new
+    obj.should_receive("image_extension=").with("jpg") { obj }
+    obj.should_receive(:save)
+    assigner.assign(obj, :image, "jpg")
+  end
+
+end

data/spec/carrierwave_reupload_fix/reupload_fixer_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe CarrierwaveReuploadFix::ReuploadFixer do
+
+  let(:associated_obj) { double(:associated_obj,
+    image: "image.jpg",
+    image_extension: "pdf",
+    carrierwave_fields_marked_for_fix_on_reupload: [:image] ) } 
+
+  let(:associated_records) { [associated_obj] }
+
+  let(:model_instance) { double(:model_instance, 
+    logo: "logo.jpg",
+    logo_extension: "pdf",
+    photos: associated_records,
+    carrierwave_fields_marked_for_fix_on_reupload: [:logo],
+    associations_marked_for_fix_in_nested_attributes: [] ) }
+
+  let(:versions_recreator) { double(:versions_recreator) }
+  let(:extensions_assigner) { double(:extensions_assigner) }
+
+  describe "no associations passed" do
+
+    context "extensions changed" do
+      it "recreates versions and assigns new extensions" do
+        fixer = CarrierwaveReuploadFix::ReuploadFixer.new(model_instance,
+          versions_recreator, extensions_assigner)
+        versions_recreator.should_receive(:recreate!).with(model_instance, :logo) { true }
+        extensions_assigner.should_receive(:assign).with(model_instance, :logo, "jpg")
+        fixer.fix
+      end
+    end
+
+    context "has not changed" do
+      it "does not recreate_versions but assign extensions" do
+        fixer = CarrierwaveReuploadFix::ReuploadFixer.new(model_instance,
+          versions_recreator, extensions_assigner)
+        model_instance.stub(:logo_extension) { "jpg" }
+        versions_recreator.should_not_receive(:recreate!).with(model_instance, :logo)
+        extensions_assigner.should_receive(:assign).with(model_instance, :logo, "jpg") 
+        fixer.fix
+      end
+    end
+
+  end
+    
+
+  context "associations passed" do
+    it "recreates versions and assigns extensions on associated objects" do
+      fixer = CarrierwaveReuploadFix::ReuploadFixer.new(model_instance,
+          versions_recreator, extensions_assigner)
+      model_instance.stub(:associations_marked_for_fix_in_nested_attributes) { [:photos] }
+      versions_recreator.should_receive(:recreate!).with(associated_obj, :image)
+      extensions_assigner.should_receive(:assign).with(associated_obj, :image, "jpg") { true }
+      fixer.handle_associations
+    end
+  end
+
+end

data/spec/carrierwave_reupload_fix/versions_recreator_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+
+describe CarrierwaveReuploadFix::VersionsRecreator do 
+
+  it "calls recreate_version! on specified file" do
+    recreator = CarrierwaveReuploadFix::VersionsRecreator.new
+    obj = double(:obj, image: double)
+    obj.image.should_receive(:recreate_versions!)
+    recreator.recreate!(obj, :image)
+  end
+
+end

data/spec/carrierwave_reupload_fix_spec.rb

@@ -0,0 +1,73 @@
+$: << File.join(File.dirname(__FILE__), "/../lib")
+require 'spec_helper'
+require_relative '../lib/carrierwave_reupload_fix' 
+
+
+class DummyMainModel
+  def update(args) ; end
+
+  include CarrierwaveReuploadFix
+
+  def offers
+    [DummyAssociatedModel.new, DummyAssociatedModel.new]
+  end
+
+  def logo; end
+
+  def image; end
+
+  fix_on_reupload :logo, :image
+  nested_fix_on_reupload :offers
+
+end
+
+class DummyAssociatedModel
+
+  def update(args) ; end
+
+  include CarrierwaveReuploadFix
+
+  def photo; end
+
+  fix_on_reupload :photo
+end
+
+
+describe CarrierwaveReuploadFix do
+
+  it "adds fields to be fixed to class instance variables" do
+    expect(DummyMainModel.carrierwave_fields_marked_for_fix_on_reupload).to eq [:logo, :image]
+  end
+
+  it "adds associations to be fixed" do
+    expect(DummyMainModel.associations_marked_for_fix_in_nested_attributes).to eq [:offers]
+  end
+
+  specify "instances of models know about fields to be fixed" do
+    expect(DummyMainModel.new.carrierwave_fields_marked_for_fix_on_reupload).to eq [:logo, :image]
+  end
+
+  specify "instances of models know about associations to be fixed" do
+    expect(DummyMainModel.new.associations_marked_for_fix_in_nested_attributes).to eq [:offers]
+  end
+
+  it "aliases update to original_update" do
+    expect(DummyMainModel.new).to respond_to :original_update
+    expect(DummyMainModel.new).to respond_to :update
+  end
+
+  it "calls fixer on update" do
+    model_instance = DummyMainModel.new
+    fixer = double(:fixer)
+    recreator = double(:recreator)
+    assigner = double(:assigner)
+    CarrierwaveReuploadFix::VersionsRecreator.stub(:new) { recreator }
+    CarrierwaveReuploadFix::ExtensionsAssigner.stub(:new) { assigner }
+    CarrierwaveReuploadFix::ReuploadFixer.should_receive(:new).with(model_instance,
+        recreator, assigner) { fixer }
+    fixer.should_receive(:fix)
+    model_instance.update({})
+  end
+
+end
+

data/spec/spec_helper.rb

@@ -0,0 +1,7 @@
+require 'rubygems'
+require 'bundler/setup'
+require 'rspec'
+
+require "carrierwave_reupload_fix/reupload_fixer"
+require "carrierwave_reupload_fix/versions_recreator"
+require "carrierwave_reupload_fix/extensions_assigner"

metadata

@@ -0,0 +1,148 @@
+--- !ruby/object:Gem::Specification
+name: carrierwave_reupload_fix
+version: !ruby/object:Gem::Version
+  version: 0.0.1
+  prerelease: 
+platform: ruby
+authors:
+- Azdaroth
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2013-07-09 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: carrierwave
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '3.0'
+description: ! "Extension for fixing processing images with carrierwave on reupload\n
+  \                         when file extension changes"
+email:
+- azdaroth@gmail.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- .gitignore
+- Gemfile
+- LICENSE.txt
+- README.md
+- Rakefile
+- carrierwave_reupload_fix.gemspec
+- lib/carrierwave_reupload_fix.rb
+- lib/carrierwave_reupload_fix/extensions_assigner.rb
+- lib/carrierwave_reupload_fix/reupload_fixer.rb
+- lib/carrierwave_reupload_fix/version.rb
+- lib/carrierwave_reupload_fix/versions_recreator.rb
+- spec/carrierwave_reupload_fix/extenions_assigner_spec.rb
+- spec/carrierwave_reupload_fix/reupload_fixer_spec.rb
+- spec/carrierwave_reupload_fix/versions_recreator_spec.rb
+- spec/carrierwave_reupload_fix_spec.rb
+- spec/spec_helper.rb
+homepage: https://github.com/Azdaroth/carrierwave_reupload_fix
+licenses:
+- MIT
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 1.8.25
+signing_key: 
+specification_version: 3
+summary: Extension for fixing processing images with carrierwave
+test_files:
+- spec/carrierwave_reupload_fix/extenions_assigner_spec.rb
+- spec/carrierwave_reupload_fix/reupload_fixer_spec.rb
+- spec/carrierwave_reupload_fix/versions_recreator_spec.rb
+- spec/carrierwave_reupload_fix_spec.rb
+- spec/spec_helper.rb