carrierwave-cloudflare 0.3.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 995cee5f213250acfd445e8e5a246273c1560f15eceb6f48acb115dc45865045
-  data.tar.gz: a6ad5797dbe08b8c66efe7181e960384115cd37007686029e1ce20e62ed86b31
+  metadata.gz: 9e6c83dc0ef7c551b8993c4db9f98795eaf225a0dbfa871878e2addcb08b9755
+  data.tar.gz: 856b61f04aa55809719761cb12a7989b30f69b13ac057c2c146b363b543c79f7
 SHA512:
-  metadata.gz: 3fe828b4f6014ada52ab7b8298af0791b6e32888b1b1943475bacc81c21dc6fd61394246814c713a645441ea72e930fca94865779f8c901dbab915a32d9b2ff6
-  data.tar.gz: e917a114cf588fb87f711070ca281e658bac10747d5291c80e00d7554354de43e374e65b14e99e90f5533f18522e24eb90338a052ffa366a1b0f10f15c284bf9
+  metadata.gz: 6d37c37f600a27e199e4f5226e020f177c7bc11e3b8853d36daf7ad2670226affbb00403ca9ddaf27b52f146151eed7bdde3a618f5e364f463713072b3a9cbe4
+  data.tar.gz: d9a5822144d398a58cc2982cf8a9b4853e47c9423a14702b90dac12f08fdc9fef9d5e14dd1a82135db7f1fbbbaeba131e118ca960078ccd1a6efd92786882ea3

data/CHANGELOG.md

@@ -0,0 +1,5 @@
+CHANGELOG
+
+== 0.4.0 (2022-07-18)
+
+- Set `width` and `height` attributes to the image tag if values exist

data/README.md

@@ -1,9 +1,9 @@
-# Carrierwave::Cloudflare
+# CarrierWave::Cloudflare
 
 [![Tests](https://github.com/resume-io/carrierwave-cloudflare/actions/workflows/run-specs.yml/badge.svg?branch=master)](https://github.com/resume-io/carrierwave-cloudflare/actions/workflows/run-specs.yml)
 [![Gem Version](https://badge.fury.io/rb/carrierwave-cloudflare.svg)](https://badge.fury.io/rb/carrierwave-cloudflare)
 
-This gem integrates CarrierWave with [Cloudflare Image Resizing](https://developers.cloudflare.com/images/)
+This gem integrates CarrierWave with [Cloudflare Image Resizing](https://developers.cloudflare.com/images/image-resizing)
 
 
 ## Installation
@@ -18,7 +18,7 @@ And then execute:
 
     $ bundle install
 
-Or install it yourself as:
+Or install it yourself with:
 
     $ gem install carrierwave-cloudflare
 
@@ -32,7 +32,7 @@ class BaseUploader < CarrierWave::Uploader::Base
 end
 ```
 
-Use `cdn_transform` for define Cloudflare's version (this means that now the file will not be stored on the, but will be transformed on the cloudflare side)
+Use `cdn_transform` to define Cloudflare's version (this means that now the file will not be stored on a server, but will be transformed on the Cloudflare side)
 
 ```ruby
 class AvatarUploader < BaseUploader
@@ -56,9 +56,9 @@ Supported options:
 
 `width`, `height`, `dpr`, `fit`, `gravity`, `quality`, `format`, `onerror`, `metadata`
 
-See details in Cloudflare [documentation](https://developers.cloudflare.com/images/url-format)
+See details in Cloudflare's [documentation](https://developers.cloudflare.com/images/url-format)
 
-Also, you can define default options (supports all options described above)
+You can also define default options (supports all options described above)
 
 ```ruby
 class BaseUploader < CarrierWave::Uploader::Base
@@ -68,7 +68,7 @@ end
 
 ### In development env
 
-In development, you don't need to generate URLs for Cloudflare, because they will not work and therefore you need to disable the Cloudflare transform
+In development you don't need to generate URLs for Cloudflare, because they will not work and therefore you need to disable the Cloudflare transform
 
 ``` ruby
 CarrierWave::Cloudflare.configure do |config|
@@ -76,10 +76,7 @@ CarrierWave::Cloudflare.configure do |config|
 end
 ```
 
-`cloudflare_transform: false` disables links generation and put all Cloudflare's arguments into query string (for easy debugging)
-
-e.g:
-
+`cloudflare_transform: false` disables links generation and puts all Cloudflare's arguments into query string (for easy debugging)
 ```
 /1.jpg?cdn-cgi=width-11.height-300.fit-pad
 ```
@@ -100,7 +97,7 @@ cdn_transformed('/cdn-cgi/image/width=100,fit=pad/img.jpg', width: 333)
 
 ### hidpi_image_tag(url, dprs: nil, **options)
 
-Returns an image tag with with scaled variations (via `srcset`) attribute for devices with different DPR values.
+Returns an image tag with scaled variations (via `srcset`) attribute for devices with different DPR values.
 
 
 The transformation of the original image should be specified via options.
@@ -131,6 +128,10 @@ responsive_image_tag('/bird.jpg', width: 1200, sizes: { phone: 600, tablet: 800
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+After checking out the repo, run `bin/setup` to install dependencies. Then run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+
+## License
+
+This project is licensed and distributed under the terms of the [MIT license](https://github.com/resume-io/carrierwave-cloudflare/blob/master/LICENSE.txt). 

data/carrierwave-cloudflare.gemspec

@@ -33,4 +33,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rack", "~> 2.0"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rubocop"
 end

data/lib/carrierwave/cloudflare/action_view/responsive_images_helper.rb

@@ -47,6 +47,8 @@ module CarrierWave
           image_tag(
             cdn_transformed(url, **transform),
             srcset: hidpi_image_srcset(url, dprs: dprs, **transform),
+            width: transform[:width],
+            height: transform[:height],
             **rest
           )
         end
@@ -73,7 +75,7 @@ module CarrierWave
           url = url.url if url.is_a?(CarrierWave::Uploader)
 
           if sizes.nil?
-            return hidpi_image_tag(url, **options)
+            return hidpi_image_tag(url, width: width, **options)
           end
 
           sizes[:default] = width
@@ -108,6 +110,8 @@ module CarrierWave
             base_version,
             srcset: srcset,
             sizes: sizes_attr,
+            width: width,
+            height: transform[:height],
             **rest
           )
         end

data/lib/carrierwave/cloudflare/version.rb

@@ -2,6 +2,6 @@
 
 module CarrierWave
   module Cloudflare
-    VERSION = "0.3.2"
+    VERSION = "0.4.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: carrierwave-cloudflare
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Mark Frost
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-08-02 00:00:00.000000000 Z
+date: 2022-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -109,6 +109,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description:
 email:
 - cheerful.mf@gmail.com
@@ -157,7 +171,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Wrapper for cloudflare transforming images