career_builder 0.2.1 → 0.2.2

data/VERSION

@@ -1 +1 @@
-0.2.1
+0.2.2

data/career_builder.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{career_builder}
-  s.version = "0.2.1"
+  s.version = "0.2.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Michael Guterl"]
-  s.date = %q{2011-04-04}
+  s.date = %q{2011-04-11}
   s.description = %q{Ruby wrapper for the CareerBuilder V2 HTTP XML API}
   s.email = %q{mguterl@gmail.com}
   s.extra_rdoc_files = [
@@ -51,7 +51,9 @@ Gem::Specification.new do |s|
     "spec/career_builder/client/authentication_spec.rb",
     "spec/career_builder/client/get_resume_spec.rb",
     "spec/career_builder/client/resume_actions_remaining_today_spec.rb",
+    "spec/career_builder/client_spec.rb",
     "spec/career_builder/resume/lazy_collection_spec.rb",
+    "spec/career_builder/resume_spec.rb",
     "spec/career_builder_spec.rb",
     "spec/spec.opts",
     "spec/spec_helper.rb",
@@ -66,7 +68,9 @@ Gem::Specification.new do |s|
     "spec/career_builder/client/authentication_spec.rb",
     "spec/career_builder/client/get_resume_spec.rb",
     "spec/career_builder/client/resume_actions_remaining_today_spec.rb",
+    "spec/career_builder/client_spec.rb",
     "spec/career_builder/resume/lazy_collection_spec.rb",
+    "spec/career_builder/resume_spec.rb",
     "spec/career_builder_spec.rb",
     "spec/spec_helper.rb",
     "spec/support/webmock.rb"

data/lib/career_builder/client.rb

@@ -16,9 +16,18 @@ module CareerBuilder
 
     attr_reader :email, :password
 
+    attr_accessor :connection_retry_count
+
+    DEFAULT_CONNECTION_RETRY_COUNT = 5
+    class << self
+      attr_accessor :connection_retry_count
+    end
+    self.connection_retry_count = DEFAULT_CONNECTION_RETRY_COUNT
+
     def initialize(email, password, options = {})
       @email, @password = email, password
       @debug = options.fetch(:debug) { false }
+      @connection_retry_count = options.fetch(:connection_retry_count) { Client.connection_retry_count }
     end
 
     def resumes(options = {})

data/lib/career_builder/resume.rb

@@ -2,26 +2,28 @@ module CareerBuilder
 
   class Resume < BasicObject
 
-    attr_reader :client
-
     def initialize(client, partial_resume)
-      @partial_resume = partial_resume
       @client = client
+      @partial_resume = partial_resume
     end
 
     def real_contact_email
       full_resume.contact_email
     end
-    
+
     def home_location
       full_resume.home_location
     end
 
+    def full_resume
+      @full_resume ||= fetch_full_resume
+    end
+
     private
 
     def method_missing(meth, *args, &block)
-      if partial_resume.respond_to?(meth)
-        partial_resume.send(meth, *args, &block)
+      if @partial_resume.respond_to?(meth)
+        @partial_resume.send(meth, *args, &block)
       else
         if full_resume.respond_to?(meth)
           full_resume.send(meth, *args, &block)
@@ -31,12 +33,13 @@ module CareerBuilder
       end
     end
 
-    def partial_resume
-      @partial_resume
-    end
-
-    def full_resume
-      @full_resume ||= client.get_resume(:resume_id => @partial_resume.id)
+    def fetch_full_resume
+      @client.get_resume(:resume_id => @partial_resume.id)
+    rescue Errno::ECONNRESET => e
+      count ||= 0
+      count += 1
+      retry unless count > @client.connection_retry_count
+      raise e
     end
 
   end

data/spec/career_builder/client_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe CareerBuilder::Client do
+
+  let(:client) { CareerBuilder::Client.new('valid_username', 'valid_password') }
+
+  describe '#connection_retry_count' do
+
+    it 'has a sane default value' do
+      client.connection_retry_count.should == CareerBuilder::Client.connection_retry_count
+    end
+
+    it 'allows the value to be specified during creation' do
+      client = CareerBuilder::Client.new('valid_username', 'valid_password', :connection_retry_count => 1)
+
+      client.connection_retry_count.should == 1
+    end
+  end
+
+end

data/spec/career_builder/resume_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+describe CareerBuilder::Resume do
+
+  context 'when fetching the full resume generates a connection error' do
+
+    let(:resume) { CareerBuilder::Resume.new(client, partial_resume) }
+
+    let(:client) { CareerBuilder::Client.new('valid_email', 'valid_password') }
+    let(:partial_resume) { double(:id => 42) }
+    let(:full_resume) { double(:contact_email => 'foo@bar.com') }
+
+    before do
+      client.should_receive(:get_resume).once.and_raise(Errno::ECONNRESET)
+      client.should_receive(:get_resume).at_most(:once).and_return(full_resume)
+    end
+
+    it 'retries, working around the connection errors' do
+      resume.real_contact_email.should == 'foo@bar.com'
+    end
+
+    it 'uses connection_retry_count to determine how many times to retry' do
+      client.connection_retry_count = 0
+
+      expect {
+        resume.real_contact_email
+      }.to raise_error(Errno::ECONNRESET)
+    end
+  end
+
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: career_builder
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: false
   segments: 
   - 0
   - 2
-  - 1
-  version: 0.2.1
+  - 2
+  version: 0.2.2
 platform: ruby
 authors: 
 - Michael Guterl
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-04 00:00:00 -04:00
+date: 2011-04-11 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -178,7 +178,9 @@ files:
 - spec/career_builder/client/authentication_spec.rb
 - spec/career_builder/client/get_resume_spec.rb
 - spec/career_builder/client/resume_actions_remaining_today_spec.rb
+- spec/career_builder/client_spec.rb
 - spec/career_builder/resume/lazy_collection_spec.rb
+- spec/career_builder/resume_spec.rb
 - spec/career_builder_spec.rb
 - spec/spec.opts
 - spec/spec_helper.rb
@@ -222,7 +224,9 @@ test_files:
 - spec/career_builder/client/authentication_spec.rb
 - spec/career_builder/client/get_resume_spec.rb
 - spec/career_builder/client/resume_actions_remaining_today_spec.rb
+- spec/career_builder/client_spec.rb
 - spec/career_builder/resume/lazy_collection_spec.rb
+- spec/career_builder/resume_spec.rb
 - spec/career_builder_spec.rb
 - spec/spec_helper.rb
 - spec/support/webmock.rb