card 1.98.1 → 1.98.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ff978d04e30fcde0b78bc07120e29d88129598b5
-  data.tar.gz: 69d3bdd7fef52579cf346519e21bafc83276bc9a
+  metadata.gz: 386e1ef385810519910b21aaa3cbc57b7da75dd6
+  data.tar.gz: 88edcd64fde3e3e416557826671ce526dbabe410
 SHA512:
-  metadata.gz: 2d953145ad131cf9fca1fa5d981b52cd78f2be3309ccef00f9e9fe1cd213b7cb1b2be7bc03a0545d4ca6b36930ca8e17a63297ce4becfd77a0eccd8c3aea1055
-  data.tar.gz: '08e3e5ff1f4a0a15385debef7d3a79f641fecd48109530a4f354e2e9b4438218d260732f10c35b86964ce703583831bfba5ff4665bb75d476e1fc73487ca596b'
+  metadata.gz: d5d4982608fc630b6c3d5e6543fe357789f6689caa865bb6c255896f1725903b3d0668b7a5a9f84aa220087b7bc18b2c559e57bfbfe45e777077cc6401d3821b
+  data.tar.gz: cdd231febca1a0c86de1907e00b85bea6999a0234b202252c66f1658bb9759a47ff18f32a5f7bd8482da460113a238839cf681438aef213f82481efc9dff6fc1

data/VERSION

@@ -1 +1 @@
-0.8.1
+0.8.2

data/lib/card/error.rb

@@ -60,8 +60,9 @@ class Card
     class UserError < Error
       cattr_accessor :user_error_classes
       self.user_error_classes = [self,
-                                 ActiveRecord::RecordNotFound,
+                                 ActionController::BadRequest,
                                  ActionController::MissingFile,
+                                 ActiveRecord::RecordNotFound,
                                  ActiveRecord::RecordInvalid]
     end
 

data/lib/card/format/error.rb

@@ -59,7 +59,8 @@ class Card
 
       def quiet_error e, view
         # TODO: unify with Card::Error#report
-        Rails.logger.info "#{e.message}\n" + (e.backtrace * "\n")
+        Rails.logger.info e.message
+        Rails.logger.debug e.backtrace.join("\n")
         rendering_error e, view
       end
 

data/lib/card/query/abstract_query/tie.rb

@@ -94,8 +94,8 @@ class Card
         def id_from_val val
           case val
           when Integer then val
-          when String  then Card.fetch_id(val)
-          when Symbol  then Card::Codename.id(val)
+          when String  then Card.fetch_id(val) || -999
+          when Symbol  then Card::Codename.id(val) || -999
           end
         end
       end

data/mod/carrierwave/set/abstract/attachment.rb

@@ -12,8 +12,7 @@ end
 
 # we need a card id for the path so we have to update db_content when we have
 # an id
-event :correct_identifier, :finalize,
-      on: :create, when: proc { |c| !c.web? } do
+event :correct_identifier, :finalize, on: :create, when: proc { |c| !c.web? } do
   update_column(:db_content, attachment.db_content)
   expire
 end

data/mod/carrierwave/set/abstract/attachment/storage_type.rb

@@ -1,7 +1,6 @@
 attr_writer :bucket, :storage_type
 
-event :storage_type_change, :store,
-      on: :update, when: :storage_type_changed? do
+event :storage_type_change, :store, on: :update, when: :storage_type_changed? do
   # carrierwave stores file if @cache_id is not nil
   attachment.cache_stored_file!
   # attachment.retrieve_from_cache!(attachment.cache_name)

data/mod/carrierwave/set/abstract/attachment/upload_cache.rb

@@ -54,8 +54,7 @@ end
 
 # at some point uploaded files of canceled file card creation
 # should be deleted. We do this when ever an new file is created.
-event :clear_draft_files, :integrate_with_delay,
-      on: :create do
+event :clear_draft_files, :integrate_with_delay, on: :create do
   Card.delete_tmp_files_of_cached_uploads
 end
 

data/mod/machines/lib/javascript/decko/upload.js.coffee

@@ -1,7 +1,7 @@
 $.extend decko,
   upload_file: (fileupload) ->
 # for file as a subcard in a form,
-# excess parameters are inlcuded in the request which cause errors.
+# excess parameters are included in the request which cause errors.
 # only the file, type_id and attachment_card_name are needed
 # attachment_card_name is the original card name,
 # ex: card[subcards][+logo][image], card[file]

data/mod/standard/set/all/comment.rb

@@ -7,6 +7,7 @@ event :add_comment, :prepare_to_store, on: :save, when: :comment do
   return unless comment.present?
   self.content =
     [content, format.comment_with_signature].compact.join "\n<hr\>\n"
+  self.comment = nil
 end
 
 attr_writer :comment_author

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: card
 version: !ruby/object:Gem::Version
-  version: 1.98.1
+  version: 1.98.2
 platform: ruby
 authors:
 - Ethan McCutchen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-01 00:00:00.000000000 Z
+date: 2019-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cardname
@@ -19,14 +19,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.1
+        version: 0.8.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.8.1
+        version: 0.8.2
 - !ruby/object:Gem::Dependency
   name: haml
   requirement: !ruby/object:Gem::Requirement