card-mod-permissions 0.11.4 → 0.11.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 588c237c885364801617bf81982e5c202a6cbc9e0b5f4931bc93f3315152c1a5
-  data.tar.gz: f0502bd2c432523959497206e788d4d70b8b00bb5712c1a3a4d4684fbf6d6e25
+  metadata.gz: b8b4edad152a8ea94c2a359c04185d2ff9349e7e6c0cbdf6fb1ec454b0106c85
+  data.tar.gz: 1e14a4bef67298039970e7edc98703966f8273d9644b37861b003df207f11909
 SHA512:
-  metadata.gz: a65e935794bf6c7d9a714158582c3941cbdbe08240e9a90c724593b95f584bf798486207550fe6fcffb4004d1ddb22fb579dac6a0fc81ad1235a2f92fc8c36d0
-  data.tar.gz: 066fda9824c995c94afa6bf641d272b015932dd284a948a2e6715bd025f20a396605d26232465dce304167d839c46c616d5d5345de7c3cb73f4c032f3ee47054
+  metadata.gz: 27b47ea8c0829e1b69e9180a4734126ea1d3482acaf6f6fd086ecf750f30dcbeccdfb5a02a5ea94653813c33e428d2d295dc019028d8040b0c68904713be050c
+  data.tar.gz: 1b2da5b94b525b8d532dd638c612293885e9d241804b8b7e14fae18ea4820d93c074a6928c6835e449806cf0c31c23d7bb000fdd555350bf407f1a59606d7629

data/set/abstract/permission.rb

@@ -1,4 +1,3 @@
-
 def standardize_items
   super unless content == "_left"
 end
@@ -84,6 +83,7 @@ format :html do
 
   def inheritance_checkbox
     return unless inheritable?
+
     <<-HTML
       <div class="perm-inheritance perm-section">
         #{check_box_tag 'inherit', 'inherit', inheriting?}
@@ -106,6 +106,7 @@ format :html do
 
   def in_context_of_self_set?
     return false unless @set_context
+
     @set_context.to_name.tag_name.key == Card[:self].key
   end
 
@@ -116,7 +117,7 @@ format :html do
       link_to_card card_id, nil, target: args[:target]
     end * ", "
     "Inherit ( #{links} )"
-  rescue
+  rescue StandardError
     "Inherit"
   end
 end

data/set/all/permissions.rb

@@ -51,7 +51,7 @@ def direct_rule_card action
 end
 
 def permission_rule_id action
-  if junction? && rule(action).match?(/^\[?\[?_left\]?\]?$/)
+  if compound? && rule(action).match?(/^\[?\[?_left\]?\]?$/)
     left_permission_rule_id action
   else
     rule_card_id(action)
@@ -64,9 +64,7 @@ end
 
 def left_permission_rule_id action
   lcard = left_or_new(skip_virtual: true, skip_modules: true)
-  if action == :create && lcard.real? && lcard.action != :create
-    action = :update
-  end
+  action = :update if action == :create && lcard.real? && lcard.action != :create
   lcard.permission_rule_id action
 end
 
@@ -76,6 +74,7 @@ end
 
 def require_permission_rule! rule_id, action
   return if rule_id
+
   # RULE missing.  should not be possible.
   # generalize this to handling of all required rules
   errors.add :permission_denied,
@@ -111,6 +110,7 @@ def permit action, verb=nil
   end
 
   return true if permitted? action
+
   verb ||= action.to_s
   deny_because you_cant("#{verb} #{name.present? ? name : 'this'}")
 end
@@ -125,6 +125,7 @@ end
 def ok_to_create_side side
   # left is supercard; create permissions will get checked there.
   return true if side == :left && superleft
+
   part_card = send side, new: {}
   # if no card, there must be other errors
   return true unless part_card&.new_card? && !part_card.ok?(:create)
@@ -145,6 +146,7 @@ end
 def ok_to_update
   return false unless permit(:update)
   return true unless type_id_changed? && !permitted?(:create)
+
   deny_because you_cant("change to this type (need create permission)")
 end
 
@@ -171,17 +173,18 @@ end
 
 def update_field_read_rules
   return unless type_id_changed? || read_rule_id_changed?
+
   each_field_as_bot do |field|
     field.update_read_rule if field.rule(:read) == "_left"
   end
 end
 
-def each_field_as_bot
+def each_field_as_bot &block
   # find all cards with me as trunk and update their read_rule
   # (because of *type plus right)
   # skip if name is updated because will already be resaved
   Auth.as_bot do
-    fields.each { |field| yield field }
+    fields.each(&block)
   end
 end
 

data/set/all/update_read_rules.rb

@@ -1,4 +1,3 @@
-
 # FIXME: the following don't really belong here, but they have to come after
 # the reference stuff.  we need to organize a bit!
 

data/set/right/read.rb

@@ -44,11 +44,9 @@ def update_cards_with_read_rule_id processed
   end
 end
 
-def each_member
+def each_member &block
   Auth.as_bot do
-    all_members.each_with_object(::Set.new) do |member, processed|
-      yield member, processed
-    end
+    all_members.each_with_object(::Set.new, &block)
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: card-mod-permissions
 version: !ruby/object:Gem::Version
-  version: 0.11.4
+  version: 0.11.5
 platform: ruby
 authors:
 - Ethan McCutchen
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-05-05 00:00:00.000000000 Z
+date: 2021-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: card
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.101.4
+        version: 1.101.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.101.4
+        version: 1.101.5
 description: ''
 email:
 - info@decko.org