capybara_discoball 0.0.3 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cac015fc3b1bc5a40692f0ff66fd5080c555ea1c7070148af280d5bde5f8091a
-  data.tar.gz: 752a97d51f5e970851bdc1ca92f8ffa9d107a565c9a84fe1770050babc136e8e
+  metadata.gz: 3c9c21cc79e65ba2847f9a93894819776dc22c41bef6395040692f930da22676
+  data.tar.gz: 99903a02114b594439206b29db95b5e2cdeab490605ee9c7b0abd2c0739afb58
 SHA512:
-  metadata.gz: c6fe4ffdf43b29278d96ff7a39c4e4f25e632c4f221f994b61d12115d0927f791fa33e5d6c594cd9a46fa716fd5039b0829519c03cc731bf4168443cef129d8a
-  data.tar.gz: 7f48ead23ef8dd6a735972d8170be4967649e38d2630d57009dc1ba686b0ef36198e83c91708e8e7c27185aa9ec37b435afe95477377a656b55e39e7a5872f96
+  metadata.gz: 3340ad64eb78c8d491cb1370b1a4b87f83026146c9ab84f1f11073b0cef9a16f8341643b6e7c87ff3f0b3ffa7ad457aa6f24df6c3264aac8c90d4fdcf6e08ebd
+  data.tar.gz: 5e7f1c8e452cb93a4239d324401db05f0fb296e08a4aee3eb539ee9ea3b547bf2712be717009d87dc5eab84b232f940923ca5385adf57cc2d5fe49d146526112

data/CHANGELOG.md

@@ -0,0 +1,18 @@
+# Changelog
+
+## v0.1.0
+
+- Runner retries finding an unused port [#15]
+
+## v0.0.3
+
+- Add Capybara 3.x support [#19]
+
+## v0.0.2
+
+- Use `Capybara.register_server`, introduced in Capybara 2.7.0
+- Require Capybara ~> 2.7
+
+## v0.0.1
+
+- Initial release

data/lib/capybara_discoball/retryable.rb

@@ -0,0 +1,17 @@
+module Capybara
+  module Discoball
+    module Retryable
+      def with_retries(retry_count, *rescuable_exceptions)
+        yield
+      rescue *rescuable_exceptions => e
+        if retry_count > 0
+          retry_count -= 1
+          puts e.inspect if ENV.key?("DEBUG")
+          retry
+        else
+          raise
+        end
+      end
+    end
+  end
+end

data/lib/capybara_discoball/runner.rb

@@ -1,8 +1,13 @@
 require "capybara"
+require_relative "retryable"
 
 module Capybara
   module Discoball
     class Runner
+      include Capybara::Discoball::Retryable
+
+      RETRY_COUNT = 3
+
       def initialize(server_factory, &block)
         @server_factory = server_factory
         @after_server = block || Proc.new {}
@@ -23,7 +28,8 @@ module Capybara
       def with_webrick_runner
         default_server_process = Capybara.server
         Capybara.server = :webrick
-        yield
+
+        with_retries(RETRY_COUNT, Errno::EADDRINUSE) { yield }
       ensure
         Capybara.server = default_server_process
       end

data/lib/capybara_discoball/version.rb

@@ -1,5 +1,5 @@
 module Capybara
   module Discoball
-    VERSION = "0.0.3"
+    VERSION = "0.1.0"
   end
 end

data/spec/lib/capybara_discoball/runner_spec.rb

@@ -0,0 +1,33 @@
+require "capybara_discoball"
+require "sinatra/base"
+
+RSpec.describe Capybara::Discoball::Runner do
+  describe "when Capybara fails to find an unused port" do
+    it "retries up to 3 times" do
+      expected_url = "http://localhost:9999"
+
+      allow(Capybara::Discoball::Server).to receive(:new).and_return(
+        unbootable_server,
+        unbootable_server,
+        unbootable_server,
+        bootable_server(url: expected_url),
+      )
+
+      runner = described_class.new(Sinatra::Base)
+
+      expect(runner.boot).to eq expected_url
+    end
+  end
+
+  private
+
+  def bootable_server(url:)
+    instance_double(Capybara::Discoball::Server, boot: nil, url: url)
+  end
+
+  def unbootable_server
+    server = instance_double(Capybara::Discoball::Server)
+    allow(server).to receive(:boot).and_raise(Errno::EADDRINUSE)
+    server
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capybara_discoball
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.1.0
 platform: ruby
 authors:
 - Mike Burns
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-11 00:00:00.000000000 Z
+date: 2018-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -129,20 +129,22 @@ files:
 - ".rspec"
 - ".travis.yml"
 - Appraisals
+- CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE
-- NEWS.md
 - README.md
 - Rakefile
 - capybara_discoball.gemspec
 - gemfiles/capybara_2.gemfile
 - gemfiles/capybara_3.gemfile
 - lib/capybara_discoball.rb
+- lib/capybara_discoball/retryable.rb
 - lib/capybara_discoball/runner.rb
 - lib/capybara_discoball/server.rb
 - lib/capybara_discoball/version.rb
 - spec/black_box/rails_app_spec.rb
+- spec/lib/capybara_discoball/runner_spec.rb
 - spec/lib/capybara_discoball_spec.rb
 - spec/spec_helper.rb
 homepage: ''
@@ -170,5 +172,6 @@ specification_version: 4
 summary: Spin up an external server just for Capybara
 test_files:
 - spec/black_box/rails_app_spec.rb
+- spec/lib/capybara_discoball/runner_spec.rb
 - spec/lib/capybara_discoball_spec.rb
 - spec/spec_helper.rb

data/NEWS.md

@@ -1,4 +0,0 @@
-## 0.0.2 (2016-05-04)
-
-* Use `Capybara.register_server`, introduced in Capybara 2.7.0
-* Require Capybara ~> 2.7