capybara_active_admin 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b4c255bc74004f32015b353e3e06e0915d8bbc40b3109ad02cbe831eebb8b31f
-  data.tar.gz: c20f9d6fc40394244c59a00ee41db8836286eb96bf766c14a8ac4042d6db868b
+  metadata.gz: e5e0ee49e0960bc3a5c3e92594431390718eaed7b46ab634422d6c7c51be233c
+  data.tar.gz: 94ea844aa767f0319abae52517bd56fc2ca46e887e88c74c243b46e101e466c5
 SHA512:
-  metadata.gz: 7bcf06a3023243b731c03b26643e6007ab679830af7cf27db6962b5513ac11125f9a6573f78fa296e2eeced96ea9ebd3f7af20a55de35090e6611e9e91a3a6e1
-  data.tar.gz: e307113050bcee41a41c1d1d4742b3fb5c904ae351977b3964d7c05897837b4a354d12453acacdb5edb29c5895d00f69a9d163f1b2e72248cf1dd81dd2d8a072
+  metadata.gz: 63a541769b989dc70172f98d35833e94a9693227f382d8d2d19df2318be90b711678b0cede99ac509715bfbe95d0315fd66d261501daa47df9f21603f2e1e3ac
+  data.tar.gz: 58fb5eee24078cfbe920c9171a36bffdeae16f25b18f4d74855242623cef63c84577ce6a89b9bd41cb76a3042f75809477891e33366e98af8ba47bfcbdc112f5

data/.gitignore

@@ -16,4 +16,5 @@ Gemfile.lock
 
 # docs
 /docs/.vuepress/dist/
+/docs/.vuepress/public/api/
 /node_modules/

data/.rubocop.yml

@@ -4,6 +4,7 @@ AllCops:
   Exclude:
     - vendor/**/*
     - tmp/**/*
+    - docs/**/*
 
 # Capybara/RSpec uses have_ had_ as name convention for matchers.
 Naming/PredicateName:

data/.travis.yml

@@ -29,9 +29,10 @@ jobs:
       script: bundle exec rake default
     - name: "Deploy documentation"
       stage: deploy
-      install: skip
       before_script: yarn install
-      script: yarn docs:build
+      script:
+        - bundle exec rake yard
+        - yarn docs:build
       deploy:
         provider: pages
         edge: true

data/CHANGELOG.md

@@ -6,6 +6,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.3.3] - 2020-04-17
+### Changed
+ - `batch_action_selector`, `click_batch_action` finds element by link text
+
+### Added
+ - `select_table_row`, `open_batch_action_menu` actions
+ - `have_batch_action` matcher
+ - tests for batch actions
+
 ## [0.3.2] - 2020-04-16
 ### Changed
  - remove model_name from table related DSL arguments

data/Gemfile

@@ -14,6 +14,7 @@ gem 'rake', '~> 12.0'
 gem 'rspec-rails', '~> 4.0'
 gem 'rubocop', '~> 0.81.0', require: false
 gem 'system_test_html_screenshots', require: false
+gem 'yard', require: false
 
 gem 'activeadmin', ENV.fetch('ACTIVE_ADMIN_VERSION', '~> 2.0'), require: false
 gem 'rails', ENV.fetch('RAILS_VERSION', '6.0.0')

data/Rakefile

@@ -3,8 +3,16 @@
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rubocop/rake_task'
+require 'yard'
+require 'yard/rake/yardoc_task'
 
 RSpec::Core::RakeTask.new(:spec)
 RuboCop::RakeTask.new(:rubocop)
+YARD::Rake::YardocTask.new(:yard) do |task|
+  task.options += [
+      %(--output-dir=./docs/.vuepress/public/api/),
+      %(--title=Capybara Active Admin API Reference)
+  ]
+end
 
 task default: [:rubocop, :spec]

data/docs/.vuepress/config.js

@@ -5,6 +5,7 @@ module.exports = {
   themeConfig: {
     nav: [
       { text: 'Guide', link: '/guide/' },
+      { text: 'API Reference', link: '/api/', target: '_blank' },
       { text: 'GitHub', link: 'https://github.com/activeadmin-plugins/capybara_active_admin' }
     ]
   }

data/lib/capybara/active_admin/actions.rb

@@ -8,8 +8,8 @@ require 'capybara/active_admin/actions/form'
 module Capybara
   module ActiveAdmin
     module Actions
-      # Actions are interactions with page that change something.
-      # Click, scroll, fill, clear, switch - all these are interactions.
+      # Actions are interactions with page that change something (click button, fill field, etc).
+      # Good method names starts with *click_*, *scroll_*, *fill_*, *clear_*, *switch_*, *open_*.
 
       include Actions::Layout
       include Actions::Table

data/lib/capybara/active_admin/actions/layout.rb

@@ -16,14 +16,21 @@ module Capybara
           find(tab_header_link_selector, opts).click
         end
 
-        def click_batch_action(title)
-          find(batch_actions_button_selector).click
+        def click_batch_action(title, exact: true)
+          open_batch_action_menu
           within(dropdown_list_selector) do
-            selector = batch_action_selector(title)
-            find(selector).click
+            selector = batch_action_selector
+            opts = Util.options_with_text(title, exact: exact)
+            find(selector, opts).click
           end
         end
 
+        def open_batch_action_menu
+          return if find_all(dropdown_list_selector).present?
+
+          find(batch_actions_button_selector).click
+        end
+
         def confirm_modal_dialog
           within_modal_dialog { click_button 'OK' }
         end

data/lib/capybara/active_admin/actions/table.rb

@@ -4,6 +4,18 @@ module Capybara
   module ActiveAdmin
     module Actions
       module Table
+        def select_table_row(id: nil, index: nil)
+          raise ArgumentError, "can't use both :id and :index" if id && index
+          raise ArgumentError, 'must provide :id or :index' if id.nil? && index.nil?
+
+          if id
+            find("input#batch_action_item_#{id}").click
+            return
+          end
+
+          selector = %(input[id^="batch_action_item_"])
+          find_all(selector, minimum: index + 1)[index].click
+        end
       end
     end
   end

data/lib/capybara/active_admin/matchers/layout.rb

@@ -38,6 +38,12 @@ module Capybara
           opts = Util.options_with_text(title, options)
           have_selector(title_selector, opts)
         end
+
+        def have_batch_action(title, exact: true)
+          selector = "#{dropdown_list_selector} #{batch_action_selector}"
+          opts = Util.options_with_text(title, exact: exact)
+          have_selector(selector, opts)
+        end
       end
     end
   end

data/lib/capybara/active_admin/selectors/layout.rb

@@ -73,8 +73,8 @@ module Capybara
         end
 
         # @return [String] selector.
-        def batch_action_selector(title)
-          "li a[data-action='#{title}']"
+        def batch_action_selector
+          'li a[data-action]'
         end
 
         # @return [String] selector.

data/lib/capybara/active_admin/version.rb

@@ -2,6 +2,6 @@
 
 module Capybara
   module ActiveAdmin
-    VERSION = '0.3.2'
+    VERSION = '0.3.3'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capybara_active_admin
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Denis Talakevich
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-16 00:00:00.000000000 Z
+date: 2020-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeadmin
@@ -58,8 +58,8 @@ files:
 - bin/console
 - bin/setup
 - capybara_active_admin.gemspec
-- deploy.sh
 - docs/.vuepress/config.js
+- docs/.vuepress/public/.keep
 - docs/.vuepress/styles/index.styl
 - docs/README.md
 - docs/guide/README.md

data/deploy.sh

@@ -1,19 +0,0 @@
-#!/usr/bin/env sh
-
-# abort on errors
-set -e
-
-# build
-npm run docs:build
-
-# navigate into the build output directory
-cd docs/.vuepress/dist
-
-git init
-git add -A
-git commit -m 'deploy'
-
-# deploying to https://activeadmin-plugins.github.io/capybara_active_admin
-git push -f git@github.com:activeadmin-plugins/capybara_active_admin.git master:gh-pages
-
-cd -