capybara 3.35.0 → 3.35.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 00bf1cfd1e72093422fb61df1dae86d72948e8026d57fb00084d5bedceb0967e
-  data.tar.gz: 65a8c6b66d1ef91586ca39f7eabcf800019f853e33e087d1bb65f02a85140c8b
+  metadata.gz: 2913f83c980b16f28c90df040eea7a31502facb4d78a0dc9cd54a37e2faee9e7
+  data.tar.gz: 105f72f39f609d3865a7414d8103ae0fd12f23b3f437d867994d395487eeaf55
 SHA512:
-  metadata.gz: f961de052aa75cb3e3a941ea031d40d6d0f1fc2a9a80190c7dbe2f7d8e96b462fa71d4ed96d4dc45687e2baaf151579ca4508a2753a6e2073814857e2dee9bb4
-  data.tar.gz: 4b02c84f7bd1d9da419e3f43848da87290ba303541df516e6217fd3fc2e4cf5263e212e9a4a5329c8505b2f6111c0ce6ea17537ea3099b04f12c9b662d364088
+  metadata.gz: ec65b7e51aaf5df4fc9a3370deafd98ea35d20bc1aecd4d3349f6a64f7406f647bbdf632601c6a27db4846a6f68a32cf3c95e6d5d7a038c3fd2c48724c3a3e23
+  data.tar.gz: 8a14863dae239561f674899ee7209ab54d02b1c7b3890aaf2d8cbeb8d3a349d341c7bb6a021aa85702aa7f885aa5e2602f1c64cefc488a4d2ea9f9dd86e7710f

data/History.md

@@ -1,3 +1,11 @@
+# Version 3.35.1
+Release date: 2020-01-26
+
+### Fixed
+
+* Default chrome driver registrations use chrome - Issue #2442 [Yuriy Alekseyev]
+* 'Capybara.test_id' usage with the :button selector - Issue #2443
+
 # Version 3.35.0
 Release date: 2020-01-25
 

data/lib/capybara/registrations/drivers.rb

@@ -25,7 +25,7 @@ Capybara.register_driver :selenium_chrome do |app|
     opts.add_argument('--disable-site-isolation-trials')
   end
 
-  Capybara::Selenium::Driver.new(app, **Hash[:browser => :firefox, options_key => browser_options])
+  Capybara::Selenium::Driver.new(app, **Hash[:browser => :chrome, options_key => browser_options])
 end
 
 Capybara.register_driver :selenium_chrome_headless do |app|
@@ -38,5 +38,5 @@ Capybara.register_driver :selenium_chrome_headless do |app|
     opts.add_argument('--disable-site-isolation-trials')
   end
 
-  Capybara::Selenium::Driver.new(app, **Hash[:browser => :firefox, options_key => browser_options])
+  Capybara::Selenium::Driver.new(app, **Hash[:browser => :chrome, options_key => browser_options])
 end

data/lib/capybara/selector/definition/button.rb

@@ -57,7 +57,7 @@ Capybara.add_selector(:button, locator_type: [String, Symbol]) do
       XPath.attr(:title).is(locator),
       (XPath.attr(:id) == XPath.anywhere(:label)[XPath.string.n.is(locator)].attr(:for)),
       (XPath.attr(:'aria-label').is(locator) if config.enable_aria_label),
-      (XPath.attr(test_id) == locator if config.test_id)
+      (XPath.attr(config.test_id) == locator if config.test_id)
     ].compact.inject(&:|)
   end
 end

data/lib/capybara/spec/session/click_link_or_button_spec.rb

@@ -38,6 +38,15 @@ Capybara::SpecHelper.spec '#click_link_or_button' do
     expect(extract_results(@session)['first_name']).to eq('John')
   end
 
+  context 'with test_id' do
+    it 'should click on a button' do
+      Capybara.test_id = 'data-test-id'
+      @session.visit('/form')
+      @session.click_link_or_button('test_id_button')
+      expect(extract_results(@session)['first_name']).to eq('John')
+    end
+  end
+
   context 'with :exact option' do
     context 'when `false`' do
       it 'clicks on approximately matching link' do

data/lib/capybara/spec/views/form.erb

@@ -449,7 +449,7 @@ New line after and before textarea tag
 
   <p>
     <input type="button" aria-label="Aria button" name="form[fresh]" id="fresh_btn" value="i am fresh"/>
-    <input type="submit" name="form[awesome]" id="awe123" title="What an Awesome Button" value="awesome"/>
+    <input type="submit" name="form[awesome]" id="awe123" data-test-id="test_id_button" title="What an Awesome Button" value="awesome"/>
     <input type="submit" name="form[crappy]" id="crap321" value="crappy"/>
     <input type="image" name="form[okay]" id="okay556" title="Okay 556 Image" value="okay" alt="oh hai thar"/>
     <button type="submit" id="click_me_123" title="Click Title button" value="click_me">Click me!</button>

data/lib/capybara/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Capybara
-  VERSION = '3.35.0'
+  VERSION = '3.35.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara
 version: !ruby/object:Gem::Version
-  version: 3.35.0
+  version: 3.35.1
 platform: ruby
 authors:
 - Thomas Walpole